Pull Request已成功合入, 合并人@CANN-robot
(感谢 hu-yiliang11 的贡献)变更摘要
该 PR 为一次 Bug 修复,主要修复 RDMA 传输路径中发送请求(WQE)的 signal 标志设置逻辑,涉及文件 src/legacy/ascend910/platform/resource/transport/device/transport_device_ibverbs.cc。核心改动是:在 TxSendWqe 中不再无条件地为写请求设置 RA_SEND_SIGNALED,而是根据 wqeType 是否为数据通知类型来决定是否携带 signal 标志;同时在 TxPayLoad 中调用 ConstructPayLoadWqe 时显式传入 false,明确该路径无需 signal。
主要改动
-
按 WQE 类型决定 signal 标志:在
TxSendWqe中新增isNeedSignaled判断,仅当wqeType为WQE_TYPE_DATA_NOTIFY或WQE_TYPE_DATA_ACK_NOTIFY时才设置RA_SEND_SIGNALED,否则该位为 0;fence_为真时仍保留RA_SEND_SIGNALED | RA_SEND_FENCE,修复了原先对所有发送均强制设置RA_SEND_SIGNALED的问题。 -
TxPayLoad显式关闭 signal:在TxPayLoad中调用ConstructPayLoadWqe时追加参数false,明确该场景不产生 signal,保证与TxSendWqe的新逻辑一致。


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| src/legacy/ascend910/platform | ✅ 陈浩, 陈量 (2/2) | ✅ 陈浩 (1/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
gcw_NcEfY7mt, thanks for your pull request. All authors of the commits have signed the CLA. 👍


compile


| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


/approve


/lgtm


描述
设置集合通信RDMA wr属性,datanotify和dataacknotify才生成cqe
变更类型
请选择本次引入的变更类型:
关联的Issue
https://gitcode.com/cann/hcomm/issues/921
测试
已完成的测试用例和场景:
1.
2.
补充的UT用例:
文档更新
合入检查