Closed
[Documentation|文档反馈]: concat compact 阈值与 transpose 分核注释和实现不一致 #3802
TangPCAdd on 21 days agoClosed at 21 days ago
21 days ago Added label: documentation
TangPC
21 days ago Comments:
21 days ago Comments:
/assign @pingchuantang


21 days ago Assign pingchuantang as responsible person
21 days ago Close issue
21 days ago Added label: resolved
一、文档链接 (必填)
二、问题文档片段 (必填)
1. concat 分核注释(concat_tiling_arch35.cpp,GenTilingKey)
修改前:
// 判断是否可用 compact: 所有 tensor 的 dim1 < UINT32_MAX修改后:
// 判断是否可用 compact: 所有 tensor 的 dim1 < INT32_MAX💡 存在的问题(选填):实际判定常量为
COMPACT_THRESHOLD = std::numeric_limits<int32_t>::max(),注释写UINT32_MAX与实现不一致,易误导维护者。2. transpose 小 shape 分核说明(transpose_tiling_arch35.cpp,CalcBlockSplitInfoForSmallShape)
修改前:
修改后:
💡 存在的问题(选填):原注释描述的 ceil/floor 双候选开核逻辑与实现不符;实现为
totalElements < alignElements || totalElements < coreNum_时单核,否则按CeilAlign(totalElements / coreNum_, alignElements)求块长并CeilDiv开核。关联 PR:https://gitcode.com/cann/ops-math/pull/6493