Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)变更摘要
本 PR 为文档/注释修正类变更,仅调整两处与实现不一致的代码注释,不涉及任何逻辑改动。在 conversion/concat/op_host/arch35/concat_tiling_arch35.cpp 的 GenTilingKey 中,将 compact 可用性判断的注释阈值由 UINT32_MAX 更正为 INT32_MAX,使之与代码中实际比较的 COMPACT_THRESHOLD 保持一致;在 conversion/transpose/op_host/arch35/transpose_tiling_arch35.cpp 的 CalcBlockSplitInfoForSmallShape 中,将 SMALL_SHAPE 分核逻辑注释改写为与实现一致的单核条件与基于 CeilDiv 的开核方式。
主要改动
concatcompact 阈值注释修正: 在GenTilingKey中将「所有 tensor 的 dim1 <UINT32_MAX」的注释改为< INT32_MAX,与COMPACT_THRESHOLD的实际语义对齐。transposeSMALL_SHAPE 分核注释重写: 将原「总元素 < coreNum 按元素数开核、否则比较 ceil/floor 候选」的说明,改为「总元素不足 128B 对齐量或不足coreNum时只使用 1 核,否则按ceilAlignFactor开核」。- 开核公式说明同步: 注释显式补充核数计算方式为
CeilDiv(totalElements, ceilAlignFactor),与实现保持一致。
(本次改动仅涉及注释文本,未修改接口、数据结构、配置项或运行逻辑。)
🧩 本次 Review 已使用自定义 Skill:




Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| conversion/concat | ✅ 王林木, 张磊 (2/2) | ✅ 张磊, 王林木 (2/1) |
| conversion/transpose | ✅ 王林木, 张磊 (2/2) | ✅ 王林木, 张磊 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍


compile


| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


您好,PR已满足合入指标,请尽快联系Committer进行合入。如暂时不需要合入,请在PR标题前加[WIP]


描述
conversion/concat/op_host/arch35/concat_tiling_arch35.cpp:compact 阈值注释UINT32_MAX->INT32_MAX,与COMPACT_THRESHOLD一致。conversion/transpose/op_host/arch35/transpose_tiling_arch35.cpp:SMALL_SHAPE 分核注释改为与实现一致的单核条件与CeilDiv开核逻辑。关联的Issue
测试
文档更新
conversion/concat/op_host/arch35/concat_tiling_arch35.cppconversion/transpose/op_host/arch35/transpose_tiling_arch35.cpp类型标签