Merged
docs: 修复注释与代码不一致(HistogramV2 dtype 属性说明) #6494
TangPCAdd on Oct 19
docs: 修复注释与代码不一致(HistogramV2 dtype 属性说明) #6494
Merged
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)atomgit-bot
Oct 19 Comments:
Oct 19 Comments:
变更摘要
本 PR 为文档注释清理,主要修正 HistogramV2 算子相关代码中注释与实现不一致的问题。涉及 math/histogram_v2/op_graph/fusion_pass/histogram_fusion_pass.cpp 与 math/histogram_v2/op_graph/histogram_v2_graph_infer.cpp 两个文件,仅调整注释文本,未改变任何逻辑行为。前者将描述中不存在的 is_out_dtype_int32 属性更正为实际的 y_dtype 属性,后者将 DT_FLOAT 的枚举取值由 9 修正为 0。
主要改动
- 融合规则注释修正: 在
histogram_fusion_pass.cpp中将注释里的is_out_dtype_int32属性替换为实际的y_dtype属性,并说明该属性由x的 dtype 决定(float/f16时为DT_FLOAT)。 - 类型推导注释修正: 在
histogram_v2_graph_infer.cpp的HistogramV2InferDataTypeFunc相关注释中,将y_dtype可设置的DT_FLOAT枚举值由9更正为0。
🧩 本次 Review 已使用自定义 Skill:


Incorrect?
atomgit-bot
Oct 19 Comments:
Oct 19 Comments:


Incorrect?
Oct 19 Added label: cann-cla/yes
CANN-robot
Oct 19 Comments:
Oct 19 Comments:
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| math/histogram_v2 | ✅ 王林木, 张磊 (2/2) | ✅ 王林木, 张磊 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)


CANN-robot
Oct 19 Comments:
Oct 19 Comments:
Oct 19 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
Oct 19 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
Oct 19 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
Oct 19 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
TangPC
28 days ago Comments:
28 days ago Comments:
compile


28 days ago Pre merge succeeded (commit_id: 040ad3837d36e2808d7d2fb879611d0223492b54)
CANN-robot
28 days ago Comments:
28 days ago Comments:
| 🚀 CI 流水线已启动 |
|---|
| 📋 执行详情: 点击查看流水线 |


28 days ago Added label: ci-pipeline-running
28 days ago Removed label: ci-pipeline-running
28 days ago Added label: ci-pipeline-passed
28 days ago Modify description of pull request
28 days ago Added label: approved
28 days ago Added label: lgtm
28 days ago Closed associated issue
28 days ago Merged pull request
描述
math/histogram_v2/op_graph/histogram_v2_graph_infer.cpp:DT_FLOAT枚举值由 9 修正为 0。math/histogram_v2/op_graph/fusion_pass/histogram_fusion_pass.cpp:不存在的is_out_dtype_int32属性说明改为实际y_dtype属性。关联的Issue
测试
文档更新
math/histogram_v2/op_graph/fusion_pass/histogram_fusion_pass.cppmath/histogram_v2/op_graph/histogram_v2_graph_infer.cpp类型标签