Merged
docs: 修复注释与代码不一致(HistogramV2 dtype 属性说明) #6494
docs: 修复注释与代码不一致(HistogramV2 dtype 属性说明) #6494
Merged
TangPCAdd on Oct 19
TangPC
TangPCCollaborators
Oct 19

描述

  • math/histogram_v2/op_graph/histogram_v2_graph_infer.cpp:DT_FLOAT 枚举值由 9 修正为 0。
  • math/histogram_v2/op_graph/fusion_pass/histogram_fusion_pass.cpp:不存在的 is_out_dtype_int32 属性说明改为实际 y_dtype 属性。

关联的Issue

测试

  • pre-commit(含 OAT):通过
  • Markdown 链接/图片检查:无新增失效项
  • Markdown 代码围栏检查:通过
  • 全部 26 个分支合并验证:无冲突

文档更新

  • math/histogram_v2/op_graph/fusion_pass/histogram_fusion_pass.cpp
  • math/histogram_v2/op_graph/histogram_v2_graph_infer.cpp

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)
TangPCTangPCCollaborators
Oct 19 Created pull request, commit 93882f2e
atomgit-bot
atomgit-bot
Oct 19 Comments:

变更摘要

本 PR 为文档注释清理,主要修正 HistogramV2 算子相关代码中注释与实现不一致的问题。涉及 math/histogram_v2/op_graph/fusion_pass/histogram_fusion_pass.cpp 与 math/histogram_v2/op_graph/histogram_v2_graph_infer.cpp 两个文件,仅调整注释文本,未改变任何逻辑行为。前者将描述中不存在的 is_out_dtype_int32 属性更正为实际的 y_dtype 属性,后者将 DT_FLOAT 的枚举取值由 9 修正为 0。

主要改动

  • 融合规则注释修正: 在 histogram_fusion_pass.cpp 中将注释里的 is_out_dtype_int32 属性替换为实际的 y_dtype 属性,并说明该属性由 x 的 dtype 决定(float/f16 时为 DT_FLOAT)。
  • 类型推导注释修正: 在 histogram_v2_graph_infer.cpp 的 HistogramV2InferDataTypeFunc 相关注释中,将 y_dtype 可设置的 DT_FLOAT 枚举值由 9 更正为 0。

🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
Oct 19 Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
Oct 19 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Oct 19 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
math/histogram_v2 ✅ 王林木, 张磊 (2/2) ✅ 王林木, 张磊 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
CANN-robot
CANN-robotCollaborators
Oct 19 Comments:

CLA Signature Pass

pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
Oct 19 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
Oct 19 Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
TangPC
TangPCCollaborators
28 days ago Comments:

compile

likedislike
TangPCTangPCCollaborators
28 days ago Pre merge succeeded (commit_id: 040ad3837d36e2808d7d2fb879611d0223492b54)
CANN-robot
CANN-robotCollaborators
28 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
28 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
28 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
28 days ago Added label: ci-pipeline-passed
TangPCTangPCCollaborators
28 days ago Modify description of pull request
llimwangCollaborators
28 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
28 days ago Added label: approved
zl_hwCollaborators
28 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
28 days ago Added label: lgtm
CANN-robotCANN-robotCollaborators
28 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
28 days ago Merged pull request