Merged
docs: 修复注释与代码不一致(文件头文件名) #6496
docs: 修复注释与代码不一致(文件头文件名) #6496
Merged
TangPCAdd on 22 days ago
TangPC
TangPCCollaborators
22 days ago

描述

修正 \file 注释为实际文件名:

  • math/abs/op_graph/abs_proto.h:cast_proto.h -> abs_proto.h。
  • conversion/concat_d/op_graph/concat_d_graph_infer.cpp:concat_graph_infer.h -> concat_d_graph_infer.cpp。

关联的Issue

测试

  • pre-commit(含 OAT):通过
  • Markdown 链接/图片检查:无新增失效项
  • Markdown 代码围栏检查:通过
  • 全部 26 个分支合并验证:无冲突

文档更新

  • conversion/concat_d/op_graph/concat_d_graph_infer.cpp
  • math/abs/op_graph/abs_proto.h

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)
TangPCTangPCCollaborators
22 days ago Created pull request, commit f7bc9ef3
atomgit-bot
atomgit-bot
22 days ago Comments:

变更摘要

本 PR 为文档/注释修正类改动,主要修正 \file 注释中的文件名与实际文件不一致的问题:在 math/abs/op_graph/abs_proto.h 中将 cast_proto.h 改为 abs_proto.h,在 conversion/concat_d/op_graph/concat_d_graph_infer.cpp 中将 concat_graph_infer.h 改为 concat_d_graph_infer.cpp。同时伴随 abs_proto.h 中少量代码格式整理,包括 namespace ge 大括号风格统一、REG_OP(Abs) 的 DATATYPE 类型列表换行方式调整,以及文件末尾补加换行符。

主要改动

  • 修正 \file 注释文件名: abs_proto.h 的 \file 由 cast_proto.h 更正为 abs_proto.h,使注释与实际文件名一致。
  • 修正 \file 注释文件名: concat_d_graph_infer.cpp 的 \file 由 concat_graph_infer.h 更正为 concat_d_graph_infer.cpp,使注释与实际文件名一致。
  • 统一命名空间大括号风格: abs_proto.h 中 namespace ge 的开始大括号调整为与声明同一行。
  • 调整 DATATYPE 换行: REG_OP(Abs) 的 TensorType 类型列表在行间分布上重新排布,类型集合本身未变化。
  • 补加文件末尾换行: abs_proto.h 的 #endif 后新增换行符,消除“无文件末尾换行”状态。

🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
22 days ago Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
22 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
22 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/op_graph/*_proto.h ✅ 张磊, 王永光, 王林木 (3/2) ✅ 王永光 (1/1)
repo-cann/ops-math ✅ 王林木, 张磊 (2/2) ✅ 王林木, 张磊 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
22 days ago Set FelixTang7,yue-ma,zhou-qilong,wangrui_,su-yueming,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
22 days ago Set yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,zhanw_coding,clinglai0517 as approver
TangPC
TangPCCollaborators
19 days ago Comments:

compile

likedislike
TangPCTangPCCollaborators
19 days ago Pre merge succeeded (commit_id: bde242617e0c10cc079c184593e3f5bebb71a412)
CANN-robot
CANN-robotCollaborators
19 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
19 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
19 days ago Added label: ci-pipeline-passed
TangPCTangPCCollaborators
19 days ago Modify description of pull request
llimwangCollaborators
19 days ago Comments:

/lgtm
/approve

likedislike
zl_hwCollaborators
19 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: lgtm
wangyongguangCollaborators
19 days ago Comments:

/approve

likedislike
CANN-robotCANN-robotCollaborators
19 days ago Added label: approved
CANN-robotCANN-robotCollaborators
19 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
19 days ago Merged pull request