Merged
【unfold_grad】修复issue问题 aclnnUnfoldGrad 头文件将输出参数 gradIn 修改为 @param [out] #6715
【unfold_grad】修复issue问题 aclnnUnfoldGrad 头文件将输出参数 gradIn 修改为 @param [out] #6715
Merged
tangkaidiAdd on 16 days ago
tangkaidiCollaborators
16 days ago

描述

aclnnUnfoldGrad 头文件将输出参数 gradIn 标注为 @param [in],与同文件其他注释、以及配套文档的参数表均矛盾。
将@param [in]改为@param [out]

关联的Issue

[Documentation|文档反馈]: aclnnUnfoldGrad 头文件将输出参数 gradIn 错标为 @param [in] #3825

测试

不涉及影响精度的修改

文档更新

不涉及

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for tangkaidi's contribution.)
TtangkaidiCollaborators
16 days ago Created pull request, commit f92b3a07
CANN-robotCANN-robotCollaborators
16 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
16 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/op_api/*.h ✅ 王永光, 宋恺 (2/2) ✅ 王永光 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

tangkaidi, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
16 days ago Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,tang-lei01,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,pingchuantang,llimwang,gubaocheng,andong_hw,wangyongguang,xuejinghui,onanfield,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
16 days ago Set tang-lei01,wangyongguang as approver
tangkaidiCollaborators
16 days ago Comments:

compile

likedislike
TtangkaidiCollaborators
16 days ago Pre merge succeeded (commit_id: 36f6c2d13aa9b22581fc86eb91a84357ecb27d79)
CANN-robot
CANN-robotCollaborators
16 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
16 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
16 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
16 days ago Added label: ci-pipeline-failed
CANN-robot
CANN-robotCollaborators
16 days ago Comments:

流水线分析报告 — ops-math run#5855

流水线: https://gitcode.com/CANN/ops-math/actions/runs/238a323141ef4860841f01d4ff125a61 | PR#6715 | 2026-10-27 13:07:05 ~ 2026-10-27 13:14:18 | 失败 Job 1 个

定界结论: 代码问题 / 代码检查错误 — clang-format 格式不规范
  • 失败类型: 代码问题
  • 根因: pre-commit 检查项不通过: clang-format 与 trim trailing whitespace 两个 hook 均检测到 PR 变更文件 conversion/unfold_grad/op_api/aclnn_unfold_grad.h 存在格式问题并自动修改了该文件(hook 修改文件即判失败)
  • 处置建议: 通知 PR 提交者修复 —— 本地在 PR 分支执行 pre-commit run --all-files 或 pre-commit run clang-format --all-files, 确认改动重新提交推送后重新触发流水线
  • 排除项: 其余检查项均通过(fix end of files / merge conflicts / large files / private key / codespell / OAT); ruff 无 Python 变更文件跳过; 非环境或平台问题

失败根因分析

根因 #1: 代码问题 / 代码检查错误 — clang-format 格式不规范
  • 判据: pre-commit 检查项不通过: clang-format(本地执行 pre-commit run clang-format 修复)
  • 定位步骤: 3_precommit.log
  • 影响 Job: CodeCheck_precommit
  • 根因证据(日志原文):
[2026-10-27 13:08:34.458+08:00] trim trailing whitespace.................................................Failed
[2026-10-27 13:08:34.458+08:00] - hook id: trailing-whitespace
[2026-10-27 13:08:34.458+08:00] - exit code: 1
[2026-10-27 13:08:34.458+08:00] - files were modified by this hook
[2026-10-27 13:08:34.458+08:00] Fixing conversion/unfold_grad/op_api/aclnn_unfold_grad.h
...
[2026-10-27 13:08:34.458+08:00] clang-format.............................................................Failed
[2026-10-27 13:08:34.458+08:00] - hook id: clang-format
[2026-10-27 13:08:34.458+08:00] - files were modified by this hook
[2026-10-27 13:08:34.458+08:00] Formatting [1/1] conversion/unfold_grad/op_api/aclnn_unfold_grad.h
  • 说明: 两个失败 hook 均指向同一文件 conversion/unfold_grad/op_api/aclnn_unfold_grad.h(行尾空白 + C++ 代码格式), 属同一根因; pre-commit 仅检测 PR 变更文件, 该文件即本 PR 引入
结构化定界摘要
[{"repo": "ops-math", "run_number": 5855, "Failed_Type": "代码问题",
  "Failed_Sub_Type": "代码检查错误", "Failed_Reason": "PR 变更文件 conversion/unfold_grad/op_api/aclnn_unfold_grad.h 存在行尾空白与 clang-format 格式问题, pre-commit 的 trailing-whitespace 与 clang-format 两个 hook 失败",
  "evidence": "[2026-10-27 13:08:34.458+08:00] clang-format.............................................................Failed Formatting [1/1] conversion/unfold_grad/op_api/aclnn_unfold_grad.h",
  "suggestion": "提交者本地执行 pre-commit run clang-format 修复该文件格式后重新推送, 触发流水线复验",
  "jobs": "CodeCheck_precommit"}]

由门禁失败定界分析自动生成 | repo: ops-math | run: 238a323141ef4860841f01d4ff125a61 | PR#6715

likedislike
TtangkaidiCollaborators
16 days ago Draft state has been cancelled
9 event messages are collapsed here。 See more
CANN-robotCANN-robotCollaborators
16 days ago Added label: cann-cla/yes
tangkaidiCollaborators
16 days ago Comments:

/check-pr

likedislike
CANN-robot
CANN-robotCollaborators
16 days ago Comments:

The following labels are not ready.

lgtm: Please wait for committers to review the code.

approved: Please wait for committers to review the code.

ci-pipeline-passed: Please wait for the CI test to be completed. You can also comment /compile to retry it!

likedislike
tangkaidiCollaborators
16 days ago Comments:

compile

likedislike
TtangkaidiCollaborators
16 days ago Pre merge succeeded (commit_id: 566c9ec5b2e9b0ae50e370d735d92175a5b612f7)
CANN-robot
CANN-robotCollaborators
16 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
16 days ago Removed label: ci-pipeline-failed
CANN-robotCANN-robotCollaborators
16 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
16 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
16 days ago Added label: ci-pipeline-passed
songkai111Collaborators
16 days ago Comments:

/lgtm

likedislike
WwangyongguangCollaborators
16 days ago Approval passed
tangkaidiCollaborators
16 days ago Comments:

/check-pr

likedislike
CANN-robot
CANN-robotCollaborators
16 days ago Comments:

The following labels are not ready.

lgtm: Please wait for committers to review the code.

approved: Please wait for committers to review the code.

likedislike
wangyongguangCollaborators
16 days ago Comments:

/approve

likedislike
CANN-robotCANN-robotCollaborators
16 days ago Added label: lgtmapproved
CANN-robotCANN-robotCollaborators
16 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
16 days ago Merged pull request