Merged
fused_causal_conv1d修改cache_indices的拦截 #10073
fused_causal_conv1d修改cache_indices的拦截 #10073
Merged
xiapengcheng5Add on Aug 14
xiapengcheng5
xiapengcheng5Collaborators
Aug 14

描述

fused_causal_conv1d修改cache_indices的拦截

关联的Issue

https://gitcode.com/cann/ops-transformer/issues/4309

测试

文档更新

attention/fused_causal_conv1d/README.md
attention/fused_causal_conv1d/docs/aclnnFusedCausalConv1d.md
attention/inplace_fused_causal_conv1d/README.md
attention/inplace_fused_causal_conv1d/docs/aclnnInplaceFusedCausalConv1d.md

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for xiapengcheng5's contribution.)
xiapengcheng5xiapengcheng5Collaborators
Aug 14 Created pull request, commit d38aeb5e
atomgit-bot
atomgit-bot
Aug 14 Comments:

变更摘要

本 PR 主要调整 fused_causal_conv1d 的 host 侧 tiling 校验逻辑,围绕 cache_indices 的拦截条件进行修改:放宽 conv_states/cache_states 首维与 batch、cache_indices 总元素数之间的约束,同时在 BH tiling 中新增对权重 kernelSize_ 必须为 3 的校验,并同步更新相关算子文档。

主要改动

  • 新增 kernelSize_ 校验(BH tiling): 在 FusedCausalConv1dCutBHTiling::GetShapeInfo 中新增校验,权重第 0 维 kernelSize_ 不等于 3 时记录错误并返回 ge::GRAPH_FAILED。
  • 移除 conv_states 与 batch 的约束(BH tiling): 删除 FusedCausalConv1dCutBHTiling::ValidateConvStatesShape 中 conv_states 的 shape[0] 必须大于等于 batchSize_ 的校验。
  • 移除 conv_states 与 cache_indices 总量的约束(BH tiling): 删除 FusedCausalConv1dCutBHTiling::ValidateCacheIndicesShape 中 conv_states 的 shape[0] 必须大于等于 cache_indices 总元素数的校验。
  • 移除 cache_states 与 batch 的约束(BSH tiling): 删除 FusedCausalConv1dCutBSHTiling::CheckCacheStatesDim 中 cache_states 的 shape[0] 必须大于等于 batch_ 的校验。
  • 移除 cache_states 与 cache_indices 总量的约束(BSH tiling): 删除 FusedCausalConv1dCutBSHTiling::CheckCacheIndicesDim 中 cache_states 的 shape[0] 必须大于等于 cache_indices 总元素数的校验。
likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
Aug 14 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Aug 14 Comments:

CLA Signature Pass

xiapengcheng5, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robot
CANN-robotCollaborators
Aug 14 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here。
You can get sig-info at here
For more, you also can visit HICANN


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/README.md ✅ 吴瑶, 蔡雯雯, 陈娇 (3/2) ✅ 吴瑶, 蔡雯雯 (2/1)
*/*/docs/acl*.md ✅ 吴瑶, 陈娇, 蔡雯雯 (3/2) ✅ 蔡雯雯, 吴瑶 (2/1)
attention ✅ yuhao_, 於欣洁 (2/2) ✅ yuhao_, 於欣洁 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

xiapengcheng5, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
44 messages are collapsed here。 See more
yuhao_Collaborators
Aug 14 Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
Aug 14 Added label: approved
於欣洁Collaborators
Aug 14 Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
Aug 14 Added label: lgtm
CANN-robotCANN-robotCollaborators
Aug 14 Merged pull request