Closed
feat(aicpu): add constant folding host registration #10680
wby50065566Add on Aug 26Closed at 1 day ago
feat(aicpu): add constant folding host registration #10680
Closed
wby50065566Add on Aug 26Closed at 1 day ago
Aug 26

Description

Add common AICPU host constant-folding infrastructure for future migrated operators that support OPEN_OPS_FLAG.

Changes:

  • Add the repository-level OPS_TRANSFORMER_REGISTER_CPU_KERNELV2 wrapper.
  • Add HOSTCPU support to add_modules_sources and add_modules_sources_with_soc.
  • Collect host AICPU OBJECT targets into libopconstant_folding_transformer.so.
  • Keep host constant folding independent of the device-side ENABLE_AICPU switch.
  • Do not enable specific operators because this repository currently has no OPEN_OPS_FLAG operator.

Validation

  • git diff --check passed.
  • Both CMake entry points parse and handle HOSTCPU.
  • Neither host constant-folding path depends on ENABLE_AICPU.
  • Host compile definition, OBJECT collection, and shared-library wiring were checked.

AI declaration

  • AI-assisted

Fixes #5438

likedislike
The current Pull Request has been closed by 周云飞.
Wwby50065566
Aug 26 Created pull request, commit 71fa8e06
atomgit-bot
atomgit-bot
Aug 26 Comments:

🤖 正在生成合并请求摘要,请稍候…

likedislike
Incorrect?
CANN-robot
CANN-robotCollaborators
Aug 26 Comments:

Hi @hid29204727, welcome to submitting your first PR to ops-transformer!

PR Merge Steps

1. CLA Signing

If the current PR label includes cann-cla/yes, it means you have signed the CLA and can proceed to the next step. If the label includes cann-cla/no, please sign the CLA first. If you have any questions, please refer to the FAQ.

2. CI Check

Please comment /compile to trigger the CI pipeline check. If the CI run is successful, the PR will be tagged with ci-pipeline-passed and you can proceed to the next step. If the CI run fails, the PR will be tagged with ci-pipeline-failed, please check the CI logs to fix the issues in the PR. If you have any questions, please refer to the FAQ.

3. Code Review

After CI passes, please refer to the PR Approval Progress and proactively @ the committers in the table to review the code. After approval, committers will comment /lgtm and /approve. Once the lgtm and approved labels are successfully added, the PR will be merged automatically.

likedislike
CANN-robotCANN-robotCollaborators
Aug 26 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Aug 26 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

⚠️ This PR does not yet meet the following requirements:lgtm (requires ≥ 2 person(s) per module)

Module Approval Details

module lgtm status approve status
cmake ❌ wang-minbo (1/2)(You can also ask: 马兵, gaoxiang618, zzzzzzyf_, 黄俊健, 俞郑中) ✅ wang-minbo (1/1)
common ❌ wang-minbo (1/2)(You can also ask: 蒋礼锐, 刘丹, zzzzzzyf_, 黄俊健, 马兵) ✅ wang-minbo (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

hid29204727, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
67 messages are collapsed here。 See more
wang-minboCollaborators
15 days ago Comments:

/lgtm

likedislike
wang-minboCollaborators
15 days ago Comments:

/approve

likedislike
wang-minboCollaborators
2 days ago Comments:

存在 1 处合并冲突,请先合并目标分支 master 解决后重新提交(本次未做代码评审):

  • add/add: common/include/op_kernel/transformer_aicpu_register.h
likedislike
周云飞
周云飞Collaborators
1 day ago Comments:

感谢贡献!该 AICPU Host 常量折叠基础能力已通过后续替代 PR !14376 合入主线,本 PR 的主要修改已有对应实现。为避免重复维护,现关闭本 PR,感谢贡献。

likedislike
周云飞周云飞Collaborators
1 day ago Close pull request