Merged
Ascend960 moe_update_expert&barrier&combine #13299
yezhuoxiAdd on Sep 30
Ascend960 moe_update_expert&barrier&combine #13299
Merged
Merged fromyezhuoxi/ops-transformer_2ndmasterintocann/ops-transformermaster
Pull Request has been successfully merged by CANN-robot.
(Thank you for yezhuoxi's contribution.)atomgit-bot
Sep 30 Comments:
Sep 30 Comments:
变更摘要
本 PR 主要为 distribute_barrier 与 moe_update_expert 两个 MC2 算子补充新硬件平台 ascend960dt(DAV_9201 架构)的支持。核心是在算子的原型配置、tiling 与 ACLNN 接口分支中,将 DAV_9201 与既有的 DAV_3510 同等处理,使新平台能够走扩展(extend)通路并采用对应的 worldSize 上限配置;其余改动为指针书写风格(Type * 调整为 Type*)的统一整理,无业务行为变化。
主要改动
distribute_barrier接口新增DAV_9201分支: 在aclnnDistributeBarrierGetWorkspaceSizeBase与aclnnDistributeBarrierBase中,将Ops::Base::DAV_9201与DAV_3510一并纳入判定,使其同样调用aclnnInnerDistributeBarrierExtendGetWorkspaceSize与aclnnInnerDistributeBarrierExtend扩展通路。distribute_barriertiling 的世界规模上限调整:CheckAndSetAttrs中MAX_WORLD_SIZE的判定新增npuArch == Ops::Base::DAV_9201,使其与DAV_3510一样使用MAX_WORLD_SIZE_A5。distribute_barrier注册新平台配置:distribute_barrier_def.cpp中新增this->AICore().AddConfig("ascend960dt", aicore_config_apt);。moe_update_expert注册新平台配置:moe_update_expert_def.cpp中新增this->AICore().AddConfig("ascend960dt", aicore_config);。


Incorrect?
Sep 30 Added label: cann-cla/yes
CANN-robot
Sep 30 Comments:
Sep 30 Comments:
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/op_host/*_def.cpp | ✅ 王永光, wang-minbo, chenjunjian11 (3/2) | ✅ 王永光 (1/1) |
| mc2 | ✅ wang-minbo, chenjunjian11 (2/2) | ✅ wang-minbo (1/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
yezhuoxi, thanks for your pull request. All authors of the commits have signed the CLA. 👍


Sep 30 Set captainmiaow,monologue815,jiang-lirui,Allan_Yu,wang-minbo,tgwsakiko_,tang-lei01,liudan12,chenjunjian11,yangzeheng,liuboxi,luobaiqing,zhong-zixin,libohao6,mabing1118,wangyongguang,macech as approver
Sep 30 Set captainmiaow,monologue815,jiang-lirui,Allan_Yu,wang-minbo,tgwsakiko_,tang-lei01,liudan12,chenjunjian11,yangzeheng,liuboxi,luobaiqing,zhong-zixin,libohao6,mabing1118,wangyongguang,macech as approver
89 messages are collapsed here。 See more
26 days ago Added label: lgtm
wangyongguang
26 days ago Comments:
26 days ago Comments:
/approve


26 days ago Added label: approved
26 days ago Closed associated issue
26 days ago Merged pull request
描述
Ascend960 moe_update_expert&barrier&combine
关联的Issue
https://gitcode.com/cann/ops-transformer/issues/6345
测试
文档更新
类型标签