已合并
modify quant_reduce_scatter hccl_context #6357
yifuxiong创建于 6月3日
modify quant_reduce_scatter hccl_context #6357
已合并
Pull Request已成功合入, 合并人@CANN-robot
(感谢 yifuxiong 的贡献)6月3日 添加了label:cann-cla/yes
CANN-robot
6月3日 评论:
6月3日 评论:
Thanks for your pull-request.
The full list of commands accepted by me can be found at here。
You can get sig-info at here
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/op_api/aclnn*.h | ✅ 王永光, 俞郑中 (2/2) | ✅ 王永光 (1/1) |
| */*/op_graph/*_proto.h | ✅ 王永光, 俞郑中 (2/2) | ✅ 王永光 (1/1) |
| */*/op_host/*_def.cpp | ✅ 王永光, 俞郑中 (2/2) | ✅ 王永光 (1/1) |
| build.sh | ✅ wang-minbo, 俞郑中 (2/2) | ✅ wang-minbo (1/1) |
| classify_rule.yaml | ✅ wang-minbo, 俞郑中 (2/2) | ✅ wang-minbo (1/1) |
| cmake | ✅ wang-minbo, 俞郑中 (2/2) | ✅ wang-minbo (1/1) |
| mc2 | ✅ wang-minbo, libohao6, 俞郑中 (3/2) | ✅ wang-minbo, libohao6 (2/1) |
| tests | ✅ wang-minbo, 俞郑中 (2/2) | ✅ wang-minbo (1/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
xiongyifu, thanks for your pull request. All authors of the commits have signed the CLA. 👍


6月3日 update merge request[project id: 7673863, iid: 6357, commit_id: bde05619b8c1e9d36891779c7cf35d58a063f795] virtual merging success
6月3日 update merge request[project id: 7673863, iid: 6357, commit_id: bde05619b8c1e9d36891779c7cf35d58a063f795] virtual merging success
此处折叠了310条消息 查看更多
6月6日 添加了label:ci-pipeline-passed
YuZhengzhong
6月6日 评论:
6月6日 评论:
/lgtm


wangyongguang
6月6日 评论:
6月6日 评论:
/approve


6月6日 添加了label:lgtmapproved
6月6日 合入了pull request
描述
切换修改新的hccl context开源方案
关联的Issue
https://gitcode.com/cann/ops-transformer/issues/2844
测试
文档更新
不涉及
类型标签
代码检视报告
检视概览
修复跟踪
mc2ContextStruct未零初始化= {};(mc2_context.cpp:739)%d格式化%ld(mc2_context.cpp:724)检视统计(当前状态)
已修复问题(原 FAIL/SUSPICIOUS,现已 PASS)
[SEC-1.3] 未初始化变量 — Mc2QuantReduceScatterContext ✅ 已修复
Mc2QuantReduceScatterContext mc2ContextStruct;声明时未零初始化,HcclEngineCtxCopy拷贝含未初始化字节的结构体到 device,构成 ISO C++ 未定义行为。Mc2QuantReduceScatterContext mc2ContextStruct = {};(mc2_context.cpp:739)= {}零初始化 → 已采纳[MC2-09] 量化参数类型一致性 — worldSize 格式化 ✅ 已修复
worldSize(int64_t)使用%d格式化打印,类型链路不一致。%ld(mc2_context.cpp:724)%d→%ld→ 已采纳[MC2-14] Tiling校验与结构规范 — v2 OpDef AutoContiguous ✅ 已修复
.AutoContiguous()声明。.FormatList({ge::FORMAT_ND});末尾分号断链,.AutoContiguous()成独立语句未生效),第2次更新移除分号,链式调用正确。// v2_def.cpp:39-40 (x) .FormatList({ge::FORMAT_ND}) .AutoContiguous(); // v2_def.cpp:53-54 (scales) .FormatList({ge::FORMAT_ND}) .AutoContiguous();通过条例
[quant_reduce_scatter_kernel_G1] SEC-1.1 PASS
[quant_reduce_scatter_kernel_G1] SEC-1.2 PASS
[quant_reduce_scatter_kernel_G1] SEC-1.3 PASS
[quant_reduce_scatter_kernel_G1] SEC-2.1 PASS
[quant_reduce_scatter_kernel_G1] SEC-2.2 PASS
[quant_reduce_scatter_kernel_G1] SEC-2.3 PASS
[quant_reduce_scatter_kernel_G1] TOPK-8 PASS
[quant_reduce_scatter_kernel_G1] MC2-01 PASS
[quant_reduce_scatter_kernel_G1] MC2-02 PASS
[quant_reduce_scatter_kernel_G1] MC2-04 PASS
[quant_reduce_scatter_kernel_G1] MC2-09 PASS
[quant_reduce_scatter_kernel_G1] MC2-11 PASS
[quant_reduce_scatter_kernel_G1] MC2-17 PASS
[quant_reduce_scatter_kernel_G1] MC2-18 PASS
[quant_reduce_scatter_kernel_G1] API-3 PASS
[quant_reduce_scatter_kernel_G1] API-6 PASS
[quant_reduce_scatter_kernel_G1] API-8 PASS
[quant_reduce_scatter_host_G1] SEC-1.1 PASS
[quant_reduce_scatter_host_G1] SEC-1.2 PASS
[quant_reduce_scatter_host_G1] SEC-1.3 PASS
[quant_reduce_scatter_host_G1] SEC-2.1 PASS
[quant_reduce_scatter_host_G1] SEC-2.2 PASS
[quant_reduce_scatter_host_G1] SEC-2.3 PASS
[shared] SEC-1.1 PASS
[shared] MC2-04 PASS
[shared] MC2-14 PASS
[shared] MC2-15 PASS
[quant_reduce_scatter_v2_host_G1] MC2-04 PASS
[quant_reduce_scatter_v2_host_G1] MC2-09 PASS
[quant_reduce_scatter_v2_host_G1] TOPK-1 PASS
[quant_reduce_scatter_v2_host_G1] TOPK-2 PASS