已合并
【PR】: 拼写错误修复 #1846
YiyangChen创建于 4月27日
【PR】: 拼写错误修复 #1846
已合并
YiyangChen创建于 4月27日
YiyangChen
YiyangChen
4月27日

Pull Request

描述

Runtime 拼写错误修复

变更类型

请选择本次引入的变更类型:

关联的Issue

核对清单

详细修复列表

2.1 acl 目录 (1处)

文件 行号 修复内容
src/acl/acl_tdt_queue/queue_process.cpp 333 sucessfully → successfully
src/acl/acl_tdt_channel/tensor_data_transfer.cpp 623 faild → failed
src/acl/aclrt_impl/context.cpp 244 paramete flags → parameter flags

2.2 runtime 目录 (6处)

这里异常分支打印 测试没覆盖
改了过不去门禁

2.3 dfx 目录 (9处)

文件 行号 修复内容
src/dfx/msprof/collector/dvvp/transport/prof_channel.cpp 83-84 seperated → separated, shoud → should, seperate → separate
src/dfx/msprof/collector/dvvp/transport/hash_data.cpp 262 seperated → separated
src/dfx/adump/adump/host/adx_dump_receive.cpp 25, 42, 61, 70 sended → sent, deivce → device
src/dfx/msprof/collector/dvvp/msprofbin/include/running_mode.h 72 neccessarySet_ → necessarySet_
src/dfx/msprof/collector/dvvp/msprofbin/src/running_mode.cpp 多处 neccessarySet_ → necessarySet_, unneccessary → unnecessary
src/dfx/msprof/collector/dvvp/msprofbin/src/running_mode_closed.cpp 143 neccessarySet_ → necessarySet_
src/dfx/msprof/collector/dvvp/msprofbin/src/running_mode_open.cpp 129 neccessarySet_ → necessarySet_
src/dfx/msprof/collector/dvvp/streamio/client/src/sender.cpp 281 sended → sent
src/dfx/msprof/collector/dvvp/adda/impl/ide_daemon_monitor.cpp 92, 101 sucess → success
src/dfx/msprof/collector/dvvp/msprofbin/src/msprof_bin.cpp 80 faild → failed

2.4 platform 目录 (4处)

文件 行号 修复内容
src/platform/platform_infos_utils.cpp 81, 84-85 resoved_path → resolved_path
src/platform/platform_infos_def.cpp 375-387 instrinsic → intrinsic
src/platform/platform_info.cpp 89 GeInstance → GeInstance (已修复编译错误)
src/platform/stub/platform_info_stub.cpp 25 GeInstance → GeInstance (已修复编译错误)

2.5 mmpa 目录 (38处)

__cpluscplus → __cplusplus 注释不影响,不修改

2.6 tsd 目录 (11处)

文件 行号 修复内容
src/tsd/tsdclient/inc/process_mode_manager.h 74, 133, 375, 389, 403 capablity → capability, occured → occurred, wheteher → whether, Capabity → Capability, Conct → Connect
src/tsd/tsdclient/inc/thread_mode_manager.h 68, 74 occured → occurred, capablity → capability
src/tsd/tsdclient/src/process_mode_manager.cpp 62, 710, 953 DEFUALT → DEFAULT, GetHdcConctStatus → GetHdcConnectStatus, UseStoredCapabityInfo → UseStoredCapabilityInfo

GetHdcConctStatus → GetHdcConnectStatus 拼写理论上也读的通,不修改

2.7 cmodel_driver 目录 (5处)

文件 行号 修复内容
src/cmodel_driver/driver_impl.h 25, 31 Pilling → Piling
src/cmodel_driver/driver_queue.h 45, 96, 99 reprot → report, Handdle → Handle, Triger → Trigger
src/cmodel_driver/driver_api.c 294-295 Handdle → Handle
src/cmodel_driver/driver_impl.c 35-36, 146 Triger → Trigger
src/cmodel_driver/driver_queue.c 89, 213 Handdle → Handle, Triger → Trigger

2.8 其他位置

文件 行号 修复内容
src/queue_schedule/common/queue_schedule_interface.h 23 sucess → success
src/aicpu_sched/aicpu_schedule/core/operator_kernel/communication/operator_kernel_remote_comm.cpp 126, 165 sucess → success
src/runtime/core/inc/tsch_defines.h 303 defination → definition
src/runtime/core/inc/task/task.hpp 149, 181 defination → definition
src/runtime/core/inc/task/task_info_base.hpp 305 defination → definition
src/runtime/core/inc/task/task_base.hpp 109 defination → definition
src/runtime/core/src/task/task_info/model/model_execute_task.cc 403 timout → timeout
src/dfx/adump/adcore/hdc/hdc_api.h 70 timout → timeout

三、未修复项 (API 兼容性考虑)

以下拼写错误涉及结构体/类型定义,可能影响 API 兼容性,暂未修复:

错误 正确拼写 位置 原因
dpuTack dpuTask MsprofDpuTrack 结构体字段 API 字段名
pmmComPletionKey pmmCompletionKey 类型定义 API 类型名
frequence_ frequency_ 多处变量名 大量使用,需全面测试
lenght length 日志字符串 少量,可忽略
conect connect 注释 可忽略
funtion function 注释 可忽略

顺便修复了一些 printf 格式不匹配的问题;
涉及到一些错误分支的日志打印,测试未覆盖,所以没有修改

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 YiyangChen 的贡献)
YiyangChenYiyangChen
4月27日 创建了 pull request,commit 31f74f75
YiyangChenYiyangChen
4月27日 添加了label:enhancement
YiyangChenYiyangChen
4月27日 关联了issue:源码中拼写错误
CANN-robot
CANN-robot成员
4月27日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here
You can get sig-info at here


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-cann/runtime 卢煜坤, 王涛 (2/2) 卢煜坤, 王涛 (2/1)
src/acl 卢煜坤, 王涛 (2/2) 卢煜坤, 王涛 (2/1)
src/aicpu_sched ZhaiPeiChao, 卢煜坤 (2/2) ZhaiPeiChao (1/1)
src/dfx 卢煜坤, zhuliangying (2/2) zhuliangying (1/1)
src/platform 卢煜坤, arthur_morgan_hw (2/2) arthur_morgan_hw (1/1)
src/queue_schedule ZhaiPeiChao, 卢煜坤 (2/2) ZhaiPeiChao (1/1)
src/runtime 卢煜坤, 王涛 (2/2) 卢煜坤, 王涛 (2/1)
src/tsd ZhaiPeiChao, 卢煜坤 (2/2) ZhaiPeiChao (1/1)
tests/ut/runtime 卢煜坤, 王涛 (2/2) 卢煜坤, 王涛 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

cyy010617, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robot成员
4月27日 添加了label:cann-cla/yes
此处折叠了143条消息 查看更多
CANN-robotCANN-robot成员
4月29日 添加了label:lgtmapproved
shikai成员
4月29日 评论:

/lgtm

likedislike
CANN-robot
CANN-robot成员
4月29日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: 卢煜坤, 王涛, ZhaiPeiChao, zhuliangying, arthur_morgan_hw.
Reviewers who wrote a comment of /lgtm are: arthur_morgan_hw, shikai-1, 卢煜坤, 王涛, ZhaiPeiChao, zhuliangying.

likedislike
CANN-robotCANN-robot成员
4月29日 关闭了关联的issue
CANN-robotCANN-robot成员
4月29日 合入了pull request