KKazu Hirata[mlir] Add #include <optional> (NFC)
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[mlir][PDLL] Don't use the result of Constraint::getDefName() when uniquing In the case of anonymous defs this may return the name of the base def class, which can lead to two different defs with the same name (which hits an assert). This commit adds a new getUniqueDefName method that returns a unique name for the constraint. Differential Revision: https://reviews.llvm.org/D124074 | 4 年前 | |
[mlir][PDLL] Don't use the result of Constraint::getDefName() when uniquing In the case of anonymous defs this may return the name of the base def class, which can lead to two different defs with the same name (which hits an assert). This commit adds a new getUniqueDefName method that returns a unique name for the constraint. Differential Revision: https://reviews.llvm.org/D124074 | 4 年前 | |
[mlir] Add #include <optional> (NFC) This patch adds #include <optional> to those files containing llvm::Optional<...> or Optional<...>. I'll post a separate patch to actually replace llvm::Optional with std::optional. This is part of an effort to migrate from llvm::Optional to std::optional: https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 | 3 年前 | |
[mlir:PDLL] Rework the C++ generation of native Constraint/Rewrite arguments and results The current translation uses the old "ugly"/"raw" form which used PDLValue for the arguments and results. This commit updates the C++ generation to use the recently added sugar that allows for directly using the desired types for the arguments and result of PDL functions. In addition, this commit also properly imports the C++ class for ODS operations, constraints, and interfaces. This allows for a much more convienent C++ API than previously granted with the raw/low-level types. Differential Revision: https://reviews.llvm.org/D124817 | 4 年前 | |
[mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite documentation This commit enables providing long-form documentation more seamlessly to the LSP by revamping decl documentation. For ODS imported constructs, we now also import descriptions and attach them to decls when possible. For PDLL constructs, the LSP will now try to provide documentation by parsing the comments directly above the decls location within the source file. This commit also adds a new parser flag enableDocumentation that gates the import and attachment of ODS documentation, which is unnecessary in the normal build process (i.e. it should only be used/consumed by tools). Differential Revision: https://reviews.llvm.org/D124881 | 4 年前 |