已合并
[New Image] Add nco 5.4.0-alpha04 for openEuler 24.03-lts-sp4 #3270
[New Image] Add nco 5.4.0-alpha04 for openEuler 24.03-lts-sp4 #3270
已合并
jcccx创建于 8 天前
jcccx
8 天前

Summary

Add nco 5.4.0-alpha04 built from the pinned upstream source for openEuler 24.03-lts-sp4.

  • Validated run: 31660957237.
  • Candidate SHA256: 15ba76539ec2606c6444c0b3d42d59a7efe19c0a3071acc98e1ca702a5c5a0fa.

Changes

Status File
Modified HPC/image-list.yml
Added HPC/nco/5.4.0-alpha04/24.03-lts-sp4/Dockerfile
Added HPC/nco/README.md
Added HPC/nco/doc/image-info.yml
Added HPC/nco/doc/picture/logo.png
Added HPC/nco/meta.yml
Added HPC/nco/results/5.4.0-alpha04/24.03-lts-sp4/aarch64.junit.xml
Added HPC/nco/results/5.4.0-alpha04/24.03-lts-sp4/version_info.json
Added HPC/nco/results/5.4.0-alpha04/24.03-lts-sp4/x86_64.junit.xml
Added HPC/nco/tests/test.sh

Adversarial review

Testcase review

  • Final result: approved after 1 round.
  • Coverage score: 0.9.
  • Round 1: approved — Tests are correct and sufficient for the NCO CLI contract: exact version assertion plus a genuine netCDF data path (ncgen fabricate -> ncatted write -> ncks -m readback -> ncap2 compute -> ncks -H exact value verification) matching the final Dockerfile with no Docker/network/lifecycle violations;...
    • Review input: full.
    • minorHPC/nco/tests/test.sh: The suite exercises only the netCDF classic (netCDF-3) data path; the netCDF4/HDF5 layer compiled into the image is never touched, so an image with broken HDF5/netCDF4 support (e.g., bad hdf5 linkage or a runtime hdf5 lib missing) would pass every assertion.

Fixer process

  • Native Fixer invocations: 2.
  • Round 1, attempt 1: fixed — Both architectures built and passed version + ncatted/ncks data-path tests but failed because ncap2 was never built: NCO's configure gates ncap2 on finding the antlr executable (HAVE_ANTLR != no), and the builder only installed antlr-C++ (headers/static lib), not antlr-tool (which ships /usr/bin/...
    • Trigger: native_validation_failure; failed architectures: x86_64, aarch64.
    • Change: HPC/nco/5.4.0-alpha04/24.03-lts-sp4/Dockerfile — Added antlr-tool to the builder-stage dnf install list (line 10: antlr-C++ antlr-tool gsl-devel)
  • Round 2, attempt 1: fixed — Both architectures built and ran ncap2/ncks correctly; the only failure was a stale test assertion expecting the old annotated temp_sq[i]=val output format that NCO 5.4.0-alpha04 no longer emits. Verified against the pinned upstream 5.4.0-alpha04 source that -H/--hdn means data-toggle/hidde...
    • Trigger: native_validation_failure; failed architectures: x86_64, aarch64.
    • Change: HPC/nco/tests/test.sh — Replaced the temp_sq[i]=val per-element substring checks with a whitespace-normalized assertion that the ncks output contains the exact CDL data line temp_sq=0,4,16,36;, and updated the PASS/FAIL messages accordingly.
  • Final outcome: the repaired candidate passed sealed native validation on x86_64 and aarch64.

Repository checks

Architecture Platform Image ID Duration Passed checks
x86_64 linux/amd64 sha256:fa8311b9abaa1a590598f83e970d98442a8cb151d6db0b623c54880cf87144be 5.547s native_build, runtime_test
aarch64 linux/arm64 sha256:4cff2517397b1dbbb425af461e64db2308fd8f5c4c54a6e5bd947ef74f574854 7.287s native_build, runtime_test
  • Promoted from validated run 31660957237.
  • Deterministic target contract: passed
  • Hadolint: 5 advisory findings.
    • /home/openeuler/actions-runner/_work/_temp/phase1-target/HPC/nco/5.4.0-alpha04/24.03-lts-sp4/Dockerfile:6 DL3041 warning: Specify version with dnf install -y -.
    • /home/openeuler/actions-runner/_work/_temp/phase1-target/HPC/nco/5.4.0-alpha04/24.03-lts-sp4/Dockerfile:14 SC2046 warning: Quote this to prevent word splitting.
    • /home/openeuler/actions-runner/_work/_temp/phase1-target/HPC/nco/5.4.0-alpha04/24.03-lts-sp4/Dockerfile:14 DL3003 warning: Use WORKDIR to switch to a directory
    • 2 more findings are preserved in the candidate artifact.

Confidence Score

  • Score: 0.9 (auto-merge).
  • Inputs: both native builds passed; both required runtime test sets passed; Hadolint advisories: 5; final metadata contract passed.
  • Target base SHA: 23a59d858085a33b05fd45fe9affc26dea3e2298.
  • Task ID: new-image-hpc-nco-5.4.0-alpha04-24.03-lts-sp4.
  • Target evidence: version_info.json, x86_64.junit.xml, aarch64.junit.xml.
  • Production candidate evidence: reports/results.json.
  • Candidate integrity: verified before delivery.

Checklist

likedislike
Pull Request已成功合入, 合并人@openeuler-ci-bot
(感谢 jcccx 的贡献)
Jjcccx
8 天前 创建了 pull request,commit 30523da4
atomgit-bot
atomgit-bot
8 天前 评论:

变更摘要

本 PR 为 openEuler 24.03-lts-sp4 新增 nco 5.4.0-alpha04 镜像,主要包含镜像注册、多阶段构建的 Dockerfile、版本元数据、使用文档以及验证测试与结果。构建阶段从 pinned 的上游源码编译 NCO,并额外安装 antlr-tool 以启用 ncap2;运行时阶段安装运行依赖、复制构建产物并配置库搜索路径与 PATH。测试覆盖版本精确断言以及 ncgenncattedncksncap2ncks 的 netCDF 数据通路验证。

主要改动

  • 镜像注册与版本映射: HPC/image-list.yml 新增 nco: nco 条目,HPC/nco/meta.yml 将标签 5.4.0-alpha04-oe2403sp4 映射到 5.4.0-alpha04/24.03-lts-sp4/Dockerfile,使新镜像纳入镜像列表管理。
  • 多阶段 Dockerfile 构建: HPC/nco/5.4.0-alpha04/24.03-lts-sp4/Dockerfile 在 builder 阶段安装 gccnetcdf-develhdf5-develantlr-toolgsl-devel 等并执行 ./configure --prefix=/usr/local --disable-udunits 编译安装;运行阶段安装 netcdf hdf5 gsl antlr-C++ perl 等依赖,复制 /usr/local 并写入 /etc/ld.so.conf.d/nco.confENV PATH=/usr/local/bin:$PATH
  • 文档与镜像元数据: HPC/nco/doc/image-info.yml 定义了名称、类别、描述、tags、docker pull/docker run 用法示例、license、依赖列表及 upstream 版本规则,为镜像提供完整的使用与元信息。
  • 验证测试脚本: HPC/nco/tests/test.sh 断言 ncks --version 输出与 EXPECTED_VERSION 精确一致,并通过 ncgen 生成、ncatted 写属性、ncks -m 回读、ncap2 计算 temp_sq=temp*tempncks -H 校验结果 temp_sq=0,4,16,36; 来验证核心功能。
  • 验证结果记录: 新增 HPC/nco/results/.../version_info.jsonx86_64.junit.xmlaarch64.junit.xml,记录 nco 5.4.0-alpha04 在 x86_64 与 aarch64 上的系统信息与 native_buildruntime_test 通过结果。
likedislike
atomgit-bot
atomgit-bot
8 天前 评论:

代码审查

✅ 未发现问题

likedislike
Jjcccx
8 天前 关联了issue:【new-image】add nco docker image on openEuler 24.03-LTS-SP4
openeuler-ci-botopeneuler-ci-bot成员
8 天前 将weibaohui,yangzhao_kl,jimmieme,duguhaotian,wonleing,zmr_2020,gaodaweiky,lu-wei-army,zhaoyifan28设为审查人
openeuler-ci-botopeneuler-ci-bot成员
8 天前 添加了label:sig/sig-CloudNative
openeuler-ci-bot
openeuler-ci-bot成员
8 天前 评论:

Welcome To openEuler Community

Hey @qq_42020325 , thanks for your contribution to the community.

Bot Usage Manual

I'm the Bot here serving you. You can find the instructions on how to interact with me at Here . That means you can comment below every pull request or issue to trigger Bot Commands.

Contact Guide

If you have any questions, please contact the SIG: sig-CloudNative ,
and any of the maintainers: @duguhaotian, @gaodaweiky, @jimmieme, @lu-wei-army, @weibaohui, @wonleing, @yangzhao_kl, @zhaoyifan28, @zmr_2020 ,

likedislike
openeuler-ci-botopeneuler-ci-bot成员
8 天前 添加了label:openeuler-cla/yes
openeuler-ci-bot
openeuler-ci-bot成员
8 天前 评论:

CLA Signature Pass

qq_42020325, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
openeuler-ci-botopeneuler-ci-bot成员
8 天前 添加了label:ci_processing
openeuler-ci-bot
openeuler-ci-bot成员
8 天前 评论:

门禁正在运行, 您可以通过以下链接查看实时门禁检查结果.
若您对门禁结果含义不清晰或者遇到问题不知如何解决,可参考门禁指导手册
门禁入口及编码规范检查: multiarch/openeuler/trigger/openeuler-docker-images/2981/console

likedislike
openeuler-ci-botopeneuler-ci-bot成员
8 天前 删除了label:ci_processing
lu-wei-army成员
3 天前 评论:

/retest

likedislike
openeuler-ci-botopeneuler-ci-bot成员
3 天前 添加了label:ci_processing
openeuler-ci-bot
openeuler-ci-bot成员
3 天前 评论:

门禁正在运行, 您可以通过以下链接查看实时门禁检查结果.
若您对门禁结果含义不清晰或者遇到问题不知如何解决,可参考门禁指导手册
门禁入口及编码规范检查: multiarch/openeuler/trigger/openeuler-docker-images/2987/console

likedislike
lu-wei-army成员
2 天前 评论:

/retest

likedislike
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:

门禁正在运行, 您可以通过以下链接查看实时门禁检查结果.
若您对门禁结果含义不清晰或者遇到问题不知如何解决,可参考门禁指导手册
门禁入口及编码规范检查: multiarch/openeuler/trigger/openeuler-docker-images/3005/console

likedislike
openeuler-ci-botopeneuler-ci-bot成员
2 天前 删除了label:ci_processing
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:
Check Name Build Result 详情 Build Details
check_sca SUCCESS #3005
check_package_license WARNING • 仓库copyright检查未通过: 缺少项目级Copyright声明文件
x86_64 check_build SUCCESS #2946
aarch64 check_build SUCCESS #2891
likedislike
openeuler-ci-botopeneuler-ci-bot成员
2 天前 添加了label:ci_successful
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:
likedislike
lu-wei-army成员
2 天前 评论:

/lgtm
/approve

likedislike
openeuler-ci-botopeneuler-ci-bot成员
2 天前 添加了label:approvedlgtm
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:

Review Code Feedback

  • The label lgtm, approved was added to this pull request. It means that lu-wei-army reviewed the code changes. 👋
Tips
  • If this pull request is not merged while all conditions are met, comment /check-pr to try again. 😄
likedislike
openeuler-ci-botopeneuler-ci-bot成员
2 天前 合入了pull request,合并节点 SHA:8d0458d521f460258b779f00b90100d3b7a513e2
openeuler-ci-botopeneuler-ci-bot成员
2 天前 删除了label:ci_successful
openeuler-ci-botopeneuler-ci-bot成员
2 天前 添加了label:ci_processing
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:

门禁正在运行, 您可以通过以下链接查看实时门禁检查结果.
若您对门禁结果含义不清晰或者遇到问题不知如何解决,可参考门禁指导手册
门禁入口及编码规范检查: multiarch/openeuler/trigger/openeuler-docker-images/3006/console

likedislike
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:
Image Tag Publish Result
nco:5.4.0-alpha04-oe2403sp4 :white_check_mark:SUCCESS
HPC/nco/README.md :white_check_mark:SUCCESS
likedislike
openeuler-ci-botopeneuler-ci-bot成员
2 天前 删除了label:ci_processing
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:
Check Name Build Result 详情 Build Details
check_sca SUCCESS #3006
check_package_license WARNING • 仓库copyright检查未通过: 缺少项目级Copyright声明文件
x86_64 check_build SUCCESS #2947
aarch64 check_build SUCCESS #2892
likedislike
openeuler-ci-botopeneuler-ci-bot成员
2 天前 添加了label:ci_successful
openeuler-ci-bot
openeuler-ci-bot成员
2 天前 评论:
likedislike