| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Type profiler by intercepting 'new' and 'delete' expressions. It stores mapping between object's starting addresses and their allocated types when a build option 'clang_type_profiler=1' is specified. It enables information like "an object at 0x37f3c88 is an instance of std::string." Nothing is changed when the option is not specified. It depends on a modified version of the LLVM/Clang compiler introduced at deps/third_party/llvm-allocated-type. BUG=123758 TEST=build with clang_type_profiler=1 and run type_profiler_unittests and type_profiler_map_unittests manually. Review URL: https://chromiumcodereview.appspot.com/10411047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158752 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reduce number of temporory objects created posting tasks Gives the GC a little less work todo, especially during repeatedly called async callpaths. Review URL: https://chromiumcodereview.appspot.com/10913284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158713 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Set svn:executable on windows executables. Remove third_party/tlslite/installers/ TBR=thestig@chromium.org BUG= TEST= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10178018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134316 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Trace PostTasks from post to run. To do this properly, we need a new type of trace event "FLOW" which will be drawn as lines in about:tracing from BEGIN to END. Also instruments SequencedWorkerPool and ChannelReader::DispatchInputData, which were not currently traced. BUG=79942 Review URL: https://codereview.chromium.org/10913242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157288 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix stack corruption bug in FilePathWatcherTest.Callback. BUG=145653 Review URL: https://chromiumcodereview.appspot.com/10912017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154406 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Check string and UI direction in GetDisplayStringInLTRDirectionality, etc. Continue always wrapping the string in RTL UI. (in case it's appended to an RTL string later, etc.) Additionally wrap strings with RTL first strong characters in LTR UI. (previously, text inherited UI base direction, now it uses the first strong char) Add, expand upon, and cleanup unit tests. BUG=144541 TEST=Download shelf (and other UI) file paths are shown as LTR (without stray rendered glyphs or other regressions). Review URL: https://chromiumcodereview.appspot.com/10910128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156459 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implements iOS device util methods. Utility methods in this package provides IOS device-specific information. BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/10818023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150324 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix the failed case ValueStoreTest.DotsInKeyNamesWithDicts for Android Json parser uses a stack-based input copy string and the parsed result 'Value' references the internal pointer of the input copy string. To make the references valid, 'Value' has one member std::string to swap its content with the input copy string. On other platforms, the member std::string can get the internal pointer of the input copy string. However, on Android, std::string just swaps the content of two strings instead of swapping their internal pointers. This makes the pointer reference of value invalid. Fix this by forcing options |= JSON_DETACHABLE_CHILDREN for Android so disable this optimization. BUG=139434 TEST=run_tests.py -s unit_tests Review URL: https://chromiumcodereview.appspot.com/10831322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152944 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement RemovableDeviceNotifications for Mac This CL adds a class to monitor disks being added, removed or changed. When ever such events happen notifications are posted through base::SystemMonitor. BUG=110400, 110823 Review URL: https://chromiumcodereview.appspot.com/10919185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157002 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add WARN_UNUSED_RESULT to scoped_refptr::release. Also fixed some possible leaks related by scoped_refptr::release. See https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/b5thcBgubsM BUG= Review URL: https://chromiumcodereview.appspot.com/10874054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153719 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SampleSet -> HistogramSamples which can be reused by SparseHistogram BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Prevent crashes in mime_util_xdg. Review URL: https://chromiumcodereview.appspot.com/10831337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152347 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable memory profiler on Linux when TC_MALLOC is enabled. Added a tc_malloc memory extension to get bytes allocated on current thread (GetBytesAllocatedOnCurrentThread API call). R=jam@chromium.org,jar@chromium.org BUG=139667 TEST=test about:profiler after setting the env variable CHROME_PROFILER_TIME=1. In about:profiler, it will show the memory allocated per thread. This change impacts linux only. This is same as the following previously approved CL. Added needed BASE_EXPORT for kAlternateProfilerTime and SetAlternateTimeSource. the https://chromiumcodereview.appspot.com/10820063/ Review URL: https://chromiumcodereview.appspot.com/10834199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150477 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change explicit usage of each type of message loop in WaitableEventWatcher tests to instead loop through an array of message loop types. This allows for easier-to-read code while including a platform that cannot run the tests on every kind of message loop. Specifically, iOS cannot run the UI loop for unit tests. Un-exclude synchronization/waitable_event_watcher_unittest.cc on ios in base.gyp. BUG=b/6825256 TEST=None Review URL: https://chromiumcodereview.appspot.com/10790028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147198 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Document bad pattern in base::SystemMonitor. NOTRY=TRUE BUG=149059 Review URL: https://chromiumcodereview.appspot.com/10917243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156634 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move base Java utils to base/test/android/javatests. gyp targets should not depend on tests from other packages, but instead be able to depend on their test utils. The target including the base utilities is called base_java_test_support and contains files from base/test/android/javatests. base_java_test_support was also the name of the wrongly named target for building base/android/javatests, but since only contained util-classes, no new target has been created for tests of base/android/java. BUG=151561,150773 Review URL: https://chromiumcodereview.appspot.com/10974012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158422 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update license tool to check several additional directories Some of these directories are currently excluded from the license check. This change fixes the metadata where required and removes them from PRUNE_PATHS. Other directories contain third-party code, but aren't in directories named 'third-party', so aren't checked by the license tool by default. This change fixes the metadata where required and adds them to ADDITIONAL_PATHS. To avoid adding to about:credits licenses for modules that don't ship as part of the product, this change also introduces a special 'NOT_SHIPPED' value for the 'License File' field. This will simplify the process of adding a tool to check license compatibility for the Android WebView build. BUG=138921 Review URL: https://chromiumcodereview.appspot.com/10830201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150800 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Trace PostTasks from post to run. To do this properly, we need a new type of trace event "FLOW" which will be drawn as lines in about:tracing from BEGIN to END. Also instruments SequencedWorkerPool and ChannelReader::DispatchInputData, which were not currently traced. BUG=79942 Review URL: https://codereview.chromium.org/10913242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157288 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158402 - Base: disable the scoped handle verifier for M23 beta. BUG=152037 TEST=none TBR=willchan@chromium.org Review URL: https://codereview.chromium.org/10978006 TBR=rvargas@google.com Review URL: https://codereview.chromium.org/10978007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158405 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable parts of base_untrusted that are used by remoting client 1. base64, rand_util, threading, time and threads were previosly disabled in base_untrusted. Remoting code depends on these parts of base, so they need to be enabled. 2. Implemented NaCl version of rand_util. 3. Enabled glibc version of base_untrusted BUG=134216 Review URL: https://chromiumcodereview.appspot.com/10795083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove myself from base/OWNERS. I don't want to be involved in it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122177 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Allow Objective-C files in base/test/. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10695172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146348 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 144488 - For unit tests, track additions to AtExitManager and warn. While trying to bullet proof a unit test, I had trouble getting very far when running all tests in shuffle mode. Tracked that back to a few other tests doing stuff that accessed Singleton()s outside of a test-scoped ShadowingAtExitManager. Seemed to me that should be an invariant around any unit test, so created this towards that end, hopefully helping stabilize out unit_tests a bit more. BUG=133403 Review URL: https://chromiumcodereview.appspot.com/10582012 TBR=scottbyer@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148405 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 144488 - For unit tests, track additions to AtExitManager and warn. While trying to bullet proof a unit test, I had trouble getting very far when running all tests in shuffle mode. Tracked that back to a few other tests doing stuff that accessed Singleton()s outside of a test-scoped ShadowingAtExitManager. Seemed to me that should be an invariant around any unit test, so created this towards that end, hopefully helping stabilize out unit_tests a bit more. BUG=133403 Review URL: https://chromiumcodereview.appspot.com/10582012 TBR=scottbyer@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148405 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Callback API Change: Reimplement Bind(); support IgnoreResult, full currying, and use less types. The main API change IgnoreResult() and fully currying. See unittest for what the new API looks like. The rest of the changes are done to support that. Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object. Now, IgnoreResult() wraps the function like Unretained(). As an incidental benefit, the new implementation gave us fully currying for free. Also, the new implementation scales better when supporting higher arities of functions. The new type growth is: (n^2 + 20n) / 2 as opposed to (3n^2 + 17n) / 2 where n == arity. For n = 6 and n=10, the new implementation has 81 and 155 templates respectively. The old implementation had 105 and 235 templates respectively. BUG=35233,98919,98542 TEST=existing unittests Review URL: http://codereview.chromium.org/8483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110975 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix atomic ops on ARM to compile in NaCl untrusted targets. This makes the arm version of atomicops_internals use gcc intrinsics for the NaCl build. Other linux targets won't change. BUG=116317 TEST=compiles on arm bots Review URL: https://chromiumcodereview.appspot.com/10831358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152791 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix atomicops internal implementation using GCC intrinsics. BUG=116317 TEST=none Review URL: https://chromiumcodereview.appspot.com/10879019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152833 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Have iOS use the same atomicops_internal implementation that Mac uses. The atomicops_internal file for Mac and iOS is not actually architecture-specific, so it is being renamd to be arch-independent. BUG=b/6754112 TEST=None Review URL: https://chromiumcodereview.appspot.com/10696193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146584 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
NO CODE CHANGE Normalize end of file newlines in base/. All files end in a single newline. Review URL: http://codereview.chromium.org/42011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11329 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
iwyu: Cleanup in the following files: * at_exit.cc * atomicops.h * base_paths.h * bzip2_error_handler.cc * callback_internal.h * command_line.cc * cpu.cc * environment.h * event_recorder.cc * file_descriptor_shuffle.cc * file_path.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/6759017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80340 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move base Java utils to base/test/android/javatests. gyp targets should not depend on tests from other packages, but instead be able to depend on their test utils. The target including the base utilities is called base_java_test_support and contains files from base/test/android/javatests. base_java_test_support was also the name of the wrongly named target for building base/android/javatests, but since only contained util-classes, no new target has been created for tests of base/android/java. BUG=151561,150773 Review URL: https://chromiumcodereview.appspot.com/10974012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158422 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Type profiler by intercepting 'new' and 'delete' expressions. It stores mapping between object's starting addresses and their allocated types when a build option 'clang_type_profiler=1' is specified. It enables information like "an object at 0x37f3c88 is an instance of std::string." Nothing is changed when the option is not specified. It depends on a modified version of the LLVM/Clang compiler introduced at deps/third_party/llvm-allocated-type. BUG=123758 TEST=build with clang_type_profiler=1 and run type_profiler_unittests and type_profiler_map_unittests manually. Review URL: https://chromiumcodereview.appspot.com/10411047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158752 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Address outstanding comments from CL 10384140 This adds some clarifying comments, no code-changes here. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10406022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137695 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base: No need to inherit testing::Test in base64 unittest. TEST=base_unittests TBR=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10969059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158203 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix PathServiceTest.Get on iOS. DIR_USER_DESKTOP does not apply on iOS, so exclude it from the set of paths that are tested. BUG=b/151050 Review URL: https://chromiumcodereview.appspot.com/10970019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158607 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ui/base: Move message_box_win.{h,cc} to ui/base/win. R=sky@chromium.org TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/9669028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126144 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make base_unittests_run use run_test_cases.py. This will speed up the swarm infrastructure without any modification. Only do base_unittests_run for now in case something blows up. A follow up CL will do all of net_unittests, unit_tests and browser_tests. These tests will benifit much more from the speed up than base_unittests. TBR=cmp@chromium.org NOTRY=true BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10667042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147585 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make NaCl IPC-based PPAPI proxy build on ARM. This change modifies the build to fix compile and link failures. It introduces a build/common_untrusted.gypi file, to add things that are needed by all untrusted targets that build Chrome code. BUG=116317 TEST=compiles native_client.gyp:nacl_ipc_irt target on ARM. Review URL: https://chromiumcodereview.appspot.com/10871009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153074 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 154885 - Extend base::Callback to 8 arguments. This is required by the Android port in order to support using base::Bind with the FaviconService::GetRawFaviconForURL method. This is used in code yet in process of being upstreamed (bug 138755). BUG=146003 Review URL: https://chromiumcodereview.appspot.com/10919055 TBR=leandrogracia@chromium.org Review URL: https://chromiumcodereview.appspot.com/10915080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154901 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add quick reference for bind/callback usage. Review URL: https://chromiumcodereview.appspot.com/10692147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146425 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove task.h and finish base::Bind() migration. Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove task.h and finish base::Bind() migration. Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Revert 154885 - Extend base::Callback to 8 arguments. This is required by the Android port in order to support using base::Bind with the FaviconService::GetRawFaviconForURL method. This is used in code yet in process of being upstreamed (bug 138755). BUG=146003 Review URL: https://chromiumcodereview.appspot.com/10919055 TBR=leandrogracia@chromium.org Review URL: https://chromiumcodereview.appspot.com/10915080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154901 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add quick reference for bind/callback usage. Review URL: https://chromiumcodereview.appspot.com/10692147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146425 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 154885 - Extend base::Callback to 8 arguments. This is required by the Android port in order to support using base::Bind with the FaviconService::GetRawFaviconForURL method. This is used in code yet in process of being upstreamed (bug 138755). BUG=146003 Review URL: https://chromiumcodereview.appspot.com/10919055 TBR=leandrogracia@chromium.org Review URL: https://chromiumcodereview.appspot.com/10915080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154901 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add virtual and OVERRIDE to base/ implementation files BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Callback API Change: Reimplement Bind(); support IgnoreResult, full currying, and use less types. The main API change IgnoreResult() and fully currying. See unittest for what the new API looks like. The rest of the changes are done to support that. Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object. Now, IgnoreResult() wraps the function like Unretained(). As an incidental benefit, the new implementation gave us fully currying for free. Also, the new implementation scales better when supporting higher arities of functions. The new type growth is: (n^2 + 20n) / 2 as opposed to (3n^2 + 17n) / 2 where n == arity. For n = 6 and n=10, the new implementation has 81 and 155 templates respectively. The old implementation had 105 and 235 templates respectively. BUG=35233,98919,98542 TEST=existing unittests Review URL: http://codereview.chromium.org/8483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110975 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved bits.h from O3D to Chrome base. TEST=none BUG=none Review URL: http://codereview.chromium.org/373001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32428 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
base: export GetBuildTime A need for the function came up in another context so this change exposes it from base/. BUG=none TEST=base_unittests Review URL: http://codereview.chromium.org/8510027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109638 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base: export GetBuildTime A need for the function came up in another context so this change exposes it from base/. BUG=none TEST=base_unittests Review URL: http://codereview.chromium.org/8510027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109638 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Revert 154885 - Extend base::Callback to 8 arguments. This is required by the Android port in order to support using base::Bind with the FaviconService::GetRawFaviconForURL method. This is used in code yet in process of being upstreamed (bug 138755). BUG=146003 Review URL: https://chromiumcodereview.appspot.com/10919055 TBR=leandrogracia@chromium.org Review URL: https://chromiumcodereview.appspot.com/10915080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154901 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename template parameter in callback from RunType to BindRunType. The original code is correct. The fix is a work around for mips gcc 4.3.2. The constructor of Callback is a template. In the context of the constructor, there are two type named RunType. One is its second template parameter, the other is a typedef inside Callback. The correct compiler will pick the "local" one, i.e. the template parameter. However, gcc 4.3.2 on mips incorrectly uses the typedef. The solution is to rename the template parameter. After discussing with ajwong, we decide to push the work around up stream as it is cleaner not to shadow names anyways. BUG= Review URL: https://chromiumcodereview.appspot.com/10836215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151383 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|. Callers can use cb.Reset().Run(args...); to avoid reentrancy-like bugs. Replace the special-purpose versions of ResetAndRunCB in the media/ codebase with this more-general facility. Review URL: http://codereview.chromium.org/9717021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128772 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make Callback.Reset safe against deleting itself. BUG=99159 TEST=CallbackTest.ResetRefCountedOwnerOfCallback Review URL: https://chromiumcodereview.appspot.com/10388060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142011 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make Callback.Reset safe against deleting itself. BUG=99159 TEST=CallbackTest.ResetRefCountedOwnerOfCallback Review URL: https://chromiumcodereview.appspot.com/10388060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142011 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make Callback.Equals() only work when comparing against the same type. Previously, we were using the base class's comparator to check equality, which allows us to make comparisons across callbacks of different types. This disallows such a thing. BUG=none TEST=New no-compile test. Review URL: http://codereview.chromium.org/7780016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100565 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base::Bind: Implement a 1-arity CancelableCallback and use this to implement net::CancelableCompletionClosure. BUG=none TEST=none R=ajwong@chromium.org Review URL: http://codereview.chromium.org/8662047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112279 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make CHECK not print messages in official builds This cuts down on the number of strings in the executable, as well as executable code to print them. On Linux, this saves 208kb on a stripped official build (chrome executable file went from 64569072 bytes -> 64782064 bytes) On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes) On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes) Fix test failure in logging_unittest.cc in official builds. Add new executable check_example for easy testing of changes to the CHECK macros. BUG=101561 TEST= Review URL: http://codereview.chromium.org/8734021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Allow callers of CommandLine::Init to know whether they were the first caller. If there are multiple callers to Init, only one should call Reset. The boolean return value tells the caller whether they are the one responsible for the destruction. As long as the lifetimes of clients are strictly nested (i.e., a client X who uses CommandLine after client Y has initialized it always ceases its use before client Y destroys it) this secures access to this singleton object. One client in particular is updated to follow this model. I will submit follow-up CLs for remaining clients (at least, those who currently do call Reset). This is motivated by a crash in the chrome_frame_net_tests. This test executable nests a TestSuite within the lifetime of a ContentMainRunner (i.e., the engine that is typically used to run Chrome). The content layer initializes CommandLine and Resets it, but the TestSuite also resets it, leading to a DCHECK. This is currently the last remaining issue keeping the chrome_frame_net_tests off the waterfall, and I am very eager to get them back there to reduce the likelihood of further issues being introduced. BUG=114369 TEST=A test has been modified to reflect this change. Review URL: http://codereview.chromium.org/9477001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123763 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow callers of CommandLine::Init to know whether they were the first caller. If there are multiple callers to Init, only one should call Reset. The boolean return value tells the caller whether they are the one responsible for the destruction. As long as the lifetimes of clients are strictly nested (i.e., a client X who uses CommandLine after client Y has initialized it always ceases its use before client Y destroys it) this secures access to this singleton object. One client in particular is updated to follow this model. I will submit follow-up CLs for remaining clients (at least, those who currently do call Reset). This is motivated by a crash in the chrome_frame_net_tests. This test executable nests a TestSuite within the lifetime of a ContentMainRunner (i.e., the engine that is typically used to run Chrome). The content layer initializes CommandLine and Resets it, but the TestSuite also resets it, leading to a DCHECK. This is currently the last remaining issue keeping the chrome_frame_net_tests off the waterfall, and I am very eager to get them back there to reduce the likelihood of further issues being introduced. BUG=114369 TEST=A test has been modified to reflect this change. Review URL: http://codereview.chromium.org/9477001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123763 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Upgrade AlignedMemory to support dynamic allocations. Adds two new methods: AlignedAlloc and AlignedFree for creating and destroying dynamic aligned allocations respectively. Also adds a helper class, ScopedPtrAlignedFree, for use with scoped_ptr_malloc. AlignedAlloc uses posix_memalign for OS X (now that we're targeting 10.6), Linux and _aligned_alloc() on Windows. Android and NaCl use memalign() since they do not expose posix_memalign() and memalign() is safe to use with free() on those platforms. Also hacks around a bug in Visual C++ where __alignof will sometimes return zero: http://connect.microsoft.com/VisualStudio/feedback/details/682695/c-alignof-fails-to-properly-evalute-alignment-of-dependent-types BUG=none TEST=base_unittests + new test, trybots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147988 Review URL: https://chromiumcodereview.appspot.com/10796020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148483 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix base::CPU detection. ARCH_CPU_X86_FAMILY was never being defined, causing base::CPU::Initialize to be a no-op. BUG= TEST= Review URL: http://codereview.chromium.org/9836125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130046 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix base::CPU detection. ARCH_CPU_X86_FAMILY was never being defined, causing base::CPU::Initialize to be a no-op. BUG= TEST= Review URL: http://codereview.chromium.org/9836125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130046 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add inline annotation for base::MakeCriticalClosure() in platform other than ios. The implementation of this method is basically noop in platforms other than ios and it is put in the header file; this change adds inline annotation to avoid duplicate symbol link error on other platforms. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/10837182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150831 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add APIs to protect critical tasks on iOS. On iOS, once an application goes into the background, it receives no CPU cycles until it is moved to foreground. At any time the OS may kill the application, but the application itself is never told or given any chance to clean up. Thus the time before going into the background is critical to ensure certain tasks have chance to complete. Luckily, an application may ask for a little more time when going into the background by calling certain methods that let the OS know it wants to perform some short-lived work in the background. This cl provides APIs to protect critical tasks in this case. - A class is provided to mark the beginning and end of a critical task for iOS. - A wrapper around a task is introduced that annotates that a class is "critical". Right now we have the wrapping code for iOS and it is just a no-op for other platforms. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/10835032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149422 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
NO CODE CHANGE Normalize end of file newlines in base/. All files end in a single newline. Review URL: http://codereview.chromium.org/42011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11329 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add virtual and OVERRIDE to base/ implementation files BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Deprecate wstring version of PathService::Get() in webkit. Review URL: http://codereview.chromium.org/99266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15032 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base. [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
iwyu: Cleanup in the following files: * at_exit.cc * atomicops.h * base_paths.h * bzip2_error_handler.cc * callback_internal.h * command_line.cc * cpu.cc * environment.h * event_recorder.cc * file_descriptor_shuffle.cc * file_path.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/6759017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80340 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add virtual and OVERRIDE to base/ implementation files BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
PrintTo for FilePath -- Pretty-print when comparing FilePaths in gtest Used in upcoming http://codereview.chromium.org/10996005/ (and potentially others). BUG=148539 TEST=Write a test with an error comparing two FilePaths and confirm the paths' values are printed by gtest as opposed to the byte-representation. Review URL: https://chromiumcodereview.appspot.com/10984028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158893 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
PrintTo for FilePath -- Pretty-print when comparing FilePaths in gtest Used in upcoming http://codereview.chromium.org/10996005/ (and potentially others). BUG=148539 TEST=Write a test with an error comparing two FilePaths and confirm the paths' values are printed by gtest as opposed to the byte-representation. Review URL: https://chromiumcodereview.appspot.com/10984028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158893 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
foo (1).user.js, not foo.user (1).js. BUG=136795 Review URL: https://chromiumcodereview.appspot.com/10872072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153409 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, to remove static_cast<> in the callers. BUG=139130 TEST=try bots Review URL: https://chromiumcodereview.appspot.com/10855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org BUG=132825, 148539 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* (run tests on XP as well) Review URL: https://chromiumcodereview.appspot.com/10909171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix temp dir path for Android. "/data/local/tmp" is not writable by applications. BUG=125059 TEST= Review URL: https://chromiumcodereview.appspot.com/10332218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137719 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add support for the cgroups config we have in chromeos BUG=None TEST=None Review URL: http://codereview.chromium.org/6713089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79308 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Publish app shortcuts on Mac With this CL when installing a platform app we do the following - copy the stub App Mode Loader.app bundle to a tmp folder with the correct app name - update the info plist - copy the final app to /Applications - if we don't have write permission to /Application then we copy the app to ~/Application instead Note, for now I'm putting this feature behind a --enable-platform-apps flag. BUG=112651 TEST= Review URL: http://codereview.chromium.org/9346013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121613 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove FileEnumerator::IsLink BUG=133270 Review URL: https://chromiumcodereview.appspot.com/10916204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156229 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: IWYU for base/file_util_proxy.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/10115017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133520 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: IWYU for base/file_util_proxy.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/10115017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133520 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixed file leak in test. R=kinuko@chromium.org, jar@chromium.org BUG=130497 TEST=unit_tests --gtest_filter=FileUtilProxyTest.CreateTemporary Review URL: https://chromiumcodereview.appspot.com/10446109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140006 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org BUG=132825, 148539 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* (run tests on XP as well) Review URL: https://chromiumcodereview.appspot.com/10909171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org BUG=132825, 148539 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* (run tests on XP as well) Review URL: https://chromiumcodereview.appspot.com/10909171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make the Mac Info.plist SCM keys generic This allows the file_version_info_mac code to make sense for any SCM (e.g., git). It also aligns the use of FetchVersionInfo to its documented behavior, which is to return a (branch, revision) tuple for "some appropriate revision control system". BUG=None Review URL: https://chromiumcodereview.appspot.com/10828228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153101 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Base: Fix FileVersionInfo::CreateFileVersionInfoForCurrentModule so that when base is built as a dll, the module that is inspected for the version info is the one that makes the call instead of base.dll BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6897016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82754 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use isfinite() on all POSIX platforms Based on some research online, it appears this should work everywhere. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10700183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146361 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make GlobalDescriptors::MaybeGet return -1 when the key is not found. BUG=None TEST=Unit tests should still pass. Review URL: https://chromiumcodereview.appspot.com/10387218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144350 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Retry to checkin a version of gmock, modified to use our boost_tuple in VS2005. This checkin adds gmock, and a small example of how to write a gmock-based unittest. Original Review URL: http://codereview.chromium.org/113807 Review URL: http://codereview.chromium.org/115846 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17066 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move hash.h/cc from net to base. Review URL: https://chromiumcodereview.appspot.com/10920026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154554 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move hash.h/cc from net to base. Review URL: https://chromiumcodereview.appspot.com/10920026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154554 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Tighten up DEPS some more. NaCl/service process code are including internal content files. Fix the instances other sandbox stuff, which I'll do in a followup. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10512010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140346 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Tighten up DEPS some more. NaCl/service process code are including internal content files. Fix the instances other sandbox stuff, which I'll do in a followup. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10512010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140346 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Tighten up DEPS some more. NaCl/service process code are including internal content files. Fix the instances other sandbox stuff, which I'll do in a followup. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10512010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140346 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Clean up of -Wunused-but-set-variable (gcc 4.6) BUG=80071 TEST=base_unittests Review URL: http://codereview.chromium.org/7232025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90489 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Allow linker initialization of lazy instance Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add virtual and OVERRIDE to base/ implementation files BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
clang: Remove an ancient workaround. This was added 2 years ago when Evan added the initial clang support (http://codereview.chromium.org/522020). It's no longer needed. BUG=none Review URL: https://chromiumcodereview.appspot.com/10933014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156002 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use static_cast in LinkNode<T>::value() so that it works with multiple inheritance. R=eroman BUG=none TEST=LinkedList.MultipleInheritanceNode Review URL: http://codereview.chromium.org/266020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28439 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOS This makes ChromeOS more consistent with Linux, which uses the DISTRIB_DESCRIPTION from /etc/lsb-release here. We have a different pre-existing mechanism in the code for reading the value (since ChromeOS doesn't have the lsb_release tool), but it's conceptually the same thing. This makes it possible to search / catagorize ChromeOS crash reports based on the build, or other information about the ChromeOS version. It also allows the matching build/symbols to be more easily found given a crash report. There's no need for Aura customization of distro anymore - that was added when Aura was experimental. All ChromeOS is now Aura. BUG=142630 Review URL: https://chromiumcodereview.appspot.com/10827322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151741 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create a new SetuidSandboxClient class. We move the setuid sandbox "client" code to its own location in /sandbox/linux/suid/client and we create a SetuidSandboxClient class to use it. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10807059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147993 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[UMA] Use proper C++ objects to serialize tracked_objects across process boundaries. See https://chromiumcodereview.appspot.com/9702014/ for the original code review. Uploading to a new issue due to an AppEngine error... BUG=103480 TEST=none (refactoring, no functional change expected) TBR=jam@chromium.org,jar@chromium.org,eroman@chromium.org,jhawkins@chromium.org,ajwong@chromium.org Review URL: http://codereview.chromium.org/10077001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132109 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[UMA] Use proper C++ objects to serialize tracked_objects across process boundaries. See https://chromiumcodereview.appspot.com/9702014/ for the original code review. Uploading to a new issue due to an AppEngine error... BUG=103480 TEST=none (refactoring, no functional change expected) TBR=jam@chromium.org,jar@chromium.org,eroman@chromium.org,jhawkins@chromium.org,ajwong@chromium.org Review URL: http://codereview.chromium.org/10077001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132109 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Supressing unreferenced variable warning in nacl build. g_vlog_info_prev is not currently referenced in the nacl build of logging.cc. Cast to void to suppress warning and reduce build spew. BUG=http://code.google.com/p/chromium/issues/detail?id=148648 TEST=no spew on incremental R=bbudge@chromium.org,brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10960029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158201 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert "Revert 147986 - [Android] Add remaining build/common.gypi changes from downstream and strip NOTIMPLEMENTED()s from official builds." Relanding http://codereview.chromium.org/10816039/ but removing the clang parts and fixing x86. This reverts commit 7fc96c8b734fc9bc8152329d99e8ee3f3de14a65. BUG=137569 Review URL: https://chromiumcodereview.appspot.com/10809081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148338 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix official build breakage introduced by 112649 BUG=107753 TEST= Review URL: http://codereview.chromium.org/8968008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114775 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Mac] Add a perf test that counts the number of Mach ports in the browser. BUG=105513 TEST=This is one. Review URL: http://codereview.chromium.org/9193024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119541 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
MD5Update function uses StringPiece instead of raw buffer. BUG=none TEST=base_unittests --gtest_filter=MD5.ContextWithStringData* Review URL: http://codereview.chromium.org/7466003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94203 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
MD5Update function uses StringPiece instead of raw buffer. BUG=none TEST=base_unittests --gtest_filter=MD5.ContextWithStringData* Review URL: http://codereview.chromium.org/7466003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94203 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Trace PostTasks from post to run. To do this properly, we need a new type of trace event "FLOW" which will be drawn as lines in about:tracing from BEGIN to END. Also instruments SequencedWorkerPool and ChannelReader::DispatchInputData, which were not currently traced. BUG=79942 Review URL: https://codereview.chromium.org/10913242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157288 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Trace PostTasks from post to run. To do this properly, we need a new type of trace event "FLOW" which will be drawn as lines in about:tracing from BEGIN to END. Also instruments SequencedWorkerPool and ChannelReader::DispatchInputData, which were not currently traced. BUG=79942 Review URL: https://codereview.chromium.org/10913242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157288 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make new TaskRunner, SequencedTaskRunner, and SingleThreadTaskRunner interfaces TaskRunner just has Post{,Delayed}Task(), SequencedTaskRunner extends Executor to have ordering guarantees and PostNonNestable{,Delayed}Task(), and SingleThreadTaskRunner extends SequencedTaskRunner and guarantees execution on a single thread. Move a bunch of methods from MessageLoopProxy into the TaskRunner classes and make it inherit from SingleThreadTaskRunner. BUG=110973 TEST= Review URL: https://chromiumcodereview.appspot.com/9169037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121999 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove old Sleep and PostDelayedTask interfaces that use int ms instead of TimeDelta. The previous version of this patch was reverted due to crashing cros_x86 and cros_tegra2 builds. See: http://codereview.chromium.org/9703053/ BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10572030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143401 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add virtual and OVERRIDE to base/ implementation files BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add virtual and OVERRIDE to base/ implementation files BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Convert ProtocolHandlerRegistry to be a ProfileKeyedService. BUG=129200 TEST=protocol_handler_registry_browsertest.cc,protocol_handler_registry_unittest.cc willchan@ -> profile_io changes +bauerb -> content_settings changes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147597 Review URL: https://chromiumcodereview.appspot.com/10546083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147745 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
FBTF: Moves code to the headers. One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file. (Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3452030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Uses gyp "rules" rather than "actions" templates for the JNI generator. This allow finer grain control over what is rebuilt. Also, since we have approval over the generated header file name, it greatly simplifies both the generator and also all the gyp files as they no longer need to list the header file and keep in sync with the java file, so the process now is as simple as adding a single java file to the sources. BUG=137069 TEST=build on android Review URL: https://chromiumcodereview.appspot.com/10798010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147515 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
aura-x11: Make sure the events targetted for root-window reaches all the root-window dispatchers. BUG=133721 Review URL: https://chromiumcodereview.appspot.com/10911157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155598 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Merge aura::DispatcherLinux into base::MessagePumpAuraX11. The majority of incoming XEvents are related to specific XWindows and need to be sent to a specific MessagePumpDispatcher. MessagePumpAuraX11 would pass the XEvent to aura::DispatcherLinux, which would pass it to the next dispatcher. Because of the chromeos unit tests, which spin up a new XDisplay on each test, these two objects need to have equivalent lifetimes. Due to the incoming clipboard support (which this patch was split off from), DispatcherLinux can't live in aura:: anymore. The solution is to merge the two objects that have to have equivalent lifetimes together. The one ui:: specific check was split off into an MessagePumpObserver. This also got rid of those hacks where we would static downcast to DispatcherLinux from MessagePumpDispatcher. BUG=130805 Review URL: https://chromiumcodereview.appspot.com/10895020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154174 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Expose the sandbox related code through the content API. I did a bit of cleanup while I was doing this. -got rid of SandboxInitWrapper, since I didn't see a need to expose given that we can just expose sandbox::SandboxInterfaceInfo -got rid of the duplicated code to initialize the broker -since I made MainFunctionParams only have the sandbox struct on Windows, I also made the mac specific auto release pool behind an ifdef as well. It seemed odd to make something so mac specific compile on all platforms to save some #ifdefs. BUG=98716 Review URL: http://codereview.chromium.org/8414020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107863 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
RefCounted types should not have public destructors, Linux fixes BUG=123295 TEST=none Review URL: https://chromiumcodereview.appspot.com/10392152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137893 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Merge aura::DispatcherLinux into base::MessagePumpAuraX11. The majority of incoming XEvents are related to specific XWindows and need to be sent to a specific MessagePumpDispatcher. MessagePumpAuraX11 would pass the XEvent to aura::DispatcherLinux, which would pass it to the next dispatcher. Because of the chromeos unit tests, which spin up a new XDisplay on each test, these two objects need to have equivalent lifetimes. Due to the incoming clipboard support (which this patch was split off from), DispatcherLinux can't live in aura:: anymore. The solution is to merge the two objects that have to have equivalent lifetimes together. The one ui:: specific check was split off into an MessagePumpObserver. This also got rid of those hacks where we would static downcast to DispatcherLinux from MessagePumpDispatcher. BUG=130805 Review URL: https://chromiumcodereview.appspot.com/10895020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154174 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base: Add missing "virtual" keyword and OVERRIDE to some methods. Found with: $ ./build/gyp_chromium -Dclang=1 -Dclang_use_chrome_plugins=1 $ ninja -C out/Debug base -k4 -j4 2>&1 | tee errors And a tweak in plugin_flags.sh BUG=115047 R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149109 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
RefCounted types should not have public destructors, Linux fixes BUG=123295 TEST=none Review URL: https://chromiumcodereview.appspot.com/10392152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137893 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base: Remove an unused member from MessagePumpLibevent::FileDescriptorWatcher MessagePumpLibevent::FileDescriptorWatcher::is_persistent_ is not used at all. BUG=none TEST=base_unittests Review URL: https://chromiumcodereview.appspot.com/10534169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142351 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix failed apk unit test case MessagePumpLibeventTest.* on Android. The MessagePumpLibeventTest.StopWatcher and MessagePumpLibeventTest.DeleteWatcher use fd 0, which is not permitted in apk test while calling 'epoll_ctl', and cause failure on Android. Fix this by using fd created from pipe. Also remove them from Android disabled case list. BUG=None TEST=base_unittests Review URL: https://chromiumcodereview.appspot.com/10698112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146041 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adds MessageLoopUIApplication for use on iOS. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10689161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146553 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adds MessageLoopUIApplication for use on iOS. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10689161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146553 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Merge aura::DispatcherLinux into base::MessagePumpAuraX11. The majority of incoming XEvents are related to specific XWindows and need to be sent to a specific MessagePumpDispatcher. MessagePumpAuraX11 would pass the XEvent to aura::DispatcherLinux, which would pass it to the next dispatcher. Because of the chromeos unit tests, which spin up a new XDisplay on each test, these two objects need to have equivalent lifetimes. Due to the incoming clipboard support (which this patch was split off from), DispatcherLinux can't live in aura:: anymore. The solution is to merge the two objects that have to have equivalent lifetimes together. The one ui:: specific check was split off into an MessagePumpObserver. This also got rid of those hacks where we would static downcast to DispatcherLinux from MessagePumpDispatcher. BUG=130805 Review URL: https://chromiumcodereview.appspot.com/10895020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154174 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace PeekMessage for TSF awareness Replace PeekMessage with TSF interface's one in MessagePumpForIO Add MessagePumpTSFInternal class for above replacing. BUG=137627 TEST= Review URL: https://chromiumcodereview.appspot.com/10826223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155589 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace PeekMessage for TSF awareness Replace PeekMessage with TSF interface's one in MessagePumpForIO Add MessagePumpTSFInternal class for above replacing. BUG=137627 TEST= Review URL: https://chromiumcodereview.appspot.com/10826223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155589 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Coverity: Fix a pass-by-value. CID_COUNT=1 CID=103292 BUG=none TEST=none R=groby Review URL: https://chromiumcodereview.appspot.com/9380051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125070 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
linux: don't always print dlopen errors from LoadNativeLibrary Instead, return them to the caller and let the caller decide whether the error is worth notifying the user about. BUG=79068 Review URL: http://codereview.chromium.org/6864020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82008 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
rename some _linux files to _posix and introduce os_bsd The os_bsd variable is only available on FreeBSD and OpenBSD. Later on others like NetBSD and DragonflyBSD can be added. This variable was introduced in order to have shorter conditions in the gyp files. BUG= TEST=compile Patch by Robert Nagy <robert.nagy@gmail.com> Review URL: http://codereview.chromium.org/8567001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109929 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
linux: don't always print dlopen errors from LoadNativeLibrary Instead, return them to the caller and let the caller decide whether the error is worth notifying the user about. BUG=79068 Review URL: http://codereview.chromium.org/6864020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82008 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base: Reverse the parameters passed to EXPECT_EQ in ObserverList test. The order should be (expected, actual). TBR=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10876012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152976 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming diffs in os_compat_android.cc The original change description is: Add mkdtemp() implementation. The Android C library doesn't expose mkdtemp() through the NDK (even though it implements it internally starting with ICS). To avoid any problem in the future and keep everything strictly compliant, provide our own implementation of the function. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10696114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming diffs in os_compat_android.cc The original change description is: Add mkdtemp() implementation. The Android C library doesn't expose mkdtemp() through the NDK (even though it implements it internally starting with ICS). To avoid any problem in the future and keep everything strictly compliant, provide our own implementation of the function. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10696114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming diffs in os_compat_android.cc The original change description is: Add mkdtemp() implementation. The Android C library doesn't expose mkdtemp() through the NDK (even though it implements it internally starting with ICS). To avoid any problem in the future and keep everything strictly compliant, provide our own implementation of the function. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10696114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable parts of base_untrusted that are used by remoting client 1. base64, rand_util, threading, time and threads were previosly disabled in base_untrusted. Remoting code depends on these parts of base, so they need to be enabled. 2. Implemented NaCl version of rand_util. 3. Enabled glibc version of base_untrusted BUG=134216 Review URL: https://chromiumcodereview.appspot.com/10795083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable parts of base_untrusted that are used by remoting client 1. base64, rand_util, threading, time and threads were previosly disabled in base_untrusted. Remoting code depends on these parts of base, so they need to be enabled. 2. Implemented NaCl version of rand_util. 3. Enabled glibc version of base_untrusted BUG=134216 Review URL: https://chromiumcodereview.appspot.com/10795083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add PathService::RemoveOverride to clear path overrides. This is especially useful for unit tests because they live in the same process and share all the singletons including PathService. One can of course override the overrides but it is much cleaner and sometimes the only good solution to return to the original PathProvider instead. BUG=149161 TEST=base_unittests:PathServiceTest.* Review URL: https://chromiumcodereview.appspot.com/10909228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158842 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add PathService::RemoveOverride to clear path overrides. This is especially useful for unit tests because they live in the same process and share all the singletons including PathService. One can of course override the overrides but it is much cleaner and sometimes the only good solution to return to the original PathProvider instead. BUG=149161 TEST=base_unittests:PathServiceTest.* Review URL: https://chromiumcodereview.appspot.com/10909228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158842 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add PathService::RemoveOverride to clear path overrides. This is especially useful for unit tests because they live in the same process and share all the singletons including PathService. One can of course override the overrides but it is much cleaner and sometimes the only good solution to return to the original PathProvider instead. BUG=149161 TEST=base_unittests:PathServiceTest.* Review URL: https://chromiumcodereview.appspot.com/10909228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158842 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ChromeFrame: Convert TaskMarshallerThroughMessageQueue to new Callback system. BUG=none TEST=none R=willchan@chromium.org,stoyan@chromium.org Review URL: http://codereview.chromium.org/8591009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110595 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Call logging::InitLogging. The lack of this was causing some hangs (and possibly crashes) in ObserverListTest.BUG=6286 This CL has expanded to include some cleanup and refactoring of test_suite and related files, so that this logging change (and other improvements) are applied to all unit tests. Review URL: http://codereview.chromium.org/18003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7977 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove Pickle::WriteSize() now that it has no remaining callers. Also rename Pickle::WriteLong() to WriteLongUsingDangerousNonPortableLessPersistableForm() and add a strongly-worded comment against its use; it is used only for IPC which is safe. (These methods write variable amounts of data to pickles, depending on architecture, and aren't safe if pickles are persisted.) Review URL: http://codereview.chromium.org/9641005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128347 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor Pickle Read methods to use higher performance PickleIterator. There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Start sorting methods in class declarations. A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70749 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update #if guards in base/ that control whether to use stat or stat64 (and friends). Mac SDKs earlier than 10.5 did not define fstat64. The 10.5 SDK defined both fstat and fstat64. And in the 10.6 SDK, fstat64 is deprecated and the right implementation is selected at runtime. This makes the use of fstat unconditional on OS_MACOSX now that the build SDK is 10.6. BUG=137676 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10808037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147554 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Flakiness cleanup: disable flaky tests under base/ See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6 BUG=46246,85930,10611,86494,95058,61589,25038 Review URL: https://chromiumcodereview.appspot.com/9386014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121782 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Implement serial API for Windows. - Got it working using PlatformFile. - Noticed threading-constraint violations; refactored APIResourceController to allow for its resources to exist on different threads, depending on the resource type. - Wondered why I wasn't using PlatformFile for the POSIX version, which would have caused me to build the POSIX version on the file thread to being with. - Fixed that. - Once things were working, observed that serial was not yet using ArrayBuffer. Fixed that. - Simplified ExtensionService's relationship with APIResourceController. - Hardcode all platforms to set bitrate of 57600. BUG=129391,129483 TEST=Widened scope of existing tests, manually tested with Arduino Review URL: https://chromiumcodereview.appspot.com/10392181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139463 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add virtual and OVERRIDE to base/ implementation files BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate RecordBrowserStartupTime() into one location * Create a CurrentProcessInfo class as a central storage place for information about the current process. For now store the process creation time there. * Move RecordBrowserStartupTime() int browser_main.cc. The motivation for this is that we will want to add some more UMA measurements which require knowledge of the process startup time. BUG=None Test=Chrome should continue to compile on all platforms. TEST= Review URL: https://chromiumcodereview.appspot.com/10561009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142984 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate RecordBrowserStartupTime() into one location * Create a CurrentProcessInfo class as a central storage place for information about the current process. For now store the process creation time there. * Move RecordBrowserStartupTime() int browser_main.cc. The motivation for this is that we will want to add some more UMA measurements which require knowledge of the process startup time. BUG=None Test=Chrome should continue to compile on all platforms. TEST= Review URL: https://chromiumcodereview.appspot.com/10561009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142984 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
CheckForNicePermission: Make sure can_reraise_priority is set in ctor CID=102592 BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/8989035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115631 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix tab backgrounding This broke because an incompatible change was made to Process, and because there was no test that would catch it. I've fixed the underlying problem for both Linux and ChromeOS and made it testable. BUG=102726 TEST=Added new RenderProcessHostTest.Backgrounding Review URL: http://codereview.chromium.org/8506036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112712 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Upstream misc changes for android. BUG= TEST= Review URL: http://codereview.chromium.org/7701014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98432 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
unchecked_malloc() for Skia on OSX. On tcmalloc-based versions of Chromium, skia resets the global new handler to prevent the oom-killer from kicking in. Traditionally the OSX developers have been agin this, because it's not thread-safe, and we have questions about whether it's even the right thing to do. This change should be thread-safe because g_old_malloc is only set on the main thread at startup. As far as whether it's the right thing to do, I'm tired and want to quit hearing about it. Additionally, remove a bit of leftover pre-10.6 code. BUG=103980,73751,117949 Review URL: https://chromiumcodereview.appspot.com/10908245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157646 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
use os_bsd and OS_BSD and add some OS_FREEBSD conditions this change is the first part of the FreeBSD support BUG= TEST= Review URL: http://codereview.chromium.org/8773051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112936 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add minimal support for process_utils on iOS Much of process_utils isn't meaningful on iOS, but this provides enough to support unit tests and minimal metrics. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10698149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146123 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Add a const variable for /proc/self/exe. Review URL: https://chromiumcodereview.appspot.com/10914279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157001 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
unchecked_malloc() for Skia on OSX. On tcmalloc-based versions of Chromium, skia resets the global new handler to prevent the oom-killer from kicking in. Traditionally the OSX developers have been agin this, because it's not thread-safe, and we have questions about whether it's even the right thing to do. This change should be thread-safe because g_old_malloc is only set on the main thread at startup. As far as whether it's the right thing to do, I'm tired and want to quit hearing about it. Additionally, remove a bit of leftover pre-10.6 code. BUG=103980,73751,117949 Review URL: https://chromiumcodereview.appspot.com/10908245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157646 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
fix typo introduced in CR# 8341026 BUG= TEST= Review URL: http://codereview.chromium.org/8490020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108952 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Type profiler by intercepting 'new' and 'delete' expressions. It stores mapping between object's starting addresses and their allocated types when a build option 'clang_type_profiler=1' is specified. It enables information like "an object at 0x37f3c88 is an instance of std::string." Nothing is changed when the option is not specified. It depends on a modified version of the LLVM/Clang compiler introduced at deps/third_party/llvm-allocated-type. BUG=123758 TEST=build with clang_type_profiler=1 and run type_profiler_unittests and type_profiler_map_unittests manually. Review URL: https://chromiumcodereview.appspot.com/10411047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158752 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
unchecked_malloc() for Skia on OSX. On tcmalloc-based versions of Chromium, skia resets the global new handler to prevent the oom-killer from kicking in. Traditionally the OSX developers have been agin this, because it's not thread-safe, and we have questions about whether it's even the right thing to do. This change should be thread-safe because g_old_malloc is only set on the main thread at startup. As far as whether it's the right thing to do, I'm tired and want to quit hearing about it. Additionally, remove a bit of leftover pre-10.6 code. BUG=103980,73751,117949 Review URL: https://chromiumcodereview.appspot.com/10908245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157646 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add minimal support for process_utils on iOS Much of process_utils isn't meaningful on iOS, but this provides enough to support unit tests and minimal metrics. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10698149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146123 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
64-bit support for Mac OS X in base_unittests. BUG=44127, 18323 TEST=64-bit base_unittests should all pass Review URL: http://codereview.chromium.org/2126001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47275 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add a flag force_breakaway_from_job_ to the base::LaunchOptions structure for Windows, which when set ensures that the child process is created with the CREATE_BREAKAWAY_FROM_JOB flag. BUG=148753 R=cpu Review URL: https://codereview.chromium.org/10914277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156690 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix tab backgrounding This broke because an incompatible change was made to Process, and because there was no test that would catch it. I've fixed the underlying problem for both Linux and ChromeOS and made it testable. BUG=102726 TEST=Added new RenderProcessHostTest.Backgrounding Review URL: http://codereview.chromium.org/8506036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112712 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added crypto random-number generator Added a cryptographic random-number generator to crypto/. Modified sync to use this function instead. May also be used by Cloud Print in the future. Review URL: https://chromiumcodereview.appspot.com/10698177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149689 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable parts of base_untrusted that are used by remoting client 1. base64, rand_util, threading, time and threads were previosly disabled in base_untrusted. Remoting code depends on these parts of base, so they need to be enabled. 2. Implemented NaCl version of rand_util. 3. Enabled glibc version of base_untrusted BUG=134216 Review URL: https://chromiumcodereview.appspot.com/10795083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added crypto random-number generator Added a cryptographic random-number generator to crypto/. Modified sync to use this function instead. May also be used by Cloud Print in the future. Review URL: https://chromiumcodereview.appspot.com/10698177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149689 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added crypto random-number generator Added a cryptographic random-number generator to crypto/. Modified sync to use this function instead. May also be used by Cloud Print in the future. Review URL: https://chromiumcodereview.appspot.com/10698177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149689 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add base::RunLoop and update ui_test_utils to use it to reduce flakiness Timeout flakiness has been observed in multiple tests that use Quit. This changes various test utility APIs to use QuitNow via base::RunLoop instead. Some instances of Quit are left as-is where it appears they may have a use case. The ui_test_utils QuitThisRunLoop function does a safer form of MessageLoop::QuitWhenIdle that allows a few generations of tasks to run before actually quitting the MessageLoop. This addresses the design assumptions of many existing tests while hopefully reducing flaky timeouts by moving away from QuitWhenIdle. This fixes throughput_tests.cc which is currently timing out on Mac. BUG=124906,130141,131220,128305,132932 Review URL: https://chromiumcodereview.appspot.com/10479018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144824 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adds MessageLoopUIApplication for use on iOS. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10689161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146553 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
NaCl base bringup. Native client uses the GLIBC style of strerror_r but does not define __GLIBC__. It's possible the right thing to do is for the native client toolchain to define GLIBC, but the path of least resistance seems to be to adjust our conditionals in this file to understand NaCl. Original patch by Eric Seidel. Review URL: http://codereview.chromium.org/4883001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65961 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move scoped_temp_dir and scoped_native_library back from base/memory to base. It looks like they got moved accidentally in http://codereview.chromium.org/6714032 BUG=none TEST=none Review URL: http://codereview.chromium.org/7048007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move scoped_temp_dir and scoped_native_library back from base/memory to base. It looks like they got moved accidentally in http://codereview.chromium.org/6714032 BUG=none TEST=none Review URL: http://codereview.chromium.org/7048007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove log spew from scoped_tempdir.cc. BUG=108724 TBR=yoz@chromium.org Review URL: https://chromiumcodereview.appspot.com/9371006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121131 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix file leaks in a ETW test and a ScopedTempDir test. BUG=none TEST=none Review URL: http://codereview.chromium.org/8972009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115036 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove old Sleep and PostDelayedTask interfaces that use int ms instead of TimeDelta. The previous version of this patch was reverted due to crashing cros_x86 and cros_tegra2 builds. See: http://codereview.chromium.org/9703053/ BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10572030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143401 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add base::SHA1HashBytes. We need this for LevelDB. BUG=64078 TEST=base_unittest --gtest_filter=SHA1Test Review URL: http://codereview.chromium.org/6661025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77973 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Update SHA1_LENGTH -> kSHA1Length to match previous change to SHA256_LENGTH. (I didn't try and understand or fix why kSHA1Length is in base:: while kSHA256Length is in crypto::.) BUG=92247 TEST=compiles Review URL: http://codereview.chromium.org/7972024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103179 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base. [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Advertise a minimum alignment for SharedMemory::Map(). No real changes, just adds a DCHECK() and unit test for a minimum alignment that callers can count on from Map(). Map() is already returning addresses which are aligned to the platform page size. Necessary for a media use case in which a wrapped shared memory object is passed around and is expected to have a certain alignment. BUG=none TEST=unittests, try bots. Review URL: https://chromiumcodereview.appspot.com/10827400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152218 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix Android build. Accomodate shmem changes in http://codereview.chromium.org/8585002. BUG=None TEST= Review URL: http://codereview.chromium.org/8771022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112588 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Advertise a minimum alignment for SharedMemory::Map(). No real changes, just adds a DCHECK() and unit test for a minimum alignment that callers can count on from Map(). Map() is already returning addresses which are aligned to the platform page size. Necessary for a media use case in which a wrapped shared memory object is passed around and is expected to have a certain alignment. BUG=none TEST=unittests, try bots. Review URL: https://chromiumcodereview.appspot.com/10827400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152218 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Advertise a minimum alignment for SharedMemory::Map(). No real changes, just adds a DCHECK() and unit test for a minimum alignment that callers can count on from Map(). Map() is already returning addresses which are aligned to the platform page size. Necessary for a media use case in which a wrapped shared memory object is passed around and is expected to have a certain alignment. BUG=none TEST=unittests, try bots. Review URL: https://chromiumcodereview.appspot.com/10827400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152218 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Advertise a minimum alignment for SharedMemory::Map(). No real changes, just adds a DCHECK() and unit test for a minimum alignment that callers can count on from Map(). Map() is already returning addresses which are aligned to the platform page size. Necessary for a media use case in which a wrapped shared memory object is passed around and is expected to have a certain alignment. BUG=none TEST=unittests, try bots. Review URL: https://chromiumcodereview.appspot.com/10827400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152218 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Advertise a minimum alignment for SharedMemory::Map(). No real changes, just adds a DCHECK() and unit test for a minimum alignment that callers can count on from Map(). Map() is already returning addresses which are aligned to the platform page size. Necessary for a media use case in which a wrapped shared memory object is passed around and is expected to have a certain alignment. BUG=none TEST=unittests, try bots. Review URL: https://chromiumcodereview.appspot.com/10827400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152218 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove MSVC check in stack_container_unittest. BUG= TEST=Compile Review URL: https://chromiumcodereview.appspot.com/10825048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148846 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add PrintTo for string16 This is required by googletest to print a readable output when failing to compare two string16's (ref: http://goo.gl/jALbO) Without this the output of a failed comparison could be: Value of: ElideEmail(UTF8ToUTF16(testcases[i].input), font, font.GetStringWidth(expected_output)) Actual: { 97, 116, 34, 64, 64, 64, 64, 64, 64, 64, 64, 64, 46, 46, 46, 64, 64, 46, 8230, 64, 109, 97, 100, 110, 101, 115, 115, 46, 99, 111, 109 } Expected: expected_output Which is: { 97, 116, 34, 64, 64, 64, 64, 64, 64, 64, 64, 64, 46, 46, 46, 64, 64, 46, 64, 46, 8230, 64, 109, 97, 110, 101, 115, 115, 46, 99, 111, 109 } With this patch the same error is now properly formatted: Value of: ElideEmail(UTF8ToUTF16(testcases[i].input), font, font.GetStringWidth(expected_output)) Actual: at"@@@@@@@@@...@@.…@madness.com Expected: expected_output Which is: at"@@@@@@@@@...@@.@.…@maness.com BUG= TEST=unit_tests Review URL: http://codereview.chromium.org/9641017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125642 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Apparently we weren't running this unittest. When porting this test to NaCl, I discovered that it didn't build! This patch makes it build and adds it to our test suite. Review URL: http://codereview.chromium.org/4966001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66068 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
(re-land) Add StringToSizeT to base/string_number_conversions. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119540 Review URL: http://codereview.chromium.org/9296002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119585 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
(re-land) Add StringToSizeT to base/string_number_conversions. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119540 Review URL: http://codereview.chromium.org/9296002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119585 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add some unittests for DoubleToString. Some of these test cases are causing crashes in the wild. They don't crash on my machine, with or without the dtoa patch, but we may as well check in the test cases. BUG=123157 Review URL: https://chromiumcodereview.appspot.com/10332159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137301 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move operator<< for StringPiece into string_piece.{h,cc} BUG=110651 TEST= Review URL: https://chromiumcodereview.appspot.com/9159005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118416 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Resolve an ambiguous function call error in string_piece_unittest.cc BUG= TEST= Review URL: http://codereview.chromium.org/9167008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117050 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues() and SplitStringIntoKeyValuePairs() already did this.) This is more in line with what other APIs that take outparams do. I audited all callers, and the only ones affected by this are the buggy ones in bug 134695 that already wanted this behavior, as well as the couple of places in this CL that were manually calling clear() and now don't have to. BUG=134695 TEST=none TBR=brettw,phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10684003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144323 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues() and SplitStringIntoKeyValuePairs() already did this.) This is more in line with what other APIs that take outparams do. I audited all callers, and the only ones affected by this are the buggy ones in bug 134695 that already wanted this behavior, as well as the couple of places in this CL that were manually calling clear() and now don't have to. BUG=134695 TEST=none TBR=brettw,phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10684003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144323 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adding support for Reset in StringTokenizerT and HttpHeadersIterator. TEST=Run HeadersIterator_Reset and the Reset test for StringTokenizer BUG=none Review URL: http://codereview.chromium.org/276067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29330 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Add support for joining strings on strings rather than just chars. BUG= Review URL: https://chromiumcodereview.appspot.com/10828217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153568 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add support for joining strings on strings rather than just chars. BUG= Review URL: https://chromiumcodereview.appspot.com/10828217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153568 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add support for joining strings on strings rather than just chars. BUG= Review URL: https://chromiumcodereview.appspot.com/10828217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153568 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add shared macros for stringizing and converting ANSI string constants (in particular defined by macros) to wide string constants. Convert existing locally-defined stringizing to use the shared macros. Unit tests for the shared macros. This also fixes a minor bug in ceee_module_util.cc where I accidentally quoted a string constant I only meant to convert to wide (this caused no bug, but was unintended, so the change in semantics in that file in the current change is intentional). BUG=none TEST=automated tests Review URL: http://codereview.chromium.org/5103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66579 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove wchar_t versions of StringPrintf from Android BUG=137864 TEST=StringPrintfTest Review URL: https://chromiumcodereview.appspot.com/10800078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149397 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove wchar_t versions of StringPrintf from Android BUG=137864 TEST=StringPrintfTest Review URL: https://chromiumcodereview.appspot.com/10800078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149397 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove wchar_t versions of StringPrintf from Android BUG=137864 TEST=StringPrintfTest Review URL: https://chromiumcodereview.appspot.com/10800078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149397 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SupportsUserData is not thread safe Lets ensure none of its usages are unsafe. BUG= Review URL: https://chromiumcodereview.appspot.com/10919137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155794 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SupportsUserData is not thread safe Lets ensure none of its usages are unsafe. BUG= Review URL: https://chromiumcodereview.appspot.com/10919137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155794 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement SyncSocket for untrusted NaCl builds. BUG=116317 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10696217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146732 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert revert 132842 If we are using blocking write, when the renderer stop getting the data without notifying the browser, it will hang the browser. This happens with some plugins which use the sync sockets provided by the Pepper. This patch change CancellableSyncSocket to be non-blocking on sending, so that we don't need to worry the whole browser hangs by one plugin application. Also, we remove the lock in audio_sync_reader.cc since it is not really needed if we don't set the socket_ to NULL when calling Close(). By doing this we allow the user to close the socket while another thread is writing to the socket. BUG=121152 TEST=ipc_tests TBR=tommi@chromium.org Review URL: https://chromiumcodereview.appspot.com/10124004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132975 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert revert 132842 If we are using blocking write, when the renderer stop getting the data without notifying the browser, it will hang the browser. This happens with some plugins which use the sync sockets provided by the Pepper. This patch change CancellableSyncSocket to be non-blocking on sending, so that we don't need to worry the whole browser hangs by one plugin application. Also, we remove the lock in audio_sync_reader.cc since it is not really needed if we don't set the socket_ to NULL when calling Close(). By doing this we allow the user to close the socket while another thread is writing to the socket. BUG=121152 TEST=ipc_tests TBR=tommi@chromium.org Review URL: https://chromiumcodereview.appspot.com/10124004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132975 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing issues with alignment, undefined behaviour and endianness in the FieldTrial::HashName function. I also added new functions to base that convert from host order to little endian. BUG=123230FieldTrialTest.HashName TEST=FieldTrialTest.HashName Review URL: http://codereview.chromium.org/10088001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132404 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement SysInfo::CPUArchitecture() on Windows. Try to make Windows and POSIX versions return consistent architecture names. Review URL: https://chromiumcodereview.appspot.com/10910247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158726 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move Android user agent generation to native code Gets rid of a pathway that forced us to set the user agent from the Java side, replacing it with one that's entirely native. Functions have been added to base to allow accessing information about the device and Android build, while the user agent generation code was moved to the webkit_glue namespace. BUG=131312 Review URL: https://chromiumcodereview.appspot.com/10832235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152675 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implemented a "Last Updated" field for the about page of Chrome OS. BUG=117517 TEST= Review URL: http://codereview.chromium.org/10038034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133840 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
OpenBSD patches for base and build, part 2 base/base.gyp: - exclude test/test_file_util_linux.cc on OpenBSD because of missing fdatasync() base/base.gypi: - include linux_util.cc on OpenBSD too - exclude some linux specific files from the OpenBSD build because the openbsd implementation is different base/file_util_posix.cc: - Use file_util::GetTempDir directly to get the shm dir on !linux base/sys_info_freebsd.cc: - return 0 and do a NOTREACHED() in case sysctlbyname() fails base/sys_info_openbsd.cc: - cleanup includes - use arraysize() in the sysctl() call - implement SysInfo::MaxSharedMemorySize() build/common.gypi: - -Wno-deprecated is C++ only flag so move it to cflags_cc - Do not exclude linux specific files, dirs on OpenBSD since 90% of it is sharable base/sys_info_linux.cc: - DCHECK if the read string is empty - Use base::StringToInt64() to convert the string to an int64 - DCHECK if the returned int64 is okay for a size_t - call NOTREACHED() and return 0 if fails BUG= TEST=runs on linux? Review URL: http://codereview.chromium.org/8382001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106984 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Refine systemInfo.cpu API and provide systemInfo.cpu.get impl for Windows and Linux. BUG=136519 TEST=browser_test --gtest_filter=SystemInfoCpuApiTest.* Review URL: https://chromiumcodereview.appspot.com/10914060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155575 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refine systemInfo.cpu API and provide systemInfo.cpu.get impl for Windows and Linux. BUG=136519 TEST=browser_test --gtest_filter=SystemInfoCpuApiTest.* Review URL: https://chromiumcodereview.appspot.com/10914060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155575 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refine systemInfo.cpu API and provide systemInfo.cpu.get impl for Windows and Linux. BUG=136519 TEST=browser_test --gtest_filter=SystemInfoCpuApiTest.* Review URL: https://chromiumcodereview.appspot.com/10914060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155575 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
OpenBSD patches for base and build, part 2 base/base.gyp: - exclude test/test_file_util_linux.cc on OpenBSD because of missing fdatasync() base/base.gypi: - include linux_util.cc on OpenBSD too - exclude some linux specific files from the OpenBSD build because the openbsd implementation is different base/file_util_posix.cc: - Use file_util::GetTempDir directly to get the shm dir on !linux base/sys_info_freebsd.cc: - return 0 and do a NOTREACHED() in case sysctlbyname() fails base/sys_info_openbsd.cc: - cleanup includes - use arraysize() in the sysctl() call - implement SysInfo::MaxSharedMemorySize() build/common.gypi: - -Wno-deprecated is C++ only flag so move it to cflags_cc - Do not exclude linux specific files, dirs on OpenBSD since 90% of it is sharable base/sys_info_linux.cc: - DCHECK if the read string is empty - Use base::StringToInt64() to convert the string to an int64 - DCHECK if the returned int64 is okay for a size_t - call NOTREACHED() and return 0 if fails BUG= TEST=runs on linux? Review URL: http://codereview.chromium.org/8382001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106984 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Implement SysInfo::CPUArchitecture() on Windows. Try to make Windows and POSIX versions return consistent architecture names. Review URL: https://chromiumcodereview.appspot.com/10910247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158726 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Exclude unsupported tests from the android build. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10701121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145985 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement SysInfo::CPUArchitecture() on Windows. Try to make Windows and POSIX versions return consistent architecture names. Review URL: https://chromiumcodereview.appspot.com/10910247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158726 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[OSX] Remove wide->NSString conversion Since we a) have a PRESUBMIT check for wstring in new code and b) this code isn't used any more.... might as well kill it. TBR=rsesek@chromium.org R=mark@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10818016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150002 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[OSX] Remove wide->NSString conversion Since we a) have a PRESUBMIT check for wstring in new code and b) this code isn't used any more.... might as well kill it. TBR=rsesek@chromium.org R=mark@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10818016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150002 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[OSX] Remove wide->NSString conversion Since we a) have a PRESUBMIT check for wstring in new code and b) this code isn't used any more.... might as well kill it. TBR=rsesek@chromium.org R=mark@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10818016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150002 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix some grammatical errors in base/ BUG=None Review URL: http://codereview.chromium.org/9854040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130117 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Cleanup in base/test. This is related to http://codereview.chromium.org/7003028/. BUG=60476 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89664 Review URL: http://codereview.chromium.org/7129056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89681 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
NO CODE CHANGE Normalize end of file newlines in base/. All files end in a single newline. Review URL: http://codereview.chromium.org/42011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11329 0039d316-1c4b-4281-b951-d872f2087c98 | 17 年前 | |
Remove old Sleep and PostDelayedTask interfaces that use int ms instead of TimeDelta. The previous version of this patch was reverted due to crashing cros_x86 and cros_tegra2 builds. See: http://codereview.chromium.org/9703053/ BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10572030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143401 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix a leak following r135955 BUG=127364 TEST=no leak TBR=willchan,dhollowa Review URL: https://chromiumcodereview.appspot.com/10382088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch template_utils_unittest to using COMPILE_ASSERT. This should be faster, and just as correct. BUG=None Review URL: https://chromiumcodereview.appspot.com/10565006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142998 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add base::ThreadTaskRunnerHandler class. The class will be used to hold a reference to the thread's task runner. Review URL: https://chromiumcodereview.appspot.com/10380016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136110 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add base::ThreadTaskRunnerHandler class. The class will be used to hold a reference to the thread's task runner. Review URL: https://chromiumcodereview.appspot.com/10380016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136110 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing Time::Max()'s behavior with Time::ToTimeT() and friends. It looks like the math that's done to convert epoch times between platforms is giving incorrect results when confronted with a "max" time. This CL adjusts the various conversion methods to persist maxness in the same way they currently persist zeroness. BUG=146328 Review URL: https://chromiumcodereview.appspot.com/10916089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155591 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing Time::Max()'s behavior with Time::ToTimeT() and friends. It looks like the math that's done to convert epoch times between platforms is giving incorrect results when confronted with a "max" time. This CL adjusts the various conversion methods to persist maxness in the same way they currently persist zeroness. BUG=146328 Review URL: https://chromiumcodereview.appspot.com/10916089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155591 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing Time::Max()'s behavior with Time::ToTimeT() and friends. It looks like the math that's done to convert epoch times between platforms is giving incorrect results when confronted with a "max" time. This CL adjusts the various conversion methods to persist maxness in the same way they currently persist zeroness. BUG=146328 Review URL: https://chromiumcodereview.appspot.com/10916089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155591 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Try to fix the possible bug in base::Time:Now() that can cause the crashing later in icu code called from ash tray TimeView::UpdateTextInternal() if the call to gettimeofday fails. BUG=147570 Review URL: https://chromiumcodereview.appspot.com/10907178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156134 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing Time::Max()'s behavior with Time::ToTimeT() and friends. It looks like the math that's done to convert epoch times between platforms is giving incorrect results when confronted with a "max" time. This CL adjusts the various conversion methods to persist maxness in the same way they currently persist zeroness. BUG=146328 Review URL: https://chromiumcodereview.appspot.com/10916089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155591 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing Time::Max()'s behavior with Time::ToTimeT() and friends. It looks like the math that's done to convert epoch times between platforms is giving incorrect results when confronted with a "max" time. This CL adjusts the various conversion methods to persist maxness in the same way they currently persist zeroness. BUG=146328 Review URL: https://chromiumcodereview.appspot.com/10916089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155591 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix base::CPU detection. ARCH_CPU_X86_FAMILY was never being defined, causing base::CPU::Initialize to be a no-op. BUG= TEST= Review URL: http://codereview.chromium.org/9836125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130046 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Use ThreadTaskRunnerHandle in base::Timer. Now ThreadTaskRunnerHandle is used instead of MessageLoop::current(). This allows to use Timer classes on threads that don't have MessageLoop but have a different task runner. Review URL: https://chromiumcodereview.appspot.com/10213012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136667 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change explicit usage of each type of message loop in TimerTest to instead loop through an array of message loop types. This allows for easier-to-read code while including a platform that cannot run the tests on every kind of message loop. Specifically, iOS cannot run the UI loop for unit tests. Un-exclude timer_unittest.cc on ios in base.gyp. BUG=b/6825060 TEST=None Review URL: https://chromiumcodereview.appspot.com/10786013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146980 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Tweak Memcheck sanity tests to avoid duplicate reports. BUG=128264 TEST=ToolsSanityTest under valgrind TBR=jar Review URL: https://chromiumcodereview.appspot.com/10383208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137383 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Handle wrapping of task run count beyond 2^31 times. Some long lived browsers (and more likely, run-away and hyperactive tasks) can run more times than can be tallied in a mere int (2^31 times). We use the count as a modulus to take a uniform sample of other profiled activities. If the task runs enough times, this value turns negative, and eventually becomes zero, which would cause an arithmetic exception (divide by zero when doing modulo operation). We now clamp the value at 2^31 - 1, which will make clear what has happened when users visit about:profiler (a task has run a LOT), and we then use this clamped value (instead of the real count) to be very infrequent about taking a replacement sample. This sampling should be "good enough for government work," and should not impact enough folks to have any effect on our profiling stats. r=isherman BUG=138961 Review URL: https://chromiumcodereview.appspot.com/10826018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148628 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix timings in TrackedObjects unit test BUG=none TEST=green build TBR=jar@chromium.org Review URL: https://chromiumcodereview.appspot.com/10071030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132121 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support profiling of tasks run as sequenced_tasks Mimic code seen in message_loop.cc (since these tasks are run on named threads) to support tracking of sequenced worker pool runs of tasks. We surround the *.Run() method with a call to get the time before we start, and then call to tally the time it took to run after task.Run() returns. r=brettw BUG=139035 Review URL: https://chromiumcodereview.appspot.com/10825022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148986 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support profiling of tasks run as sequenced_tasks Mimic code seen in message_loop.cc (since these tasks are run on named threads) to support tracking of sequenced worker pool runs of tasks. We surround the *.Run() method with a call to get the time before we start, and then call to tally the time it took to run after task.Run() returns. r=brettw BUG=139035 Review URL: https://chromiumcodereview.appspot.com/10825022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148986 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Minor C++ fixes found by Clang. In cases where I've added an #include, it's generally due to Clang being more picky about templates being available during expansions. Review URL: http://codereview.chromium.org/1432003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43098 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add UTF16ToUTF8AndAdjustOffset() to base/. Currently, only UTF8ToUTF16 version is implemented. The converse version will be required for an upcoming patch for supporting input methods in PPAPI (crbug.com/59425), where WebKit strings (UTF16) with segmentation information must be converted to PPAPI strings (UTF8). BUG= TEST=base_unittests Review URL: http://codereview.chromium.org/7828092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100079 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add UTF16ToUTF8AndAdjustOffset() to base/. Currently, only UTF8ToUTF16 version is implemented. The converse version will be required for an upcoming patch for supporting input methods in PPAPI (crbug.com/59425), where WebKit strings (UTF16) with segmentation information must be converted to PPAPI strings (UTF8). BUG= TEST=base_unittests Review URL: http://codereview.chromium.org/7828092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100079 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Split *AndAdjustOffset() functions into their own header, to restore utf_string_conversions.h to a simple, readable state. BUG=4010 TEST=none Review URL: http://codereview.chromium.org/387012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31928 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change UTF8ToUTF16 to accept const StringPiece&. BUG=70936 TEST=All unit tests should pass. Review URL: http://codereview.chromium.org/6317016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72921 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
clang/mac: Fix almost all problems when building all.xcodeproj. BUG=None TEST=None TBR=hans git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61344 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Refactor chrome.alarms interface to support absolute alarm deadlines. BUG=122817 TEST=Created an extension with absolute delays under 5 minutes away, and watched that they didn't fire for 5 minutes. Review URL: https://chromiumcodereview.appspot.com/10545104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142037 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add some useful features to base::Values: - Typed Append methods to ListValue (AppendString etc) including AppendStrings. - Typed SetWithoutPathExpansion methods (SetStringWithoutPathExpansion etc). The latter is important because it's a common mistake to use Set rather than SetWithoutPathExpansion; the existence of these extra methods should help. Review URL: https://chromiumcodereview.appspot.com/10914246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156716 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add some useful features to base::Values: - Typed Append methods to ListValue (AppendString etc) including AppendStrings. - Typed SetWithoutPathExpansion methods (SetStringWithoutPathExpansion etc). The latter is important because it's a common mistake to use Set rather than SetWithoutPathExpansion; the existence of these extra methods should help. Review URL: https://chromiumcodereview.appspot.com/10914246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156716 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reverting due to memory waterfall failures. Revert 138044 - Allowed BinaryValue to take a NULL buffer. BUG=127630 Review URL: https://chromiumcodereview.appspot.com/10389088 TBR=mitchellwrosen@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138050 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base. [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Integrate ETW with VLOG logging. This change extends the log severities into the negative for VLOG verbosities. It also keeps track of file/line information and passes it to any registered log handler. The log level is naturally controlled by translating ETW log levels to the severities. BUG=none TEST=none Review URL: http://codereview.chromium.org/4164011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 17 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 16 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 17 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 16 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 16 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 16 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 17 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 16 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 14 年前 | ||
| 17 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 16 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 15 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 14 年前 | ||
| 13 年前 | ||
| 15 年前 |