Rrvargas@google.comRevert 158402 - Base: disable the scoped handle verifier for M23 beta.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[windows] Make calls to exit(), _exit(), abort(), and ExitProcess() from the renderer process result in a crash. BUG=118665 Review URL: http://codereview.chromium.org/9803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128701 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Improve support for multiselect list box accessibility on Windows. Exposes several new states and attributes and fires new notifications when the selection changes. Adds general-purpose implementations of IUnknown and IEnumVARIANT to base/win/, which will be used in the future as we remote ATL from accessibility code. BUG=5027,98984 TEST=manual testing with JAWS and NVDA Review URL: http://codereview.chromium.org/8588036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112870 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Improve support for multiselect list box accessibility on Windows. Exposes several new states and attributes and fires new notifications when the selection changes. Adds general-purpose implementations of IUnknown and IEnumVARIANT to base/win/, which will be used in the future as we remote ATL from accessibility code. BUG=5027,98984 TEST=manual testing with JAWS and NVDA Review URL: http://codereview.chromium.org/8588036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112870 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix EtwTraceConsumerDataTest fixture. BUG=129129 TEST=The unittest no longer fails on trybots. Review URL: https://chromiumcodereview.appspot.com/10407098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138352 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move Windows-specific Event Tracing for Windows implementation to base/win. fix users of same. BUG=none TEST=unittests Review URL: http://codereview.chromium.org/4517004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65310 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 136990 - Make sure the thread calling CoCreateGuid is CoInitialized. BUG=127671 TEST=Test passes on Vista test bots. Review URL: https://chromiumcodereview.appspot.com/10383162 TBR=siggi@chromium.org Review URL: https://chromiumcodereview.appspot.com/10382159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136997 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
New test infrastructure for producing verbose logs in failing tests. This infrastructure allows Google Test-based tests to opt-in to some magic that results in extremely verbose logs appearing in test output for only those tests that fail. This includes all LOG() messages generated by chrome.exe, npchrome_frame.exe, and the test executable itself, as well as all TRACE_EVENT_*_ETW events. The interesting entrypoints are in test_log_collector_win.h, file_logger_win.h, and log_file_printer_win.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/9584017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126240 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move Windows-specific Event Tracing for Windows implementation to base/win. fix users of same. BUG=none TEST=unittests Review URL: http://codereview.chromium.org/4517004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65310 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Replace most LOG/CHECK statements with DLOG/DCHECK statements in base. [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
The UI language rather than the locale is now used to pick Chrome's language on Windows. (Also fixed some unrelated lint errors.) With this change, l10n_util::GetApplicationLocale first checks for an override of the "configured locale" (in base::i18n) containing the list of preferred Windows UI languages. The browser triggers an override early in startup before the ApplicationLocale is determined. In effect, the browser no longer uses ICU on Windows for language detection. (This locale override mechanism is borrowed from the OS X port.) Changes in Chrome Frame are largely a refactor, as some Win32 code in there has been moved into base/win. Also cleaned up language selection in installer_util so that the proper language is chosen for the EULA, installer messages, and shortcuts. In so doing, replaced hand-crafted lists of supported languages with either auto-generated lists (static consts) or logic so that the addition of translations in the future doesn't require code motion (that being said, there may be reason to update the alias and/or wildcard tables in language_selector.cc). In so doing, this change unlocks Amharic, Farsi, and Swahili translations for installer messages and shortcuts. BUG=39986,40496,26470 TEST=New MUI/Win32 calls are tested in base/win/i18n_unittest.cc. To test the overall functionality, uninstall Chrome, remove intl.app_locale user pref, switch to a supported display language (via the "Keyboards and Languages" tab of Win7's "Regional and Language" control panel, and install with { "distribution": { "require_eula": true } } in master_preferences (via -installerdata arg to setup.exe). If all goes well, both EULA and outer frame are in the same language as Windows. Also, from gwilson: "Install system-level Chrome in audit mode on a new machine, then go through the out-of-box-experience, select a language, and the in -product EULA (triggered by "require_eula" : true) and Chrome's UI should be in the language that the user selected." Review URL: http://codereview.chromium.org/4139010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66275 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Reland "Move app/win/* files to base/win/, ui/base/win and chrome/common/ directories." The issue with the r90464 was that in the win shared build we build dlls and we need BASE_API to export functions and symbols. BUG=72317 TEST=None TBR=rsesek@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/7263009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90505 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Improve support for multiselect list box accessibility on Windows. Exposes several new states and attributes and fires new notifications when the selection changes. Adds general-purpose implementations of IUnknown and IEnumVARIANT to base/win/, which will be used in the future as we remote ATL from accessibility code. BUG=5027,98984 TEST=manual testing with JAWS and NVDA Review URL: http://codereview.chromium.org/8588036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112870 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Improve support for multiselect list box accessibility on Windows. Exposes several new states and attributes and fires new notifications when the selection changes. Adds general-purpose implementations of IUnknown and IEnumVARIANT to base/win/, which will be used in the future as we remote ATL from accessibility code. BUG=5027,98984 TEST=manual testing with JAWS and NVDA Review URL: http://codereview.chromium.org/8588036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112870 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
If desktop chrome is launched via the New Window/the recently opened url shortcuts on the chrome shortcut or simply from the command line, if we defer to immersive chrome if it is already running, then we should also activate the metro chrome instance. Added a helper function IsProcessImmersive which takes in the process handle to determine if it is immersive to base\win\metro.cc/.h BUG=144297 R=cpu Review URL: https://codereview.chromium.org/10910311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
If desktop chrome is launched via the New Window/the recently opened url shortcuts on the chrome shortcut or simply from the command line, if we defer to immersive chrome if it is already running, then we should also activate the metro chrome instance. Added a helper function IsProcessImmersive which takes in the process handle to determine if it is immersive to base\win\metro.cc/.h BUG=144297 R=cpu Review URL: https://codereview.chromium.org/10910311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 143251 - Log stack trace when ObjectWatcher::StartWatching() is called. Something isn't being cleaned up properly and we're seeing crashes where we call into a destroyed class. BUG=121086 TEST=none Review URL: https://chromiumcodereview.appspot.com/10535041 TBR=dcheng@chromium.org Review URL: https://chromiumcodereview.appspot.com/10633015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143468 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
move base/object_watcher into base/win and add the win namespace. Fixup callers. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5971008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70360 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add infrastructure enabling tests of installer upgrade scenarios. BUG=none TEST=none Review URL: http://codereview.chromium.org/5236002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67099 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Lump client and server versions of Windows together. Previously, Server 2008 R2 and Server 2012 had been treated like Server 2008, which was bad. I debated adding enum values for these two, but I can't think of a compelling argument for it. The big argument against doing so would be that any code that currently has some logic based on the version bearing some relation to VERSION_WIN7, for example, would be broken one way or another on a 2008 R2 box BUG=129217 TEST=none Review URL: https://chromiumcodereview.appspot.com/10408084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142539 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove IO thread restrictions from registry functions Registry access is mostly not IO bound. These restrictions needessly complicate chrome code. BUG=none TEST=current tests suffice Review URL: https://chromiumcodereview.appspot.com/10785022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146894 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base/win: small improvement to RegKey API. - Rename ValueExists() to HasValue(). - Rename ValueCount() to GetValueCount(). - Rename ReadName() to GetValueNameAt(). R=maruel@chromium.org,willchan@chromium.org Review URL: http://codereview.chromium.org/8337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106074 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move base/resource_util.* into base/win/ since it's windows specific. Review URL: http://codereview.chromium.org/7698005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98337 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add a convenience typedef LazyInstance<T>::Leaky to avoid repeating T. Converted the first 20 or so hits for LeakyLazyInstanceTraits on codesearch to demonstrate the benefit at callsites. The real change is base/lazy_instance.h; everything else is example. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9192024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118754 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to TimeDelta interface for process waiting functions in base. R=jar@chromium.org BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10694131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146211 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
More DCHECK() updates. A mixture of _EQ and _GE. Bug=58409 Review URL: http://codereview.chromium.org/6469070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76343 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the windows-specific scoped_* stuff from base to base/win and in the base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add additional debug/check for ScopedCOMInitializer. BUG=145095 Review URL: https://chromiumcodereview.appspot.com/10899041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Base: Enable the scoped handle verifier for Win7. BUG=131699 TEST=none Review URL: https://chromiumcodereview.appspot.com/10541121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141783 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158402 - Base: disable the scoped handle verifier for M23 beta. BUG=152037 TEST=none TBR=willchan@chromium.org Review URL: https://codereview.chromium.org/10978006 TBR=rvargas@google.com Review URL: https://codereview.chromium.org/10978007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158405 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use GenericScopedHandle to implement ScopedCreateDC. TEST=Existing unit-tests, Chrome runs, everybody happy. Review URL: https://chromiumcodereview.appspot.com/10696185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146457 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Base: Crash when failing to close a process/thread handle. BUG=127931 TEST=none TBR=willchan Review URL: https://chromiumcodereview.appspot.com/10447108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139722 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ScopedProcessInformation protects against process/thread handle leaks from CreateProcess calls. This CL includes the definition of the class along with changes to clients of CreateProcess. Please see http://codereview.chromium.org/9959018/ for the most substantial usages I propose introducing. This was motivated by realizing that my previous fix to LaunchProcess actually still had a leak of the thread handle. BUG=None TEST=tests added in base_unittests Review URL: https://chromiumcodereview.appspot.com/9700038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130710 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
More DCHECK() updates. A mixture of _EQ and _GE. Bug=58409 Review URL: http://codereview.chromium.org/6469070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76343 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #ifdef OFFICIAL_BUILD from scoped variant unittest, as the code is now always compiled BUG=none TEST=none Review URL: http://codereview.chromium.org/8890067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113944 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org BUG=132825, 148539 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* (run tests on XP as well) Review URL: https://chromiumcodereview.appspot.com/10909171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove TODO I have already done. I had left a TODO for myself, but ended up doing it in the same CL in http://crrev.com/156250 NOTRY=True BUG=148539 Review URL: https://chromiumcodereview.appspot.com/10911345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157780 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org BUG=132825, 148539 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* (run tests on XP as well) Review URL: https://chromiumcodereview.appspot.com/10909171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156250 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
* Rename ScopedStartupInfoEx to StartupInformation. * Add const accessor for startup_info_ member. * Add has_extended_startup_info check. * Make startup_info_ member explicitly unicode. Review URL: https://chromiumcodereview.appspot.com/10870093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153543 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
* Rename ScopedStartupInfoEx to StartupInformation. * Add const accessor for startup_info_ member. * Add has_extended_startup_info check. * Make startup_info_ member explicitly unicode. Review URL: https://chromiumcodereview.appspot.com/10870093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153543 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
* Rename ScopedStartupInfoEx to StartupInformation. * Add const accessor for startup_info_ member. * Add has_extended_startup_info check. * Make startup_info_ member explicitly unicode. Review URL: https://chromiumcodereview.appspot.com/10870093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153543 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix wrong permission TBR=yoichio@chromium.org BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10912164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155593 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix wrong permission TBR=yoichio@chromium.org BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10912164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155593 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add tablet heuristic detection Useful for win8 metro launching BUG=141032 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10909206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156589 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add tablet heuristic detection Useful for win8 metro launching BUG=141032 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10909206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156589 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move base/win_util to the base/win directory and use the base::win namespace. Fix up includes, many files including base/win_util don't actually need it. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70341 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Refine systemInfo.cpu API and provide systemInfo.cpu.get impl for Windows and Linux. BUG=136519 TEST=browser_test --gtest_filter=SystemInfoCpuApiTest.* Review URL: https://chromiumcodereview.appspot.com/10914060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155575 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refine systemInfo.cpu API and provide systemInfo.cpu.get impl for Windows and Linux. BUG=136519 TEST=browser_test --gtest_filter=SystemInfoCpuApiTest.* Review URL: https://chromiumcodereview.appspot.com/10914060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155575 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added base::win::InitializeWindowClass() wrapper to make sure that window classes are properly associated with the modules containing their window procedures. TEST=win,win_rel Review URL: https://chromiumcodereview.appspot.com/10315012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136116 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add an exception wrapper to the WindowProc functions so that we receive crash reports when something goes wrong. BUG=63702 TEST=base_unittests Review URL: http://codereview.chromium.org/6697004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78475 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 |