Ccsharp@chromium.orgShare Font Code for New Autofill.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Start the process of making Autofill into a Browser Component. This means, add the intended DEPS rules for a Browser Component (depend on nothing within chrome/browser outside the component except chrome/browser/api) and add a temporary owner for pure refactoring changes so that such changes can be done more quickly. Larger changes (that affect functionality or interfaces in non-refactoring ways) will still be sent to a proper OWNER. With the new DEPS, a presubmit check will warn developers that add new temporarily-allowed (the files designated with a "!" rule in the DEPS file). See http://www.chromium.org/developers/design-documents/browser-components BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10825134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149490 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove FieldTypeSubGroups from the AutofillType class. BUG=none TEST=none Review URL: http://codereview.chromium.org/8169009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104583 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make autofill regular expressions unicode again. Instead of compiling the source file with UTF8 directly, run it through a python script that rewrites the UTF8 into C literals. BUG=95858 Review URL: http://codereview.chromium.org/7891020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101236 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Revert 142048 - Move thread checking from autofill_country.cc to browser_process_impl.cc DCHECK(CalledOnValidThread()) is better than BrowserThread::CurrentlyOn(...) because it automatically supports unit test without requiring setting up specific threads. BUG=132643 TEST=Run Autofill tests in debug build Review URL: https://chromiumcodereview.appspot.com/10545169 TBR=wangxianzhu@chromium.org Review URL: https://chromiumcodereview.appspot.com/10533143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142066 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use BrowserContext as key in API. Switch Autofill to use BC in place of Profile. All that Autofill needed from Profile, apart from looking up services keyed on Profile, was stuff already in BrowserContext e.g. IsIncognitoMode(). Once a base class for ProfileSyncService migrates to API, we should be able to remove the profile.h includes in Autofill. TBR=mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10919066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156620 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce a couple of abstract bases for WebDataService. WebDataService is really a collection of different services that have a common initialization and some commonality e.g. how to cancel requests, and it's probably best that the interfaces reflect this logical split so that the implementation might some daybe tidied up. Starting this off with a WebDataServiceBase for the common bits, and an AutofillWebData for the Autofill-specific functionalities of WebDataService. Using these interfaces to break Autofill's concrete dependency on WebDataService. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10908065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156567 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable much of AutofillTest.* browser_tests BUG=150084 TBR=dhollowa@chromium.org Review URL: https://codereview.chromium.org/10979021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158670 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename InfoBarTabService -> InfoBarService. This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10879037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154023 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename InfoBarTabService -> InfoBarService. This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10879037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154023 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create chrome/browser/api directory. Move infobar delegates used by Autofill to the directory. Also, consolidate infobar delegate interfaces under infobars/ rather than some under infobars/ and some under tab_contents/, as the ones under tab_contents/ were not coupled with tab_contents/ in any way. Remove feedback/proto/extension.pb.h from Autofill's DEPS file simply by dropping the include, it was not being used. BUG=140037,138280 Review URL: https://chromiumcodereview.appspot.com/10843071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151279 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix the settings page for es-419 locale: Spanish (Latin America). Before the fix, the settings page for es-419 was half broken as there was an JavaScript error like below while loading the page. Uncaught TypeError: Cannot read property 'name' of undefined The error was caused by the fact that "419" isn't a valid country code. BUG=chromium-os:12857 TEST=open the "Languages and Input" settings on Chromium OS, and confirmed that it's shown correctly. Review URL: http://codereview.chromium.org/6626070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77402 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use BrowserContext as key in API. Switch Autofill to use BC in place of Profile. All that Autofill needed from Profile, apart from looking up services keyed on Profile, was stuff already in BrowserContext e.g. IsIncognitoMode(). Once a base class for ProfileSyncService migrates to API, we should be able to remove the profile.h includes in Autofill. TBR=mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10919066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156620 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to TimeDelta interfaces for TestTimeouts in autofill unit test. R=dhollowa@chromium.org BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10704116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145688 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Start of New Autofill UI for Windows Add some very basic functionality for the new Autofill UI system for windows. It currently just shows an empty popup in the correct location. Future cls will add the actual functionality. BUG=51644 Review URL: https://chromiumcodereview.appspot.com/10825324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155476 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Removing web_contents from AutofillExternalDelegateGtk BUG= Review URL: https://chromiumcodereview.appspot.com/10831313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151591 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make FormField be a struct rather than a class per c++ standards. This makes automatic generation of IPC messages much easier. Convert autofill messsage to automatic generation in the process. Attempt #2: fix build on chromeos, see http://codereview.chromium.org/6633001 for original CL. Review URL: http://codereview.chromium.org/6625087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77307 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
[Sync] Move 'sync' target to sync/ Also move related test files. Move WriteNode::UpdateEntryWithEncryption to nigori_util.h. Clean up defines and dependencies. In particular, get rid of SYNC_ENGINE_VERSION_STRING and hard-code the string in the single place it's used. Rename data_encryption.* to data_encryption_win.* and add a pragma for crypt32.lib. Clean up exit-time constructor warnings in sync{able,er}_unittest.cc. Remove some unused files. BUG=117585 TEST= TBR=jhawkins@chromium.org Review URL: https://chromiumcodereview.appspot.com/9699057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126872 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
iwyu: Cleanup in the following files: * autofill_download.cc * autofill_ie_toolbar_import_win.cc * autofill_field.h * autofill_metrics.cc * autofill_profile.cc * autofill_type.cc * autofill_xml_parser.cc * contact_info.cc * credit_card.cc * credit_card_field.cc * fax_number.h * form_field.cc BUG=none TEST=none R=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6775005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79839 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
[Sync] Move 'sync' target to sync/ Also move related test files. Move WriteNode::UpdateEntryWithEncryption to nigori_util.h. Clean up defines and dependencies. In particular, get rid of SYNC_ENGINE_VERSION_STRING and hard-code the string in the single place it's used. Rename data_encryption.* to data_encryption_win.* and add a pragma for crypt32.lib. Clean up exit-time constructor warnings in sync{able,er}_unittest.cc. Remove some unused files. BUG=117585 TEST= TBR=jhawkins@chromium.org Review URL: https://chromiumcodereview.appspot.com/9699057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126872 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base: Make ScopedVector::clear() destroy elements. This makes ScopedVector's clear() method destroy the elements before clearing the internal vector, matching the behavior of the erase() method. I'm moving clear()'s previous element-preserving behavior into a new weak_clear() method, matching weak_erase(). I'm also removing ScopedVector::reset(), as it duplicated clear()'s new behavior and isn't a part of std::vector. BUG=137909 TEST=added Review URL: https://chromiumcodereview.appspot.com/10797017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147360 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Autofill] Add "fp05cc03e1" experiment BUG=none TEST=none Review URL: http://codereview.chromium.org/9463035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123905 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upgrade Seperator in New Autofill UI Modify the new Autofill UI to use WebAutofillClient::MenuItemIDSeparator as the sperator index, which will make it easier to have multiple separators in the future. BUG=125001 TEST=Unit tests pass Review URL: https://chromiumcodereview.appspot.com/10408070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138860 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share Font Code for New Autofill. Move the gfx::Font code into the base class to allow the platform specific subclasses to share it. BUG=51644 Review URL: https://chromiumcodereview.appspot.com/10987018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158684 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share Font Code for New Autofill. Move the gfx::Font code into the base class to allow the platform specific subclasses to share it. BUG=51644 Review URL: https://chromiumcodereview.appspot.com/10987018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158684 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of PAGE_TRANSITION_START_PAGE cleanup. I replaced START_PAGE with AUTO_TOPLEVEL because that more accurately describes how its being used in the code. In a followed CL I will add specific support for startup pages, which was the original intention of START_PAGE. This CL is basically a large search and replace and does not change the behaviour of the code. BUG=144002 TEST=No user visible change Review URL: https://chromiumcodereview.appspot.com/10897034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155047 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Autofill: Remove a regular expression for fax which is no longer used. BUG=81846 TEST=none R=isherman@chromium.org Review URL: http://codereview.chromium.org/8745018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112251 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Autofill: Ignore gift cards when filling credit card info BUG=98338 TEST=browser_tests --gtest_filter=*DataDrivenHeuristics* Review URL: http://codereview.chromium.org/8052024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103085 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
This broke lots of layout tests on OSX. See this link for the failure list: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/dom/HTMLTextAreaElement/reset-textarea.html,fast/dom/isindex-001.html,fast/dom/isindex-002.html,fast/forms/blankbuttons.html,fast/forms/box-shadow-override.html,fast/forms/button-default-title.html,fast/forms/file-input-direction.html,fast/forms/hidden-input-file.html,fast/forms/input-appearance-height.html,fast/forms/input-file-re-render.html,fast/forms/input-first-letter.html,fast/forms/isindex-placeholder.html,fast/forms/text-style-color.html,fast/forms/validation-message-appearance.html,fast/html/details-no-summary1.html,fast/html/details-no-summary2.html,fast/html/details-no-summary3.html,fast/html/details-no-summary4.html,fast/html/details-remove-summary-1-and-click.html,fast/html/details-remove-summary-1.html,fast/html/details-remove-summary-4-and-click.html,fast/html/details-remove-summary-4.html,fast/html/keygen.html,tables/mozilla/bugs/bug39209.html,tables/mozilla/bugs/bug4429.html,fast/forms/005.html,fast/forms/input-file-label.html,fast/invalid/residual-style.html,fast/parser/fragment-parser.html,fast/replaced/table-percent-height-text-controls.html,html5lib/runner.html,http/tests/misc/isindex-with-no-form-base-href.html,http/tests/misc/isindex-with-no-form.html Revert 101213 - Updated *.pak file format to support both UTF8 and UTF16 Inserted a new field in the header that specifies which encoding is to be used for the text resources. I also upped file format to version 4. BUG=76281 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973 Review URL: http://codereview.chromium.org/7744017 TBR=adriansc@chromium.org Review URL: http://codereview.chromium.org/7890060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101224 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify Autofill Scanner semantics SaveCursor() no longer provides stack semantics. Instead, it only saves the most recent cursor position. Clients who want to save multiple cursors can now capture the result of SaveCursor() and later explicitly RewindTo() saved positions. BUG=85142 TEST=unit_tests --gtest_filter=Autofill*:CreditCard*:FormField* Review URL: http://codereview.chromium.org/7120005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88243 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove FieldTypeSubGroups from the AutofillType class. BUG=none TEST=none Review URL: http://codereview.chromium.org/8169009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104583 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove FieldTypeSubGroups from the AutofillType class. BUG=none TEST=none Review URL: http://codereview.chromium.org/8169009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104583 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Roll libjingle 88:92 Beside other changes the new version of libjingle has thread-safe QName class and has all std::string and QName statics removed. BUG=94993,102451 TEST=Compiles Review URL: http://codereview.chromium.org/8413059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108065 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Roll libjingle 132:135 Review URL: https://chromiumcodereview.appspot.com/10209008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134065 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Autofill: Support 'full names' that are lacking a first or a middle name. BUG=98335 TEST=unit_tests --gtest_filter=NameInfoTest.* Review URL: http://codereview.chromium.org/8038064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103241 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Autofill: Support 'full names' that are lacking a first or a middle name. BUG=98335 TEST=unit_tests --gtest_filter=NameInfoTest.* Review URL: http://codereview.chromium.org/8038064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103241 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Autofill: Ignore gift cards when filling credit card info BUG=98338 TEST=browser_tests --gtest_filter=*DataDrivenHeuristics* Review URL: http://codereview.chromium.org/8052024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103085 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Switch ChromeTestSuite to the same convention as ContentTestSuite: the test suite implicitly provides global resources for each test, but they're re-initialized between each test. The performance overhead is negligible. We need that to continue moving tests from unit_tests to content_unittests. Because of shared test fixtures the test suites need to be compatible. BUG=90443 Review URL: http://codereview.chromium.org/7744039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add SCOPED_TRACE to data driven tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/6733055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79511 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make autofill regular expressions unicode again. Instead of compiling the source file with UTF8 directly, run it through a python script that rewrites the UTF8 into C literals. BUG=95858 Review URL: http://codereview.chromium.org/7891020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101236 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Autofill: Remove fax number completely. BUG=81846 TEST=* R=isherman@chromium.org Review URL: http://codereview.chromium.org/7892048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101602 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Convert ASCIIToUTF16("") to string16(). Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Review URL: http://codereview.chromium.org/8687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move a bunch of non-shared methods out of the FormGroup class. Some of them can be removed completely! BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8143007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104045 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base: Remove dereference structure operator (i.e ->) from ScopedVector. BUG=128663 R=brettw@chromium.org,willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10669038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make autofill regular expressions unicode again. Instead of compiling the source file with UTF8 directly, run it through a python script that rewrites the UTF8 into C literals. BUG=95858 Review URL: http://codereview.chromium.org/7891020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101236 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
New Autofill UI uses ID for password The new Autofill UI uses field IDs to determine which values should be handled by the password manager or the default Autofill manager. BUG=51644 TEST= Review URL: http://codereview.chromium.org/10230005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134266 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
New Autofill UI uses ID for password The new Autofill UI uses field IDs to determine which values should be handled by the password manager or the default Autofill manager. BUG=51644 TEST= Review URL: http://codereview.chromium.org/10230005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134266 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update the password generation algorithm to contain at least one upper case letter, one lower case letter, one digit, and one other symbol. BUG= TEST=PasswordGeneratorTest, AutofillManagerTest, PasswordGenerationManagerTest. Review URL: https://chromiumcodereview.appspot.com/10458018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140812 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update the password generation algorithm to contain at least one upper case letter, one lower case letter, one digit, and one other symbol. BUG= TEST=PasswordGeneratorTest, AutofillManagerTest, PasswordGenerationManagerTest. Review URL: https://chromiumcodereview.appspot.com/10458018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140812 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Taking over issue 10006037. Moved WebDataService to ProfileKeyedService James: chrome\browser\ui\intents Peter: chrome\browser\ui\search_engines chrome\browser\search_engines Nicolas: chrome\browser\sync Rachel/Elliot: chrome\browser\profiles and the whole cl BUG=112234 TEST=unit-tests TBR=jhawkins@chromium.org,pkasting@chromium.org,zea@chromium.org,erg@chromium.org,isherman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136499 Review URL: https://chromiumcodereview.appspot.com/10185008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137014 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Profile shouldn't own PersonalDataManager Converts PersonalDataManager over to be a ProfileKeyedService. Decouples Sync code from PersonalDataManager and moves to a notification-based update. Changes various test mocks over to the new ProfileKeyedService mechanisms. BUG=94026 TEST=PersonalDataManagerTest.*:AutofillTest.*:AutofillMetricsTests.*:AutofillDataTypeControllerTest.*: and other Sync tests. Review URL: http://codereview.chromium.org/7967024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102598 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
base: Make ScopedVector::clear() destroy elements. This makes ScopedVector's clear() method destroy the elements before clearing the internal vector, matching the behavior of the erase() method. I'm moving clear()'s previous element-preserving behavior into a new weak_clear() method, matching weak_erase(). I'm also removing ScopedVector::reset(), as it duplicated clear()'s new behavior and isn't a part of std::vector. BUG=137909 TEST=added Review URL: https://chromiumcodereview.appspot.com/10797017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147360 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce a couple of abstract bases for WebDataService. WebDataService is really a collection of different services that have a common initialization and some commonality e.g. how to cancel requests, and it's probably best that the interfaces reflect this logical split so that the implementation might some daybe tidied up. Starting this off with a WebDataServiceBase for the common bits, and an AutofillWebData for the Autofill-specific functionalities of WebDataService. Using these interfaces to break Autofill's concrete dependency on WebDataService. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10908065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156567 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Autofill: Remove fax number completely. BUG=81846 TEST=* R=isherman@chromium.org Review URL: http://codereview.chromium.org/7892048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101602 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix an Autofill crash caused by accessing the g_browser_process on the DB thread. This is meant as a minimal-impact CL, so that it should be safe to merge to M16. The more complete fix is being tracked in bug 100845. BUG=100745 TEST=less crashy Review URL: http://codereview.chromium.org/8355025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106822 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-committing http://codereview.chromium.org/8736001/ originally committed revision=112305 The difference is the phone library pulled is version 407 instead of 403, it includes fixes, including missing licenses. Original description: Pull the phone library directly. Delete old version. TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8790002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112865 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Convert ASCIIToUTF16("") to string16(). Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Review URL: http://codereview.chromium.org/8687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Group forms-related files in webkit/glue in a forms/ subdirectory. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
TabContentsWrapper -> TabContents, part 5. Autofill. BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10546054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141221 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Merge branch 'trunk' of http://git.chromium.org/git/chromium into autofill remove autofill impl from upstream Autofill involves calls to native view, so the dependency is not correct. If we want to upstream autofill_external_delegate_android, we have to introduce another delegate. Remove the code from upstream for now. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10701058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146021 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |