Ppedrosimonetti@chromium.orgNTP5: Adjusting dynamic padding implementation.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Disabling flaky test, AccessibilityWinBrowserTest.TestNotificationActiveDescendantChanged. TBR=dmazzoni@chromium.org BUG=145537 NOTRY=true TEST=none Review URL: https://chromiumcodereview.appspot.com/10887033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153938 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add rendering support to the TestShell. - Tie the Compositor into the TestShell. - Tie a really basic Tab into the TestShell. BUG=http://crbug.com/136786 Review URL: https://chromiumcodereview.appspot.com/10968003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158654 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-land r158555: "[Android] Exclude unsupported URLs from chrome://chrome-urls." Original code review: https://chromiumcodereview.appspot.com/10980008/ Reverted by: https://codereview.chromium.org/10993005/ This CL fixes builtin_provider_unittest.cc which was broken by the previous CL. BUG=136996 Review URL: https://chromiumcodereview.appspot.com/10993018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158753 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share Font Code for New Autofill. Move the gfx::Font code into the base class to allow the platform specific subclasses to share it. BUG=51644 Review URL: https://chromiumcodereview.appspot.com/10987018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158684 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's only used for ChromeFrame, move it to the ExternalTabContainer interface instead. Also remove WebContentsDelegate::GetFrameNativeWindow which isn't used. Review URL: https://codereview.chromium.org/10987047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158861 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
bookmarks: Remove browser_list.h entry from DEPS whitelist. BUG=144783 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/10993022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158701 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch CaptivePortalTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10946011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157613 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Add CHECK for screen unlock problem On some devices when you unlock the screen after suspend the launcher and desktop windows do not appear. I suspect the background widget is not being reparented properly but I cannot reproduce the problem internally. Since the user can't recover from this state without rebooting, add some CHECKs to try to track down the source. Also initialize empty wallpaper if we're running tests, as we previously skipped it which would cause my CHECKs to be hit. BUG=149043 TEST=ScreenLockerTest and manual, lock screen with Ctrl-Shift-L, unlock by entering password Review URL: https://chromiumcodereview.appspot.com/10982035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158846 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstream chromium side of modal dialogs for webview. There's still some default handling needed if the embedder doesn't override the handler. Includes clean-up of previous hooks in content that aren't needed anymore. BUG=138483 Review URL: https://chromiumcodereview.appspot.com/10907166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157815 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup the IPC param traits structure: -traits that are only used by chrome should be in chrome -traits that aren't used by chrome shouldn't be in content/public -use macros for serialization where possible -traits that are only used by one message file should just be listed in it -get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change. Review URL: https://codereview.chromium.org/10980010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158570 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix content settings bubble crash. BUG=151591 TEST=as in bug Review URL: https://chromiumcodereview.appspot.com/10987022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158617 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix registerProtocolHandler OS registration on Windows 8 On Windows 8 to register as the default handler for a protocol you need to go through a Windows shell UI flow, it cannot be done anymore via the IApplicationAssociationRegistration interface. BUG=150850 TEST=Ensure gmail and other protocol handlers can be registered successfully on Windows 7 and 8. Review URL: https://chromiumcodereview.appspot.com/10963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158612 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
DevTools: provide the debugger detach reason in chrome.debugger.onDetach extension API. BUG=129539 Review URL: https://chromiumcodereview.appspot.com/10947037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157754 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 152946 - Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date. Detailed comments about the changes made in this CL can be found in the document shared separately. Previous reviewers: sky, pkasting, shess. BUG=95686, 95876, 131668 TEST=New tests added, old tests updated, all tests pass. To manually verify changes: NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider. 1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion. 2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show. 3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted. 4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP. 5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title. Previously reviewed as: http://codereview.chromium.org/10477018/. 10477018 was reverted due to memory leaks detected by build bots. Review URL: https://chromiumcodereview.appspot.com/10837244 TBR=mrossetti@chromium.org This is causing performance regressions across a range of perf bots. Review URL: https://chromiumcodereview.appspot.com/10872032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152963 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable ExtensionApiTest.NativeMessageBasic The CL that introduced this was reverted, but that had to be reverted because of compile failures, and somehow a data file this depends on didn't get re-added. Just disable it until the revert can be re-landed. Make sense? :) TBR=mpcomplete@chromium.org BUG=142915 Review URL: https://codereview.chromium.org/10979038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158874 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch ExternalProtocolObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10961053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158878 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's only used for ChromeFrame, move it to the ExternalTabContainer interface instead. Also remove WebContentsDelegate::GetFrameNativeWindow which isn't used. Review URL: https://codereview.chromium.org/10987047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158861 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Eliminate kAshNotifyDisabled and SystemNotification BUG=134561 For OWNERS: TBR=ben Review URL: https://codereview.chromium.org/10947046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158305 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable EULA dialog to be shown from metro Chrome. BUG=131033 TEST=Run Chrome in Metro mode while the EULA dialog still needs to be accepted. Get kicked back to the desktop to accept the dialog. On accept, get kicked back into metro mode. Review URL: https://chromiumcodereview.appspot.com/10837222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158797 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update the network-based geolocation to use the new Google Location Service API. BUG=146354 Review URL: https://chromiumcodereview.appspot.com/10912081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156273 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow the X-Chrome-Variations header to transmit to all ports. This is to make internal testing simpler. BUG=145886 TEST=Navigate to a *.google.<TLD> URL with a port other than 80 (or 443 on https). Ensure that the X-Chrome-Variations header is transmitted as part of that request. Review URL: https://chromiumcodereview.appspot.com/10908028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155095 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
drive: Nullify --enable-drive-v2-api temporarily The feature under the flag is not yet ready to be used. Will remove the flag from about:flags in a separate patch. BUG=152230,151957,149009,151963 TEST=Drive on Files.app works as before (the flag was disabled by default) Review URL: https://codereview.chromium.org/10986031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158663 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Render/pepper hang debugging: generate dumps for the browser and renderer processes if users kill a hung pepper plugin. This CL collects information in order to diagnose inter-process pepper deadlocks. - We don't crash those renderers or the browser. - We only do this on the Windows Canary channel for 20% of pepper plugin hangs, if there are not too many renderers (<4). BUG=147593 TEST=None Review URL: https://chromiumcodereview.appspot.com/10983028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158717 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Review URL: https://codereview.chromium.org/10978016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158725 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup the IPC param traits structure: -traits that are only used by chrome should be in chrome -traits that aren't used by chrome shouldn't be in content/public -use macros for serialization where possible -traits that are only used by one message file should just be listed in it -get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change. Review URL: https://codereview.chromium.org/10980010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158570 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158513 - Maybe fix InstantTest.NewWindowDismissesInstant on Mac. The test still fails (see review thread for log link), even after the attempted fix, so revert it. See bug for possible true cause. BUG=152461 R=jennb@chromium.org TEST=none Review URL: https://chromiumcodereview.appspot.com/10984047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158869 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Using API keys for requests to Chrome Web Store. BUG=148801 R=gbillock@chromium.org for Web Intents changes. R=joi@chromium.org to verify that I am using GetAPIKey() correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157197 Review URL: https://chromiumcodereview.appspot.com/10911331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157393 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't use NXArgc or NXArgv. Access them via _NSGetArgc() and _NSGetArgv(). This allows dead code stripping to be turned back on for the main executables and for the NXArgc and NXArgv symbols to be stripped. BUG=139902 Review URL: https://chromiumcodereview.appspot.com/10837149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150419 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Begin adding support for tab mirroring via the MediaStream audio/video capturing framework. Expanded the scope of the content::MediaStreamDeviceType enum to support the new concept of "internal capture devices." From there, many modules were tweaked to account for the new concept. In some cases, significant new functionality was added (described below). In this change, tab mirroring audio and video capture devices have been introduced, but stubbed-out. The following proposal provides more backrgound on this and the overall motivation for the code changes at-hand: http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/webrtc-tab-content-capture Significant changes: 1. content/common/media and content/public/common -- a) Expand content::MediaStreamDeviceType enum; b) Update media_stream::StreamOptions so that extension API bindings can ask for any of the MediaStreamTypes. 2. content/browser/renderer_host/media -- Minor refactoring: MediaStreamManager handles all MediaStreamDeviceTypes. Only supports EnumerateDevices and OpenDevice for physical device types. Add new GenerateStreamForDevice() API. 3. chrome/browser/media and chrome/browser/ui -- Enhance "Allow/Deny and device selection" infobar to handle all MediaStreamDeviceTypes. Review URL: https://chromiumcodereview.appspot.com/10912004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155925 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Media Galleries: Change the media gallery name to be a JSON value with the name and pref id. BUG=144535 Review URL: https://chromiumcodereview.appspot.com/10933137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157277 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Activate the VariationsService for ChromeOS and ensure that it does not ping the server until the EULA is accepted. We accomplish this by adding an OnEulaAccepted method to the WizardControllerObserver and have the VariationsService be notified on that method when the EULA is accepted. BUG=146865 TEST=Start CrOS on a new machine and ensure that, with a network connection, no requests are made to the variations server before the EULA is accepted. As soon as the EULA is accepted, ensure that a request is made. Also ensure that a request is made each time at startup after the first time the EULA is accepted. Review URL: https://chromiumcodereview.appspot.com/10917120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158648 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove old flags from about:flags and add new ones instead. We are moving from nacl64-gdb to debugger via debug stub. In order to reduce user confusion, we need to leave only new flag. BUG= none TEST= bots, launch chrome and open about:flags page. Review URL: https://chromiumcodereview.appspot.com/10918021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157006 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SampleSet -> HistogramSamples which can be reused by SparseHistogram BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10822030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148514 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL fixes the issue that password save prompt is suppressed when the action URL is modified prior to submit. BUG=27246 TEST= Login to the website http://ikariam.com/ and verify password save prompt is shown after navigation. Review URL: https://chromiumcodereview.appspot.com/10892011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158301 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 157168 - Add guards to metric values; erase bad events/metrics from db Improves the database by not inserting blatantly erroneous data, and by deleting any events or metrics which cannot be properly retrieved from the database. Also make DB take a metric for AddMetric() - this makes it so that we have a more accurate timestamp since we record the time before the thread-jumping. BUG=130212 Review URL: https://chromiumcodereview.appspot.com/10907121 TBR=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/10915318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157182 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove PluginFinder async interface Depends on this CL: http://codereview.chromium.org/10910168/ BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10917189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158799 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158894 - Disable TLS channel ID by default. (for merging to branch) BUG=129174 TEST=browse to https://www.google.com, check chrome://histograms for DomainBoundCerts.Support. Then try with --enable-tls-channel-id flag. Review URL: https://codereview.chromium.org/10979040 TBR=mattm@chromium.org Review URL: https://codereview.chromium.org/10981045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158897 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Review URL: https://codereview.chromium.org/10978016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158725 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify document title for Windows printing. Some drivers can't handle long titles or control characters. BUG=65469 Review URL: https://chromiumcodereview.appspot.com/10941025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157715 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstream USB web debugging enabled user pref. Chrome on Android has a user preference for enabling USB web debugging from Chrome desktop, upstream the preference. BUG=151444 Review URL: https://chromiumcodereview.appspot.com/10989006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158505 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SampleSet -> HistogramSamples which can be reused by SparseHistogram BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158830 - Revert 156678 - Native messaging now uses the MessageService back-end. Reason: Regression in a ChromeOS extension causing it to continue running after unloading. BUG=142915 Review URL: https://codereview.chromium.org/10818013 TBR=eaugusti@chromium.org TBR=mpcomplete@chromium.org TBR=mmoss, rouslan Review URL: https://codereview.chromium.org/10991044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158833 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
NTP5: Adjusting dynamic padding implementation. BUG= Review URL: https://chromiumcodereview.appspot.com/10983045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158901 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
rlz: Do not record omnibox events for non-branded builds Pings weren't sent, so this information was only collected locally. However, other parts of the RLZ code don't collect events for non-branded builds at all, so don't do it here either. BUG=141108,138158 Review URL: https://chromiumcodereview.appspot.com/10829302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151345 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add more OWNERS inside chrome/browser. Review URL: https://chromiumcodereview.appspot.com/10877002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152827 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix: Prerendering was confusing SessionService to not save sessionStorage. BUG=149905 Review URL: https://chromiumcodereview.appspot.com/10969012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158778 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Speech Input: always abort when user clicks outside speech bubble. This prevents a race which would lead to a browser crash (null ptr deref) when a speech input icon is clicked on repeatedly: 1. User clicks speech icon 2. We show speech bubble, ask sound system to start recording 3. User clicks outside bubble, we close it 3a. Speech system not recording yet, so we don't abort session 4. Sound system calls back: "Here's some audio!" 5. We try to update the bubble which dosn't exist anymore. This patch fixes 3a; we should just always abort here. BUG=146689 TEST=manual (click speech icon rapidly many times) Review URL: https://chromiumcodereview.appspot.com/10960010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157777 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing spelling service to use GetAPIKey. BUG=150906 TBR=hbono@chromium.org Review URL: https://chromiumcodereview.appspot.com/10947042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157869 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch SSLTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10916348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157292 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correctly remove file browser notifications from Ash notification tray. Also added replace_id to DesktopNotificationService::AddNotification so that notifications are correctly replaced/updated. BUG=135286 For minor changes to status_icons/ background/ and printing/: TBR=atwilson@chromium.org,thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151305 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Refactor handling of session tabs Add SessionTab <-> sync_pb::SessionTab conversion functions. Add IsPinned() method to SyncedTabDelegate and fix latent NULL-dereference bug in the process. Remove HasExtensionAppId() also. Rework tab contents association to: - update a SessionTab from the tab delegate (UpdateSessionTabFromDelegate); - get the current virtual URL for the tab (GetCurrentVirtualURL); - and convert to sync_pb::SessionTab in separate phases. Rework the SessionModelAssociator tests. BUG=128449 Review URL: https://chromiumcodereview.appspot.com/10990012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158777 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Media galleries: disable detection of attached devices during startup NOTRY=TRUE BUG=150608 Review URL: https://codereview.chromium.org/10991029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158706 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158830 - Revert 156678 - Native messaging now uses the MessageService back-end. Reason: Regression in a ChromeOS extension causing it to continue running after unloading. BUG=142915 Review URL: https://codereview.chromium.org/10818013 TBR=eaugusti@chromium.org TBR=mpcomplete@chromium.org TBR=mmoss, rouslan Review URL: https://codereview.chromium.org/10991044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158833 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158707 - Enable by default: 1. threaded compositing on windows (except XP) 2. force compositing mode on mac On linux we switch to a 1/3 1/3 fcm and thread experiments . This patch also gives priority to the command line switches so that both threaded and force compositing mode can be turned off via the about:flags page or command line. In the near future, we will use the Finch framework to tweak the experiment percentages. Note: This patch has a dependency on: https://bugs.webkit.org/show_bug.cgi?id=96871 It also disables ExtensionApiTest.CaptureVisibleTabJPeg as it triggers flakiness on it. chrome.tabs.captureVisibleTab is inherently racy as there is no way to guarantee that the tab has been painted at least once when that call is made. Note how the other variants of CaptureVisibleTab tests have already been disabled for similar reasons. BUG=143809,128387,146861 Review URL: https://chromiumcodereview.appspot.com/10914247 Reverted due to failures on Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/29446/steps/interactive_ui_tests/logs/AutoResize http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/2143/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/26358/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/1804/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine TBR=vangelis@chromium.org Review URL: https://codereview.chromium.org/10991032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158711 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add more OWNERS inside chrome/browser. Review URL: https://chromiumcodereview.appspot.com/10877002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152827 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use new find in page resource on Windows too. Screenshots are in bug. BUG=129757 TEST=None. Review URL: https://codereview.chromium.org/10965042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158560 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch PepperBrokerObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158887 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing use of deprecated DISALLOW_EVIL_CONSTRUCTORS BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10991039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 157723 - Revert 157713 - Make database failures in LeveldbValueStore more descriptive. Reason: memory leak. Reason: actually, I just need to update a suppression. Note that I initially intentionally didn't do this so that extensions didn't get any unnecessary information. However, it will help with bug reports. BUG=149888 Review URL: https://chromiumcodereview.appspot.com/10928227 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/10956008 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/10964010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157724 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support simultaneous notification and bubble promos. BUG=NONE TEST=manual Review URL: https://chromiumcodereview.appspot.com/10944019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157482 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Render/pepper hang debugging: generate dumps for the browser and renderer processes if users kill a hung pepper plugin. This CL collects information in order to diagnose inter-process pepper deadlocks. - We don't crash those renderers or the browser. - We only do this on the Windows Canary channel for 20% of pepper plugin hangs, if there are not too many renderers (<4). BUG=147593 TEST=None Review URL: https://chromiumcodereview.appspot.com/10983028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158717 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
drive: Remove --enable-drive-v2-api from about:flags The feature under the flag is not yet ready to be exposed to users. Besides, the flag was a source of mysterious crash bugs. BUG=152230, 151957, 149009, 151963 TEST="Enable Drive V2 API" is gone from about:flags Review URL: https://chromiumcodereview.appspot.com/10993015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158789 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add dummy implementation of about_flags for Android. This is part of the unit_tests linking effort. Review URL: https://chromiumcodereview.appspot.com/10698095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146249 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Show all experiments, even those that are unavailable on the current platform BUG=53560 TEST=Go to about:flags, check that all experiments are shown, with a list of the platforms where each one can run. Review URL: http://codereview.chromium.org/8898039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115054 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Miscellaneous cleanups from several months ago I never got around to landing. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10890023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154549 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
mac: Remove now-unneeded includes of cocoa_protocols.h BUG=137676 TEST=compiles TBR=OWNERS Review URL: https://chromiumcodereview.appspot.com/10831025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148560 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Get rid of the content::NOTIFICATION_APP_ACTIVATED notification since it was fired from Chrome (content notifications should only be fired from content). Review URL: https://codereview.chromium.org/10958066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158279 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Always enable dom automation for browser_tests. This avoids developers having to call EnableDOMAutomation manually, which is not evident. ui_tests used to do this automatically. Also while at it, removed needless InProcessBrowserTest::SetUpCommandLine() calls. Review URL: https://chromiumcodereview.appspot.com/10778044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147272 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch ChromeTestSuite to the same convention as ContentTestSuite: the test suite implicitly provides global resources for each test, but they're re-initialized between each test. The performance overhead is negligible. We need that to continue moving tests from unit_tests to content_unittests. Because of shared test fixtures the test suites need to be compatible. BUG=90443 Review URL: http://codereview.chromium.org/7744039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Badge Windows profile shortcuts with multi-user avatar. BUG=105110 TEST=Ensure that when Chrome on Windows creates a desktop icon for a new Profile, the icon image has the user avatar in it. Ensure that changing the Avatar changes the image in the icon. TBR=rsesek Review URL: http://codereview.chromium.org/8785006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113104 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make sure the Autolaunch infobar... 1) shows up on First Run of Chrome (for the right experiment brand code). 2) takes precedent over the 'Chrome is not your default browser' infobar. 3) is not shown if other infobars are present. Also some minor cleanup: - Renamed IsInAutoLaunchGroup to IsInAutoLaunchFieldTrial (better fit). - Moved brand specific code to auto_launch_trial namespace (easier to find) and created meaningful function names for'em. BUG=106801 TEST=This requires a special branded build (see instructions for http://codereview.chromium.org/8729009). Review URL: http://codereview.chromium.org/8969024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114974 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-land r158555: "[Android] Exclude unsupported URLs from chrome://chrome-urls." Original code review: https://chromiumcodereview.appspot.com/10980008/ Reverted by: https://codereview.chromium.org/10993005/ This CL fixes builtin_provider_unittest.cc which was broken by the previous CL. BUG=136996 Review URL: https://chromiumcodereview.appspot.com/10993018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158753 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use the last committed entry for View Source. BUG=138140 TEST=Ctrl+U while a page load is in progress. Review URL: https://chromiumcodereview.appspot.com/10829308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151512 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-enable BrowserEncodingTest.TestEncodingAliasMapping under ASan BUG=127748 TEST=manual and on bot Review URL: https://chromiumcodereview.appspot.com/10834309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151543 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future change, but I wanted to break it up. Review URL: https://chromiumcodereview.appspot.com/10823392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152102 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Mark BrowserKeyEventsTest.PageUpDownKeys as flaky. See: http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20%28dbg%29/builds/27190/steps/interactive_ui_tests/logs/stdio http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=54925 http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/54919/steps/interactive_ui_tests/logs/PageUpDownKeys ... TBR=ben@chromium.org BUG=147579 Review URL: https://chromiumcodereview.appspot.com/10911182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155739 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move download stuff from download helper back to TabContents. This is basically a revert of r85762, with updating for code changes in the meantime. BUG=82782 Review URL: http://codereview.chromium.org/7374008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92747 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Try 2 - Change how ui::Clipboard is accessed so there's only one per thread. Currently, there can be any number of Clipboard objects, which can be massively simplified. This removes interfaces for fetching the Clipboard and makes everyone go through a single static ui::Clipboard::GetForCurrentThread() access point. [Differences from the first patch: this may fix the pdf tests, but since I have no way to run them locally or on a trybot, this is going in blind.] BUG=130805 R=jam@chromium.org TBR=tc,ben,dcheng,kaiwang First Review URL: https://chromiumcodereview.appspot.com/10911074 Review URL: https://chromiumcodereview.appspot.com/10916214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156027 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Separate plugin_metadata from plugin_installer, make plugin_finder thread-safe and expose its sync interface BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10910168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158679 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Try 2 - Change how ui::Clipboard is accessed so there's only one per thread. Currently, there can be any number of Clipboard objects, which can be massively simplified. This removes interfaces for fetching the Clipboard and makes everyone go through a single static ui::Clipboard::GetForCurrentThread() access point. [Differences from the first patch: this may fix the pdf tests, but since I have no way to run them locally or on a trybot, this is going in blind.] BUG=130805 R=jam@chromium.org TBR=tc,ben,dcheng,kaiwang First Review URL: https://chromiumcodereview.appspot.com/10911074 Review URL: https://chromiumcodereview.appspot.com/10916214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156027 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move gpu blacklist data file to content side. This also fixes the bug that GPU histograms are missing. BUG=151057 TEST=tree R=jbauman Review URL: https://codereview.chromium.org/10911315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157851 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Metro mode switching (chrome side) This change puts a menu option to restart chrome in desktop or to restart chrome in metro mode and then wires up to the restart helper. BUG=141032 TEST=see bug Review URL: https://chromiumcodereview.appspot.com/10885047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155263 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
first-run: Pull IsBrowserAlreadyRunning() out of upgrade_util_win.h. This concept is not specific to upgrade path and thus shouldn't belong there. Move it to a new header file called browser_util_win.h as it's more appropriate. BUG=79203 TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6861001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81691 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NSS functions out of CertDatabase into a new NSSCertDatabase class. BUG=chromium-os:33872 Review URL: https://chromiumcodereview.appspot.com/10916094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155720 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove BrowserList::GetLastActive usage from WebUI pages. I've plumbed the TabContents to the page bubble code so that the webui certificate viewer can get the Browser from it. BUG=129187 Review URL: https://chromiumcodereview.appspot.com/10554010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142963 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Coverity] CID 6203: pass std::string by const-ref BUG=none TEST=compile Review URL: http://codereview.chromium.org/9474020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123886 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove SSLHostInfo. BUG=105208 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144468 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome/browser should build on the x86_64 architecture. BUG=143395 TEST=32/64-bit chrome/browser builds without errors. TBR=mac64 Review URL: https://chromiumcodereview.appspot.com/10825447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152572 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SampleSet -> HistogramSamples which can be reused by SparseHistogram BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extend safebrowsing interstitial field trial end date. BUG=148870,143999, 151709 Review URL: https://chromiumcodereview.appspot.com/10967057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158167 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable TLS channeld id by default. Replace --enable-origin-bound-certs command line flag with --disable-tls-channel-id. Remove field trial. BUG=136462,129174 Review URL: https://chromiumcodereview.appspot.com/10910240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156939 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable EULA dialog to be shown from metro Chrome. BUG=131033 TEST=Run Chrome in Metro mode while the EULA dialog still needs to be accepted. Get kicked back to the desktop to accept the dialog. On accept, get kicked back into metro mode. Review URL: https://chromiumcodereview.appspot.com/10837222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158797 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use ChromeBrowserMainPartsAndroid. Includes several changes: 1) Stubs out jankometer 2) Makes some background-related profile code guarded by ENABLE_BACKGROUND 3) Remove SingletonProcess because it's guaranteed by the OS. 4) If-def out first-run code and process startup code as it's necessary handled in the Java layer on Android. In order to improve startup performance, Chrome for Android runs startup code in the java layer asynchronously with loading the native shared library. Re-using this code would result in us blocking until the entire library is loaded into memory. 5) Removes UMA code. UMA sessions are handled differently on Android as the browser isn't ever killed and is instead paused/resumed. 6) Also removes things like ManagedMode/PageCycler which are unused on Android. BUG=138184 Review URL: https://chromiumcodereview.appspot.com/10885023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154029 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add native-side unit test for Android NetworkChangeNotifier * Renames some classes to move them out of the android namespace. * Changes singleton handling in the Java NetworkChangeNotifier. The singleton is unfortunately still required for Android to turn the AutoDetector on. * Adds a native-side unit test to track that the JNI calls are correctly plumbed to alert native-side observers of connection changes. BUG=136984 Review URL: https://chromiumcodereview.appspot.com/10928193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157687 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming ChromeBrowserMainAndroid Upstreaming the chrome_browser_main_android and its immediate dependencies. This code is used to override the default chromium initialization with android specific initialization. Android uses custom MessageLoop. BUG=138184 TEST=Compile unit_tests_apk target Review URL: https://chromiumcodereview.appspot.com/10819003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150438 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make BrowserMainParts have an empty implementation to make embedding easier. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10443091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139626 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move device notification impl out of chrome/browser/media_gallery BUG=145400 TEST=None Review URL: https://chromiumcodereview.appspot.com/10919051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154961 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove use of weakptr for RemovableDeviceNotificationsMac BUG= Review URL: https://chromiumcodereview.appspot.com/10948019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157569 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove use of weakptr for RemovableDeviceNotificationsMac BUG= Review URL: https://chromiumcodereview.appspot.com/10948019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157569 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming ChromeBrowserMainAndroid Upstreaming the chrome_browser_main_android and its immediate dependencies. This code is used to override the default chromium initialization with android specific initialization. Android uses custom MessageLoop. BUG=138184 TEST=Compile unit_tests_apk target Review URL: https://chromiumcodereview.appspot.com/10819003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150438 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make chrome/browser/chrome_browser_main_linux.* Linux-only. BUG=none TEST=none Review URL: http://codereview.chromium.org/9839028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128650 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Use a different algorithm with the low entropy source for field trials. The new algorithm maps the original 13-bit low entropy source to a new 13-bit entropy value using a mapping that is shuffled using the trial name as a seed. The algorithm is roughly as follows: Take the low entropy source as an integer between 0-8191. Generate an identity mapping of size 8192 where mapping[i] == i. Seed a Mersenne Twister random number generator with the hash of the field trial name. Use the seeded random number generator to shuffle the mapping array. Map the low entropy source using the mapping array, i.e. entropy' = mapping[entropy]. Divide the resulting entropy' by 8192 to produce a double in the range of [0, 1) that will be used for bucketing in field_trial.cc. The above algorithm improves uniformity over the existing entropy provider when the 13-bit entropy source is used while still providing very little overlaps of buckets between different field trials. Adds third_party library mt19937ar, an implementation of Mersenne Twister, for the seeded random number generation. This is needed until C++11 becomes available for use in Chromium, at which point C++11's <random> could be used. BUG=143239 TEST=Unit tests. Additionally, verified that the new algorithm produces uniform results with very little overlap of buckets between different field trials. Review URL: https://chromiumcodereview.appspot.com/10830318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153322 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update Windows System Monitor Removable Device Impl. Change the notifier to notify about all removable devices, to get more device information and to fetch the already connected removable devices. Implement the Windows specific part of MediaStorageUtil Original CL: http://codereview.chromium.org/10911234 BUG=144496 Review URL: https://codereview.chromium.org/10911350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157290 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update Windows System Monitor Removable Device Impl. Change the notifier to notify about all removable devices, to get more device information and to fetch the already connected removable devices. Implement the Windows specific part of MediaStorageUtil Original CL: http://codereview.chromium.org/10911234 BUG=144496 Review URL: https://codereview.chromium.org/10911350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157290 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
x11: Unset the X11 error handlers when the message-loop starts getting destroyed. The X11 error handlers report the errors from a PostTask()ed function, but since the X11 error may have happened when the message-loop was already getting destroyed (e.g. the message-pump destructor), this can cause errors. BUG=146928 Review URL: https://codereview.chromium.org/10933113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157056 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
x11: Unset the X11 error handlers when the message-loop starts getting destroyed. The X11 error handlers report the errors from a PostTask()ed function, but since the X11 error may have happened when the message-loop was already getting destroyed (e.g. the message-pump destructor), this can cause errors. BUG=146928 Review URL: https://codereview.chromium.org/10933113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157056 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add rendering support to the TestShell. - Tie the Compositor into the TestShell. - Tie a really basic Tab into the TestShell. BUG=http://crbug.com/136786 Review URL: https://chromiumcodereview.appspot.com/10968003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158654 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Close leaking FDs. When starting a SandboxedProcess the resource file descriptors were leaked in the browser process, eventually causing crashers. BUG=None TEST=When using the Android content shell for a long time, it should not crash. Review URL: https://chromiumcodereview.appspot.com/10949027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158456 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Second try of 157576 https://chromiumcodereview.appspot.com/10780013/ Add reverse URL handler for shortening uber URLs BUG=120493 TEST=Open the settings page. The address bar should show "chrome://settings". Click the "extensions" button on the left. The address bar should show "chrome://extensions". Click the "settings" button on the left, "show advanced settings", "content settings". The address bar should show "chrome://settings/content". Review URL: https://chromiumcodereview.appspot.com/10941050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158504 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158707 - Enable by default: 1. threaded compositing on windows (except XP) 2. force compositing mode on mac On linux we switch to a 1/3 1/3 fcm and thread experiments . This patch also gives priority to the command line switches so that both threaded and force compositing mode can be turned off via the about:flags page or command line. In the near future, we will use the Finch framework to tweak the experiment percentages. Note: This patch has a dependency on: https://bugs.webkit.org/show_bug.cgi?id=96871 It also disables ExtensionApiTest.CaptureVisibleTabJPeg as it triggers flakiness on it. chrome.tabs.captureVisibleTab is inherently racy as there is no way to guarantee that the tab has been painted at least once when that call is made. Note how the other variants of CaptureVisibleTab tests have already been disabled for similar reasons. BUG=143809,128387,146861 Review URL: https://chromiumcodereview.appspot.com/10914247 Reverted due to failures on Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/29446/steps/interactive_ui_tests/logs/AutoResize http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/2143/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/26358/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/1804/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine TBR=vangelis@chromium.org Review URL: https://codereview.chromium.org/10991032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158711 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add field trial for enabling Stage3D in XP Adds an experiment that we can set to enable Stage3D on XP (where not completely blacklisted). It will be disabled by default. BUG=136447 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157910 Review URL: https://chromiumcodereview.appspot.com/10944037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158078 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create content\public\test\test_utils.h to hold common test classes that are used by unit and browser tests. unit tests shouldn't be including ui_test_utils.h. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10807047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147602 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixes chrome_page_zoom::Zoom(). First, correctly retrieves the default zoom level from the user Profile instead of from RendererPreferences. Second, correctly sets the default zoom level when content::PAGE_ZOOM_RESET is passed as the zoom parameter (previously, it just set the zoom to 100% no matter what the default zoom level was). BUG= TBR=jhawkins Review URL: https://chromiumcodereview.appspot.com/10826136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149964 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable keyboard shortcuts and some menu commands for browserless Panels. Prevent context menu in Panels. BUG=127323 TEST=open panels and try various shortcuts and menu commands Review URL: https://chromiumcodereview.appspot.com/10736037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146580 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move chrome zoom constants into their own file. BUG=107063 TEST=none TBR=jam Review URL: http://codereview.chromium.org/8951008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114611 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Page zoom improvements: 1. Change from using zoom levels to a range of preset zoom factors (percentages). Zoom levels are the values that WebKit uses for page zoom. While zoom levels are simple to implement, they result in undesirable percentages like 57%, 144%, 207%, etc. Changing to zoom factors gives us user-friendly zoom percentages. 2. Increase the range of supported zoom values. A user can now zoom between 25% to 500%. 3. Use an epsilon value when comparing zoom floating point values. The previous version was doing an equality comparison of double values which may not always work as expected. BUG=71484 TEST=Exercise zoom in/out via the wrench menu; exercise default page zoom setting in options window Review URL: http://codereview.chromium.org/8528011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111087 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix installed plugins test to test for Chrome Remote Desktop Viewer even on non-ChromeOS platforms. Review URL: https://chromiumcodereview.appspot.com/10958061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158452 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move chrome/browser/plugin_* to chrome/browser/plugins/ TBR=jhawkins@chromium.org BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10933044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157834 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make quota requests from background pages not crash BUG=149804 Review URL: https://chromiumcodereview.appspot.com/10948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158184 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
RefCounted types should not have public destructors, chrome/browser/ part 6 BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10071036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134218 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Check ChromeToMobileService OriginalURLs before handling. Example one-day UMA shows "Send Success" > "Sending URL" + "Sending Snapshot": https://gfsviewer.corp.google.com/cns/pa-d/home/uma-data/public/dashboards/histograms.html?dayCount=1&endDate=09-21-2012&version=24.0.1273.0-W&group=ChromeToMobile&histogram=Service&otherVersions=10 Perhaps these URLs may be redirected? This CL checks the *original* URLs before handling. This speculative fix should be safe even if it doesn't address the root issue. BUG=102709,120941 TEST=UMA data doesn't report (send success+failure) > (send URL+snapshot). R=nyquist@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10970054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158352 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Log ChromeToMobile search and auth errors to UMA and INFO. Add more UMA and VLOG(0) to OnGetTokenFailure and HandleSearchResponse. (add supporting GoogleServiceAuthError::NUM_STATES enum value) (add supporting CTMService SEARCH_[SUCCESS|ERROR] enum values) (change existing LOG_IF(INFO, ...) to VLOG_IF(0, ...) in HandleSubmitResponse) ChromeToMobile.AuthError UMA histogram added here: https://chromereviews.googleplex.com/4964015 BUG=102709,120941 TEST=Additional UMA and INFO logging of any auth token generation errors. R=joi@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10970055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158345 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-reland Integrate invalidation API into ChromeToMobileService. A continuation of http://codereview.chromium.org/10869002 r152745 reverted 2nd attempt r152735 for Mac clobber build break: /b/build/slave/Mac/build/src/chrome/browser/chrome_to_mobile_service.cc:42:10: fatalerror: 'google/cacheinvalidation/types.pb.h' file not found http://build.chromium.org/p/chromium/builders/Mac/builds/16802/steps/compile/logs/stdio#error1 Add cacheinvalidation[_proto_cpp] dependency to chrome_browser.gypi. This fixes my xcodebuild locally (not repro through ninja, etc.) Remaining description matches that of the second CL: ==================================================== Reland Integrate invalidation API into ChromeToMobileService. A continuation of http://codereview.chromium.org/10834203 r152609 reverted original r152609 for debug test crashes: http://build.chromium.org/p/chromium/builders/Mac%2010.7%20Tests%20%28dbg%29%284%29/builds/100/steps/browser_tests/logs/stdio Move dtor logic to a ProfileKeyedService::Shutdown OVERRIDE. This fixes the problem locally (we have no debug trybots?). Remaining description matches that of the original CL: ====================================================== Integrate invalidation API into ChromeToMobileService. Update chrome/browser/DEPS with new dependencies: (google/cacheinvalidation and sync/notifier) Observe Sync Notifier invalidation notifications: (depend on this service for mobile list updates) (refresh the device list on cloud print invalidation) Remove RequestMobileListUpdate, timestamp, & account info: (no longer needed with invalidation integration) (just set command state and icon visibility w/HasMobiles) Lazily init the access token, queue search/send operations: (only get an access token as needed, add |task_queue_|) Allow concurrent cloud print device search requests: (handle user-triggered updates while fetching the list) Misc cleanup (CloudPrintUrl handling, tests, etc.) TODO(followup): Additional logging, tests, invalidation ack. BUG=102709,137086,133352 TEST=Chrome To Mobile devices update with cloud print! TBR=sky@chromium.org,erg@chromium.org,sail@chromium.org,akalin@chromium.org,thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/10876009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152801 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-reland Integrate invalidation API into ChromeToMobileService. A continuation of http://codereview.chromium.org/10869002 r152745 reverted 2nd attempt r152735 for Mac clobber build break: /b/build/slave/Mac/build/src/chrome/browser/chrome_to_mobile_service.cc:42:10: fatalerror: 'google/cacheinvalidation/types.pb.h' file not found http://build.chromium.org/p/chromium/builders/Mac/builds/16802/steps/compile/logs/stdio#error1 Add cacheinvalidation[_proto_cpp] dependency to chrome_browser.gypi. This fixes my xcodebuild locally (not repro through ninja, etc.) Remaining description matches that of the second CL: ==================================================== Reland Integrate invalidation API into ChromeToMobileService. A continuation of http://codereview.chromium.org/10834203 r152609 reverted original r152609 for debug test crashes: http://build.chromium.org/p/chromium/builders/Mac%2010.7%20Tests%20%28dbg%29%284%29/builds/100/steps/browser_tests/logs/stdio Move dtor logic to a ProfileKeyedService::Shutdown OVERRIDE. This fixes the problem locally (we have no debug trybots?). Remaining description matches that of the original CL: ====================================================== Integrate invalidation API into ChromeToMobileService. Update chrome/browser/DEPS with new dependencies: (google/cacheinvalidation and sync/notifier) Observe Sync Notifier invalidation notifications: (depend on this service for mobile list updates) (refresh the device list on cloud print invalidation) Remove RequestMobileListUpdate, timestamp, & account info: (no longer needed with invalidation integration) (just set command state and icon visibility w/HasMobiles) Lazily init the access token, queue search/send operations: (only get an access token as needed, add |task_queue_|) Allow concurrent cloud print device search requests: (handle user-triggered updates while fetching the list) Misc cleanup (CloudPrintUrl handling, tests, etc.) TODO(followup): Additional logging, tests, invalidation ack. BUG=102709,137086,133352 TEST=Chrome To Mobile devices update with cloud print! TBR=sky@chromium.org,erg@chromium.org,sail@chromium.org,akalin@chromium.org,thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/10876009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152801 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome/browser/ui: Put browser_dialogs.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10703061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145141 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moves command handling from Browser to a new object, BrowserCommandController. Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moves command handling from Browser to a new object, BrowserCommandController. Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Quota info and Flash LSO cookie tree nodes can't be storage protected. BUG=none TEST=no crash when opening "All cookies and site data" in a debug build TBR=thakis@chromium.org - we should move those files to browsing_data/ Review URL: https://chromiumcodereview.appspot.com/10823225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150534 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Show Flash LSOs for Pepper Flash in cookie dialog. It won't show anything until the Flash side has been updated. BUG=132409 Review URL: https://chromiumcodereview.appspot.com/10790150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149439 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Show Flash LSOs for Pepper Flash in cookie dialog. It won't show anything until the Flash side has been updated. BUG=132409 Review URL: https://chromiumcodereview.appspot.com/10790150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149439 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix breakpad compilation on Android. base::FileDescriptorGetInode expects a pointer of type ino_t Review URL: https://chromiumcodereview.appspot.com/10920060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154799 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Breakpad support for ASan: take 2. This is an updated version of https://chromiumcodereview.appspot.com/10703116/ which got reverted. When the code is built with ASan, Chrome should register a callback which notifies the browser about a memory error. The error report message is passed to the crash handler and is then sent to the crash server along with the minidump. BUG=143657 Review URL: https://chromiumcodereview.appspot.com/10860006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152989 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename back _linuxish to linux. _linuxish is ambiguous. Use 'target_conditions' to include the required files that are for linux on Android. (TBR because the changes in chrome/browser/ui/gtk and content/app/android are all simple changes of #include file names) BUG=none TEST=Build successfully TBR=erg@chromium.org,jrg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10532178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144176 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
disable CrashRecoveryBrowserTest.LoadInNewTab on linux BUG=144278 Review URL: https://chromiumcodereview.appspot.com/10871023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152822 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing "error C2039: 'back_inserter' : is not a member of 'std'" on Windows Review URL: http://codereview.chromium.org/9717039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127427 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement CrashUploadListWin to enable chrome://crashes on Windows. Added new class CrashUploadListWin, subclass of CrashUploadList which has the Windows platform-specific logic to read crash logs from Windows Event Log. Added static CrashUploadList::Create() factory method which returns an instance of CrashUploadListWin on Windows and an instance of CrashUploadList on other platforms. Also implemented the max_count parameter in CrashUploadList::GetUploadedCrashes(), which was part of the interface but was ignored by the code. BUG=73468 TEST=Open chrome://crashes under Windows after one or more crash reports were uploaded. See the crash reports listed. Review URL: http://codereview.chromium.org/6771021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80165 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Removing usage of profile_->GetHistory() from the codebase in order to remove that function. This was previously reverted, found not to be the cause of the issue, now I am reinstating the changes. BUG=97804 TEST=existing unittests TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10782004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147112 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Chrome OS should open to empty desktop when session restore is empty. Also remove code that opened empty browser behind getting started guide for new users. BUG=141718,148675 Review URL: https://chromiumcodereview.appspot.com/10911222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156517 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Chrome OS should open to empty desktop when session restore is empty. Also remove code that opened empty browser behind getting started guide for new users. BUG=141718,148675 Review URL: https://chromiumcodereview.appspot.com/10911222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156517 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move GenericHandler back to Chrome since it was really Chrome specific (i.e. chrome's mapping of click to disposition). BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9481008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123801 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add navigator.doNotTrack property It'll be "1" iff the respective setting is enabled, and null otherwise BUG=151610 TEST=DoNotTrackTest.DOMProperty Review URL: https://codereview.chromium.org/10960042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158089 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Integrate about:conflicts with --diagnostics This should enable the user to find conflicting dlls that are crashing Chrome on startup. This changelist introduces a limited_mode for scanning, since the diagnostics tests run without the help of many Chrome services, so we can't use the File thread for asynchronous scanning or the notification system. Also changed the scanning so that if no signature/description is given in the blacklist, then we mark the DLL as a confirmed match if the name and the location match (before we used to match it as a 'suspected' match). A very sizable chunk of the blacklist is malware, which has no signature, so this gives us the ability to trigger the wrench badge on finding malware (that part remains opt-in through about:flags). Also added failure count to diagnostics output (sometimes the error scrolls off screen, so having a note at the bottom helps). BUG=51105 TEST=All diagnostics tests run as part of the unit tests. Review URL: http://codereview.chromium.org/6098004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70600 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-enable most of the tests disabled for bug 136310, the underlying WebKit bug has now been fixed. MultipartResponseTest.SingleVisit is still disabled, since it's still failing for some reason. BUG=136310 Review URL: https://chromiumcodereview.appspot.com/10911187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155852 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace views::MouseEvent with ui::MouseEvent http://crbug/com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move TitleWatcher from ui_test_utils.h to browser_test_utils.h so it can be reused by content_browsertests. BUG=90448 TBR=scottmg Review URL: https://chromiumcodereview.appspot.com/10815025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147618 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
tes git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153748 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming SelectFileDialog for Android Upstreaming the Select File Dialog and its dependencies needed for Chrome on Android BUG=116131 Review URL: https://chromiumcodereview.appspot.com/10916160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157424 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[cros] disable GDrive option on certain file pickers This disables the GDrive folder for features that don't support reading/writing gdata. See bug for complete list. BUG=149184 TEST=manual (all pickers listed on bug under "doesn't work", no longer shows gdrive, others still do) Review URL: https://chromiumcodereview.appspot.com/10908262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157012 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Modified the pepper file chooser API to support filtering files by extensions. Previously you could filter only by MIME type. This adds support for filtering by specific extensions as well, e.g. .txt,.html. This change is aligned with the web platform which now allows filtering by file extension for <input> elements (http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#attr-input-accept). This also changes the linux implementation of the file dialog (SelectFileDialogImplGTK). In the past, it would turn file extensions to filter into MIME types. However this is a bit silly because in FileSelectHelper we do the reverse (turn MIME types into a list of file extensions to filter by). It also prevents us from filtering by a specific extensions when this is really what is desired. BUG=129251 TEST= Review URL: https://chromiumcodereview.appspot.com/10414085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139434 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename GetRootWindow() -> GetPrimaryRootWindow() BUG=123160 TEST=none Review URL: https://chromiumcodereview.appspot.com/10442017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138950 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Recommitting Aura/ash split: Remove hacks and get chrome linking without ash. This changes TestViewsDelegate::CreateNativeWidgetHelper to always return NULL, and for views_examples_exe to use its own subclass that create the desktop implementation. For the first time now, you can do: > build/gyp_chromium -Duse_aura=1 -Duse_ash=0 And get a running chrome. It has lots of issues, especially related to window placement, tab handling, etc, but it pops up and renders web content. Also consolidates most of the desktop behavior into its own class. Also makes views_examples_exe work again. Several of the hacks are no longer needed after Ben's refactoring to support WebView. BUG=116458,119759 TEST=none First Review URL: http://codereview.chromium.org/10081022 Review URL: http://codereview.chromium.org/10083058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133105 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Aura desktop: Fix tab dragging within a single chrome window. Tabs can now be reordered inside a single chrome window on linux_aura. Multiselection works too. Dragging out of a window doesn't work yet. Most of dock_info_aura.cc has been copied from dock_info_gtk.cc. A helper function was moved from gtk_util to x11_util (which only used pure X functions.) BUG=133059 TEST=none Review URL: https://chromiumcodereview.appspot.com/10560014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142568 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Do not show notifications when in fullscreen or screensaver mode. I add full-screen/presentation mode detection for all 3 platforms. I also add screensaver detection for MacOSX and Linux since it is missing in these 2 platforms. BUG=25061 TEST=Manual test Review URL: http://codereview.chromium.org/6359008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72539 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Use base::win::GetVersion for Windows run-time version checks in preference to base::SysInfo::OperatingSystemVersionNumbers. The latter is just a harder-to-use wrapper around the former. BUG=86062 TEST=none Review URL: http://codereview.chromium.org/7150018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89055 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cocoa: Fix avatar menu shortcut If focus was in the Omnibox then pressing Command-M would incorrectly trigger the avatar menu. The problem was due to the fact that when MatchesEventForKeyboardShortcut() matches against a key character it ignores the shift flag. Fix was to use a key code for the shortcut so that the shift flag was correctly checked. BUG=104457 TEST=Verified that Command-Shift-M correctly showed the avatar menu while focused on a web page and while focused on the location bar. Verified that Command-M correctly minimized the window while focused on a web page and focused on the location bar. Review URL: http://codereview.chromium.org/8718002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111708 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Allow keypad 1..9 keys to be used as shortcuts to switch tabs. BUG=63143 TEST=as in bug; also verify that it doesn't regress the feature with Italian keyboard layout which has numbers requiring shift Review URL: http://codereview.chromium.org/5072003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66452 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Make GpuDataManager thread safe. Instead of forcing it on UI thread only, this CL makes it thread safe. We already put a locker around gpu_info, this CL puts another locker around log_messages, and the updater_list is thread safe. Therefore, the whole class now is thread safe. Also, I did a little bit clean up, 1) remove two dead function declarations; 2) rename Features to BlacklistedFeatures, because the old naming is confusing and multiple people complained to me already. 3) Expose AddLogMessage() so it can also be called on browser thread, which is the original motivation for me to do this refactoring. I am working on a unit test for GpuDataManager, but will upload it as a separate CL. This CL does not change behavior at all. BUG= TEST=tree Review URL: https://chromiumcodereview.appspot.com/10891013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154275 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add GPU memory tab to the task manager. Each renderer process will have all of the resources that the GPU process has allocated on its behalf (including WebGL resources, compositor resources, and the backbuffer) included in its printed total. The GPU process will have the all resources currently allocated by the GPU process in its column. This will be approximately the sum of all other rows. The row for the GPU process is printed in ()s to draw attention to the fact that its size includes duplicates from other processes' sizes. I happy this UI scheme (having played with a few), but I'd wider feedback. Note that we do not account for swapchains or for backbuffers allocated by the browser process, so those allocations are not counted in the total. BUG=140157 Review URL: https://chromiumcodereview.appspot.com/10854076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152233 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added support for Hidpi in download UI BUG=136949 TEST=Manual, see instructions below Run chrome with --force-device-scale-factor=2 --highlight-missing-2x-resources Ensure that the file type icon in the download bar shows up red Review URL: https://chromiumcodereview.appspot.com/10703173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148334 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added support for Hidpi in download UI BUG=136949 TEST=Manual, see instructions below Run chrome with --force-device-scale-factor=2 --highlight-missing-2x-resources Ensure that the file type icon in the download bar shows up red Review URL: https://chromiumcodereview.appspot.com/10703173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148334 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement minimal IconManager and IconLoader for Android. Another step towards linking sync_unit_tests BUG=113487 TEST= Review URL: http://codereview.chromium.org/9363058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122040 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move shared file type images into chrome://theme/ scheme These images are used by WebUI code (which uses 2x/ subdirectories for hi-dpi) and by C++ code (which uses the default_###_percent scheme). Move them to chrome/app/theme so that scaling will work in C++ code. drive.png was unmentioned in the grd file. I added IDR_FILE_MANAGER_IMG_FILETYPE_DRIVE. Some uses of the images in CSS/JS use only the 1x versions. I left these as-is. BUG=138965 TEST=Look at file manager and chrome://downloads in Linux chromeos build with --force-device-scale-factor=[12] Review URL: https://chromiumcodereview.appspot.com/10916305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157013 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Load 2x resources on demand Currently, this always load 1x. This will be fixed in follow up CL to use currently used scale factor. * Added thread check to ImageSkiaStorage using NonThreadSafe. This is important as GetRepresentation may change the stage now even for the Image obtained from ResourceBundle. * Added SetReadOnly to protect read only resources (ones in ResourceBundle) from being modified by accident. * Addded MakeThreadSafe to guarantee that it can be safely accessed from multiple threads. BUG=141351,144367 TEST=covered by tests. Also run with --force-device-scale-factor=2 and --load-2x-resources and make sure chrome still uses 2x resources where available. Review URL: https://chromiumcodereview.appspot.com/10820049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153846 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Load 2x resources on demand Currently, this always load 1x. This will be fixed in follow up CL to use currently used scale factor. * Added thread check to ImageSkiaStorage using NonThreadSafe. This is important as GetRepresentation may change the stage now even for the Image obtained from ResourceBundle. * Added SetReadOnly to protect read only resources (ones in ResourceBundle) from being modified by accident. * Addded MakeThreadSafe to guarantee that it can be safely accessed from multiple threads. BUG=141351,144367 TEST=covered by tests. Also run with --force-device-scale-factor=2 and --load-2x-resources and make sure chrome still uses 2x resources where available. Review URL: https://chromiumcodereview.appspot.com/10820049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153846 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
In icon_loader_win.cc, if CreateSkBitmapFromHICON fails, don't pass NULL to gfx::Image and crash. BUG=92982 TEST=none Review URL: https://chromiumcodereview.appspot.com/7753009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155434 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add interface to CancelableRequest that allows use of base::Callback<>. BUG=none TEST=none Review URL: http://codereview.chromium.org/8068013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103691 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement minimal IconManager and IconLoader for Android. Another step towards linking sync_unit_tests BUG=113487 TEST= Review URL: http://codereview.chromium.org/9363058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122040 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Consolidate icon loading on ChromeOS. BUG=110919, 109677 TEST=unit_tests --gtest_filter=FileIconSourceTest.* && browser_tests --gtest_filter=DownloadExtensionTest.DownloadsApi_FileIcon_* Review URL: http://codereview.chromium.org/9167019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119935 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Linux: Move base/mime_util* to base/nix. It's not used on any other platform. BUG=none TEST=none Review URL: http://codereview.chromium.org/8538008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109685 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add file icons to chrome://downloads/ on the Mac. Add Skia helper CGImageToSkBitmap(). Patch by Robert Sesek <rsesek@bluestatic.org> Review URL: http://codereview.chromium.org/118488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18517 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Stub implementation of linux, mac icon loader/manager. Define a platform specific type IconGroupID which helps with caching multiple requests for the same icon. Previously we just used the file path (or the extension), but on POSIX we use mime types rather than extensions. Review URL: http://codereview.chromium.org/113120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15665 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add minimal CalculateIdleState implementation for Android. It currently just reports that we're active on Android. Further revisions could check device state to see if we're active but on memory constrained devices such as Android we'll often get completely killed if Chrome isn't active. This is a minimal step towards linking Chrome on Android. BUG=113487 TEST= Review URL: http://codereview.chromium.org/9347052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122184 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move files inside chrome/browser/chromeos/dbus to chromeos/dbus Move files in chrome/browser/chromeos/dbus/ to chromeos/dbus Add chromeos/dbus/DEPS Add chromeos.gyp:chromeos_test_support and chromeos.gyp:chromeos_unittests Add CHROMEOS_EXPORT to classes Move power related proto targets to chromeos.gyp Rewrite and sort #includes BUG=119583 TEST=component chromeos build success, checkdeps success Review URL: https://chromiumcodereview.appspot.com/9838085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131065 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
browser: Move more files into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10694060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145220 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove -F$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework/Frameworks It wasn't ever correct to compile or link with this, and it just encourages people to do stupid things that aren't guaranteed to work at runtime in future OS releases or with future SDKs. Just #include <ApplicationServices/ApplicationServices.h> or link against ApplicationServices.framework by adding $(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework to your 'link_settings': {'libraries': []} section. The WebKit portion was fixed at https://bugs.webkit.org/show_bug.cgi?id=88569 . Review URL: https://chromiumcodereview.appspot.com/10535059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142137 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Move more files into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10694060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145220 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing the bug, that caused UI to hang after unsupported device was inserted. In the idle.h new synchronous method was added - IsWorkstationInLockedState. BUG=chromium-os:20261 TEST=None Review URL: http://codereview.chromium.org/7864022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100582 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Force avatar and wallpaper decoding to use robust JPEG. The next step in an upcoming CL will bind this separate path to a different JPEG library (at a minimum on CrOS). BUG=144296 Review URL: https://chromiumcodereview.appspot.com/10892023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154001 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Force avatar and wallpaper decoding to use robust JPEG. The next step in an upcoming CL will bind this separate path to a different JPEG library (at a minimum on CrOS). BUG=144296 Review URL: https://chromiumcodereview.appspot.com/10892023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154001 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Move more files into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10694060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145220 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Move more files into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10694060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145220 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move files related to registry-controlled domains into a new net/base/registry_controlled_domains/ subdirectory. This includes net/base/registry_controlled_domain.* and net/base/effective_tld_names* BUG=138047 TEST=covered by existing tests Review URL: https://chromiumcodereview.appspot.com/10796033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix bug in setting IOThread::Globals Thanks to mmoss for the catch and willchan for the debug. Review URL: https://chromiumcodereview.appspot.com/10905299 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157038 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove static variables from HttpStreamFactory. Refresh of issue 10389162. BUG=124900 Review URL: https://chromiumcodereview.appspot.com/10834215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155485 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove gtk_util.h from jankometer.cc R=erg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10539083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141560 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use ChromeBrowserMainPartsAndroid. Includes several changes: 1) Stubs out jankometer 2) Makes some background-related profile code guarded by ENABLE_BACKGROUND 3) Remove SingletonProcess because it's guaranteed by the OS. 4) If-def out first-run code and process startup code as it's necessary handled in the Java layer on Android. In order to improve startup performance, Chrome for Android runs startup code in the java layer asynchronously with loading the native shared library. Re-using this code would result in us blocking until the entire library is loaded into memory. 5) Removes UMA code. UMA sessions are handled differently on Android as the browser isn't ever killed and is instead paused/resumed. 6) Also removes things like ManagedMode/PageCycler which are unused on Android. BUG=138184 Review URL: https://chromiumcodereview.appspot.com/10885023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154029 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the temporary scaffolding stubs. They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Review URL: http://codereview.chromium.org/593037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Introduce structures to reduce the number of arguments in the FaviconService methods. Issue 10870022 introduced new arguments for the FaviconService methods, some of them now having more than 6 arguments. These methods cannot be called using the base::Bind mechanism because of template limitations. This patch introduces auxiliar structures to reduce the number of arguments in these methods and therefore allow using base::Bind on them. BUG=146003 Review URL: https://chromiumcodereview.appspot.com/10918065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155113 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix file permissions of language_usage_metrics.{cc,h} TEST=none BUG=none Review URL: http://codereview.chromium.org/7472030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93366 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Record language usage as UMA histograms. Record accept languages and application language as UMA histograms on browser start-up. See also http://crosbug.com/17419 BUG=none TEST=run the unit tests Review URL: http://codereview.chromium.org/7348004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93360 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove unused fields found by clang's new Wunused-private-fields. Test file edition. BUG=none TEST=none TBR=remaining owners Review URL: https://chromiumcodereview.appspot.com/10680013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144464 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10822030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148514 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add ManagedModeURLFilter. ManagedModeURLFilter will eventually allow special treatment (e.g. blocking, notifying) for URLs that aren't on a defined whitelist. BUG=134417 Review URL: https://chromiumcodereview.appspot.com/10824257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151993 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add ManagedModeURLFilter. ManagedModeURLFilter will eventually allow special treatment (e.g. blocking, notifying) for URLs that aren't on a defined whitelist. BUG=134417 Review URL: https://chromiumcodereview.appspot.com/10824257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151993 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate Browser Creation. . Make all instantiators use a single ctor that takes CreateParams. . Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10692195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable uses of URLBlacklist on platforms that don't support it. This was causing linking issues on the Linux Redux bot. Review URL: https://chromiumcodereview.appspot.com/10827411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152396 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add ManagedModeURLFilter. ManagedModeURLFilter will eventually allow special treatment (e.g. blocking, notifying) for URLs that aren't on a defined whitelist. BUG=134417 Review URL: https://chromiumcodereview.appspot.com/10824257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151993 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add ManagedModeURLFilter. ManagedModeURLFilter will eventually allow special treatment (e.g. blocking, notifying) for URLs that aren't on a defined whitelist. BUG=134417 Review URL: https://chromiumcodereview.appspot.com/10824257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151993 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correctly determine extension renderer type on chrome://memory page. Previously "continue" statement left renderer_type undefined. BUG= 140305 TEST= open chrome://memory page if NaCl extension is opened. Review URL: https://chromiumcodereview.appspot.com/10836313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152160 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Log per-process memory use on low memory events We're seeing a lot of tab reloads caused by the tab discarder, but we're not sure yet where the memory is going. Dump the per-process private and shared memory use (same as the Task Manager columns) for Chrome processes when we hit low memory, such that we can see it in the system logs when users send us a feedback report. This adds tens of milliseconds to the delay between the low memory signal and the tab discard starting, but that isn't significant as we allow 750 ms for the discard to happen and the memory stats are collected asynchronously off of the UI thread. Also refactor when we log UMA memory statistics - we used to do it every time we collected memory details, but with this change we need to be able to collect the details and skip additional UMA stats. BUG=124038 TEST=browser_tests OomPriorityManagerTest, manual inspection of logs after triggering tab discard with about:discards Review URL: http://codereview.chromium.org/10151005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133232 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix build error with gcc-4.7 BUG=120724 TEST=none Review URL: https://chromiumcodereview.appspot.com/10553031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142750 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Log per-process memory use on low memory events We're seeing a lot of tab reloads caused by the tab discarder, but we're not sure yet where the memory is going. Dump the per-process private and shared memory use (same as the Task Manager columns) for Chrome processes when we hit low memory, such that we can see it in the system logs when users send us a feedback report. This adds tens of milliseconds to the delay between the low memory signal and the tab discard starting, but that isn't significant as we allow 750 ms for the discard to happen and the memory stats are collected asynchronously off of the UI thread. Also refactor when we log UMA memory statistics - we used to do it every time we collected memory details, but with this change we need to be able to collect the details and skip additional UMA stats. BUG=124038 TEST=browser_tests OomPriorityManagerTest, manual inspection of logs after triggering tab discard with about:discards Review URL: http://codereview.chromium.org/10151005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133232 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Log per-process memory use on low memory events We're seeing a lot of tab reloads caused by the tab discarder, but we're not sure yet where the memory is going. Dump the per-process private and shared memory use (same as the Task Manager columns) for Chrome processes when we hit low memory, such that we can see it in the system logs when users send us a feedback report. This adds tens of milliseconds to the delay between the low memory signal and the tab discard starting, but that isn't significant as we allow 750 ms for the discard to happen and the memory stats are collected asynchronously off of the UI thread. Also refactor when we log UMA memory statistics - we used to do it every time we collected memory details, but with this change we need to be able to collect the details and skip additional UMA stats. BUG=124038 TEST=browser_tests OomPriorityManagerTest, manual inspection of logs after triggering tab discard with about:discards Review URL: http://codereview.chromium.org/10151005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133232 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Removing usage of profile_->GetHistory() from the codebase in order to remove that function. This was previously reverted, found not to be the cause of the issue, now I am reinstating the changes. BUG=97804 TEST=existing unittests TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10782004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147112 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the save_package_browsertest.cc to content_browsertests. Also move mouseleave_browsertest.cc to src\chrome. This is an interactive_ui_tests, and while we can theoretically create another content_browsertest target for interactive tests, it seems pointless for just one test. So run it as part of chrome. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10821089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148970 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Converted the rest of chrome except for extensions and favicons to user ImageSkia Used same conversion script as 10437006 Modified the following files afterwards: 1 chrome/browser/background/background_application_list_model.cc 2 chrome/browser/extensions/extension_install_ui.cc 3 chrome/browser/extensions/extension_install_ui.h 4 chrome/browser/speech/speech_recognition_bubble.cc 5 chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc 6 chrome/browser/speech/speech_recognition_bubble_gtk.cc 7 chrome/browser/speech/speech_recognition_tray_icon_controller.h 8 chrome/browser/task_manager/task_manager_resource_providers.cc 9 chrome/browser/ui/panels/panel_browser_frame_view.cc 10 chrome/browser/ui/search_engines/template_url_table_model.cc 11 chrome/browser/ui/search_engines/template_url_table_model.h 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/avatar_menu_button.cc 14 chrome/browser/ui/views/detachable_toolbar_view.cc 15 chrome/browser/ui/views/download/download_item_view.cc 16 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc 17 chrome/browser/ui/views/location_bar/icon_label_bubble_view.h 18 chrome/browser/ui/views/location_bar/location_bar_view.cc 19 chrome/browser/ui/views/tab_icon_view.cc 20 chrome/browser/ui/views/tab_icon_view.h 21 chrome/browser/ui/views/tabs/tab_strip.cc Include, whitespace changes in 1 chrome/browser/automation/automation_provider_observers.cc 2 chrome/browser/background/background_application_list_model.h 3 chrome/browser/background/background_mode_manager.cc 4 chrome/browser/custom_home_pages_table_model.h 5 chrome/browser/download/download_util.cc 6 chrome/browser/extensions/extension_function_dispatcher.cc 7 chrome/browser/extensions/extension_install_dialog.cc 8 chrome/browser/extensions/extension_install_dialog.h 9 chrome/browser/ntp_background_util.cc 10 chrome/browser/speech/speech_recognition_bubble.h 11 chrome/browser/task_manager/task_manager.h 12 chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc 13 chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc 14 chrome/browser/ui/cocoa/task_manager_mac.h 15 chrome/browser/ui/views/about_chrome_view.cc 16 chrome/browser/ui/views/avatar_menu_bubble_view.cc 17 chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc 18 chrome/browser/ui/views/download/download_item_view.h 19 chrome/browser/ui/views/find_bar_view.cc 20 chrome/browser/ui/views/infobars/extension_infobar.cc 21 chrome/browser/ui/views/notifications/balloon_view.cc 22 chrome/browser/ui/views/page_info_bubble_view.cc 23 chrome/browser/ui/views/tabs/base_tab.cc 24 chrome/browser/ui/views/tabs/tab.cc 25 chrome/browser/ui/views/toolbar_view.cc Review URL: https://chromiumcodereview.appspot.com/10453101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140628 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch OmniboxSearchHint to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10951008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157392 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch OmniboxSearchHint to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10951008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157392 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
net: disable SSL compression This change also updates the page-info dialog to assume that compression isn't used. It doesn't, however, remove the message from the .grd file in order to make this change easier to merge. BUG=139744 Review URL: https://chromiumcodereview.appspot.com/10823111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149672 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch PepperBrokerObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158887 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch PepperBrokerObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158887 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move chrome/browser/plugin_* to chrome/browser/plugins/ TBR=jhawkins@chromium.org BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10933044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157834 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add GetSitesWithData and FreeSiteList methods to PPP_Flash_BrowserOperations interface and hook them up in PepperFlashSettingsManager. BUG=132409 TEST=none Review URL: https://chromiumcodereview.appspot.com/10825018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148839 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Put simple_message_box.h and chrome_web_contents_view_delegate.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145421 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstreaming SelectFileDialog for Android Upstreaming the Select File Dialog and its dependencies needed for Chrome on Android BUG=116131 Review URL: https://chromiumcodereview.appspot.com/10916160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157424 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Work on USE_ASH/USE_AURA split. This reduced link errors in the chrome binary down to roughly ten. - Supplies an X11 implementation of parts of gfx::Screen. - Multiple files renamed from _aura.cc to _ash.cc or placed outside of ash only directories. - Some random usage #ifdefed properly. BUG=116458 TEST=Everything still compiles in all different configurations. Review URL: http://codereview.chromium.org/10020048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131900 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make chrome::Navigate take in a Browser* that is never NULL. That function doesn't have a context, so it could never figure out which desktop it should open new windows in. Instead, push this out to callers that have more context. BUG=129187 Review URL: https://chromiumcodereview.appspot.com/10696222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146681 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Abstract message box dialog functions into its own header file. BUG=None TEST=None R=evan@chromium.org Review URL: http://codereview.chromium.org/7601014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96071 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Cleanup: Remove base::environment_vector and base::file_handle_mapping_vector to StudlyCaps. BUG=none TEST=none Review URL: http://codereview.chromium.org/9429039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123438 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Mac: Prevent NTP mousewheel events from being suppressed on Lion. On Lion, when the "two-finger page swipe" system preference is enabled, horizontal scrolling should never trigger NTP page flipping -- it should always mean back/forward navigation. https://chromiumcodereview.appspot.com/9296040/ implemented this by suppressing mousewheel events on the NTP. However, this prevents containers with vertical scrollbars (e.g. the Other Devices menu) from being scrolling. This fix reverts most of that change, and instead places the logic in the NTP. BUG=120191 TEST=Manual. On a non-Lion machine, scrolling left and right should always flip between NTP pages. On Lion, when the pref is turned on, it should trigger back and forward navigation. Turn the pref off, reload the NTP, and ensure that scrolling flips between pages again. In all cases, vertical scrolling on the NTP should still work (shrink the window vertically and the NTP will get a vertical scroll bar). Review URL: https://chromiumcodereview.appspot.com/10092017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133020 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change over IgnoreReturn to IgnoreResult. remove IgnoreReturn. BUG=98919 TEST=existing Review URL: http://codereview.chromium.org/9111032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116631 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Switch BlockedContentTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10938033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Dynamic policy refresh support for the Mac. Adapt the file watching code we already had for ConfigDirPolicyProvider to support a loader delegate, make the old code use it and change the Mac policy provider to watch for changes to the plist file in /Library/Managed Preferences/<username>. BUG=52040 TEST=unit tests Review URL: http://codereview.chromium.org/4062002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64415 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Dynamic policy refresh support for the Mac. Adapt the file watching code we already had for ConfigDirPolicyProvider to support a loader delegate, make the old code use it and change the Mac policy provider to watch for changes to the plist file in /Library/Managed Preferences/<username>. BUG=52040 TEST=unit tests Review URL: http://codereview.chromium.org/4062002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64415 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Clean-up inline members of nested classes (chrome/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10855075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Clean-up inline members of nested classes (chrome/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10855075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Remove base::environment_vector and base::file_handle_mapping_vector to StudlyCaps. BUG=none TEST=none Review URL: http://codereview.chromium.org/9429039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123438 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Refactor ProcessSingleton so that it may be used distinctly from a full browser process. The main effect is that ProcessSingleton is much more restricted to its basic functionality, which is to ensure that a single instance of Chrome runs per profile directory and to pass messages from new Chrome invocations to the existing instance. Exactly how those messages were handled has been moved from the implementations of ProcessSingleton into ChromeBrowserMain where (I think) it more rightly belongs. This will allow the Chrome Frame net tests to use ProcessSingleton to implement a stub Chrome for the purpose of handling network-related IPC from Chrome Frame without having to launch the rest of Chrome, upon which ProcessSingleton previously depended directly. BUG=None TEST=None Review URL: http://codereview.chromium.org/9968053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130853 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Implement lock file for windows profiles. BUG=120389 TEST=Start chrome from two PCs at the same time with shared profile and observe the second instance not starting at all. Review URL: https://chromiumcodereview.appspot.com/10702159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147121 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to TimeDelta interfaces of TestTimeouts in chrome and ui code reviewable by ben. R=ben@chromium.org BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10704115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145729 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove message_loop_helpers.h and update the includes to point to the new location. Note: This was a TODO for akalin@. This patch was generated by: $ find . -name '*.h' -o -name '*.cc' -o -name '*.mm' | xargs sed -i -e "s/base\/message_loop_helpers.h/base\/sequenced_task_runner_helpers.h/g" R=akalin@chromium.org TBR=willchan@chromium.org,ben@chromium.org,jam@chromium.org,tony@chromium.org Review URL: https://chromiumcodereview.appspot.com/10578026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143174 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to TimeDelta interfaces of TestTimeouts in chrome and ui code reviewable by ben. R=ben@chromium.org BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10704115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145729 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor ProcessSingleton so that it may be used distinctly from a full browser process. The main effect is that ProcessSingleton is much more restricted to its basic functionality, which is to ensure that a single instance of Chrome runs per profile directory and to pass messages from new Chrome invocations to the existing instance. Exactly how those messages were handled has been moved from the implementations of ProcessSingleton into ChromeBrowserMain where (I think) it more rightly belongs. This will allow the Chrome Frame net tests to use ProcessSingleton to implement a stub Chrome for the purpose of handling network-related IPC from Chrome Frame without having to launch the rest of Chrome, upon which ProcessSingleton previously depended directly. BUG=None TEST=None Review URL: http://codereview.chromium.org/9968053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130853 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Refactor ProcessSingleton so that it may be used distinctly from a full browser process. The main effect is that ProcessSingleton is much more restricted to its basic functionality, which is to ensure that a single instance of Chrome runs per profile directory and to pass messages from new Chrome invocations to the existing instance. Exactly how those messages were handled has been moved from the implementations of ProcessSingleton into ChromeBrowserMain where (I think) it more rightly belongs. This will allow the Chrome Frame net tests to use ProcessSingleton to implement a stub Chrome for the purpose of handling network-related IPC from Chrome Frame without having to launch the rest of Chrome, upon which ProcessSingleton previously depended directly. BUG=None TEST=None Review URL: http://codereview.chromium.org/9968053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130853 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Enable EULA dialog to be shown from metro Chrome. BUG=131033 TEST=Run Chrome in Metro mode while the EULA dialog still needs to be accepted. Get kicked back to the desktop to accept the dialog. On accept, get kicked back into metro mode. Review URL: https://chromiumcodereview.appspot.com/10837222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158797 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move WaitForLoadStop from ui_test_utils to browser_test_utils so that it can be reused in content_browsertests. BUG=90448 TBR=viettrungluu Review URL: https://chromiumcodereview.appspot.com/10823029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148463 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add navigator.doNotTrack property It'll be "1" iff the respective setting is enabled, and null otherwise BUG=151610 TEST=DoNotTrackTest.DOMProperty Review URL: https://codereview.chromium.org/10960042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158089 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create content\public\test\test_utils.h to hold common test classes that are used by unit and browser tests. unit tests shouldn't be including ui_test_utils.h. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10807047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147602 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove TOOLKIT_USES_GTK and consolidate it into TOOLKIT_GTK Add gtk dependency to base.gyp for android host_os="linux" case BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9969080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130784 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Aura desktop: Fix tab dragging within a single chrome window. Tabs can now be reordered inside a single chrome window on linux_aura. Multiselection works too. Dragging out of a window doesn't work yet. Most of dock_info_aura.cc has been copied from dock_info_gtk.cc. A helper function was moved from gtk_util to x11_util (which only used pure X functions.) BUG=133059 TEST=none Review URL: https://chromiumcodereview.appspot.com/10560014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142568 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix registerProtocolHandler OS registration on Windows 8 On Windows 8 to register as the default handler for a protocol you need to go through a Windows shell UI flow, it cannot be done anymore via the IApplicationAssociationRegistration interface. BUG=150850 TEST=Ensure gmail and other protocol handlers can be registered successfully on Windows 7 and 8. Review URL: https://chromiumcodereview.appspot.com/10963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158612 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix registerProtocolHandler OS registration on Windows 8 On Windows 8 to register as the default handler for a protocol you need to go through a Windows shell UI flow, it cannot be done anymore via the IApplicationAssociationRegistration interface. BUG=150850 TEST=Ensure gmail and other protocol handlers can be registered successfully on Windows 7 and 8. Review URL: https://chromiumcodereview.appspot.com/10963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158612 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
The CL adds to ShellUtil and ShellIntegration and adjusts invocations of the latter whenever necessary. R=grt@chromium.org, sky@chromium.org BUG=113326, 129232 TEST=N/A Review URL: https://chromiumcodereview.appspot.com/10453041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141172 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Packaged apps are now enabled by default (and arguments on launcher shortcuts are unlikely to function when chrome is already running), so this extra argument on shortcuts can be dropped. BUG=146037 TEST=ensure shortcuts for packaged apps are still created (e.g. on desktop), and can execute successfully Review URL: https://chromiumcodereview.appspot.com/10915079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155118 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
The CL adds to ShellUtil and ShellIntegration and adjusts invocations of the latter whenever necessary. R=grt@chromium.org, sky@chromium.org BUG=113326, 129232 TEST=N/A Review URL: https://chromiumcodereview.appspot.com/10453041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141172 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Packaged apps are now enabled by default (and arguments on launcher shortcuts are unlikely to function when chrome is already running), so this extra argument on shortcuts can be dropped. BUG=146037 TEST=ensure shortcuts for packaged apps are still created (e.g. on desktop), and can execute successfully Review URL: https://chromiumcodereview.appspot.com/10915079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155118 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable EULA dialog to be shown from metro Chrome. BUG=131033 TEST=Run Chrome in Metro mode while the EULA dialog still needs to be accepted. Get kicked back to the desktop to accept the dialog. On accept, get kicked back into metro mode. Review URL: https://chromiumcodereview.appspot.com/10837222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158797 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future change, but I wanted to break it up. Review URL: https://chromiumcodereview.appspot.com/10823392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152102 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable flaky UnloadTests that are timing out on linux asan. BrowserCloseInfiniteBeforeUnload, BrowserCloseInfiniteBeforeUnloadAlert, and CrossSiteInfiniteBeforeUnloadAsync are all timing out. BUG=86469 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/10939039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157562 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ash: Update system update notification behaviour. Decorate the update notification appropriately depending on the severity of the update recommendation. BUG=145577 Review URL: https://chromiumcodereview.appspot.com/10915214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156263 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move notifications only used in chrome/ to chrome/, renames one notification for clarity. BUG=137741 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10779042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147307 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Kill PropertyBag, switch WebContents to SupportsUserData. BUG=141177 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10831407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152882 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |