Ssschmitz@chromium.orgfix "IME changed" notification uses a wrong field of IME
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Add OWNERS file for chromeos/input_method directory BUG=None Review URL: https://chromiumcodereview.appspot.com/10831069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148931 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract PrefServiceBase into chrome/browser/api. Use in api and autofill. TBR=owners other than for prefs and api, since other changes are trivial and mechanical BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10828345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152569 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace views::MouseEvent with ui::MouseEvent http://crbug/com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support multi display candidate window. BUG=147394 TEST=Manually done on lumpy Review URL: https://chromiumcodereview.appspot.com/10919236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156544 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix candidate window position issue. This CL contains: 1. Extend SetCursorLocation message to propagate composition head character rectangle. 2. Do not send SetCursorLocation dbus message, which is not require any more. 3. Show candidate window at the composition head location when the candidate window category is SUGGESTION. BUG=120597 TEST=unit_tests and manually check by alex Review URL: https://chromiumcodereview.appspot.com/10534134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142103 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support label field in ExtensinoIME API. BUG=126793 TEST=manually done on lumpy and try bot Review URL: https://chromiumcodereview.appspot.com/10872011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153009 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename ibus_input_methods.txt to input_methods.txt. The prefix "ibus_" is no longer relevant because IBus is not used anymore for a keyboard whose ID starts with "xkb:". Another reason to avoid the prefix is that we're likely going to reimplement some of the input methods as Chrome extensions. BUG=chromium-os:19655 TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127471 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127914 Review URL: http://codereview.chromium.org/9721017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128116 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
chrome/browser/chromeos/input_method/ refactoring [part 6 of 6]. * Overview of the change The main purpose of this CL is to make InputMethodManager fully unit-testable. To accomplish that, InputMethodManager is modified as follows: - Add setters to set mock versions of IBusController, CandidateWindowController, and XKeyboard. - Move ibus-daemon startup and shutdown code from the manager to IBusControllerImpl. They lived in the manager only for historical reasons. - Remove code for monitoring the status of the connection between Chrome and ibus-daemon (InputMethodManager::OnConnectionChange(bool)). This kind of thing should also be done in IBusControllerImpl. * Details ash/shell.cc: ash/system/ime/tray_ime.cc: ash/system/tray/system_tray*.*: chrome/browser/chromeos/system/ash_system_tray_delegate.cc: Remove unused parameter |is_selection| from the SystemTrayDelegate interface following sadrul's suggestion in http://codereview.chromium.org/10008043/. chrome/browser/chromeos/chrome_browser_main_chromeos.cc: Initialize() and Shutdown() InputMethodManager. chrome/browser/chromeos/extensions/input_method_event_router.h: chrome/browser/chromeos/extensions/input_method_event_router.cc: Follow the interface change of InputMethodManager::Observer. Implementation is not changed at all. chrome/browser/chromeos/input_method/browser_state_monitor.h: chrome/browser/chromeos/input_method/browser_state_monitor.cc: Follow the interface change of InputMethodManager::Observer. Make the class testable by adding some setters and getters. Remove STATE_LOGGING_IN. Since preferences.cc is fixed in #5 of the series of patches, the intermediate state is no longer needed. chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc: Verify if the implementation updates the correct pref file (i.e. Local\ State or Preferences depending on the browser state). chrome/browser/chromeos/input_method/ibus_controller.h: Simplify the IBusController::Observer interface. Add Start() which is called when a non-XKB input method is enabled. Rename SetImePropertyActivated() to ActivateInputMethodProperty() and remove the second parameter |is_selection| which is no longer needed. Remove CreateInputMethodDescriptor() as we can simply use a constructor in InputMethodDescriptor. chrome/browser/chromeos/input_method/ibus_controller.cc: Move HAVE_IBUS part to chrome/browser/chromeos/input_method/ibus_controller_impl.cc. Move !HAVE_IBUS part to chrome/browser/chromeos/input_method/mock_ibus_controller.cc. Move some functions which do not depend on libibus to chrome/browser/chromeos/input_method/ibus_controller_base.cc. chrome/browser/chromeos/input_method/ibus_controller_base.h: chrome/browser/chromeos/input_method/ibus_controller_base.cc: chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc: Implement some part of the IBusController interface. Since the files do not depend on libibus, they are unit-testable. chrome/browser/chromeos/input_method/ibus_controller_impl.h: chrome/browser/chromeos/input_method/ibus_controller_impl.cc: Implement libibus dependent part of the IBusController interface. Moved ibus-daemon startup and shutdown code from input_method_manager.cc. Most of other part are unchanged. chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc: Tests FindAndUpdateProperty() function in ibus_controller_impl.cc since the function does not use libibus structues/functions. Other functions in ibus_controller_impl.cc will become unit testable soon once crosbug.com/26334 is fixed (by nona@c). chrome/browser/chromeos/input_method/input_method_engine.cc: Follow InputMethodManager interface changes. chrome/browser/chromeos/input_method/input_method_manager.h: Simplify InputMethodManager::Observer interface. Add EnableInputMethods(). We used to set an ibus-daemon config called "preload_engines" to enable input methods, but it is difficult to understand. In addition to the readability problem, the "preload_engines" config has been removed from ibus-1.5. On the daemon side, what we have to do to switch the current input method is just to call ibus_bus_set_global_engine("engine-name") without calling ibus_config_set_value("preload_engiens", ...). So enabling engines by calling SetInputMethodConfig() does not make sense at all now. Rename AddActiveIme() to AddInputMethodExtension(). Do the same for RemoveActiveIme(). Move StartInputMethodDaemon() and StopInputMethodDaemon() to IBusControllerImpl. This should be done automatically in the libibus layer. Add Initialize() and Shutdown() to stop initializing the instance as a singleton. chrome/browser/chromeos/input_method/input_method_manager.cc: Move to input_method_manager_impl.cc. chrome/browser/chromeos/input_method/input_method_manager_impl.h: chrome/browser/chromeos/input_method/input_method_manager_impl.cc: The manager implementation. Fully tested. chrome/browser/chromeos/input_method/input_method_manager_browsertest.cc: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc: Rename input_method_manager_browsertest.cc to input_method_manager_impl_unittest.cc. Added bunch of unit tests that tests all methods in the manager implementation. chrome/browser/chromeos/login/login_utils_browsertest.cc: chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc: Initialize() and Shutdown() the input method manager instance. chrome/browser/chromeos/login/screen_locker.cc: Move code for changing the set of enabled input methods on lock/unlock to input_method_manager_impl.cc. chrome/browser/chromeos/preferences_unittest.cc: Add a unit test which checks if the correct input method is set as a default one on signing in. Note that the CL compiles and works correctly only with app-i18n/ibus >= 1.4.99. BUG=chromium-os:19655 TEST=try Review URL: https://chromiumcodereview.appspot.com/9999018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132751 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace InputMethodEngineIBus. This CL removes libibus dependent code. This CL does not provide functionally changes into extension IME. This CL does not provide any unittests for input_method_engine_ibus.{cc|h}. Let me split CL for simplicity. BUG=126947 TEST=Try bots and manually check the extension IME works on Lumpy. Review URL: https://chromiumcodereview.appspot.com/10834108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150497 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome/browser/chromeos/input_method/ refactoring [part 6 of 6]. * Overview of the change The main purpose of this CL is to make InputMethodManager fully unit-testable. To accomplish that, InputMethodManager is modified as follows: - Add setters to set mock versions of IBusController, CandidateWindowController, and XKeyboard. - Move ibus-daemon startup and shutdown code from the manager to IBusControllerImpl. They lived in the manager only for historical reasons. - Remove code for monitoring the status of the connection between Chrome and ibus-daemon (InputMethodManager::OnConnectionChange(bool)). This kind of thing should also be done in IBusControllerImpl. * Details ash/shell.cc: ash/system/ime/tray_ime.cc: ash/system/tray/system_tray*.*: chrome/browser/chromeos/system/ash_system_tray_delegate.cc: Remove unused parameter |is_selection| from the SystemTrayDelegate interface following sadrul's suggestion in http://codereview.chromium.org/10008043/. chrome/browser/chromeos/chrome_browser_main_chromeos.cc: Initialize() and Shutdown() InputMethodManager. chrome/browser/chromeos/extensions/input_method_event_router.h: chrome/browser/chromeos/extensions/input_method_event_router.cc: Follow the interface change of InputMethodManager::Observer. Implementation is not changed at all. chrome/browser/chromeos/input_method/browser_state_monitor.h: chrome/browser/chromeos/input_method/browser_state_monitor.cc: Follow the interface change of InputMethodManager::Observer. Make the class testable by adding some setters and getters. Remove STATE_LOGGING_IN. Since preferences.cc is fixed in #5 of the series of patches, the intermediate state is no longer needed. chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc: Verify if the implementation updates the correct pref file (i.e. Local\ State or Preferences depending on the browser state). chrome/browser/chromeos/input_method/ibus_controller.h: Simplify the IBusController::Observer interface. Add Start() which is called when a non-XKB input method is enabled. Rename SetImePropertyActivated() to ActivateInputMethodProperty() and remove the second parameter |is_selection| which is no longer needed. Remove CreateInputMethodDescriptor() as we can simply use a constructor in InputMethodDescriptor. chrome/browser/chromeos/input_method/ibus_controller.cc: Move HAVE_IBUS part to chrome/browser/chromeos/input_method/ibus_controller_impl.cc. Move !HAVE_IBUS part to chrome/browser/chromeos/input_method/mock_ibus_controller.cc. Move some functions which do not depend on libibus to chrome/browser/chromeos/input_method/ibus_controller_base.cc. chrome/browser/chromeos/input_method/ibus_controller_base.h: chrome/browser/chromeos/input_method/ibus_controller_base.cc: chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc: Implement some part of the IBusController interface. Since the files do not depend on libibus, they are unit-testable. chrome/browser/chromeos/input_method/ibus_controller_impl.h: chrome/browser/chromeos/input_method/ibus_controller_impl.cc: Implement libibus dependent part of the IBusController interface. Moved ibus-daemon startup and shutdown code from input_method_manager.cc. Most of other part are unchanged. chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc: Tests FindAndUpdateProperty() function in ibus_controller_impl.cc since the function does not use libibus structues/functions. Other functions in ibus_controller_impl.cc will become unit testable soon once crosbug.com/26334 is fixed (by nona@c). chrome/browser/chromeos/input_method/input_method_engine.cc: Follow InputMethodManager interface changes. chrome/browser/chromeos/input_method/input_method_manager.h: Simplify InputMethodManager::Observer interface. Add EnableInputMethods(). We used to set an ibus-daemon config called "preload_engines" to enable input methods, but it is difficult to understand. In addition to the readability problem, the "preload_engines" config has been removed from ibus-1.5. On the daemon side, what we have to do to switch the current input method is just to call ibus_bus_set_global_engine("engine-name") without calling ibus_config_set_value("preload_engiens", ...). So enabling engines by calling SetInputMethodConfig() does not make sense at all now. Rename AddActiveIme() to AddInputMethodExtension(). Do the same for RemoveActiveIme(). Move StartInputMethodDaemon() and StopInputMethodDaemon() to IBusControllerImpl. This should be done automatically in the libibus layer. Add Initialize() and Shutdown() to stop initializing the instance as a singleton. chrome/browser/chromeos/input_method/input_method_manager.cc: Move to input_method_manager_impl.cc. chrome/browser/chromeos/input_method/input_method_manager_impl.h: chrome/browser/chromeos/input_method/input_method_manager_impl.cc: The manager implementation. Fully tested. chrome/browser/chromeos/input_method/input_method_manager_browsertest.cc: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc: Rename input_method_manager_browsertest.cc to input_method_manager_impl_unittest.cc. Added bunch of unit tests that tests all methods in the manager implementation. chrome/browser/chromeos/login/login_utils_browsertest.cc: chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc: Initialize() and Shutdown() the input method manager instance. chrome/browser/chromeos/login/screen_locker.cc: Move code for changing the set of enabled input methods on lock/unlock to input_method_manager_impl.cc. chrome/browser/chromeos/preferences_unittest.cc: Add a unit test which checks if the correct input method is set as a default one on signing in. Note that the CL compiles and works correctly only with app-i18n/ibus >= 1.4.99. BUG=chromium-os:19655 TEST=try Review URL: https://chromiumcodereview.appspot.com/9999018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132751 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace InputMethodEngineIBus. This CL removes libibus dependent code. This CL does not provide functionally changes into extension IME. This CL does not provide any unittests for input_method_engine_ibus.{cc|h}. Let me split CL for simplicity. BUG=126947 TEST=Try bots and manually check the extension IME works on Lumpy. Review URL: https://chromiumcodereview.appspot.com/10834108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150497 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix compilation problem for clang-3.0. The clang error is - chrome/browser/chromeos/input_method/ibus_controller_impl.cc:319:15: error: function 'PrintPropList' has internal linkage but is not defined [-Werror] std::string PrintPropList(IBusPropList *prop_list, int tree_level); ^chrome/browser/chromeos/input_method/ibus_controller_impl.cc:350:13: note: used here stream << PrintPropList(ibus_property_get_sub_props(prop), tree_level + 1); Fixed by moving proto-type out of function body. BUG=None TEST=Built using clang Review URL: https://chromiumcodereview.appspot.com/10911269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158339 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome/browser/chromeos/input_method/ refactoring [part 6 of 6]. * Overview of the change The main purpose of this CL is to make InputMethodManager fully unit-testable. To accomplish that, InputMethodManager is modified as follows: - Add setters to set mock versions of IBusController, CandidateWindowController, and XKeyboard. - Move ibus-daemon startup and shutdown code from the manager to IBusControllerImpl. They lived in the manager only for historical reasons. - Remove code for monitoring the status of the connection between Chrome and ibus-daemon (InputMethodManager::OnConnectionChange(bool)). This kind of thing should also be done in IBusControllerImpl. * Details ash/shell.cc: ash/system/ime/tray_ime.cc: ash/system/tray/system_tray*.*: chrome/browser/chromeos/system/ash_system_tray_delegate.cc: Remove unused parameter |is_selection| from the SystemTrayDelegate interface following sadrul's suggestion in http://codereview.chromium.org/10008043/. chrome/browser/chromeos/chrome_browser_main_chromeos.cc: Initialize() and Shutdown() InputMethodManager. chrome/browser/chromeos/extensions/input_method_event_router.h: chrome/browser/chromeos/extensions/input_method_event_router.cc: Follow the interface change of InputMethodManager::Observer. Implementation is not changed at all. chrome/browser/chromeos/input_method/browser_state_monitor.h: chrome/browser/chromeos/input_method/browser_state_monitor.cc: Follow the interface change of InputMethodManager::Observer. Make the class testable by adding some setters and getters. Remove STATE_LOGGING_IN. Since preferences.cc is fixed in #5 of the series of patches, the intermediate state is no longer needed. chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc: Verify if the implementation updates the correct pref file (i.e. Local\ State or Preferences depending on the browser state). chrome/browser/chromeos/input_method/ibus_controller.h: Simplify the IBusController::Observer interface. Add Start() which is called when a non-XKB input method is enabled. Rename SetImePropertyActivated() to ActivateInputMethodProperty() and remove the second parameter |is_selection| which is no longer needed. Remove CreateInputMethodDescriptor() as we can simply use a constructor in InputMethodDescriptor. chrome/browser/chromeos/input_method/ibus_controller.cc: Move HAVE_IBUS part to chrome/browser/chromeos/input_method/ibus_controller_impl.cc. Move !HAVE_IBUS part to chrome/browser/chromeos/input_method/mock_ibus_controller.cc. Move some functions which do not depend on libibus to chrome/browser/chromeos/input_method/ibus_controller_base.cc. chrome/browser/chromeos/input_method/ibus_controller_base.h: chrome/browser/chromeos/input_method/ibus_controller_base.cc: chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc: Implement some part of the IBusController interface. Since the files do not depend on libibus, they are unit-testable. chrome/browser/chromeos/input_method/ibus_controller_impl.h: chrome/browser/chromeos/input_method/ibus_controller_impl.cc: Implement libibus dependent part of the IBusController interface. Moved ibus-daemon startup and shutdown code from input_method_manager.cc. Most of other part are unchanged. chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc: Tests FindAndUpdateProperty() function in ibus_controller_impl.cc since the function does not use libibus structues/functions. Other functions in ibus_controller_impl.cc will become unit testable soon once crosbug.com/26334 is fixed (by nona@c). chrome/browser/chromeos/input_method/input_method_engine.cc: Follow InputMethodManager interface changes. chrome/browser/chromeos/input_method/input_method_manager.h: Simplify InputMethodManager::Observer interface. Add EnableInputMethods(). We used to set an ibus-daemon config called "preload_engines" to enable input methods, but it is difficult to understand. In addition to the readability problem, the "preload_engines" config has been removed from ibus-1.5. On the daemon side, what we have to do to switch the current input method is just to call ibus_bus_set_global_engine("engine-name") without calling ibus_config_set_value("preload_engiens", ...). So enabling engines by calling SetInputMethodConfig() does not make sense at all now. Rename AddActiveIme() to AddInputMethodExtension(). Do the same for RemoveActiveIme(). Move StartInputMethodDaemon() and StopInputMethodDaemon() to IBusControllerImpl. This should be done automatically in the libibus layer. Add Initialize() and Shutdown() to stop initializing the instance as a singleton. chrome/browser/chromeos/input_method/input_method_manager.cc: Move to input_method_manager_impl.cc. chrome/browser/chromeos/input_method/input_method_manager_impl.h: chrome/browser/chromeos/input_method/input_method_manager_impl.cc: The manager implementation. Fully tested. chrome/browser/chromeos/input_method/input_method_manager_browsertest.cc: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc: Rename input_method_manager_browsertest.cc to input_method_manager_impl_unittest.cc. Added bunch of unit tests that tests all methods in the manager implementation. chrome/browser/chromeos/login/login_utils_browsertest.cc: chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc: Initialize() and Shutdown() the input method manager instance. chrome/browser/chromeos/login/screen_locker.cc: Move code for changing the set of enabled input methods on lock/unlock to input_method_manager_impl.cc. chrome/browser/chromeos/preferences_unittest.cc: Add a unit test which checks if the correct input method is set as a default one on signing in. Note that the CL compiles and works correctly only with app-i18n/ibus >= 1.4.99. BUG=chromium-os:19655 TEST=try Review URL: https://chromiumcodereview.appspot.com/9999018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132751 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome/browser/chromeos/input_method/ refactoring [part 6 of 6]. * Overview of the change The main purpose of this CL is to make InputMethodManager fully unit-testable. To accomplish that, InputMethodManager is modified as follows: - Add setters to set mock versions of IBusController, CandidateWindowController, and XKeyboard. - Move ibus-daemon startup and shutdown code from the manager to IBusControllerImpl. They lived in the manager only for historical reasons. - Remove code for monitoring the status of the connection between Chrome and ibus-daemon (InputMethodManager::OnConnectionChange(bool)). This kind of thing should also be done in IBusControllerImpl. * Details ash/shell.cc: ash/system/ime/tray_ime.cc: ash/system/tray/system_tray*.*: chrome/browser/chromeos/system/ash_system_tray_delegate.cc: Remove unused parameter |is_selection| from the SystemTrayDelegate interface following sadrul's suggestion in http://codereview.chromium.org/10008043/. chrome/browser/chromeos/chrome_browser_main_chromeos.cc: Initialize() and Shutdown() InputMethodManager. chrome/browser/chromeos/extensions/input_method_event_router.h: chrome/browser/chromeos/extensions/input_method_event_router.cc: Follow the interface change of InputMethodManager::Observer. Implementation is not changed at all. chrome/browser/chromeos/input_method/browser_state_monitor.h: chrome/browser/chromeos/input_method/browser_state_monitor.cc: Follow the interface change of InputMethodManager::Observer. Make the class testable by adding some setters and getters. Remove STATE_LOGGING_IN. Since preferences.cc is fixed in #5 of the series of patches, the intermediate state is no longer needed. chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc: Verify if the implementation updates the correct pref file (i.e. Local\ State or Preferences depending on the browser state). chrome/browser/chromeos/input_method/ibus_controller.h: Simplify the IBusController::Observer interface. Add Start() which is called when a non-XKB input method is enabled. Rename SetImePropertyActivated() to ActivateInputMethodProperty() and remove the second parameter |is_selection| which is no longer needed. Remove CreateInputMethodDescriptor() as we can simply use a constructor in InputMethodDescriptor. chrome/browser/chromeos/input_method/ibus_controller.cc: Move HAVE_IBUS part to chrome/browser/chromeos/input_method/ibus_controller_impl.cc. Move !HAVE_IBUS part to chrome/browser/chromeos/input_method/mock_ibus_controller.cc. Move some functions which do not depend on libibus to chrome/browser/chromeos/input_method/ibus_controller_base.cc. chrome/browser/chromeos/input_method/ibus_controller_base.h: chrome/browser/chromeos/input_method/ibus_controller_base.cc: chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc: Implement some part of the IBusController interface. Since the files do not depend on libibus, they are unit-testable. chrome/browser/chromeos/input_method/ibus_controller_impl.h: chrome/browser/chromeos/input_method/ibus_controller_impl.cc: Implement libibus dependent part of the IBusController interface. Moved ibus-daemon startup and shutdown code from input_method_manager.cc. Most of other part are unchanged. chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc: Tests FindAndUpdateProperty() function in ibus_controller_impl.cc since the function does not use libibus structues/functions. Other functions in ibus_controller_impl.cc will become unit testable soon once crosbug.com/26334 is fixed (by nona@c). chrome/browser/chromeos/input_method/input_method_engine.cc: Follow InputMethodManager interface changes. chrome/browser/chromeos/input_method/input_method_manager.h: Simplify InputMethodManager::Observer interface. Add EnableInputMethods(). We used to set an ibus-daemon config called "preload_engines" to enable input methods, but it is difficult to understand. In addition to the readability problem, the "preload_engines" config has been removed from ibus-1.5. On the daemon side, what we have to do to switch the current input method is just to call ibus_bus_set_global_engine("engine-name") without calling ibus_config_set_value("preload_engiens", ...). So enabling engines by calling SetInputMethodConfig() does not make sense at all now. Rename AddActiveIme() to AddInputMethodExtension(). Do the same for RemoveActiveIme(). Move StartInputMethodDaemon() and StopInputMethodDaemon() to IBusControllerImpl. This should be done automatically in the libibus layer. Add Initialize() and Shutdown() to stop initializing the instance as a singleton. chrome/browser/chromeos/input_method/input_method_manager.cc: Move to input_method_manager_impl.cc. chrome/browser/chromeos/input_method/input_method_manager_impl.h: chrome/browser/chromeos/input_method/input_method_manager_impl.cc: The manager implementation. Fully tested. chrome/browser/chromeos/input_method/input_method_manager_browsertest.cc: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc: Rename input_method_manager_browsertest.cc to input_method_manager_impl_unittest.cc. Added bunch of unit tests that tests all methods in the manager implementation. chrome/browser/chromeos/login/login_utils_browsertest.cc: chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc: Initialize() and Shutdown() the input method manager instance. chrome/browser/chromeos/login/screen_locker.cc: Move code for changing the set of enabled input methods on lock/unlock to input_method_manager_impl.cc. chrome/browser/chromeos/preferences_unittest.cc: Add a unit test which checks if the correct input method is set as a default one on signing in. Note that the CL compiles and works correctly only with app-i18n/ibus >= 1.4.99. BUG=chromium-os:19655 TEST=try Review URL: https://chromiumcodereview.appspot.com/9999018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132751 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace InputMethodEngineIBus. This CL removes libibus dependent code. This CL does not provide functionally changes into extension IME. This CL does not provide any unittests for input_method_engine_ibus.{cc|h}. Let me split CL for simplicity. BUG=126947 TEST=Try bots and manually check the extension IME works on Lumpy. Review URL: https://chromiumcodereview.appspot.com/10834108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150497 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove IBusClientImpl from ui/base/ime/* BUG=126947 TEST=ran ui_unittests and checked on lumpy Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144677 Review URL: https://chromiumcodereview.appspot.com/10656017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144696 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add decoration to the language button to indicate that a third party IME is in use TBR=jhawkins@chromium.org BUG=None TEST=Install an IME extension. Enable it. Check that the Language Bar indicates that it is 3rd party Review URL: https://chromiumcodereview.appspot.com/10544070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141594 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename ibus_input_methods.txt to input_methods.txt. The prefix "ibus_" is no longer relevant because IBus is not used anymore for a keyboard whose ID starts with "xkb:". Another reason to avoid the prefix is that we're likely going to reimplement some of the input methods as Chrome extensions. BUG=chromium-os:19655 TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127471 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127914 Review URL: http://codereview.chromium.org/9721017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128116 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
cleanup: Split ibus_controller.h into 5 headers. - Remove small classes and structures from ibus_controller.cc and .h. - Add input_method_{descriptor,property,whitelist,config}.cc and .h instead. - Do the same for ibus_controller_unittest.cc. - Move IBusController::GetSupportedInputMethods() to input_method_whitelist.h. This CL is in preparation for removing IBus dependencies from all classes except InputMethodManagerImpl. BUG=chromium-os:19655 TEST=try Review URL: http://codereview.chromium.org/9701095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127435 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add decoration to the language button to indicate that a third party IME is in use TBR=jhawkins@chromium.org BUG=None TEST=Install an IME extension. Enable it. Check that the Language Bar indicates that it is 3rd party Review URL: https://chromiumcodereview.appspot.com/10544070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141594 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add decoration to the language button to indicate that a third party IME is in use TBR=jhawkins@chromium.org BUG=None TEST=Install an IME extension. Enable it. Check that the Language Bar indicates that it is 3rd party Review URL: https://chromiumcodereview.appspot.com/10544070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141594 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace InputMethodEngineIBus. This CL removes libibus dependent code. This CL does not provide functionally changes into extension IME. This CL does not provide any unittests for input_method_engine_ibus.{cc|h}. Let me split CL for simplicity. BUG=126947 TEST=Try bots and manually check the extension IME works on Lumpy. Review URL: https://chromiumcodereview.appspot.com/10834108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150497 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix crash bug of IME extension API. BUG=147526,147539,149189 Review URL: https://chromiumcodereview.appspot.com/10968056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158527 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace InputMethodEngineIBus. This CL removes libibus dependent code. This CL does not provide functionally changes into extension IME. This CL does not provide any unittests for input_method_engine_ibus.{cc|h}. Let me split CL for simplicity. BUG=126947 TEST=Try bots and manually check the extension IME works on Lumpy. Review URL: https://chromiumcodereview.appspot.com/10834108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150497 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace all LOGs in input_method/, except two user-facing errors, to DVLOG(1). Our style guide says "DVLOG(1) is the canonical debug "off by default, selectively enabled" call." http://dev.chromium.org/developers/coding-style BUG=chromium-os:19655 TEST=None Review URL: http://codereview.chromium.org/10109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132773 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the ability to filter out extension IMEs from the language settings page. BUG=137640 Review URL: https://chromiumcodereview.appspot.com/10907196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157737 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the ability to filter out extension IMEs from the language settings page. BUG=137640 Review URL: https://chromiumcodereview.appspot.com/10907196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157737 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the ability to filter out extension IMEs from the language settings page. BUG=137640 Review URL: https://chromiumcodereview.appspot.com/10907196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157737 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix preedit handling on IME switching. This is hack for Korean IME which required to commit preedit when it is disabled or switched to other IME. The root of the problem is that, in ChromeOS, if the next engine is xkb layout, SetGlobalEngine is not called. Due to this logic, ibus-daemon can't know the ime switching. As the result, IBusPreeditFocusMode does not work. BUG=chrome-os-partner:12798 TEST=Manually done on lumpy Review URL: https://chromiumcodereview.appspot.com/10917061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154802 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome/browser/chromeos/input_method/ refactoring [part 6 of 6]. * Overview of the change The main purpose of this CL is to make InputMethodManager fully unit-testable. To accomplish that, InputMethodManager is modified as follows: - Add setters to set mock versions of IBusController, CandidateWindowController, and XKeyboard. - Move ibus-daemon startup and shutdown code from the manager to IBusControllerImpl. They lived in the manager only for historical reasons. - Remove code for monitoring the status of the connection between Chrome and ibus-daemon (InputMethodManager::OnConnectionChange(bool)). This kind of thing should also be done in IBusControllerImpl. * Details ash/shell.cc: ash/system/ime/tray_ime.cc: ash/system/tray/system_tray*.*: chrome/browser/chromeos/system/ash_system_tray_delegate.cc: Remove unused parameter |is_selection| from the SystemTrayDelegate interface following sadrul's suggestion in http://codereview.chromium.org/10008043/. chrome/browser/chromeos/chrome_browser_main_chromeos.cc: Initialize() and Shutdown() InputMethodManager. chrome/browser/chromeos/extensions/input_method_event_router.h: chrome/browser/chromeos/extensions/input_method_event_router.cc: Follow the interface change of InputMethodManager::Observer. Implementation is not changed at all. chrome/browser/chromeos/input_method/browser_state_monitor.h: chrome/browser/chromeos/input_method/browser_state_monitor.cc: Follow the interface change of InputMethodManager::Observer. Make the class testable by adding some setters and getters. Remove STATE_LOGGING_IN. Since preferences.cc is fixed in #5 of the series of patches, the intermediate state is no longer needed. chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc: Verify if the implementation updates the correct pref file (i.e. Local\ State or Preferences depending on the browser state). chrome/browser/chromeos/input_method/ibus_controller.h: Simplify the IBusController::Observer interface. Add Start() which is called when a non-XKB input method is enabled. Rename SetImePropertyActivated() to ActivateInputMethodProperty() and remove the second parameter |is_selection| which is no longer needed. Remove CreateInputMethodDescriptor() as we can simply use a constructor in InputMethodDescriptor. chrome/browser/chromeos/input_method/ibus_controller.cc: Move HAVE_IBUS part to chrome/browser/chromeos/input_method/ibus_controller_impl.cc. Move !HAVE_IBUS part to chrome/browser/chromeos/input_method/mock_ibus_controller.cc. Move some functions which do not depend on libibus to chrome/browser/chromeos/input_method/ibus_controller_base.cc. chrome/browser/chromeos/input_method/ibus_controller_base.h: chrome/browser/chromeos/input_method/ibus_controller_base.cc: chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc: Implement some part of the IBusController interface. Since the files do not depend on libibus, they are unit-testable. chrome/browser/chromeos/input_method/ibus_controller_impl.h: chrome/browser/chromeos/input_method/ibus_controller_impl.cc: Implement libibus dependent part of the IBusController interface. Moved ibus-daemon startup and shutdown code from input_method_manager.cc. Most of other part are unchanged. chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc: Tests FindAndUpdateProperty() function in ibus_controller_impl.cc since the function does not use libibus structues/functions. Other functions in ibus_controller_impl.cc will become unit testable soon once crosbug.com/26334 is fixed (by nona@c). chrome/browser/chromeos/input_method/input_method_engine.cc: Follow InputMethodManager interface changes. chrome/browser/chromeos/input_method/input_method_manager.h: Simplify InputMethodManager::Observer interface. Add EnableInputMethods(). We used to set an ibus-daemon config called "preload_engines" to enable input methods, but it is difficult to understand. In addition to the readability problem, the "preload_engines" config has been removed from ibus-1.5. On the daemon side, what we have to do to switch the current input method is just to call ibus_bus_set_global_engine("engine-name") without calling ibus_config_set_value("preload_engiens", ...). So enabling engines by calling SetInputMethodConfig() does not make sense at all now. Rename AddActiveIme() to AddInputMethodExtension(). Do the same for RemoveActiveIme(). Move StartInputMethodDaemon() and StopInputMethodDaemon() to IBusControllerImpl. This should be done automatically in the libibus layer. Add Initialize() and Shutdown() to stop initializing the instance as a singleton. chrome/browser/chromeos/input_method/input_method_manager.cc: Move to input_method_manager_impl.cc. chrome/browser/chromeos/input_method/input_method_manager_impl.h: chrome/browser/chromeos/input_method/input_method_manager_impl.cc: The manager implementation. Fully tested. chrome/browser/chromeos/input_method/input_method_manager_browsertest.cc: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc: Rename input_method_manager_browsertest.cc to input_method_manager_impl_unittest.cc. Added bunch of unit tests that tests all methods in the manager implementation. chrome/browser/chromeos/login/login_utils_browsertest.cc: chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc: Initialize() and Shutdown() the input method manager instance. chrome/browser/chromeos/login/screen_locker.cc: Move code for changing the set of enabled input methods on lock/unlock to input_method_manager_impl.cc. chrome/browser/chromeos/preferences_unittest.cc: Add a unit test which checks if the correct input method is set as a default one on signing in. Note that the CL compiles and works correctly only with app-i18n/ibus >= 1.4.99. BUG=chromium-os:19655 TEST=try Review URL: https://chromiumcodereview.appspot.com/9999018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132751 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add operator= to InputMethodProperty. This is for writing unit tests for InputMethodManager, BUG=chromium-os:19655 TEST=ran unit_tests Review URL: https://chromiumcodereview.appspot.com/10025015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131325 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add operator= to InputMethodProperty. This is for writing unit tests for InputMethodManager, BUG=chromium-os:19655 TEST=ran unit_tests Review URL: https://chromiumcodereview.appspot.com/10025015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131325 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
fix "IME changed" notification uses a wrong field of IME Added a medium length name to IMEInfo. It is used for the bubble with "Your input method has changed to ...". In most cases the medium length text is equal to the short text except where this issue is concerned. BUG=137629 TEST=Enable English and Japanese keyboards; restart; Control + Space: observe popup bubble "Your input method has changed to..." Review URL: https://chromiumcodereview.appspot.com/10960060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
fix "IME changed" notification uses a wrong field of IME Added a medium length name to IMEInfo. It is used for the bubble with "Your input method has changed to ...". In most cases the medium length text is equal to the short text except where this issue is concerned. BUG=137629 TEST=Enable English and Japanese keyboards; restart; Control + Space: observe popup bubble "Your input method has changed to..." Review URL: https://chromiumcodereview.appspot.com/10960060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
fix "IME changed" notification uses a wrong field of IME Added a medium length name to IMEInfo. It is used for the bubble with "Your input method has changed to ...". In most cases the medium length text is equal to the short text except where this issue is concerned. BUG=137629 TEST=Enable English and Japanese keyboards; restart; Control + Space: observe popup bubble "Your input method has changed to..." Review URL: https://chromiumcodereview.appspot.com/10960060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add decoration to the language button to indicate that a third party IME is in use TBR=jhawkins@chromium.org BUG=None TEST=Install an IME extension. Enable it. Check that the Language Bar indicates that it is 3rd party Review URL: https://chromiumcodereview.appspot.com/10544070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141594 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove virtual keyboard support from input_method_descriptor.h. Since we've removed VK support (crrev.com/138223), now we can simplify InputMethodDescriptor. BUG=128295 TEST=try Review URL: https://chromiumcodereview.appspot.com/10388181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138709 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove virtual keyboard support: 1. common.gypi: use_virtual_keyboard define 2. Any code controlled by that define 3. chrome/browser/ui/virtual_keyboard/* 4. chrome/browser/resources/keyboard/* 5. experimental extension APIs for virtual keyboard No user-visible changes. BUG=128295 TEST=try Review URL: https://chromiumcodereview.appspot.com/10399046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138223 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome/browser/chromeos/input_method/ refactoring [part 3 of 6]. Add a mock implementation of the chromeos::input_method::CandidateWindowController interface. This is for http://codereview.chromium.org/9999018/. BUG=chromium-os:19655 TEST=try Review URL: https://chromiumcodereview.appspot.com/10034009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131973 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add Reset() to IBusController. This depends on http://codereview.chromium.org/9999018/. BUG=chromium-os:29502 TEST=ran the new unit test Review URL: http://codereview.chromium.org/10092006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132786 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the ability to filter out extension IMEs from the language settings page. BUG=137640 Review URL: https://chromiumcodereview.appspot.com/10907196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157737 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the ability to filter out extension IMEs from the language settings page. BUG=137640 Review URL: https://chromiumcodereview.appspot.com/10907196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157737 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using "+chromeos(...)" in an XKB layout name. This CL requires Chrome OS 2375.0.0 or newer. BUG=chromium-os:31324 TEST=ran unit_tests Review URL: https://chromiumcodereview.appspot.com/10456055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140274 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Move some ash files into ui/ash. BUG=125846 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10694127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146283 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using "+chromeos(...)" in an XKB layout name. This CL requires Chrome OS 2375.0.0 or newer. BUG=chromium-os:31324 TEST=ran unit_tests Review URL: https://chromiumcodereview.appspot.com/10456055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140274 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using "+chromeos(...)" in an XKB layout name. This CL requires Chrome OS 2375.0.0 or newer. BUG=chromium-os:31324 TEST=ran unit_tests Review URL: https://chromiumcodereview.appspot.com/10456055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140274 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |