Star0
64
代码
代码
Issues350
Pull Requests45
流水线
讨论
Wiki
分析
Star0
64
Jjam@chromium.orgRemove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome.
5e88bc55创建于 2012年9月26日历史提交
文件最后提交记录最后更新时间
android
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
DEPS
Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Review URL: https://codereview.chromium.org/10978016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158725 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
OWNERS
Remove more set noparents BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10824025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148406 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
archived_database.cc
Close ArchivedDatabase connection after transaction rollback. ArchivedDatabase::Init attempts to initialize its database tables inside of a transaction. If the initialization fails, the transaction object's destructor attempts to perform a rollback which fails because the database connection has been closed. Ensure that the transaction object is always destructed before database closure by moving the table initialization into a separate method. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10669033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145124 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
archived_database.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
download_database.cc
Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING Changes from original CL only in downloads_api.* Reviewers: Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc rdsmith, asanka: all Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.* Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.* Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.* Scott (sky): chrome/browser/history/history_unittest.cc Aaron (aa): chrome/browser/extensions/webstore_installer.* Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history. Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086 http://crbug.com/140687 Review URL: https://chromiumcodereview.appspot.com/10704026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
download_database.h
Fix downloads db state=3 corruption using version=23 Add a layer of abstraction between the |state| db field and DownloadItem::DownloadState. This will actually prevent the same problem from happening again when I reland http://codereview.chromium.org/10704026/ TBR=sky@chromium.org BUG=140687 Review URL: https://chromiumcodereview.appspot.com/10823203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150542 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
expire_history_backend.cc
First part of PAGE_TRANSITION_START_PAGE cleanup. I replaced START_PAGE with AUTO_TOPLEVEL because that more accurately describes how its being used in the code. In a followed CL I will add specific support for startup pages, which was the original intention of START_PAGE. This CL is basically a large search and replace and does not change the behaviour of the code. BUG=144002 TEST=No user visible change Review URL: https://chromiumcodereview.appspot.com/10897034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155047 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
expire_history_backend.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
expire_history_backend_unittest.cc
Pass in favicon sizes parameter to ThumbnailDatabase::AddFavicon(). Fix ThumbnailDatabase::GetIconMappingsForPageURL to have functionality described by the comment. Bug=10896006 Test=Try bots Review URL: https://chromiumcodereview.appspot.com/10915146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155540 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history.cc
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_backend.cc
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_backend.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_backend_android.cc
Completed the code path from AndroidProviderService to HistoryBackend. - Added AndroidProviderService. - Added methods in HistoryService and HistoryBackend to support Android content provider. - Also fixed a issue in testing_profile.cc. BUG= TEST=Added the new tests Review URL: http://codereview.chromium.org/10217010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135414 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_backend_unittest.cc
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_browsertest.cc
Second try of 157576 https://chromiumcodereview.appspot.com/10780013/ Add reverse URL handler for shortening uber URLs BUG=120493 TEST=Open the settings page. The address bar should show "chrome://settings". Click the "extensions" button on the left. The address bar should show "chrome://extensions". Click the "settings" button on the left, "show advanced settings", "content settings". The address bar should show "chrome://settings/content". Review URL: https://chromiumcodereview.appspot.com/10941050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158504 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_database.cc
Remove legacy migration code that coupled history and bookmarks. R=sky BUG=144050 Review URL: https://chromiumcodereview.appspot.com/10870029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154058 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_database.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_database_unittest.cc
Remove legacy migration code that coupled history and bookmarks. R=sky BUG=144050 Review URL: https://chromiumcodereview.appspot.com/10870029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154058 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_extension_api.cc
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_extension_api.h
Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_extension_apitest.cc
Disable flaky tests that were re-enabled in r128299 BUG=119505 TEST=flaky tests don't run TBR=cduvall@chromium.org Review URL: https://chromiumcodereview.appspot.com/9863022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129137 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
history_indexer.idl
Fix history_indexer.idl to stop from rebuilding it every time. Review URL: http://codereview.chromium.org/10816 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5235 0039d316-1c4b-4281-b951-d872f2087c98
17 年前
history_marshaling.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_marshaling_android.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_notifications.cc
Now mark delete notifications for archived URLs specially BUG=124508 TEST=existing tests suffice Review URL: https://chromiumcodereview.appspot.com/10380015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135963 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_notifications.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_publisher.cc
wstring removal fix. BUG=23581 TEST=No visible change. Review URL: http://codereview.chromium.org/6626054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77205 0039d316-1c4b-4281-b951-d872f2087c98
15 年前
history_publisher.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_publisher_none.cc
Port some unit tests from chrome/browser/ Makes over 200 tests pass on Linux. Review URL: http://codereview.chromium.org/18758 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9041 0039d316-1c4b-4281-b951-d872f2087c98
17 年前
history_publisher_win.cc
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
history_querying_unittest.cc
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_service_factory.cc
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_service_factory.h
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_tab_helper.cc
Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Review URL: https://codereview.chromium.org/10978016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158725 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_tab_helper.h
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_types.cc
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_types.h
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_types_unittest.cc
Tweak typed-count Usage. Tweak how the typed count is used in the HistoryQuickProvider so that a typed_count of 1 is considered when presenting results. Adjusted usage of the three factors in RowQualifiesAsSignificant so that the comparison operations are the same. Adjusted unit tests since the tweak to RowQualifiesAsSignificant changes the expected results just a bit. BUG=77476 TEST=Adjusted unit tests. Review URL: http://codereview.chromium.org/7618028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97505 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
history_unittest.cc
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
history_unittest_base.cc
Move app/sql/* files to sql/ directory. I can't remove app/app.gyp and app/app_base.gypi yet because they are referenced by third_party gyp files :( BUG=72317 TEST=None R=rsesek@chromium.org move app/sql to sql Review URL: http://codereview.chromium.org/7353026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93069 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
history_unittest_base.h
Switch ChromeTestSuite to the same convention as ContentTestSuite: the test suite implicitly provides global resources for each test, but they're re-initialized between each test. The performance overhead is negligible. We need that to continue moving tests from unit_tests to content_unittests. Because of shared test fixtures the test suites need to be compatible. BUG=90443 Review URL: http://codereview.chromium.org/7744039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
in_memory_database.cc
Database usage adjustment for .../history R=shess@chromium.org BUG=None TEST=.../history tests Review URL: http://codereview.chromium.org/9071014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118184 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
in_memory_database.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_history_backend.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_history_backend.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_url_index.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_url_index.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_url_index_cache.proto
Gather word-start Information to Aid in Scoring. This change implements word start gathering and provides those word starts to the scoring routine but does not yet implement consideration of those word starts in the actual score calculation. BUG=NONE TEST=Added and updated unit tests. Review URL: https://chromiumcodereview.appspot.com/9655003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126661 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
in_memory_url_index_types.cc
Move ScoredHistoryMatch into Its Own Set of Files Created scored_history_match.h/cc and moved the ScoredHistoryMatch struct therein. Moved all scoring functions into that struct. Created scored_history_match_unittest.cc and moved scoring tests therein. BUG=None TEST=All unit tests pass. Review URL: https://chromiumcodereview.appspot.com/10541045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141004 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_url_index_types.h
Revert 152946 - Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date. Detailed comments about the changes made in this CL can be found in the document shared separately. Previous reviewers: sky, pkasting, shess. BUG=95686, 95876, 131668 TEST=New tests added, old tests updated, all tests pass. To manually verify changes: NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider. 1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion. 2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show. 3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted. 4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP. 5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title. Previously reviewed as: http://codereview.chromium.org/10477018/. 10477018 was reverted due to memory leaks detected by build bots. Review URL: https://chromiumcodereview.appspot.com/10837244 TBR=mrossetti@chromium.org This is causing performance regressions across a range of perf bots. Review URL: https://chromiumcodereview.appspot.com/10872032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152963 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_url_index_types_unittest.cc
Revert 152946 - Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date. Detailed comments about the changes made in this CL can be found in the document shared separately. Previous reviewers: sky, pkasting, shess. BUG=95686, 95876, 131668 TEST=New tests added, old tests updated, all tests pass. To manually verify changes: NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider. 1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion. 2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show. 3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted. 4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP. 5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title. Previously reviewed as: http://codereview.chromium.org/10477018/. 10477018 was reverted due to memory leaks detected by build bots. Review URL: https://chromiumcodereview.appspot.com/10837244 TBR=mrossetti@chromium.org This is causing performance regressions across a range of perf bots. Review URL: https://chromiumcodereview.appspot.com/10872032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152963 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
in_memory_url_index_unittest.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
multipart_browsertest.cc
WebKit gardening. Disable tests which started to fail on canary after r121912 of WebKit. CaptivePortalBrowserTest.GoBackToTimeout MultipartResponseTest.SingleVisit ErrorPageTest.DNSError_GoBack2Forward2 ErrorPageTest.DNSError_GoBack2AndForward ErrorPageTest.DNSError_GoBack2 CaptivePortalBrowserTest.ReloadTimeout BUG=136310 TEST=None TBR=rafaelw Review URL: https://chromiumcodereview.appspot.com/10693118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145644 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
page_usage_data.cc
Removes unused thumbnail and favicon fields from PageUsageData. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10673005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144316 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
page_usage_data.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
query_parser.cc
Revert 121423 - Don't strip punctuation inside quotes in history search queries. (accidentally committed due to bad owners file). Currently, the query parser strips all punctuation from history search queries, even inside quotes. A query like ["chromium.org"] will be passed to SQLite as ["chromium org"], meaning that pages on chromium.org will not be matched unless they contain the literal string "chromium org" somewhere. BUG=100545 TEST=Do a search on chrome://history for a domain that you have previously visited, e.g. "chromium.org", and ensure that history entries matching this domain are found. Review URL: http://codereview.chromium.org/9316129 TBR=dubroy@chromium.org Review URL: https://chromiumcodereview.appspot.com/9381019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121533 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
query_parser.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
query_parser_unittest.cc
Revert 121423 - Don't strip punctuation inside quotes in history search queries. (accidentally committed due to bad owners file). Currently, the query parser strips all punctuation from history search queries, even inside quotes. A query like ["chromium.org"] will be passed to SQLite as ["chromium org"], meaning that pages on chromium.org will not be matched unless they contain the literal string "chromium org" somewhere. BUG=100545 TEST=Do a search on chrome://history for a domain that you have previously visited, e.g. "chromium.org", and ensure that history entries matching this domain are found. Review URL: http://codereview.chromium.org/9316129 TBR=dubroy@chromium.org Review URL: https://chromiumcodereview.appspot.com/9381019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121533 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
redirect_browsertest.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
scored_history_match.cc
Omnibox: Fix HistoryQuick provider can_inline bug The HistoryQuick provider erroneously sets can_inline to false when the user's input matches mid-word in the scheme, even if the scheme is droppable. For instance, for the omnibox input "t", the URL http://teams.foo.com/ would be considered not inlineable. This is wrong. This changelist revises the can_inline code to make it correct in these cases. I added tests. Before this change, the new tests fail. Specifically, lines 158 and 174 fail. BUG= Review URL: https://chromiumcodereview.appspot.com/10907176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156204 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
scored_history_match.h
Boost HQP Scores for Bookmarks During the final scoring process, in the ScoredHistoryMatch ctor, determine how many bookmarks reference a match's URL and boost the score if any. BUG=None TEST=New unit tests added. Review URL: https://chromiumcodereview.appspot.com/10909046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155106 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
scored_history_match_unittest.cc
Omnibox: Fix HistoryQuick provider can_inline bug The HistoryQuick provider erroneously sets can_inline to false when the user's input matches mid-word in the scheme, even if the scheme is droppable. For instance, for the omnibox input "t", the URL http://teams.foo.com/ would be considered not inlineable. This is wrong. This changelist revises the can_inline code to make it correct in these cases. I added tests. Before this change, the new tests fail. Specifically, lines 158 and 174 fail. BUG= Review URL: https://chromiumcodereview.appspot.com/10907176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156204 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_favicon_frames.cc
Fix comment numbering This got jumbled up in https://chromiumcodereview.appspot.com/10834196 BUG=none TBR=sky Review URL: https://codereview.chromium.org/10946024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157531 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_favicon_frames.h
Cleanup FaviconHandler code now that http://codereview.chromium.org/10870022/ has landed. Fix FaviconHandler::DownloadImage to return the best matching unresized bitmap as specified in favicon_tab_helper.h Bug=130896 Test=FaviconHandlerTest.* Review URL: https://chromiumcodereview.appspot.com/10911149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156222 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_favicon_frames_unittest.cc
Move SelectFaviconFrames from favicon/ to history/ so that HistoryBackend can use it. BUG=10802066 Test=chrome and unit_tests compile R=thakis TBR=sky Review URL: https://chromiumcodereview.appspot.com/10908114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155139 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_backend.cc
Make ShortcutsBackend a ProfileKeyedService. Removed all GetShortcutsBackend. Also minor enhancement of ShortcutsBackend unit tests to test shortcut update notifications. BUG=112558 TEST=All tests pass. Enhanced one test. TBR=sky Review URL: https://chromiumcodereview.appspot.com/10701043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145378 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_backend.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_backend_factory.cc
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_backend_factory.h
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_backend_unittest.cc
Make ShortcutsBackend a ProfileKeyedService. Removed all GetShortcutsBackend. Also minor enhancement of ShortcutsBackend unit tests to test shortcut update notifications. BUG=112558 TEST=All tests pass. Enhanced one test. TBR=sky Review URL: https://chromiumcodereview.appspot.com/10701043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145378 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_database.cc
Make ShortcutsBackend a ProfileKeyedService. Removed all GetShortcutsBackend. Also minor enhancement of ShortcutsBackend unit tests to test shortcut update notifications. BUG=112558 TEST=All tests pass. Enhanced one test. TBR=sky Review URL: https://chromiumcodereview.appspot.com/10701043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145378 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_database.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
shortcuts_database_unittest.cc
Make ShortcutsBackend a ProfileKeyedService. Removed all GetShortcutsBackend. Also minor enhancement of ShortcutsBackend unit tests to test shortcut update notifications. BUG=112558 TEST=All tests pass. Enhanced one test. TBR=sky Review URL: https://chromiumcodereview.appspot.com/10701043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145378 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
snippet.cc
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
15 年前
snippet.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
snippet_unittest.cc
base: Move SplitString functions into the base namespace and update the callers. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
15 年前
text_database.cc
Added parameter 'clear_bound_vars', so we could reset the statement without clearing bound variables, so and current row is reset to the beginning. It is used to support the Andorid' sqlite cursor feature which could move the cursor around the result set. BUG= TEST=Added a new test. TBR=agl,akalin,michaeln Review URL: http://codereview.chromium.org/10171014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133985 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
text_database.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
text_database_manager.cc
TabContents -> WebContentsImpl, part 18. TabContents -> WebContents in chrome/, part 2. BUG=105875 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10107002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132568 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
text_database_manager.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
text_database_manager_unittest.cc
Revert 121423 - Don't strip punctuation inside quotes in history search queries. (accidentally committed due to bad owners file). Currently, the query parser strips all punctuation from history search queries, even inside quotes. A query like ["chromium.org"] will be passed to SQLite as ["chromium org"], meaning that pages on chromium.org will not be matched unless they contain the literal string "chromium org" somewhere. BUG=100545 TEST=Do a search on chrome://history for a domain that you have previously visited, e.g. "chromium.org", and ensure that history entries matching this domain are found. Review URL: http://codereview.chromium.org/9316129 TBR=dubroy@chromium.org Review URL: https://chromiumcodereview.appspot.com/9381019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121533 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
text_database_unittest.cc
Move scoped_temp_dir and scoped_native_library back from base/memory to base. It looks like they got moved accidentally in http://codereview.chromium.org/6714032 BUG=none TEST=none Review URL: http://codereview.chromium.org/7048007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
thumbnail_database.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
thumbnail_database.h
Modifies history backend to be able to take advantage of storing the pixel size of favicons into the database. Changed FaviconData to allow retrieving favicon bitmaps for multiple pixel sizes from the database simultaneously. Added History::GetFavicons() and History::GetFaviconsForURL() to do this. Changed History::SetFavicon() to History::SetFavicons() such that multiple favicon bitmaps for a page URL can be set simultaneously. BUG=138553 TEST=ThumbnailDatabaseTest.*, HistoryBackendTest.* Depends on http://codereview.chromium.org/10815068 Review URL: https://chromiumcodereview.appspot.com/10802066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155645 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
thumbnail_database_unittest.cc
Modifies history backend to be able to take advantage of storing the pixel size of favicons into the database. Changed FaviconData to allow retrieving favicon bitmaps for multiple pixel sizes from the database simultaneously. Added History::GetFavicons() and History::GetFaviconsForURL() to do this. Changed History::SetFavicon() to History::SetFavicons() such that multiple favicon bitmaps for a page URL can be set simultaneously. BUG=138553 TEST=ThumbnailDatabaseTest.*, HistoryBackendTest.* Depends on http://codereview.chromium.org/10815068 Review URL: https://chromiumcodereview.appspot.com/10802066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155645 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites.cc
Make the mobile welcome page the only default most visited page BUG=138239 Review URL: https://chromiumcodereview.appspot.com/10831359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152023 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_backend.cc
Move BrowserThread to content namespace. TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
top_sites_backend.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_cache.cc
Move RefCountedMemory Class to Base namespace BUG=none TEST=compiles chrome, browser_tests and ui_tests Review URL: http://codereview.chromium.org/10272004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135011 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_cache.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_database.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_database.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_database_unittest.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_extension_api.cc
Added support for multiple parameters to Extension API callbacks. BUG=135269 TEST= Review URL: https://chromiumcodereview.appspot.com/10694106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146469 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_extension_api.h
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_extension_test.cc
Added support for multiple parameters to Extension API callbacks. BUG=135269 TEST= Review URL: https://chromiumcodereview.appspot.com/10694106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146469 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_sites_unittest.cc
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
url_index_private_data.cc
Boost HQP Scores for Bookmarks During the final scoring process, in the ScoredHistoryMatch ctor, determine how many bookmarks reference a match's URL and boost the score if any. BUG=None TEST=New unit tests added. Review URL: https://chromiumcodereview.appspot.com/10909046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155106 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
url_index_private_data.h
Boost HQP Scores for Bookmarks During the final scoring process, in the ScoredHistoryMatch ctor, determine how many bookmarks reference a match's URL and boost the score if any. BUG=None TEST=New unit tests added. Review URL: https://chromiumcodereview.appspot.com/10909046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155106 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_database.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_database.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_database_unittest.cc
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_filter.cc
Support for different weight-functions for time-slicing. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10060003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137229 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_filter.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_filter_unittest.cc
Support for different weight-functions for time-slicing. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10060003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137229 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_tracker.cc
some cleanup for base/stl_util removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
visit_tracker.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visit_tracker_unittest.cc
More style nits. (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
16 年前
visitsegment_database.cc
Added parameter 'clear_bound_vars', so we could reset the statement without clearing bound variables, so and current row is reset to the beginning. It is used to support the Andorid' sqlite cursor feature which could move the cursor around the result set. BUG= TEST=Added a new test. TBR=agl,akalin,michaeln Review URL: http://codereview.chromium.org/10171014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133985 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
visitsegment_database.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前