Star0
64
代码
代码
Issues350
Pull Requests46
流水线
讨论
Wiki
分析
Star0
64
Jjam@chromium.orgMove the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome.
05238365创建于 2012年9月25日历史提交
文件最后提交记录最后更新时间
OWNERS
Fix typo in owner's email address. BUG=none Review URL: https://chromiumcodereview.appspot.com/10829353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151970 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon.cc
Move extension pop-ups and notifications to the new auto-resize code. This should fix the "flicker" issues where autosize ends up flipping back and forth between two size in rapid succession. The change in render_widget_host is needed to avoid cases where the OnMsgUpdateRect happens while processing a resize message which may result in recursion back into the resize code which is undesirable. BUG=58816,56693 TEST=Try out auto resize in notifications and extensions. Best to do with windows that change size and hit the maximum as well as minimum sizes on the 3 desktop platforms for pop-ups. Review URL: http://codereview.chromium.org/9702068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127824 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
balloon.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon_collection.cc
Reapply and fix r73019. BalloonViewImpl has a different implemementation on linux_gtk, linux_views, and chromeos, but everyone uses the same class name. sizeof(linux_views BVI) > sizeof(linux_gtk BVI). Previously, the GTK version allocated on object of linux_views BVI, and just had some uninitialized memory at the end. Switching these around by changing the includes, the linux_views implementation wrote past the sizeof the linux_gtk BVI. Fix by #ifdefing on TOOLKIT. Fix style problems in the Balloon implementation on linux in preparation for turning on chrome-style bot. - Rename file that had all BalloonCollectionImpl code from balloon_collection.cc to balloon_collection_impl.cc so I could add a real balloon_collection.cc for deinlining. - GTK implementation files shouldn't depend on views/ code. BUG=none TEST=compiles Original Review URL: http://codereview.chromium.org/6400006 Review URL: http://codereview.chromium.org/6260040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73310 0039d316-1c4b-4281-b951-d872f2087c98
15 年前
balloon_collection.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon_collection_base.cc
Add support for Ash to Notifications * Adds BalloonViewAsh and moves/renames related classes. * Adds support for image icons to Notification class * Adds GetRenderViewHost() method to NotificationDelegate for fetching images BUG=124914 TEST=Tests pass. No visual changes to notifications on non-ash platforms. Web notifications show up in new tray on Ash with --ash-notify. For CloudPrintProxyService: TBR=scottbyer@chromium.org Review URL: https://chromiumcodereview.appspot.com/10537158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142172 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon_collection_base.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon_collection_impl.cc
Rename gfx::Screen::GetMonitorXXXX to gfx::Screen::GetDisplayXXX. BUG=130828 R=oshima@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10540123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142631 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon_collection_impl.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon_host.cc
Pass result of blockage across content API when new tab blocked. This change allows the proper blockage of foreground tabs created without user-gestures for rel=noreferrer links. BUG=118317 Review URL: https://chromiumcodereview.appspot.com/10868116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155535 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
balloon_host.h
Pass result of blockage across content API when new tab blocked. This change allows the proper blockage of foreground tabs created without user-gestures for rel=noreferrer links. BUG=118317 Review URL: https://chromiumcodereview.appspot.com/10868116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155535 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notification_service.cc
Eliminate kAshNotifyDisabled and SystemNotification BUG=134561 For OWNERS: TBR=ben Review URL: https://codereview.chromium.org/10947046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158305 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notification_service.h
Correctly remove file browser notifications from Ash notification tray. Also added replace_id to DesktopNotificationService::AddNotification so that notifications are correctly replaced/updated. BUG=135286 For minor changes to status_icons/ background/ and printing/: TBR=atwilson@chromium.org,thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151305 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notification_service_factory.cc
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notification_service_factory.h
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notification_service_unittest.cc
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notification_service_win.cc
Implement base::win::IsMetroProcess. Change GetMetroModule callers that don't need the HMODULE. TBR=stevenjb@chromium.org,brettw@chromium.org,mirandac@chromium.org,sky@chromium.org,kalman@chromium.org BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10560015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142801 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notifications_unittest.cc
notifications: Refactor MockBalloonView into FakeBalloonView. R=atwilson@chromium.org TBR=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150036 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
desktop_notifications_unittest.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
fake_balloon_view.cc
notifications: Refactor MockBalloonView into FakeBalloonView. R=atwilson@chromium.org TBR=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150036 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
fake_balloon_view.h
notifications: Refactor MockBalloonView into FakeBalloonView. R=atwilson@chromium.org TBR=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150036 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification.cc
Add support for Ash to Notifications * Adds BalloonViewAsh and moves/renames related classes. * Adds support for image icons to Notification class * Adds GetRenderViewHost() method to NotificationDelegate for fetching images BUG=124914 TEST=Tests pass. No visual changes to notifications on non-ash platforms. Web notifications show up in new tray on Ash with --ash-notify. For CloudPrintProxyService: TBR=scottbyer@chromium.org Review URL: https://chromiumcodereview.appspot.com/10537158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142172 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_browsertest.cc
Introduce InfoBarTabService API. The new interface extracts the API bits from InfoBarTabHelper. This change switches files under chrome/browser/autofill and chrome/browser/api to use the API and remove the temporarily-allowed dependency on InfoBarTabHelper. TBRing other owners as the changes are just to match the updated API and include paths. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10830353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_delegate.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_object_proxy.cc
Add support for Ash to Notifications * Adds BalloonViewAsh and moves/renames related classes. * Adds support for image icons to Notification class * Adds GetRenderViewHost() method to NotificationDelegate for fetching images BUG=124914 TEST=Tests pass. No visual changes to notifications on non-ash platforms. Web notifications show up in new tray on Ash with --ash-notify. For CloudPrintProxyService: TBR=scottbyer@chromium.org Review URL: https://chromiumcodereview.appspot.com/10537158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142172 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_object_proxy.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_options_menu_model.cc
notifications: Forward declared Balloon in notification_options_menu_model.h R=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10879008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153594 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_options_menu_model.h
notifications: Forward declared Balloon in notification_options_menu_model.h R=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10879008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153594 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_prefs_manager.cc
It used to be possible to change the position of the notification bubble on ChromeOS. Now that the wrench menu for doing so is disabled it is no longer possible to change the balloon position. Force the pref to be the default position such that users are not stuck with the notification bubble in a weird place. Bug=None Test=Manual Review URL: https://chromiumcodereview.appspot.com/10260021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136043 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_prefs_manager.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_test_util.cc
notifications: Refactor MockBalloonView into FakeBalloonView. R=atwilson@chromium.org TBR=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150036 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_test_util.h
notifications: Refactor MockBalloonView into FakeBalloonView. R=atwilson@chromium.org TBR=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150036 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_ui_manager.cc
[Mac] Implement a NotificationUIManager that uses Notification Center on 10.8 for text notifications. BUG=120677 TEST=On 10.8, enable Gmail desktop notifications and chat with somebody. You see notifications and clicking them closes them, brings Chromium to the foreground, and removes them from the tray. TEST=On 10.8, try using a HTML-based notification and it gets displayed in the old style. Review URL: http://codereview.chromium.org/10021026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132611 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_ui_manager.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_ui_manager_impl.cc
Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_ui_manager_impl.h
Move PrefMember and PrefChangeRegistrar to api directory. This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_ui_manager_mac.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notification_ui_manager_mac.mm
[Mac] Only attempt to replace a notification if the replacement_id is not empty. This was causing notifications to be dismissed too quickly because replacement was being attempted for all notifications since the replacement_id was empty. BUG=134990 TEST=Go to http://www/~rsesek/html_notifications.html and click "Notify Me" three times. "onclose" should not show up in the log box. Review URL: https://chromiumcodereview.appspot.com/10690192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146617 0039d316-1c4b-4281-b951-d872f2087c98
13 年前