Aakalin@chromium.org[Sync] Refactor handling of session tabs
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
[Sync] Refactor handling of session tabs Add SessionTab <-> sync_pb::SessionTab conversion functions. Add IsPinned() method to SyncedTabDelegate and fix latent NULL-dereference bug in the process. Remove HasExtensionAppId() also. Rework tab contents association to: - update a SessionTab from the tab delegate (UpdateSessionTabFromDelegate); - get the current virtual URL for the tab (GetCurrentVirtualURL); - and convert to sync_pb::SessionTab in separate phases. Rework the SessionModelAssociator tests. BUG=128449 Review URL: https://chromiumcodereview.appspot.com/10990012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158777 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add InvalidationStateTracker::Forget() to erase an entry from storage. BUG=none Review URL: https://chromiumcodereview.appspot.com/10824140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154826 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
It seems GAIA had changed dosserver rules today, so we can go back to accounts.google.com. Revert 137937 - Reverted 136345 - Ran into GAIA dosserver issues in prod for http://accounts.google.com. We are going back to http://www.google.com/accounts/... for all API calls. BUG=127147 TEST=all serivices dependent on GAIA auth should still work (sync, login, policy, drive...) Review URL: https://chromiumcodereview.appspot.com/10411025 TBR=zelidrag@chromium.org Review URL: https://chromiumcodereview.appspot.com/10413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137978 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Refactor GetEncryptedTypes usage. The cryptographer is now owned by the SyncEncryptionHandlerImpl, and no longer needs any connection to the nigori handler or encrypted types. Those are accessed via the directory, which now has a GetNigoriHandler method. Because of this, we can now clean up the thread safety guarantees in the sync encryption handler impl, enforcing that everything except GetEncryptedTypes (and IsUsingExplicitPassphrase, which will be fixed in a followup patch) are invoked on the syncer thread. This lets us not have to open unnecessary transactions. At the chrome layer, encrypted types are accessed via BaseTransaction:: GetEncryptedTypes(). At the syncer layer, they're accessed via directory:: GetNigoriHandler()->GetEncryptedTypes(BaseTransaction* trans const). BUG=142476,139848 Review URL: https://chromiumcodereview.appspot.com/10844005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153335 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove set noparent from a bunch of places and add it to src/chrome/OWNERS BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10824024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148398 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert the XXX_sync builders to using directly sync_integration_tests. TBR=nsylvain@chromium.org BUG=109517 TEST=sync_integration_tests is properly run. NOTRY=true Review URL: http://codereview.chromium.org/9513008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124732 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added nudge source counters to about:sync. Added counters for each possible nudge source on the summary tab of the about:sync page. The counters are stored in SyncStatus and managed by SyncManagerImpl via allstatus_. BUG=78166 Review URL: https://chromiumcodereview.appspot.com/10991005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158633 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Track validity of about:sync fields This commit changes the way we initialize the fields which get exported to about:sync's about tab. The goal was to pre-declare all the data which would be exported in a complete snapshot, and to track which of these fields were actually set. Unset fields will have a default value and be specially highlighted on about:sync. This commit includes the changes necessary to perform this highlighting. Also in this commit are a few backend changes that are used to determine from sync_ui_util which fields are properly initialized and which fields have been unset by anything other than a default constructor. The signature for ProfileSyncService::QueryDetailedSyncStatus() has been modified to return an additional parameter indicating whether or not the returned status actually came from the backend. The SyncSesionSnapshot takes a different approach. The object is immutable and has two constructors. If it is constructed with the zero-argument constructor it is clearly uninitialized, and will remain so. This change adds a flag which is set or unset based on which constructor is used. Finally, the ConstructAboutInforation function and all its helpers have been moved out of sync_ui_util.cc and into their own file. BUG=134927 TEST= Review URL: https://chromiumcodereview.appspot.com/10696107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147531 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Track validity of about:sync fields This commit changes the way we initialize the fields which get exported to about:sync's about tab. The goal was to pre-declare all the data which would be exported in a complete snapshot, and to track which of these fields were actually set. Unset fields will have a default value and be specially highlighted on about:sync. This commit includes the changes necessary to perform this highlighting. Also in this commit are a few backend changes that are used to determine from sync_ui_util which fields are properly initialized and which fields have been unset by anything other than a default constructor. The signature for ProfileSyncService::QueryDetailedSyncStatus() has been modified to return an additional parameter indicating whether or not the returned status actually came from the backend. The SyncSesionSnapshot takes a different approach. The object is immutable and has two constructors. If it is constructed with the zero-argument constructor it is clearly uninitialized, and will remain so. This change adds a flag which is set or unset based on which constructor is used. Finally, the ConstructAboutInforation function and all its helpers have been moved out of sync_ui_util.cc and into their own file. BUG=134927 TEST= Review URL: https://chromiumcodereview.appspot.com/10696107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147531 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Refactor CreateRoot() test helper function Move the function's definition so we can eventually make use of it in FakeSyncManager to test the DEVICE_INFO type. This change also removes the unnecessary TestIdFactory parameter. BUG=122825 Review URL: https://chromiumcodereview.appspot.com/10958007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158331 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Refactor CreateRoot() test helper function Move the function's definition so we can eventually make use of it in FakeSyncManager to test the DEVICE_INFO type. This change also removes the unnecessary TestIdFactory parameter. BUG=122825 Review URL: https://chromiumcodereview.appspot.com/10958007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158331 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Introduce control data types The Nigori node has always been treated specially. It is downloaded during early sync initialization. It has custom encryption, update application, and conflict resolution logic. It is not user-selectable, but is instead always implicitly enabled. This patch replaces a lot of if (NIGORI)' code branches and creates the infrastructure we will need to support other data types that have these properties. These types will be used to store metadata required for the normal operation of the syncer. Notable changes include: - Introduce mutually exclusive lists of control types and user types in model_type.cc. - Create an ApplyControlDataUpdates() function, which will be used to apply changes and resolve conflicts for control data types. - Add some if statements to skip processing of control data updates in the regular conflict resolution code path. - Move around some code to accomodate the above changes. Introduce apply_control_data_updates_unittest.cc and conflict_util.cc - Have SyncBackendHost download all control types during init, not just the NIGORI. - Introduce a PurgeForMigration() function on the DataTypeManagerImpl class to support migration of control data types. This replaces ConfigureWithoutNigori(), which would not have scaled well as additional control data types were addded. - Modify the encryption logic so that only user types may be set to be encrypted. The Nigori is no longer expected to be in the set of encrypted types, though it is no less encrypted than it was before this change. - Use the list of user types to help calculate the list of registered sync prefs. BUG=122825,111297 Review URL: https://chromiumcodereview.appspot.com/10832286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154522 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Move ModelType and related classes to 'syncer' namespace Previously they were in 'syncer::syncable'. Also remove aliases to those classes from 'syncable'. BUG=128060 TEST= TBR=pkasting@chromium.org,jhawkins@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10696087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145399 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Introduce control data types The Nigori node has always been treated specially. It is downloaded during early sync initialization. It has custom encryption, update application, and conflict resolution logic. It is not user-selectable, but is instead always implicitly enabled. This patch replaces a lot of if (NIGORI)' code branches and creates the infrastructure we will need to support other data types that have these properties. These types will be used to store metadata required for the normal operation of the syncer. Notable changes include: - Introduce mutually exclusive lists of control types and user types in model_type.cc. - Create an ApplyControlDataUpdates() function, which will be used to apply changes and resolve conflicts for control data types. - Add some if statements to skip processing of control data updates in the regular conflict resolution code path. - Move around some code to accomodate the above changes. Introduce apply_control_data_updates_unittest.cc and conflict_util.cc - Have SyncBackendHost download all control types during init, not just the NIGORI. - Introduce a PurgeForMigration() function on the DataTypeManagerImpl class to support migration of control data types. This replaces ConfigureWithoutNigori(), which would not have scaled well as additional control data types were addded. - Modify the encryption logic so that only user types may be set to be encrypted. The Nigori is no longer expected to be in the set of encrypted types, though it is no less encrypted than it was before this change. - Use the list of user types to help calculate the list of registered sync prefs. BUG=122825,111297 Review URL: https://chromiumcodereview.appspot.com/10832286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154522 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Rename csync namespace to syncer Everyone was confused by 'csync'. 'syncer' seems more understandable. (Note that we can't use the 'sync' namespace since sync() is a function from unistd.h.) BUG=10662035 TEST= TBR=jhawkins@chromium.org,pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144820 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from chrome/browser/sync Review URL: https://chromiumcodereview.appspot.com/10689154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[sync] Apply sync config changes only after sync backend is initialized During chrome startup on Win 8, if CredentialCacheService detects sync config changes in the alternate profile, we try to apply them immediately. Instead, we must try to apply config changes only after the sync backend is initialized, and preferably, after local sync configuration is done. This patch does the following: 1) Modify the constraints in MayReconfigureSync to include the fact that the sync backend has been initialized. 2) In case of sync auto-start, we try to consume config changes, if any, from the alternate profile once local configuration is done. 3) Update ScheduleNextReadFromAlternateCredentialCache to take a delay parameter, so that we can schedule a read of the alternate cache immediately or in the future. BUG=144302 TEST=Sign in on desktop; launch metro (so it signs in); close desktop; reconfigure metro; restart desktop; make sure config changes from metro are immediately applied on desktop. Review URL: https://chromiumcodereview.appspot.com/10872025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153123 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Move ModelType and related classes to 'syncer' namespace Previously they were in 'syncer::syncable'. Also remove aliases to those classes from 'syncable'. BUG=128060 TEST= TBR=pkasting@chromium.org,jhawkins@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10696087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145399 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from chrome/browser/sync Review URL: https://chromiumcodereview.appspot.com/10689154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Invalidations] Add GetInvalidatorState() to Invalidator{,Frontend} Combine OnNotifications{Enabled,Disabled}() into OnInvalidatorStateChange(). Replace NotificationsDisabledReason with InvalidatorState. Rename OnIncomingNotification to OnIncomingInvalidation. Also change some references of "notification" to "invalidation". Set the initial invalidator state in ChromeToMobileService. Also remove OnNotificationsEnabled() call from OnIncomingInvalidation(). Instantiate InvalidatorTest template for ProfileSyncService. Move comments for invalidation-related functions from ProfileSyncService to InvalidatorFrontend. Put DISALLOW_COPY_AND_ASSIGN on some classes. Fix comment in invalidator.h. BUG=142475 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10916131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155448 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeManagerOserver interface As of today, DataTypeManager sends out notifications for various configure events via NotificationService notifications. This is bad, because other services that depend on these events need to have knowledge of DataTypeManager, which is internal to the sync implementation. This patch does the following: 1) Creates a new DatTypeManagerObserver interface through which observers are made aware of configure events. 2) Has ProfileSyncService implement the interface. 3) Gets rid of unnecessary sync configure * notification types. 4) Has PSS send out notifications for SYNC_CONFIGURE_START and SYNC_CONFIGURE_DONE. 5) Allows ForeignSessionHandler to listen to SYNC_CONFIGURE_DONE notifications from the PSS, instead of from all sources, while waiting to populate the "other devices" section of the NTP. 6) Updates various mock and test classes and fixes unit tests. TBR=estade@chromium.org, thakis@chromium.org BUG=142984,124717,111676,142550 Review URL: https://chromiumcodereview.appspot.com/10834351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152170 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeManagerOserver interface As of today, DataTypeManager sends out notifications for various configure events via NotificationService notifications. This is bad, because other services that depend on these events need to have knowledge of DataTypeManager, which is internal to the sync implementation. This patch does the following: 1) Creates a new DatTypeManagerObserver interface through which observers are made aware of configure events. 2) Has ProfileSyncService implement the interface. 3) Gets rid of unnecessary sync configure * notification types. 4) Has PSS send out notifications for SYNC_CONFIGURE_START and SYNC_CONFIGURE_DONE. 5) Allows ForeignSessionHandler to listen to SYNC_CONFIGURE_DONE notifications from the PSS, instead of from all sources, while waiting to populate the "other devices" section of the NTP. 6) Updates various mock and test classes and fixes unit tests. TBR=estade@chromium.org, thakis@chromium.org BUG=142984,124717,111676,142550 Review URL: https://chromiumcodereview.appspot.com/10834351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152170 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeManagerOserver interface As of today, DataTypeManager sends out notifications for various configure events via NotificationService notifications. This is bad, because other services that depend on these events need to have knowledge of DataTypeManager, which is internal to the sync implementation. This patch does the following: 1) Creates a new DatTypeManagerObserver interface through which observers are made aware of configure events. 2) Has ProfileSyncService implement the interface. 3) Gets rid of unnecessary sync configure * notification types. 4) Has PSS send out notifications for SYNC_CONFIGURE_START and SYNC_CONFIGURE_DONE. 5) Allows ForeignSessionHandler to listen to SYNC_CONFIGURE_DONE notifications from the PSS, instead of from all sources, while waiting to populate the "other devices" section of the NTP. 6) Updates various mock and test classes and fixes unit tests. TBR=estade@chromium.org, thakis@chromium.org BUG=142984,124717,111676,142550 Review URL: https://chromiumcodereview.appspot.com/10834351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152170 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Move ModelType and related classes to 'syncer' namespace Previously they were in 'syncer::syncable'. Also remove aliases to those classes from 'syncable'. BUG=128060 TEST= TBR=pkasting@chromium.org,jhawkins@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10696087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145399 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Remove SyncableServiceAdapter. This comprises the following changes: - Convert all UI thread datatypes using SyncableService API to use the new UIDataTypeController - Convert ExtensionSettings to use NewNonFrontendDataTypeController (soon to be renamed NonUIDataTypeController). - Have all datatypes using the SyncableService api accessible under one GetSyncableServiceForType(..) method in the ProfileSyncComponentsFactory. - Fix up a bunch of tests. BUG=104658 TEST= Review URL: http://codereview.chromium.org/9395058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125215 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
[sync] Divorce DataTypeManager from NotificationService notifications by creating a new DataTypeManagerOserver interface As of today, DataTypeManager sends out notifications for various configure events via NotificationService notifications. This is bad, because other services that depend on these events need to have knowledge of DataTypeManager, which is internal to the sync implementation. This patch does the following: 1) Creates a new DatTypeManagerObserver interface through which observers are made aware of configure events. 2) Has ProfileSyncService implement the interface. 3) Gets rid of unnecessary sync configure * notification types. 4) Has PSS send out notifications for SYNC_CONFIGURE_START and SYNC_CONFIGURE_DONE. 5) Allows ForeignSessionHandler to listen to SYNC_CONFIGURE_DONE notifications from the PSS, instead of from all sources, while waiting to populate the "other devices" section of the NTP. 6) Updates various mock and test classes and fixes unit tests. TBR=estade@chromium.org, thakis@chromium.org BUG=142984,124717,111676,142550 Review URL: https://chromiumcodereview.appspot.com/10834351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152170 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Browser test for the push messaging feature We've implemented a push messaging feature and checked it in with a unit test. This change is adding a browser test to get better coverage in a running environment. The browser test basically brings up a small packaged app, and injects a message into the sync code. For the test to succeed, the message must arrive into the JS code of the packaged app. BUG=148550 Review URL: https://chromiumcodereview.appspot.com/10915216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157296 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Refactor CreateRoot() test helper function Move the function's definition so we can eventually make use of it in FakeSyncManager to test the DEVICE_INFO type. This change also removes the unnecessary TestIdFactory parameter. BUG=122825 Review URL: https://chromiumcodereview.appspot.com/10958007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158331 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Make ProfileSyncService a ProfileKeyedService. Create ProfileSyncService using a factory, and transfer ownership of the components factory to ProfileSyncService. I deliberately left GetProfileSyncService to keep this patch focused on the actual change and more manageable in size. It now just wraps calls to the factory, and I'll change the rest of the callers in a follow up (there are a lot). BUG=93922 TEST=Sync still works / can be set up / starts properly after browser restart / shuts down. Review URL: https://chromiumcodereview.appspot.com/9232011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118474 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Refactor ModelTypePayloadMap and ObjectIdPayloadMap to StateMaps. This lays the groundwork for allowing us to pass ack handles for object IDs to SyncNotifierObservers. BUG=124149 TEST=none, there should be no behavior change. Review URL: https://chromiumcodereview.appspot.com/10837214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153158 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Relanding this as this did not fix the chromiumos breakage. Revert 150391 - Reverting this as it causes browser tests on the Linux ChromiumOS builder to fail. Will revert back if it does not address the redness. Revert 150380 - Add support for loading user cloud policy on desktop, behind the --load-cloud-policy-on-signin flag. Move UserCloudPolicyManager to be owned by the Profile as a step towards supporting multiple profiles. Added TestingProfile::Builder as a start towards taming the madness of all the different constructors and setters. BUG=141123 TEST=none Review URL: https://chromiumcodereview.appspot.com/10693022 TBR=atwilson@chromium.org Review URL: https://chromiumcodereview.appspot.com/10823208 TBR=ananta@chromium.org Review URL: https://chromiumcodereview.appspot.com/10823212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150404 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Refactor CreateRoot() test helper function Move the function's definition so we can eventually make use of it in FakeSyncManager to test the DEVICE_INFO type. This change also removes the unnecessary TestIdFactory parameter. BUG=122825 Review URL: https://chromiumcodereview.appspot.com/10958007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158331 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Refactor CreateRoot() test helper function Move the function's definition so we can eventually make use of it in FakeSyncManager to test the DEVICE_INFO type. This change also removes the unnecessary TestIdFactory parameter. BUG=122825 Review URL: https://chromiumcodereview.appspot.com/10958007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158331 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Split user agent code out of the 'glue' target This creates a new user_agent component target for the user agent handling code. This makes it straightforward for iOS to build only the user-agent part of glue. It should also make incremental dismantling of webkit/ easier, since the dependencies on user agent code are now explicit. The code that was in user_agent.cc/h (the webkit_user_agent target) has been moved to user_agent_util.cc/h, and folded into the user_agent component target. All user-agent related code has been moved to a new webkit/user_agent/ directory. BUG=None Review URL: https://chromiumcodereview.appspot.com/10869073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155695 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move creation of BrowserContext objects that live in content to content, instead of depending on the embedder. Apart from allowing us to hide more of content from embedders, it simplifies the work that every embedder has to do (see the change the shell_browser_context.cc as an example). BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122521 Review URL: https://chromiumcodereview.appspot.com/9419033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122768 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Rename csync namespace to syncer Everyone was confused by 'csync'. 'syncer' seems more understandable. (Note that we can't use the 'sync' namespace since sync() is a function from unistd.h.) BUG=10662035 TEST= TBR=jhawkins@chromium.org,pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144820 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Add sync_export.h (Step 1 for componentizing sync) Add SYNC_EXPORT{,_PRIVATE} annotations to stuff in internal_api/public/{base,engine} in the 'sync' target. Add some componentization-related TODOs. Annotate sync-related test executables with SYNC_TEST. BUG=136928 TEST= Review URL: https://chromiumcodereview.appspot.com/10700180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147325 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate Browser Creation. . Make all instantiators use a single ctor that takes CreateParams. . Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10692195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable all registered types by default on Android. Also upstreaming other minor diffs. This removed all diff in chrome/browser/sync BUG=139259 Review URL: https://chromiumcodereview.appspot.com/10960057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158693 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PrefMember and PrefChangeRegistrar to api directory. This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Move ModelType and related classes to 'syncer' namespace Previously they were in 'syncer::syncable'. Also remove aliases to those classes from 'syncable'. BUG=128060 TEST= TBR=pkasting@chromium.org,jhawkins@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10696087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145399 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Track validity of about:sync fields This commit changes the way we initialize the fields which get exported to about:sync's about tab. The goal was to pre-declare all the data which would be exported in a complete snapshot, and to track which of these fields were actually set. Unset fields will have a default value and be specially highlighted on about:sync. This commit includes the changes necessary to perform this highlighting. Also in this commit are a few backend changes that are used to determine from sync_ui_util which fields are properly initialized and which fields have been unset by anything other than a default constructor. The signature for ProfileSyncService::QueryDetailedSyncStatus() has been modified to return an additional parameter indicating whether or not the returned status actually came from the backend. The SyncSesionSnapshot takes a different approach. The object is immutable and has two constructors. If it is constructed with the zero-argument constructor it is clearly uninitialized, and will remain so. This change adds a flag which is set or unset based on which constructor is used. Finally, the ConstructAboutInforation function and all its helpers have been moved out of sync_ui_util.cc and into their own file. BUG=134927 TEST= Review URL: https://chromiumcodereview.appspot.com/10696107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147531 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from chrome/browser/sync Review URL: https://chromiumcodereview.appspot.com/10689154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Removed ProfileSyncService::UIShouldDepictAuthInProgress Changed so all code queries the auth-in-progress status directly from SigninManager. BUG=95269 TEST=existing unit tests suffice Review URL: http://codereview.chromium.org/9959038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131709 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove PSS::ShowLoginDialog() and obsolete IDC_SYNC_BOOKMARKS. Changed calls to ShowLoginDialog() to go through LoginUIService() instead. Also noticed that IDC_SYNC_BOOKMARKS has been superceded by IDC_SHOW_SYNC_SETUP so changed the remaining uses over so we only have to maintain a single UI flow. Modified MainMenu.xib to generate IDC_SHOW_SYNC_SETUP instead of IDC_SYNC_BOOKMARKS when the user clicks on the menu item. TBR=jhawkins (for new_tab_page_sync_handler.cc which I believe is obsolete/unused) BUG=111859 TEST=bring up login via wrench/app menu. Review URL: http://codereview.chromium.org/9456031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123610 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Relanding this as this did not fix the chromiumos breakage. Revert 150391 - Reverting this as it causes browser tests on the Linux ChromiumOS builder to fail. Will revert back if it does not address the redness. Revert 150380 - Add support for loading user cloud policy on desktop, behind the --load-cloud-policy-on-signin flag. Move UserCloudPolicyManager to be owned by the Profile as a step towards supporting multiple profiles. Added TestingProfile::Builder as a start towards taming the madness of all the different constructors and setters. BUG=141123 TEST=none Review URL: https://chromiumcodereview.appspot.com/10693022 TBR=atwilson@chromium.org Review URL: https://chromiumcodereview.appspot.com/10823208 TBR=ananta@chromium.org Review URL: https://chromiumcodereview.appspot.com/10823212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150404 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
sync: Refactor CreateRoot() test helper function Move the function's definition so we can eventually make use of it in FakeSyncManager to test the DEVICE_INFO type. This change also removes the unnecessary TestIdFactory parameter. BUG=122825 Review URL: https://chromiumcodereview.appspot.com/10958007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158331 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Invalidations] Add GetInvalidatorState() to Invalidator{,Frontend} Combine OnNotifications{Enabled,Disabled}() into OnInvalidatorStateChange(). Replace NotificationsDisabledReason with InvalidatorState. Rename OnIncomingNotification to OnIncomingInvalidation. Also change some references of "notification" to "invalidation". Set the initial invalidator state in ChromeToMobileService. Also remove OnNotificationsEnabled() call from OnIncomingInvalidation(). Instantiate InvalidatorTest template for ProfileSyncService. Move comments for invalidation-related functions from ProfileSyncService to InvalidatorFrontend. Put DISALLOW_COPY_AND_ASSIGN on some classes. Fix comment in invalidator.h. BUG=142475 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10916131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155448 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove #pragma once from chrome/browser/sync Review URL: https://chromiumcodereview.appspot.com/10689154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146068 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |