Ccsilv@chromium.orgRevert 158707 - Enable by default:
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Added yoshiki@chromium.org to task-manager related OWNERS files, as estade requested. BUG= TEST= Review URL: http://codereview.chromium.org/9465014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124973 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
There were two leaks detected here. The first is from a preexisting bug. GpuProcessHost::SendOnIO will leak the message if the IO thread is not present. Note that it will not leak the message if the IO thread is present, but the GPU process is absent. The second issue is that we would keep around one GpuData-Observer indefinitely. I changed this to be scoped to the task manager. On the second issue I have a concern here that there may be a race between destruction of the task manager and the GpuDataManager. The TaskManagerModel dtor calls into GpuDataManager::RemoveObserver, but is this safe if the GpuDataManager's dtor has been called first? Do we offer any guarantees of this? In practice, neither singleton's dtor is called when I just run the browser, and the GpuDataManager's dtor is called second in the unit test. BUG=143563 Review URL: https://chromiumcodereview.appspot.com/10861018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
There were two leaks detected here. The first is from a preexisting bug. GpuProcessHost::SendOnIO will leak the message if the IO thread is not present. Note that it will not leak the message if the IO thread is present, but the GPU process is absent. The second issue is that we would keep around one GpuData-Observer indefinitely. I changed this to be scoped to the task manager. On the second issue I have a concern here that there may be a race between destruction of the task manager and the GpuDataManager. The TaskManagerModel dtor calls into GpuDataManager::RemoveObserver, but is this safe if the GpuDataManager's dtor has been called first? Do we offer any guarantees of this? In practice, neither singleton's dtor is called when I just run the browser, and the GpuDataManager's dtor is called second in the unit test. BUG=143563 Review URL: https://chromiumcodereview.appspot.com/10861018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158707 - Enable by default: 1. threaded compositing on windows (except XP) 2. force compositing mode on mac On linux we switch to a 1/3 1/3 fcm and thread experiments . This patch also gives priority to the command line switches so that both threaded and force compositing mode can be turned off via the about:flags page or command line. In the near future, we will use the Finch framework to tweak the experiment percentages. Note: This patch has a dependency on: https://bugs.webkit.org/show_bug.cgi?id=96871 It also disables ExtensionApiTest.CaptureVisibleTabJPeg as it triggers flakiness on it. chrome.tabs.captureVisibleTab is inherently racy as there is no way to guarantee that the tab has been painted at least once when that call is made. Note how the other variants of CaptureVisibleTab tests have already been disabled for similar reasons. BUG=143809,128387,146861 Review URL: https://chromiumcodereview.appspot.com/10914247 Reverted due to failures on Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/29446/steps/interactive_ui_tests/logs/AutoResize http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/2143/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/26358/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/1804/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine TBR=vangelis@chromium.org Review URL: https://codereview.chromium.org/10991032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158711 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixes for browser that load content from file: schema while running as ChromeOS BVTs on actual HW. This CL also fixes resource calculations in TaskManagerBrowserTest.* due to the fact that we also have GPU process present on ChromeOS side. TEST=TaskManagerBrowserTest.* and bunch of other browser tests should be passing now in BVT environment. BUG=131915 Review URL: https://chromiumcodereview.appspot.com/10882071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155243 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixes for browser that load content from file: schema while running as ChromeOS BVTs on actual HW. This CL also fixes resource calculations in TaskManagerBrowserTest.* due to the fact that we also have GPU process present on ChromeOS side. TEST=TaskManagerBrowserTest.* and bunch of other browser tests should be passing now in BVT environment. BUG=131915 Review URL: https://chromiumcodereview.appspot.com/10882071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155243 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixes for browser that load content from file: schema while running as ChromeOS BVTs on actual HW. This CL also fixes resource calculations in TaskManagerBrowserTest.* due to the fact that we also have GPU process present on ChromeOS side. TEST=TaskManagerBrowserTest.* and bunch of other browser tests should be passing now in BVT environment. BUG=131915 Review URL: https://chromiumcodereview.appspot.com/10882071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155243 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use the new favicon resources below common/, delete the old assets Consolidate to the new favicon_foo naming scheme preferred by ux. BUG=none TBR=oshima Review URL: https://chromiumcodereview.appspot.com/10909187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156252 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use the new favicon resources below common/, delete the old assets Consolidate to the new favicon_foo naming scheme preferred by ux. BUG=none TBR=oshima Review URL: https://chromiumcodereview.appspot.com/10909187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156252 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Panels refactor] Track Panels in TaskManager now that they are not under the tab contents umbrella. BUG=127323 TEST=TaskManagerBrowserTest.NoticePanelChanges Review URL: https://chromiumcodereview.appspot.com/10790062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147564 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Converted the rest of chrome except for extensions and favicons to user ImageSkia Used same conversion script as 10437006 Modified the following files afterwards: 1 chrome/browser/background/background_application_list_model.cc 2 chrome/browser/extensions/extension_install_ui.cc 3 chrome/browser/extensions/extension_install_ui.h 4 chrome/browser/speech/speech_recognition_bubble.cc 5 chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc 6 chrome/browser/speech/speech_recognition_bubble_gtk.cc 7 chrome/browser/speech/speech_recognition_tray_icon_controller.h 8 chrome/browser/task_manager/task_manager_resource_providers.cc 9 chrome/browser/ui/panels/panel_browser_frame_view.cc 10 chrome/browser/ui/search_engines/template_url_table_model.cc 11 chrome/browser/ui/search_engines/template_url_table_model.h 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/avatar_menu_button.cc 14 chrome/browser/ui/views/detachable_toolbar_view.cc 15 chrome/browser/ui/views/download/download_item_view.cc 16 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc 17 chrome/browser/ui/views/location_bar/icon_label_bubble_view.h 18 chrome/browser/ui/views/location_bar/location_bar_view.cc 19 chrome/browser/ui/views/tab_icon_view.cc 20 chrome/browser/ui/views/tab_icon_view.h 21 chrome/browser/ui/views/tabs/tab_strip.cc Include, whitespace changes in 1 chrome/browser/automation/automation_provider_observers.cc 2 chrome/browser/background/background_application_list_model.h 3 chrome/browser/background/background_mode_manager.cc 4 chrome/browser/custom_home_pages_table_model.h 5 chrome/browser/download/download_util.cc 6 chrome/browser/extensions/extension_function_dispatcher.cc 7 chrome/browser/extensions/extension_install_dialog.cc 8 chrome/browser/extensions/extension_install_dialog.h 9 chrome/browser/ntp_background_util.cc 10 chrome/browser/speech/speech_recognition_bubble.h 11 chrome/browser/task_manager/task_manager.h 12 chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc 13 chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc 14 chrome/browser/ui/cocoa/task_manager_mac.h 15 chrome/browser/ui/views/about_chrome_view.cc 16 chrome/browser/ui/views/avatar_menu_bubble_view.cc 17 chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc 18 chrome/browser/ui/views/download/download_item_view.h 19 chrome/browser/ui/views/find_bar_view.cc 20 chrome/browser/ui/views/infobars/extension_infobar.cc 21 chrome/browser/ui/views/notifications/balloon_view.cc 22 chrome/browser/ui/views/page_info_bubble_view.cc 23 chrome/browser/ui/views/tabs/base_tab.cc 24 chrome/browser/ui/views/tabs/tab.cc 25 chrome/browser/ui/views/toolbar_view.cc Review URL: https://chromiumcodereview.appspot.com/10453101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140628 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use the new favicon resources below common/, delete the old assets Consolidate to the new favicon_foo naming scheme preferred by ux. BUG=none TBR=oshima Review URL: https://chromiumcodereview.appspot.com/10909187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156252 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |