Ppkasting@chromium.orgSimplify the translate infobar code some.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Adding myself as translate owner... ... so that we don't have to disturb chrome/OWNERS for translate changes. BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10829208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150358 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Send API keys with translate API URL requests. BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10914264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156603 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PrefMember and PrefChangeRegistrar to api directory. This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove PrefService::ScheduleSavePersistentPrefs and change SavePersistentPrefs calls to CommitPendingWrites. TBR=ncarter@chromium.org BUG=99306 TEST=none Review URL: http://codereview.chromium.org/8198007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115829 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Get rid of a bunch of tab_contents.h includes from chrome. These are all trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |