Aakalin@chromium.orgRework arguments of HistoryService::AddPage()
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Remove more set noparents BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10824025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148406 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move Render(View|Widget)Host and associated classes to content namespace. TBR=jam@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9600036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 152946 - Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date. Detailed comments about the changes made in this CL can be found in the document shared separately. Previous reviewers: sky, pkasting, shess. BUG=95686, 95876, 131668 TEST=New tests added, old tests updated, all tests pass. To manually verify changes: NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider. 1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion. 2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show. 3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted. 4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP. 5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title. Previously reviewed as: http://codereview.chromium.org/10477018/. 10477018 was reverted due to memory leaks detected by build bots. Review URL: https://chromiumcodereview.appspot.com/10837244 TBR=mrossetti@chromium.org This is causing performance regressions across a range of perf bots. Review URL: https://chromiumcodereview.appspot.com/10872032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152963 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Do not open file on UI thread in VisitedLinkMaster while writing table after rebuilding. BUG=61102 Review URL: https://chromiumcodereview.appspot.com/10800005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149310 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
iwyu: Include stringprintf.h where appropriate, part 3. BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |