Aachuith@chromium.orgSupport simultaneous notification and bubble promos.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Remove Jon, add Rob. BUG= Review URL: https://chromiumcodereview.appspot.com/10928125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156135 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extracted inner class doing process dispatch. The inner class WebResourceService::UnpackerClient is dispatching a json parsing job to a subprocess. In iOS launching a subprocess is not supported. In order to replace this class on this particular platform by one doing a thread dispatch the class has been renamed and refactored in its own file. In doing so an abstract superclass was crated to make the API more obvious. The iOS subclass already exists in the iOS tree, and will be brought up with the rest of the iOS browser changes. BUG=b/6753678 TEST=No user visible changes. Review URL: https://chromiumcodereview.appspot.com/10690096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145689 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extracted inner class doing process dispatch. The inner class WebResourceService::UnpackerClient is dispatching a json parsing job to a subprocess. In iOS launching a subprocess is not supported. In order to replace this class on this particular platform by one doing a thread dispatch the class has been renamed and refactored in its own file. In doing so an abstract superclass was crated to make the API more obvious. The iOS subclass already exists in the iOS tree, and will be brought up with the rest of the iOS browser changes. BUG=b/6753678 TEST=No user visible changes. Review URL: https://chromiumcodereview.appspot.com/10690096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145689 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support simultaneous notification and bubble promos. BUG=NONE TEST=manual Review URL: https://chromiumcodereview.appspot.com/10944019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157482 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support for ntp promo bubble. BUG=123061 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10911196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156178 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix for clang chromium-style in promo. ./chrome/browser/web_resource/notification_promo_mobile_ntp.h:21:1: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. class NotificationPromoMobileNtp { BUG= Review URL: https://chromiumcodereview.appspot.com/10919049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154576 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix for clang chromium-style in promo. ./chrome/browser/web_resource/notification_promo_mobile_ntp.h:21:1: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. class NotificationPromoMobileNtp { BUG= Review URL: https://chromiumcodereview.appspot.com/10919049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154576 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support for ntp promo bubble. BUG=123061 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10911196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156178 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support for ntp promo bubble. BUG=123061 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10911196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156178 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Split JSON processing of parameters that needs to be handled by the promotion system (e.g. rollout plan parameters) from processing of promo-type-specific parameters. BUG=143692 TESTS=unit_tests, manual tests as per test plan Review URL: https://chromiumcodereview.appspot.com/10860025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153180 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Split JSON processing of parameters that needs to be handled by the promotion system (e.g. rollout plan parameters) from processing of promo-type-specific parameters. BUG=143692 TESTS=unit_tests, manual tests as per test plan Review URL: https://chromiumcodereview.appspot.com/10860025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153180 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extracted inner class doing process dispatch. The inner class WebResourceService::UnpackerClient is dispatching a json parsing job to a subprocess. In iOS launching a subprocess is not supported. In order to replace this class on this particular platform by one doing a thread dispatch the class has been renamed and refactored in its own file. In doing so an abstract superclass was crated to make the API more obvious. The iOS subclass already exists in the iOS tree, and will be brought up with the rest of the iOS browser changes. BUG=b/6753678 TEST=No user visible changes. Review URL: https://chromiumcodereview.appspot.com/10690096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145689 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable promotion system on Android BUG=b/6538616 TEST= Review URL: https://chromiumcodereview.appspot.com/10703176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146590 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |