Star0
66
代码
代码
Issues350
Pull Requests46
流水线
讨论
Wiki
分析
Star0
66
Jjoi@chromium.orgSwitching from ForXyz naming to FromXyz naming, for consistency.
8a4ac6db创建于 2012年9月23日历史提交
文件最后提交记录最后更新时间
autocomplete_syncable_service.cc
Reland r145993. Original codereview at http://codereview.chromium.org/10766016/ [Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=stevet@chromium.org, rlarocque@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10690128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autocomplete_syncable_service.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_change.cc
[Coverity] Change some pass by values to pass by const refs. CID=8501 CID=100223 R=dhollowa@chromium.org Review URL: http://codereview.chromium.org/9006038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115456 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
autofill_change.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_entry.cc
Add probability of culling if sync is enabled to https://chromiumcodereview.appspot.com/9585020/ Initially set it to 0%. Original cl: Cull autofill entries older than 60 days. Tested with 20K Autocomplete entries selected 100000 times. 500 of them are in range. ---Start MergeDataAndStartSyncing for autofill Read from db - 7s Sift through them selecting only those needed for update - ~0.5s Process 476 changes - <1s ---End MergeDataAndStartSyncing for autofill - total ~8.5 s Callback back after deleting extra entries - 17s BUG=28990 TEST=unit-test Review URL: http://codereview.chromium.org/9959086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130852 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
autofill_entry.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_entry_unittest.cc
Add probability of culling if sync is enabled to https://chromiumcodereview.appspot.com/9585020/ Initially set it to 0%. Original cl: Cull autofill entries older than 60 days. Tested with 20K Autocomplete entries selected 100000 times. 500 of them are in range. ---Start MergeDataAndStartSyncing for autofill Read from db - 7s Sift through them selecting only those needed for update - ~0.5s Process 476 changes - <1s ---End MergeDataAndStartSyncing for autofill - total ~8.5 s Callback back after deleting extra entries - 17s BUG=28990 TEST=unit-test Review URL: http://codereview.chromium.org/9959086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130852 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
autofill_profile_syncable_service.cc
base: Make ScopedVector::clear() destroy elements. This makes ScopedVector's clear() method destroy the elements before clearing the internal vector, matching the behavior of the erase() method. I'm moving clear()'s previous element-preserving behavior into a new weak_clear() method, matching weak_erase(). I'm also removing ScopedVector::reset(), as it duplicated clear()'s new behavior and isn't a part of std::vector. BUG=137909 TEST=added Review URL: https://chromiumcodereview.appspot.com/10797017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147360 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_profile_syncable_service.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_profile_syncable_service_unittest.cc
Reland r145993. Original codereview at http://codereview.chromium.org/10766016/ [Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=stevet@chromium.org, rlarocque@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10690128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_table.cc
Refactor BrowsingDataRemover creation for clarity. We currently have two constructors for BrowsingDataRemover. This CL drops down to a single, private constructor with a few more specific public Create methods. At the same time we're making that chance, we should explicitly refer to the end of time when we want to remove all browsing data from a user's machine, rather than passing in base::Time::Now() which is vulnerable to clock skew or other simply issues of asynchronocity. The new CreateForPeriod method makes that decision explicit. base::Time::Max() has the nice property that it automatically compares as greater than any reasonable time we might encounter. This means we don't have to update every subsystem that BrowsingDataRemover relies on: they can continue to do simple comparisons without the complications of special-casing the null Time. BUG=144946,130732 Review URL: https://chromiumcodereview.appspot.com/10898002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154744 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_table.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_table_unittest.cc
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_web_data_service_impl.cc
Introduce a couple of abstract bases for WebDataService. WebDataService is really a collection of different services that have a common initialization and some commonality e.g. how to cancel requests, and it's probably best that the interfaces reflect this logical split so that the implementation might some daybe tidied up. Starting this off with a WebDataServiceBase for the common bits, and an AutofillWebData for the Autofill-specific functionalities of WebDataService. Using these interfaces to break Autofill's concrete dependency on WebDataService. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10908065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156567 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill_web_data_service_impl.h
Introduce a couple of abstract bases for WebDataService. WebDataService is really a collection of different services that have a common initialization and some commonality e.g. how to cancel requests, and it's probably best that the interfaces reflect this logical split so that the implementation might some daybe tidied up. Starting this off with a WebDataServiceBase for the common bits, and an AutofillWebData for the Autofill-specific functionalities of WebDataService. Using these interfaces to break Autofill's concrete dependency on WebDataService. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10908065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156567 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
keyword_table.cc
Add a separate protector UMA state when backup is overwritten by migration. Also added a UMA-only prepopulated entry for AVG search. BUG=None TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10695115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146742 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
keyword_table.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
keyword_table_unittest.cc
Use ScopedTempDir instead of DIR_TEST_DATA for creating test data. BUG=125513 TEST=git status Review URL: https://chromiumcodereview.appspot.com/10386222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138071 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
logins_table.cc
Remove the very old code that migrated password data from the WebDataService to PasswordStore. Anybody who was going to have their data migrated has long since had it done by now. Also remove most of the code in the WebDataService that was responsible, long ago, for managing the password data stored there. Only imported IE passwords are still stored there. This change deletes over 1500 lines of old crufty code! Review URL: https://chromiumcodereview.appspot.com/10227014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134155 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
logins_table.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
logins_table_win.cc
Update webdata files to take advantage of DLOG(FATAL) in sql/Statement and Connection. R=shess@chromium.org BUG= TEST=webdata/*Test*.* Review URL: http://codereview.chromium.org/8966003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115574 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
token_service_table.cc
Update webdata files to take advantage of DLOG(FATAL) in sql/Statement and Connection. R=shess@chromium.org BUG= TEST=webdata/*Test*.* Review URL: http://codereview.chromium.org/8966003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115574 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
token_service_table.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
token_service_table_unittest.cc
Use ScopedTempDir instead of DIR_TEST_DATA for creating test data. BUG=125513 TEST=git status Review URL: https://chromiumcodereview.appspot.com/10386222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138071 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_apps_table.cc
Update webdata files to take advantage of DLOG(FATAL) in sql/Statement and Connection. R=shess@chromium.org BUG= TEST=webdata/*Test*.* Review URL: http://codereview.chromium.org/8966003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115574 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
web_apps_table.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_apps_table_unittest.cc
Use ScopedTempDir instead of DIR_TEST_DATA for creating test data. BUG=125513 TEST=git status Review URL: https://chromiumcodereview.appspot.com/10386222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138071 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_data_service.cc
Introduce a couple of abstract bases for WebDataService. WebDataService is really a collection of different services that have a common initialization and some commonality e.g. how to cancel requests, and it's probably best that the interfaces reflect this logical split so that the implementation might some daybe tidied up. Starting this off with a WebDataServiceBase for the common bits, and an AutofillWebData for the Autofill-specific functionalities of WebDataService. Using these interfaces to break Autofill's concrete dependency on WebDataService. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10908065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156567 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_data_service.h
introduce chrome/browser/common directory and move url_database(and its dependencies) This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475 c/b/common dir is for utility/library code shared by chrome browser code. BUG=144783 TBR=joi,ben Review URL: https://codereview.chromium.org/10948045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_data_service_factory.cc
Switching from ForXyz naming to FromXyz naming, for consistency. TBR=mechanicalowners@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10956034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158186 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_data_service_factory.h
Introduce a couple of abstract bases for WebDataService. WebDataService is really a collection of different services that have a common initialization and some commonality e.g. how to cancel requests, and it's probably best that the interfaces reflect this logical split so that the implementation might some daybe tidied up. Starting this off with a WebDataServiceBase for the common bits, and an AutofillWebData for the Autofill-specific functionalities of WebDataService. Using these interfaces to break Autofill's concrete dependency on WebDataService. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10908065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156567 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_data_service_test_util.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_data_service_unittest.cc
Fix for non-sticky defaults bug. Added a bunch of tests. TBR=jhawkins@chromium.org R=smckay@chromium.org,shess@chromium.org BUG=148740 Review URL: https://chromiumcodereview.appspot.com/10914278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157331 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_data_service_win.cc
Disambiguate origins of tasks posted by the WebDataService. When calling PostTask, rather than always providing the source information corresponding to ScheduleTask, use the location of the caller of ScheduleTask. This helps in disambiguating tasks in, for example, the task profiler. BUG=105921 TEST= Review URL: http://codereview.chromium.org/8745017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113032 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
web_database.cc
Fix incomplete WebDatabase migration from downgraded version. BUG=135342 TEST=WebDatabaseMigrationTest.* Review URL: https://chromiumcodereview.appspot.com/10754006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145792 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_database.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_database_migration_unittest.cc
Force WebDatabase version to max(version, compatible version) before migration. BUG=135342 TEST=WebDatabaseMigrationTest.* Review URL: https://chromiumcodereview.appspot.com/10696127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145665 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_database_table.cc
Web Intents: Hook up the register intent InfoBar with the WebIntentsRegistry. BUG=none TEST=RegisterIntentHandlerInfoBarDelegateTest.Accept R=groby@chromium.org Review URL: http://codereview.chromium.org/7601013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96449 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
web_database_table.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_intents_table.cc
Fix for non-sticky defaults bug. Added a bunch of tests. TBR=jhawkins@chromium.org R=smckay@chromium.org,shess@chromium.org BUG=148740 Review URL: https://chromiumcodereview.appspot.com/10914278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157331 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_intents_table.h
Add support for unregistering defaults by service_url. BUG=137907 Review URL: https://chromiumcodereview.appspot.com/10824212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150669 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_intents_table_unittest.cc
Fix for non-sticky defaults bug. Added a bunch of tests. TBR=jhawkins@chromium.org R=smckay@chromium.org,shess@chromium.org BUG=148740 Review URL: https://chromiumcodereview.appspot.com/10914278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157331 0039d316-1c4b-4281-b951-d872f2087c98
13 年前