Vvabr@chromium.orgThere are two blocking network delegates in url_request_unittest:
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Use HTTPS to download code. BUG=106096 Review URL: https://chromiumcodereview.appspot.com/10532016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Add Malay as a translation. The language code is ms. This adds the necessary files to generate the locale pak file. Translations will arrive later. BUG=111670 TBR=gfeher Review URL: http://codereview.chromium.org/9232056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119548 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move files related to registry-controlled domains into a new net/base/registry_controlled_domains/ subdirectory. This includes net/base/registry_controlled_domain.* and net/base/effective_tld_names* BUG=138047 TEST=covered by existing tests Review URL: https://chromiumcodereview.appspot.com/10796033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147641 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add Malay as a translation. The language code is ms. This adds the necessary files to generate the locale pak file. Translations will arrive later. BUG=111670 TBR=gfeher Review URL: http://codereview.chromium.org/9232056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119548 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
There are two blocking network delegates in url_request_unittest: BlockingNetworkDelegate and BlockingNetworkDelegateWithManualCallback They provide various functions: * blocking in various stages of the request * three ways of responding in blocked stages: synchronous, automatic callback, and user-triggered callback * redirection But not all combinations are available (e.g. synchronous blocking after headers are sent), because the user has to chose only one of the delegates. This CL aims at allowing to combine those functions without code duplication, by joining the two classes into one. BUG=146816 TEST=N/A (this is only in unittests, also no change in behaviour of any unit-test, and no new added) Historical description for this issue, remove once the current plan stabilises: ------------------------------------------------------ Adding a base class for the blocking network delegates There are two blocking network delegates in url_request_unittest: BlockingNetworkDelegate and BlockingNetworkDelegateWithManualCallback They were independent until now, but for http://codereview.chromium.org/10911151/ BlockingNetworkDelegate needs to be able to block in various stages of the request, such as BlockingNetworkDelegateWithManualCallback does. To avoid code duplication, the common functionality is here moved to a common base class BlockingNetworkDelegateBase from which the original two inherit. This adds no new functions, nor changes it the behaviour of the current tests. ------------------------------------------------------ Review URL: https://chromiumcodereview.appspot.com/10905259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158724 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix many* python scripts in src/ Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. * Do not fix them all at once otherwise the CL would be too large. TBR=jamiewalch@chromium.org BUG=105108 TEST= Review URL: http://codereview.chromium.org/8665013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111427 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fixes to address code review comments from tommi from CL http://codereview.chromium.org/1823001/show Changes include the following:- 1. Removing the IObjectWithSite::SetSite implementation from the chrome frame activex. 2. Removing the site_ member and using the ATL m_spUnkSite member. 3. Renaming the RegisterBHOIfNeeded member function to registerBhoIfNeeded to be consistent with the other methods in the IChromeFrame interface. Fixes bug http://code.google.com/p/chromium/issues/detail?id=42790 Bug=42790 TBR=tommi Review URL: http://codereview.chromium.org/1831001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46200 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Fixes CFInstance to use a longer Deferred standard timeout. Short timeouts caused cancellation of listeners and therefore backlogged RPC callback failure. The API requires that we use a timeout, but upping the default to 10s should accomidate nearly all CF startup delays. BUG=None TEST=run all the CFInstance tests in a Debug build. TBR=ananta Review URL: http://codereview.chromium.org/464077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34116 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Tighten up DEPS checking to enforce that embedders of content only include public test headers. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10515007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140296 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update Chrome Frame owners file to reflect the folk working on Chrome Frame. BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/9420010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122316 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Adding Chrome Frame metric for SetSite performance. BUG=134640 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/10704017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145086 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add two new entry points to the Chrome Frame DLL to allow for non-admin registration. BUG=53127 TEST=Can register the CF DLL with non-admin privileges when calling into the alternate registration entry points. Review URL: http://codereview.chromium.org/3190005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58197 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a helper process to Chrome Frame to allow for non-administrative installs. The helper process registers a hook dll that performs the necessary BHO injection instead of registering it in HKLM. BUG=53127 TEST=Non-admin CF installs work. Review URL: http://codereview.chromium.org/3158036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57860 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Cleanup in ProcessSingleton. These originated as candidate fixes for issue 111361, but the true fix is cpu@'s r119830. a) Unify code to retrieve HMODULE based on address in base::GetModuleFromAddress. (cpu@'s r119830 already has the fix to use the DLL's HMODULE 119830 rather than the EXE's HINSTANCE) b) Try harder to unregister the window class, by trying it first in ProcessSingleton::Cleanup, which gets called before the fast shutdown path calls ExitProcess(). Also, use correct HMODULE to unregister. c) Avoid any possibility of a race to create the message window when the Create() method is called from NotifyOtherProcessOrCreate() or from outside the class by moving the implementation of Create(), which was always called from the constructor, into the constructor and making Create() just return true or false based on the success of the work already done. BUG=111361 Review URL: http://codereview.chromium.org/9121046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121480 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
A number of poorly written IE BHO's crash IE if ChromeFrame is the currently loaded document. This is because they expect ChromeFrame to implement interfaces like IHTMLDocument2 on the same lines as regular IE documents. Currently in ChromeFrame we patch the invoke methods of these BHO's prior to firing navigation events from ChromeFrame. However this is not enough as these objects also crash for regular navigation events fired from IE when ChromeFrame is loaded. We now don't fire navigation events for buggy BHO's if ChromeFrame is the current document. The BuggyBho handler instance is now created once for the thread. We patch when we receive navigation notifications from Chrome as before. When we receive a notification on our patched event sink we check if CF is loaded and if yes skip the call. Added helpers to chrome frame utils to check if CF is loaded in the current web browser instance. BUG=55932 TEST=none Review URL: http://codereview.chromium.org/6493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74691 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Enforce that chrome_frame only uses content through its API. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9382039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121741 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Cleanup: Remove forward declarations in various directories. BUG=none TEST=none Review URL: http://codereview.chromium.org/8567022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110631 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Don't create bogus 's' key in registry during Chrome Frame registration BUG=none TEST=register Chrome Frame on a fresh machine and note that bogus key HKCR\MIME\Database\s is no longer created. Review URL: http://codereview.chromium.org/5810001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69042 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Forgot to add this to the commit enabling code coverage in the chrome_frame.gyp a little while back. BUG=0 TEST=None Review URL: http://codereview.chromium.org/3443001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59408 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Split user agent code out of the 'glue' target This creates a new user_agent component target for the user agent handling code. This makes it straightforward for iOS to build only the user-agent part of glue. It should also make incremental dismantling of webkit/ easier, since the dependencies on user agent code are now explicit. The code that was in user_agent.cc/h (the webkit_user_agent target) has been moved to user_agent_util.cc/h, and folded into the user_agent component target. All user-agent related code has been moved to a new webkit/user_agent/ directory. BUG=None Review URL: https://chromiumcodereview.appspot.com/10869073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155695 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add rudimentary support in the ChromeFrame ActiveX to enable it work in a generic client site, i.e. a non IE client site. Some of our users are creating apps which host ChromeFrame to render web pages. This enables them to use the chrome network stack by setting up a privileged chrome frame container and setting the corresponding properties on the ChromeFrame ActiveX. It mostly works well. However things like window.open break down as we need the ability in the ActiveX to be able to connect to an existing ExternalTabContainer instance. This works well in IE where the IWebBrowser implementation initiates the navigation correctly. However a generic implementation of the IWebBrowser interface does not do this. Fixes are to add a new function to the IChromeFramePrivileged interface which allows hosts to pass in the navigation url early in the lifetime of the ActiveX. In the ChromeFrame ActiveX we check if the url coming in is for an attach tab request and if so initiate the same. Fixes portions of bug https://code.google.com/p/chromium/issues/detail?id=137335 BUG=137335 Review URL: https://chromiumcodereview.appspot.com/10783007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147109 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add rudimentary support in the ChromeFrame ActiveX to enable it work in a generic client site, i.e. a non IE client site. Some of our users are creating apps which host ChromeFrame to render web pages. This enables them to use the chrome network stack by setting up a privileged chrome frame container and setting the corresponding properties on the ChromeFrame ActiveX. It mostly works well. However things like window.open break down as we need the ability in the ActiveX to be able to connect to an existing ExternalTabContainer instance. This works well in IE where the IWebBrowser implementation initiates the navigation correctly. However a generic implementation of the IWebBrowser interface does not do this. Fixes are to add a new function to the IChromeFramePrivileged interface which allows hosts to pass in the navigation url early in the lifetime of the ActiveX. In the ChromeFrame ActiveX we check if the url coming in is for an attach tab request and if so initiate the same. Fixes portions of bug https://code.google.com/p/chromium/issues/detail?id=137335 BUG=137335 Review URL: https://chromiumcodereview.appspot.com/10783007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147109 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix in-use updates for Chrome Frame. On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome. In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done. BUG=95810 TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF. If all goes well, you won't see an IE security prompt. Review URL: http://codereview.chromium.org/7976045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102569 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Purge ImplementsThreadSafeReferenceCounting() from the codebase now that Task is dead. TBR=ananta@chromium.org,apatrick@chromium.org Review URL: https://chromiumcodereview.appspot.com/10836116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150202 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl Summary: UploadData::GetContentLengthSync() call is removed from ResourceDispatcherHostImpl. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress. A new member 'upload_size' is added to AutomationURLResponse for Chrome Frame. content::ResourceDispatcherHostImpl has been using UploadData::GetContentLengthSync() which needs ScopedAllowIO. To stop using ScopedAllowIO, there were three options considered. 1. Use asynchronous version UploadData::GetContentLength() which does not need ScopedAllowIO. pros: Changes would be minimal and straight-forward. cons: GetContentLength() is also called in UploadDataStream::Init(). If we start reusing the value, there is no need to call the same method here. 2. Communicate the upload data size to ResourceDispatcherHost by adding an event OnRequestBodyInitialized() to URLRequest::Delegate. pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). cons: Complicated interface. 3. Return upload data size as well as upload progress from URLRequest::GetUploadProgress(). pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). Simple interface. Making sense because upload progress and upload size are almost always used together (see ResourceHandler::OnUploadProgress and DOM ProgressEvent as examples). cons: Polling upload data size may imply that the size may change. We've decided to go with #3. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress, and URLRequest::GetUploadProgress() is used to get the upload size from ResourceDispatcherHostImpl instead of UploadData::GetContentLengthSync(). In Chrome Frame, URLRequestAutomationJob is used instead of URLRequestHttpJob and UploadDataStream is not initialized in the browser process. This is problematic since we cannot know the size of upload data without UploadDataStream. To deal with this, a new member 'upload_size' is added to AutomationURLResponse and the value is used to implement URLRequestAutomationJob::GetUploadProgress(). BUG=112607 TEST=Can upload files Review URL: https://chromiumcodereview.appspot.com/10825073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154286 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl Summary: UploadData::GetContentLengthSync() call is removed from ResourceDispatcherHostImpl. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress. A new member 'upload_size' is added to AutomationURLResponse for Chrome Frame. content::ResourceDispatcherHostImpl has been using UploadData::GetContentLengthSync() which needs ScopedAllowIO. To stop using ScopedAllowIO, there were three options considered. 1. Use asynchronous version UploadData::GetContentLength() which does not need ScopedAllowIO. pros: Changes would be minimal and straight-forward. cons: GetContentLength() is also called in UploadDataStream::Init(). If we start reusing the value, there is no need to call the same method here. 2. Communicate the upload data size to ResourceDispatcherHost by adding an event OnRequestBodyInitialized() to URLRequest::Delegate. pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). cons: Complicated interface. 3. Return upload data size as well as upload progress from URLRequest::GetUploadProgress(). pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). Simple interface. Making sense because upload progress and upload size are almost always used together (see ResourceHandler::OnUploadProgress and DOM ProgressEvent as examples). cons: Polling upload data size may imply that the size may change. We've decided to go with #3. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress, and URLRequest::GetUploadProgress() is used to get the upload size from ResourceDispatcherHostImpl instead of UploadData::GetContentLengthSync(). In Chrome Frame, URLRequestAutomationJob is used instead of URLRequestHttpJob and UploadDataStream is not initialized in the browser process. This is problematic since we cannot know the size of upload data without UploadDataStream. To deal with this, a new member 'upload_size' is added to AutomationURLResponse and the value is used to implement URLRequestAutomationJob::GetUploadProgress(). BUG=112607 TEST=Can upload files Review URL: https://chromiumcodereview.appspot.com/10825073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154286 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add arguments in macros where required This was breaking a variant of the current macro, so I defined a no-op for the "code" values. r=slightlyoff BUG=103830 Review URL: http://codereview.chromium.org/8511083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110585 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix in-use updates for Chrome Frame. On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome. In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done. BUG=95810 TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF. If all goes well, you won't see an IE security prompt. Review URL: http://codereview.chromium.org/7976045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102569 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a helper process to Chrome Frame to allow for non-administrative installs. The helper process registers a hook dll that performs the necessary BHO injection instead of registering it in HKLM. BUG=53127 TEST=Non-admin CF installs work. Review URL: http://codereview.chromium.org/3158036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57860 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add a helper process to Chrome Frame to allow for non-administrative installs. The helper process registers a hook dll that performs the necessary BHO injection instead of registering it in HKLM. BUG=53127 TEST=Non-admin CF installs work. Review URL: http://codereview.chromium.org/3158036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57860 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Fix up crash reporting in unit tests and the Chrome Frame helper processes: Bother to initialize crash reporting in chrome_frame_tests.exe. Correctly construct the crash reporting pipe name for non-admin installs. BUG=86846 TEST=Crash dumps are reported when running Chrome Frame tests in headless mode, user-level Chrome Frame helper processes connect to the crash service. Review URL: http://codereview.chromium.org/7219007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90255 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a self-destruct mechanism to user-level Chrome Frame when it detects that system-level Chrome Frame is present. This is a first step to handling user-to-system-level handoff. It will cause a user-level install to be correctly replaced with a system-level one once the user logs out and back in again. Additional changelists will follow that: 1) Ensure full clean-up of the user-level installation. 2) Handle notifications such that logging out and in again isn't required. BUG=82816 TEST=Install user-level Chrome Frame. Review URL: http://codereview.chromium.org/7065024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87033 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make version info get stored in the correct resource for chrome_frame_helper.exe and chrome_frame_helper.dll. Switch to using '1' as the version resource name since that is less fragile against #include path mix ups, etc. BUG=65354 TEST=NONE Review URL: http://codereview.chromium.org/7324054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92053 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chrome via Group Policy. BUG=116783 TEST=See information in comment #5 of the issue. Review URL: https://chromiumcodereview.appspot.com/9836037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129384 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add two new entry points to the Chrome Frame DLL to allow for non-admin registration. BUG=53127 TEST=Can register the CF DLL with non-admin privileges when calling into the alternate registration entry points. Review URL: http://codereview.chromium.org/3190005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58197 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove includes of message headers in headers. Review URL: http://codereview.chromium.org/6458004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74257 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h. This addresses a long-standing TODO. Cleanup is good for the soul. BUG=none Review URL: http://codereview.chromium.org/10197011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135145 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move base/win_util to the base/win directory and use the base::win namespace. Fix up includes, many files including base/win_util don't actually need it. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70341 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Committing for Steven who got LGTM from here: http://codereview.chromium.org/264068 BUG=none TEST=none Review URL: http://codereview.chromium.org/276050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29196 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Enable crash reporting for chrome frame unit tests. This ensures that crashes are reported for chrome frame unit test runs. BUG=86846 TEST=Crash dumps are reported when running Chrome Frame unit tests in headless mode. Review URL: http://codereview.chromium.org/7259009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90597 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chrome via Group Policy. BUG=116783 TEST=See information in comment #5 of the issue. Review URL: https://chromiumcodereview.appspot.com/9836037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129384 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Rewrite of chrome_launcher.exe. ETW-based perf tests suggest that this is on average about 50% faster than the previous version. Review URL: http://codereview.chromium.org/2278003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48500 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Fix up crash reporting in unit tests and the Chrome Frame helper processes: Bother to initialize crash reporting in chrome_frame_tests.exe. Correctly construct the crash reporting pipe name for non-admin installs. BUG=86846 TEST=Crash dumps are reported when running Chrome Frame tests in headless mode, user-level Chrome Frame helper processes connect to the crash service. Review URL: http://codereview.chromium.org/7219007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90255 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Don't allow Chrome to go into background mode when launched by GCF. Doing so is broken in at least a few ways: - in-use updates don't work as desired (must quit IE for 6h) - there's no UX for quitting Chrome Since extensions aren't really supported in GCF anyway, I don't see a problem with disallowing background mode. BUG=97740 TEST=the easy way: fire up IE and visit gcf:about:version, confirm that --disable-background-mode is on the command line. the hard way: install a background extension via the registry mechanism then launch IE and visit gcf:about:version. now check to see if you have an extension process. if so, see that quitting IE makes all chrome.exe processes disappear. Review URL: http://codereview.chromium.org/8070019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103277 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chrome via Group Policy. BUG=116783 TEST=See information in comment #5 of the issue. Review URL: https://chromiumcodereview.appspot.com/9836037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129384 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the \servers build output directory and place Chrome Frame parts into the root output folder next to chrome.exe et al. Also add a more helpful error message when failing to register the Chrome Frame dll. Review URL: http://codereview.chromium.org/8013001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102780 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add version information to chrome_launcher.exe. BUG=35036 TEST=Check chrome_launcher.exe properties, check that it has version information. Review URL: http://codereview.chromium.org/2497001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48724 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Convert LOG(INFO) to VLOG(1) - chrome_frame/. Plus a couple misc. cleanups. BUG=none TEST=none Review URL: http://codereview.chromium.org/3850002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63095 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add two new entry points to the Chrome Frame DLL to allow for non-admin registration. BUG=53127 TEST=Can register the CF DLL with non-admin privileges when calling into the alternate registration entry points. Review URL: http://codereview.chromium.org/3190005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58197 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Use a different algorithm with the low entropy source for field trials. The new algorithm maps the original 13-bit low entropy source to a new 13-bit entropy value using a mapping that is shuffled using the trial name as a seed. The algorithm is roughly as follows: Take the low entropy source as an integer between 0-8191. Generate an identity mapping of size 8192 where mapping[i] == i. Seed a Mersenne Twister random number generator with the hash of the field trial name. Use the seeded random number generator to shuffle the mapping array. Map the low entropy source using the mapping array, i.e. entropy' = mapping[entropy]. Divide the resulting entropy' by 8192 to produce a double in the range of [0, 1) that will be used for bucketing in field_trial.cc. The above algorithm improves uniformity over the existing entropy provider when the 13-bit entropy source is used while still providing very little overlaps of buckets between different field trials. Adds third_party library mt19937ar, an implementation of Mersenne Twister, for the seeded random number generation. This is needed until C++11 becomes available for use in Chromium, at which point C++11's <random> could be used. BUG=143239 TEST=Unit tests. Additionally, verified that the new algorithm produces uniform results with very little overlap of buckets between different field trials. Review URL: https://chromiumcodereview.appspot.com/10830318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153322 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove 1) NPAPI support from Chrome Frame and 2) Firefox/Opera/Safari tests. BUG=none TEST=automated testing should suffice R=ananta@chromium.org,robertshield@chromium.org Review URL: http://codereview.chromium.org/7276037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90914 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add rudimentary support in the ChromeFrame ActiveX to enable it work in a generic client site, i.e. a non IE client site. Some of our users are creating apps which host ChromeFrame to render web pages. This enables them to use the chrome network stack by setting up a privileged chrome frame container and setting the corresponding properties on the ChromeFrame ActiveX. It mostly works well. However things like window.open break down as we need the ability in the ActiveX to be able to connect to an existing ExternalTabContainer instance. This works well in IE where the IWebBrowser implementation initiates the navigation correctly. However a generic implementation of the IWebBrowser interface does not do this. Fixes are to add a new function to the IChromeFramePrivileged interface which allows hosts to pass in the navigation url early in the lifetime of the ActiveX. In the ChromeFrame ActiveX we check if the url coming in is for an attach tab request and if so initiate the same. Fixes portions of bug https://code.google.com/p/chromium/issues/detail?id=137335 BUG=137335 Review URL: https://chromiumcodereview.appspot.com/10783007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147109 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add two new entry points to the Chrome Frame DLL to allow for non-admin registration. BUG=53127 TEST=Can register the CF DLL with non-admin privileges when calling into the alternate registration entry points. Review URL: http://codereview.chromium.org/3190005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58197 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Make version info get stored in the correct resource for chrome_frame_helper.exe and chrome_frame_helper.dll. Switch to using '1' as the version resource name since that is less fragile against #include path mix ups, etc. BUG=65354 TEST=NONE Review URL: http://codereview.chromium.org/7324054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92053 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Committing for jeffbailey. Excerpt from: http://codereview.chromium.org/1991004/show ---------------- Put version information into header file for easy consumption by RC files. RC files can use an #include to pull in this header, rather than being each dynamically generated. BUG=none TEST=none ---------------- Review URL: http://codereview.chromium.org/2020003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46736 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Allow linker initialization of lazy instance Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix many* python scripts in src/ Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. * Do not fix them all at once otherwise the CL would be too large. TBR=jamiewalch@chromium.org BUG=105108 TEST= Review URL: http://codereview.chromium.org/8665013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111427 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix up crash reporting in unit tests and the Chrome Frame helper processes: Bother to initialize crash reporting in chrome_frame_tests.exe. Correctly construct the crash reporting pipe name for non-admin installs. BUG=86846 TEST=Crash dumps are reported when running Chrome Frame tests in headless mode, user-level Chrome Frame helper processes connect to the crash service. Review URL: http://codereview.chromium.org/7219007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90255 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix up crash reporting in unit tests and the Chrome Frame helper processes: Bother to initialize crash reporting in chrome_frame_tests.exe. Correctly construct the crash reporting pipe name for non-admin installs. BUG=86846 TEST=Crash dumps are reported when running Chrome Frame tests in headless mode, user-level Chrome Frame helper processes connect to the crash service. Review URL: http://codereview.chromium.org/7219007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90255 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
base::Bind: Remove includes of base.bind in header files. BUG=none TEST=none R=ajwong Review URL: http://codereview.chromium.org/8956019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115398 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove task.h and finish base::Bind() migration. Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move browsing_data_helper files into a separate directory. BUG=121862 TEST=existing unit_tests TBR=eroman@chromium.org,sky@chromium.org,erg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10805015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147504 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Prevent redirector from returning the current module in cases where it fails to look up the first module in. This prevents a bug that can cause user-level Chrome Frame to redirect to itself when a system-level Chrome Frame is present. BUG=96016 TEST=Upgrade a user-level CF install to a system-level CF install while user-level CF is rendering. Observe that the current explorer instance does not hang when new CF tabs are created. Review URL: http://codereview.chromium.org/7866043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100904 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a helper process to Chrome Frame to allow for non-administrative installs. The helper process registers a hook dll that performs the necessary BHO injection instead of registering it in HKLM. BUG=53127 TEST=Non-admin CF installs work. Review URL: http://codereview.chromium.org/3158036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57860 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add a helper process to Chrome Frame to allow for non-administrative installs. The helper process registers a hook dll that performs the necessary BHO injection instead of registering it in HKLM. BUG=53127 TEST=Non-admin CF installs work. Review URL: http://codereview.chromium.org/3158036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57860 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Avoid reporting crashes for exceptions that hit our SEH from calls to the original implementation of BindToStorage() when we do not wrap the bind status callback. BUG=42660 TEST=Induce exception in code called under original IMoniker::BindToStorage implementation when we don't wrap the callback and notice that no crash is reported. Review URL: http://codereview.chromium.org/1748016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46176 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Avoid reporting crashes for exceptions that hit our SEH from calls to the original implementation of BindToStorage() when we do not wrap the bind status callback. BUG=42660 TEST=Induce exception in code called under original IMoniker::BindToStorage implementation when we don't wrap the callback and notice that no crash is reported. Review URL: http://codereview.chromium.org/1748016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46176 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
MASM 10.0 fixes a problem introduced in 8.0 with extra underscore added. BUG=71145 TEST=Compile & link cleanly Review URL: http://codereview.chromium.org/6352023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72981 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Fix for the ChromeFrame DownloadFromForm test failures on the IE9 builder. This test causes the latest IE9 developer preview version to crash. Reason being a change in the interface implementing the NavigateWithBindCtx2 method. BUG=none TEST=Covered by existing DownloadFromForm test. TBR=amit Review URL: http://codereview.chromium.org/6253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71532 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Move guid generation from chrome/common/ to base/. It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correctly handle FindNext from the Find dialog. Also handle unselecting the current selection when the Find dialog is dismissed. BUG=112193 TEST=Open the find dialog in CF, search for the same string twice. Review URL: http://codereview.chromium.org/9700053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126904 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Remove obsolete base/lock.h and fix up callers to use the new header file and the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
FBTF: Remove unneeded headers from base/ (part 7) BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Enable warning 4389 as an error on windows builds. This will make windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Split user agent code out of the 'glue' target This creates a new user_agent component target for the user agent handling code. This makes it straightforward for iOS to build only the user-agent part of glue. It should also make incremental dismantling of webkit/ easier, since the dependencies on user agent code are now explicit. The code that was in user_agent.cc/h (the webkit_user_agent target) has been moved to user_agent_util.cc/h, and folded into the user_agent component target. All user-agent related code has been moved to a new webkit/user_agent/ directory. BUG=None Review URL: https://chromiumcodereview.appspot.com/10869073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155695 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add a setting to CF to remove 'chromeframe' from the UserAgent on a per-pattern basis. Useful for testing and dealing with sites with broken UA parsing. BUG=117157 TEST=chrome_frame_tests,chrome_frame_unittests,add a ExcludeUAFromDomain key to the CF settings, add some pattern values, observe that the UA string does not contain CF. Review URL: http://codereview.chromium.org/9720001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129985 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a setting to CF to remove 'chromeframe' from the UserAgent on a per-pattern basis. Useful for testing and dealing with sites with broken UA parsing. BUG=117157 TEST=chrome_frame_tests,chrome_frame_unittests,add a ExcludeUAFromDomain key to the CF settings, add some pattern values, observe that the UA string does not contain CF. Review URL: http://codereview.chromium.org/9720001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129985 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Initialize StatisticsRecorder in Child Process to hold all histograms in child processes. Made StatisticsRecorder a leaky lazy singleton. R=jar@chromium.org, jam@chromium.org BUG=114013 TEST=renderer histograms should still work. Review URL: https://chromiumcodereview.appspot.com/10779040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147501 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
SampleSet -> HistogramSamples which can be reused by SparseHistogram BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing a regression introduced with r69101, which now prevents Chrome Frame from loading chrome extension URL in privileged mode using the NPAPI plugin. The behaviour that was implemented only for the ActiveX control has been moved into the base class NavigationConstraintsImpl, which both the ActieX and NPAPI plugin derive from. TEST=Added new unit tests for this case BUG=0 Review URL: http://codereview.chromium.org/5814004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69257 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove 1) NPAPI support from Chrome Frame and 2) Firefox/Opera/Safari tests. BUG=none TEST=automated testing should suffice R=ananta@chromium.org,robertshield@chromium.org Review URL: http://codereview.chromium.org/7276037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90914 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
net: Move file operation code from UploadData to UploadDataStream ResetOffset(), GetContentLength() and IsInMemory() are moved from UploadData to UploadDataStream. This is an intermediate step to make simlar change to UploadElement BUG=72001 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10878082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154594 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl Summary: UploadData::GetContentLengthSync() call is removed from ResourceDispatcherHostImpl. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress. A new member 'upload_size' is added to AutomationURLResponse for Chrome Frame. content::ResourceDispatcherHostImpl has been using UploadData::GetContentLengthSync() which needs ScopedAllowIO. To stop using ScopedAllowIO, there were three options considered. 1. Use asynchronous version UploadData::GetContentLength() which does not need ScopedAllowIO. pros: Changes would be minimal and straight-forward. cons: GetContentLength() is also called in UploadDataStream::Init(). If we start reusing the value, there is no need to call the same method here. 2. Communicate the upload data size to ResourceDispatcherHost by adding an event OnRequestBodyInitialized() to URLRequest::Delegate. pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). cons: Complicated interface. 3. Return upload data size as well as upload progress from URLRequest::GetUploadProgress(). pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). Simple interface. Making sense because upload progress and upload size are almost always used together (see ResourceHandler::OnUploadProgress and DOM ProgressEvent as examples). cons: Polling upload data size may imply that the size may change. We've decided to go with #3. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress, and URLRequest::GetUploadProgress() is used to get the upload size from ResourceDispatcherHostImpl instead of UploadData::GetContentLengthSync(). In Chrome Frame, URLRequestAutomationJob is used instead of URLRequestHttpJob and UploadDataStream is not initialized in the browser process. This is problematic since we cannot know the size of upload data without UploadDataStream. To deal with this, a new member 'upload_size' is added to AutomationURLResponse and the value is used to implement URLRequestAutomationJob::GetUploadProgress(). BUG=112607 TEST=Can upload files Review URL: https://chromiumcodereview.appspot.com/10825073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154286 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chrome via Group Policy. BUG=116783 TEST=See information in comment #5 of the issue. Review URL: https://chromiumcodereview.appspot.com/9836037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129384 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chrome via Group Policy. BUG=116783 TEST=See information in comment #5 of the issue. Review URL: https://chromiumcodereview.appspot.com/9836037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129384 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Properly clear URL on BINDSTATUS_REDIRECTING R=ananta@chromium.org BUG=84109 TEST=none Review URL: http://codereview.chromium.org/6962028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86984 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
First step for cleaning registration code for ChromeFrame. Create separate RGS file for registering CLSID as a BHO. Remove the code that manually did the BHO registration. BUG=48987 Review URL: http://codereview.chromium.org/3029007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53040 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Add a setting to CF to remove 'chromeframe' from the UserAgent on a per-pattern basis. Useful for testing and dealing with sites with broken UA parsing. BUG=117157 TEST=chrome_frame_tests,chrome_frame_unittests,add a ExcludeUAFromDomain key to the CF settings, add some pattern values, observe that the UA string does not contain CF. Review URL: http://codereview.chromium.org/9720001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129985 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add a self-destruct mechanism to user-level Chrome Frame when it detects that system-level Chrome Frame is present. This is a first step to handling user-to-system-level handoff. It will cause a user-level install to be correctly replaced with a system-level one once the user logs out and back in again. Additional changelists will follow that: 1) Ensure full clean-up of the user-level installation. 2) Handle notifications such that logging out and in again isn't required. BUG=82816 TEST=Install user-level Chrome Frame. Review URL: http://codereview.chromium.org/7065024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87033 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a self-destruct mechanism to user-level Chrome Frame when it detects that system-level Chrome Frame is present. This is a first step to handling user-to-system-level handoff. It will cause a user-level install to be correctly replaced with a system-level one once the user logs out and back in again. Additional changelists will follow that: 1) Ensure full clean-up of the user-level installation. 2) Handle notifications such that logging out and in again isn't required. BUG=82816 TEST=Install user-level Chrome Frame. Review URL: http://codereview.chromium.org/7065024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87033 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Split user agent code out of the 'glue' target This creates a new user_agent component target for the user agent handling code. This makes it straightforward for iOS to build only the user-agent part of glue. It should also make incremental dismantling of webkit/ easier, since the dependencies on user agent code are now explicit. The code that was in user_agent.cc/h (the webkit_user_agent target) has been moved to user_agent_util.cc/h, and folded into the user_agent component target. All user-agent related code has been moved to a new webkit/user_agent/ directory. BUG=None Review URL: https://chromiumcodereview.appspot.com/10869073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155695 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Add methods to add DataPack from open files On Android, renderer sandboxing prevents us from opening files and so ResourceBundle is initialized with file descriptors passed in at process creation. This change adds methods to DataPack and ResourceBundle to support loading/initializing from PlatformFile in addition to the current FilePath. Also, the current methods are renamed so that the naming is consistent between these two files. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10686005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145927 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Load both language packs and the resource dlls in ChromeFrame and look for localized strings in the language pack and the other resources like dialogs in the dll. The latter part is done automatically by ATL. BUG=94362 TEST=No change in behavior. The resources should continue to load as before. Review URL: http://codereview.chromium.org/7763006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98502 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Set svn:executable on windows executables. Remove third_party/tlslite/installers/ TBR=thestig@chromium.org BUG= TEST= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10178018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134316 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch renderer in Moniker patch Step one of the changes. Inspect data and cause a switch in the moniker patch. Review URL: http://codereview.chromium.org/1589013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44038 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the comments setting emands and vim tab width and expansion variables. These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove obsolete base/lock.h and fix up callers to use the new header file and the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Use callback_forward.h instead of callback.h where possible. callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=ben@chromium.org Review URL: http://codereview.chromium.org/8699008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112243 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove task.h and finish base::Bind() migration. Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to TimeDelta interfaces in chrome automation test infrastructure. This is a resubmit of a previously reverted commit: https://chromiumcodereview.appspot.com/10736064/ BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10787010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147700 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Spawn a new process to register and unregister DLLs. In component=shared_library builds, it isn't safe to load npchrome_frame.dll into a process that has its own AtExit manager, singletons, logging, etc. So now spin off a new run of the given test executable to do the registration. BUG=110492 TEST=none (covered by cf_win trybot) Review URL: https://chromiumcodereview.appspot.com/9146054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119049 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
Make google_update.gyp write shared files to SHARED_INTERMEDIATE_DIR BUG=97186 Review URL: http://codereview.chromium.org/9371010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121396 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Allow linker initialization of lazy instance Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move thread local stuff from base to base/threading and consistently use the base namespace. This also fixes references to TLSSlot to base::ThreadLocalStorage::Slot. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5986012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70322 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
net: Make UploadDataStream::Init() asynchronous. Rename the existing synchronous version to InitSync() and add a new asynchronous version, Init(). However, the new asynchronous version is not used yet. The existing code is changed to use the synchronous version. BUG=72001 TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/10913179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157344 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Remove unneeded scoped_ptr.h includes from net. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10383229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137636 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl Summary: UploadData::GetContentLengthSync() call is removed from ResourceDispatcherHostImpl. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress. A new member 'upload_size' is added to AutomationURLResponse for Chrome Frame. content::ResourceDispatcherHostImpl has been using UploadData::GetContentLengthSync() which needs ScopedAllowIO. To stop using ScopedAllowIO, there were three options considered. 1. Use asynchronous version UploadData::GetContentLength() which does not need ScopedAllowIO. pros: Changes would be minimal and straight-forward. cons: GetContentLength() is also called in UploadDataStream::Init(). If we start reusing the value, there is no need to call the same method here. 2. Communicate the upload data size to ResourceDispatcherHost by adding an event OnRequestBodyInitialized() to URLRequest::Delegate. pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). cons: Complicated interface. 3. Return upload data size as well as upload progress from URLRequest::GetUploadProgress(). pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). Simple interface. Making sense because upload progress and upload size are almost always used together (see ResourceHandler::OnUploadProgress and DOM ProgressEvent as examples). cons: Polling upload data size may imply that the size may change. We've decided to go with #3. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress, and URLRequest::GetUploadProgress() is used to get the upload size from ResourceDispatcherHostImpl instead of UploadData::GetContentLengthSync(). In Chrome Frame, URLRequestAutomationJob is used instead of URLRequestHttpJob and UploadDataStream is not initialized in the browser process. This is problematic since we cannot know the size of upload data without UploadDataStream. To deal with this, a new member 'upload_size' is added to AutomationURLResponse and the value is used to implement URLRequestAutomationJob::GetUploadProgress(). BUG=112607 TEST=Can upload files Review URL: https://chromiumcodereview.appspot.com/10825073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154286 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl Summary: UploadData::GetContentLengthSync() call is removed from ResourceDispatcherHostImpl. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress. A new member 'upload_size' is added to AutomationURLResponse for Chrome Frame. content::ResourceDispatcherHostImpl has been using UploadData::GetContentLengthSync() which needs ScopedAllowIO. To stop using ScopedAllowIO, there were three options considered. 1. Use asynchronous version UploadData::GetContentLength() which does not need ScopedAllowIO. pros: Changes would be minimal and straight-forward. cons: GetContentLength() is also called in UploadDataStream::Init(). If we start reusing the value, there is no need to call the same method here. 2. Communicate the upload data size to ResourceDispatcherHost by adding an event OnRequestBodyInitialized() to URLRequest::Delegate. pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). cons: Complicated interface. 3. Return upload data size as well as upload progress from URLRequest::GetUploadProgress(). pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). Simple interface. Making sense because upload progress and upload size are almost always used together (see ResourceHandler::OnUploadProgress and DOM ProgressEvent as examples). cons: Polling upload data size may imply that the size may change. We've decided to go with #3. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress, and URLRequest::GetUploadProgress() is used to get the upload size from ResourceDispatcherHostImpl instead of UploadData::GetContentLengthSync(). In Chrome Frame, URLRequestAutomationJob is used instead of URLRequestHttpJob and UploadDataStream is not initialized in the browser process. This is problematic since we cannot know the size of upload data without UploadDataStream. To deal with this, a new member 'upload_size' is added to AutomationURLResponse and the value is used to implement URLRequestAutomationJob::GetUploadProgress(). BUG=112607 TEST=Can upload files Review URL: https://chromiumcodereview.appspot.com/10825073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154286 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Purge ImplementsThreadSafeReferenceCounting() from the codebase now that Task is dead. TBR=ananta@chromium.org,apatrick@chromium.org Review URL: https://chromiumcodereview.appspot.com/10836116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150202 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing missed deallocation of pointer from FileVersionInfo::CreateFileVersionInfoForCurrentModule(). BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10910257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156952 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h. This addresses a long-standing TODO. Cleanup is good for the soul. BUG=none Review URL: http://codereview.chromium.org/10197011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135145 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove obsolete base/lock.h and fix up callers to use the new header file and the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Change over IgnoreReturn to IgnoreResult. remove IgnoreReturn. BUG=98919 TEST=existing Review URL: http://codereview.chromium.org/9111032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116631 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 |