Vvabr@chromium.orgThere are two blocking network delegates in url_request_unittest:
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Set svn:executable on windows executables. Remove third_party/tlslite/installers/ TBR=thestig@chromium.org BUG= TEST= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10178018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134316 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Initial import of the Chrome Frame codebase. Integration in chrome.gyp coming in a separate CL. BUG=None TEST=None Review URL: http://codereview.chromium.org/218019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27042 0039d316-1c4b-4281-b951-d872f2087c98 | 16 年前 | |
There are two blocking network delegates in url_request_unittest: BlockingNetworkDelegate and BlockingNetworkDelegateWithManualCallback They provide various functions: * blocking in various stages of the request * three ways of responding in blocked stages: synchronous, automatic callback, and user-triggered callback * redirection But not all combinations are available (e.g. synchronous blocking after headers are sent), because the user has to chose only one of the delegates. This CL aims at allowing to combine those functions without code duplication, by joining the two classes into one. BUG=146816 TEST=N/A (this is only in unittests, also no change in behaviour of any unit-test, and no new added) Historical description for this issue, remove once the current plan stabilises: ------------------------------------------------------ Adding a base class for the blocking network delegates There are two blocking network delegates in url_request_unittest: BlockingNetworkDelegate and BlockingNetworkDelegateWithManualCallback They were independent until now, but for http://codereview.chromium.org/10911151/ BlockingNetworkDelegate needs to be able to block in various stages of the request, such as BlockingNetworkDelegateWithManualCallback does. To avoid code duplication, the common functionality is here moved to a common base class BlockingNetworkDelegateBase from which the original two inherit. This adds no new functions, nor changes it the behaviour of the current tests. ------------------------------------------------------ Review URL: https://chromiumcodereview.appspot.com/10905259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158724 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to TimeDelta interfaces in chrome automation test infrastructure. This is a resubmit of a previously reverted commit: https://chromiumcodereview.appspot.com/10736064/ BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10787010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147700 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to TimeDelta interfaces in chrome automation test infrastructure. This is a resubmit of a previously reverted commit: https://chromiumcodereview.appspot.com/10736064/ BUG=108171 Review URL: https://chromiumcodereview.appspot.com/10787010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147700 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl Summary: UploadData::GetContentLengthSync() call is removed from ResourceDispatcherHostImpl. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress. A new member 'upload_size' is added to AutomationURLResponse for Chrome Frame. content::ResourceDispatcherHostImpl has been using UploadData::GetContentLengthSync() which needs ScopedAllowIO. To stop using ScopedAllowIO, there were three options considered. 1. Use asynchronous version UploadData::GetContentLength() which does not need ScopedAllowIO. pros: Changes would be minimal and straight-forward. cons: GetContentLength() is also called in UploadDataStream::Init(). If we start reusing the value, there is no need to call the same method here. 2. Communicate the upload data size to ResourceDispatcherHost by adding an event OnRequestBodyInitialized() to URLRequest::Delegate. pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). cons: Complicated interface. 3. Return upload data size as well as upload progress from URLRequest::GetUploadProgress(). pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). Simple interface. Making sense because upload progress and upload size are almost always used together (see ResourceHandler::OnUploadProgress and DOM ProgressEvent as examples). cons: Polling upload data size may imply that the size may change. We've decided to go with #3. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress, and URLRequest::GetUploadProgress() is used to get the upload size from ResourceDispatcherHostImpl instead of UploadData::GetContentLengthSync(). In Chrome Frame, URLRequestAutomationJob is used instead of URLRequestHttpJob and UploadDataStream is not initialized in the browser process. This is problematic since we cannot know the size of upload data without UploadDataStream. To deal with this, a new member 'upload_size' is added to AutomationURLResponse and the value is used to implement URLRequestAutomationJob::GetUploadProgress(). BUG=112607 TEST=Can upload files Review URL: https://chromiumcodereview.appspot.com/10825073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154286 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add base::RunLoop and update ui_test_utils to use it to reduce flakiness Timeout flakiness has been observed in multiple tests that use Quit. This changes various test utility APIs to use QuitNow via base::RunLoop instead. Some instances of Quit are left as-is where it appears they may have a use case. The ui_test_utils QuitThisRunLoop function does a safer form of MessageLoop::QuitWhenIdle that allows a few generations of tasks to run before actually quitting the MessageLoop. This addresses the design assumptions of many existing tests while hopefully reducing flaky timeouts by moving away from QuitWhenIdle. This fixes throughput_tests.cc which is currently timing out on Mac. BUG=124906,130141,131220,128305,132932 Review URL: https://chromiumcodereview.appspot.com/10479018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144824 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h. This addresses a long-standing TODO. Cleanup is good for the soul. BUG=none Review URL: http://codereview.chromium.org/10197011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135145 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Try 2 - Change how ui::Clipboard is accessed so there's only one per thread. Currently, there can be any number of Clipboard objects, which can be massively simplified. This removes interfaces for fetching the Clipboard and makes everyone go through a single static ui::Clipboard::GetForCurrentThread() access point. [Differences from the first patch: this may fix the pdf tests, but since I have no way to run them locally or on a trybot, this is going in blind.] BUG=130805 R=jam@chromium.org TBR=tc,ben,dcheng,kaiwang First Review URL: https://chromiumcodereview.appspot.com/10911074 Review URL: https://chromiumcodereview.appspot.com/10916214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156027 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add base::RunLoop and update ui_test_utils to use it to reduce flakiness Timeout flakiness has been observed in multiple tests that use Quit. This changes various test utility APIs to use QuitNow via base::RunLoop instead. Some instances of Quit are left as-is where it appears they may have a use case. The ui_test_utils QuitThisRunLoop function does a safer form of MessageLoop::QuitWhenIdle that allows a few generations of tasks to run before actually quitting the MessageLoop. This addresses the design assumptions of many existing tests while hopefully reducing flaky timeouts by moving away from QuitWhenIdle. This fixes throughput_tests.cc which is currently timing out on Mac. BUG=124906,130141,131220,128305,132932 Review URL: https://chromiumcodereview.appspot.com/10479018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144824 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
More non-debug logging in Chrome Frame tests. There are only good reasons to not use DLOG and DVLOG in test code. Also, avoid a potential race by setting up ChromeFrameTestWithWebServer expectations before launching the browser. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9838058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128638 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Have Chrome Frame build its .idl artifacts into a sub-folder of SHARED_INTERMEDIATE_DIR, a globally common output folder. It's rude to dump things in the root of the dir that aren't used project-wide. Also explicitly list the installer -> ChromeFrame dependency in src\chrome\installer\DEPS. It was already present but now check_deps catches it due to the correctly formatted include path.Remove several redundant instances of SHARED_INTERMEDIATE_DIR being added to the include lists. BUG=97185 TEST=Chrome Frame artifacts do not appear in e.g. build/Debug/obj/global_intermediate/ Review URL: http://codereview.chromium.org/8317018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106287 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Include base/win/scoped_comptr.h instead of base/scoped_comptr_win.h. Fix up all the callers to use the new location and namespace. Also, delete the stub file since it isn't included by anyone more. (Note: This was a TODO for brettw). BUG=None TEST=None R=brettw@chromium.org Review URL: http://codereview.chromium.org/6825055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h. This addresses a long-standing TODO. Cleanup is good for the soul. BUG=none Review URL: http://codereview.chromium.org/10197011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135145 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two deprecated methods from base::Version BUG=none TEST=none TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Roll gtest 445 -> 446 I want to get to r492 to pick up the fix for http://code.google.com/p/googletest/issues/detail?id=321 , but r446 needs some changes, so I'm doing an extra commit for this revision. See comments at http://code.google.com/p/googletest/source/detail?r=446 BUG=None TEST=None Review URL: http://codereview.chromium.org/3705002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62246 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Use TimeDelta for Chrome Frame test's TimedMsgLoop. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix flakiness in Chrome Frame HeaderTest. Responses were being cached by IE, so there was a reasonable probability that two permutations used the same URL. This change adds a no-cache header so the URL doesn't matter. BUG=99235 TEST=none -- covered by chrome_frame_tests.exe Review URL: https://chromiumcodereview.appspot.com/9323031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120336 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Split user agent code out of the 'glue' target This creates a new user_agent component target for the user agent handling code. This makes it straightforward for iOS to build only the user-agent part of glue. It should also make incremental dismantling of webkit/ easier, since the dependencies on user agent code are now explicit. The code that was in user_agent.cc/h (the webkit_user_agent target) has been moved to user_agent_util.cc/h, and folded into the user_agent component target. All user-agent related code has been moved to a new webkit/user_agent/ directory. BUG=None Review URL: https://chromiumcodereview.appspot.com/10869073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155695 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add a setting to CF to remove 'chromeframe' from the UserAgent on a per-pattern basis. Useful for testing and dealing with sites with broken UA parsing. BUG=117157 TEST=chrome_frame_tests,chrome_frame_unittests,add a ExcludeUAFromDomain key to the CF settings, add some pattern values, observe that the UA string does not contain CF. Review URL: http://codereview.chromium.org/9720001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129985 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Fix flake in chrome_frame_net_tests due to improper use of IE configurator. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10391051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136327 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
More non-debug logging in Chrome Frame tests. There are only good reasons to not use DLOG and DVLOG in test code. Also, avoid a potential race by setting up ChromeFrameTestWithWebServer expectations before launching the browser. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9838058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128638 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Purge ImplementsThreadSafeReferenceCounting() from the codebase now that Task is dead. TBR=ananta@chromium.org,apatrick@chromium.org Review URL: https://chromiumcodereview.appspot.com/10836116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150202 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use TimeDelta for Chrome Frame test's TimedMsgLoop. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update uses of TimeDelta in chrome_frame/*. Also update a bit of TimeDelta use in webkit npapi code. Adding robertshield for his thoughts on this. R=ananta@chromium.org BUG=108171 Review URL: http://codereview.chromium.org/10019015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133395 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. This change makes all remaining tests in the suite use an address on a NIC rather than the loopback address. I don't know whether it'll resolve the flake or not. BUG=143699 TEST=none Review URL: https://chromiumcodereview.appspot.com/10868027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use TimeDelta for Chrome Frame test's TimedMsgLoop. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update uses of TimeDelta in chrome_frame/*. Also update a bit of TimeDelta use in webkit npapi code. Adding robertshield for his thoughts on this. R=ananta@chromium.org BUG=108171 Review URL: http://codereview.chromium.org/10019015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133395 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable Media Source API by default. BUG=144669 Review URL: https://chromiumcodereview.appspot.com/10915117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155438 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Set svn:executable on windows executables. Remove third_party/tlslite/installers/ TBR=thestig@chromium.org BUG= TEST= NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10178018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134316 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Automating the poor man's trybot. BUG=none TEST=none Review URL: http://codereview.chromium.org/5137008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66824 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h. This addresses a long-standing TODO. Cleanup is good for the soul. BUG=none Review URL: http://codereview.chromium.org/10197011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135145 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Handle automation server crashes. When Chrome crashes, we now handle the case and support document refresh or reload. When chrome crashes, we draw a poor man's sad tab (":-("), so that can clearly be improved. Another thing is that if the chrome instance that crashed held several navigational entries, then that history is lost. TEST=There are a couple of tests included, so run those (*TabCrash*) and also verify that when the chrome automation server is killed that we do the right thing. Also check info in bug report. BUG=25839 Review URL: http://codereview.chromium.org/3061036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55565 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Use TimeDelta for Chrome Frame test's TimedMsgLoop. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add a self-destruct mechanism to user-level Chrome Frame when it detects that system-level Chrome Frame is present. This is a first step to handling user-to-system-level handoff. It will cause a user-level install to be correctly replaced with a system-level one once the user logs out and back in again. Additional changelists will follow that: 1) Ensure full clean-up of the user-level installation. 2) Handle notifications such that logging out and in again isn't required. BUG=82816 TEST=Install user-level Chrome Frame. Review URL: http://codereview.chromium.org/7065024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87033 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Use a different algorithm with the low entropy source for field trials. The new algorithm maps the original 13-bit low entropy source to a new 13-bit entropy value using a mapping that is shuffled using the trial name as a seed. The algorithm is roughly as follows: Take the low entropy source as an integer between 0-8191. Generate an identity mapping of size 8192 where mapping[i] == i. Seed a Mersenne Twister random number generator with the hash of the field trial name. Use the seeded random number generator to shuffle the mapping array. Map the low entropy source using the mapping array, i.e. entropy' = mapping[entropy]. Divide the resulting entropy' by 8192 to produce a double in the range of [0, 1) that will be used for bucketing in field_trial.cc. The above algorithm improves uniformity over the existing entropy provider when the 13-bit entropy source is used while still providing very little overlaps of buckets between different field trials. Adds third_party library mt19937ar, an implementation of Mersenne Twister, for the seeded random number generation. This is needed until C++11 becomes available for use in Chromium, at which point C++11's <random> could be used. BUG=143239 TEST=Unit tests. Additionally, verified that the new algorithm produces uniform results with very little overlap of buckets between different field trials. Review URL: https://chromiumcodereview.appspot.com/10830318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153322 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Load both language packs and the resource dlls in ChromeFrame and look for localized strings in the language pack and the other resources like dialogs in the dll. The latter part is done automatically by ATL. BUG=94362 TEST=No change in behavior. The resources should continue to load as before. Review URL: http://codereview.chromium.org/7763006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98502 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
More non-debug logging in Chrome Frame tests. There are only good reasons to not use DLOG and DVLOG in test code. Also, avoid a potential race by setting up ChromeFrameTestWithWebServer expectations before launching the browser. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9838058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128638 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
[chrome_frame] Refactor/merge IE no interference tests with other mock event sink tests. Have the test mock contain, not inherit the IE event sink. Use the new test server to verify the right requests are being sent. BUG=none TEST=none Review URL: http://codereview.chromium.org/2822016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52137 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Reduce flakiness in chrome_frame_tests.exe by having each test run in a clean environment. This includes: * A TestScrubber runs between all test to kill stray IE and Chrome processes and delete the user data dir. * Refactored CFACWithChrome and ProxyFactoryTest tests to get rid of copy-n-paste. * Tests in ChromeFrameTestWithWebServer that launch Chrome now use a fresh user data dir so as not to collide with a users' existing profile. BUG=81479,114386 TEST=chrome_frame_tests.exe is green on the win_cf trybot Review URL: https://chromiumcodereview.appspot.com/9460019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123973 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. This change makes all remaining tests in the suite use an address on a NIC rather than the loopback address. I don't know whether it'll resolve the flake or not. BUG=143699 TEST=none Review URL: https://chromiumcodereview.appspot.com/10868027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. This change makes all remaining tests in the suite use an address on a NIC rather than the loopback address. I don't know whether it'll resolve the flake or not. BUG=143699 TEST=none Review URL: https://chromiumcodereview.appspot.com/10868027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. This change makes all remaining tests in the suite use an address on a NIC rather than the loopback address. I don't know whether it'll resolve the flake or not. BUG=143699 TEST=none Review URL: https://chromiumcodereview.appspot.com/10868027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. This change makes all remaining tests in the suite use an address on a NIC rather than the loopback address. I don't know whether it'll resolve the flake or not. BUG=143699 TEST=none Review URL: https://chromiumcodereview.appspot.com/10868027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Attempt to fix flake in FullTabModeIE_TestPostReissue by avoiding loopback address. This change makes all remaining tests in the suite use an address on a NIC rather than the loopback address. I don't know whether it'll resolve the flake or not. BUG=143699 TEST=none Review URL: https://chromiumcodereview.appspot.com/10868027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disabling chrome_frame_tests.exe ContextMenuTest.CFBackForward since it times out. BUG=121097 TEST=none Review URL: https://chromiumcodereview.appspot.com/10261014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134569 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Stop using ScopedAllowIO in content::ResourceDispatcherHostImpl Summary: UploadData::GetContentLengthSync() call is removed from ResourceDispatcherHostImpl. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress. A new member 'upload_size' is added to AutomationURLResponse for Chrome Frame. content::ResourceDispatcherHostImpl has been using UploadData::GetContentLengthSync() which needs ScopedAllowIO. To stop using ScopedAllowIO, there were three options considered. 1. Use asynchronous version UploadData::GetContentLength() which does not need ScopedAllowIO. pros: Changes would be minimal and straight-forward. cons: GetContentLength() is also called in UploadDataStream::Init(). If we start reusing the value, there is no need to call the same method here. 2. Communicate the upload data size to ResourceDispatcherHost by adding an event OnRequestBodyInitialized() to URLRequest::Delegate. pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). cons: Complicated interface. 3. Return upload data size as well as upload progress from URLRequest::GetUploadProgress(). pros: No duplicated GetContentLength() call here and in UploadDataStream::Init(). Simple interface. Making sense because upload progress and upload size are almost always used together (see ResourceHandler::OnUploadProgress and DOM ProgressEvent as examples). cons: Polling upload data size may imply that the size may change. We've decided to go with #3. The return type of net::URLRequest::GetUploadProgress() is changed from uint64 to net::UploadProgress, and URLRequest::GetUploadProgress() is used to get the upload size from ResourceDispatcherHostImpl instead of UploadData::GetContentLengthSync(). In Chrome Frame, URLRequestAutomationJob is used instead of URLRequestHttpJob and UploadDataStream is not initialized in the browser process. This is problematic since we cannot know the size of upload data without UploadDataStream. To deal with this, a new member 'upload_size' is added to AutomationURLResponse and the value is used to implement URLRequestAutomationJob::GetUploadProgress(). BUG=112607 TEST=Can upload files Review URL: https://chromiumcodereview.appspot.com/10825073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154286 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Use TimeDelta for Chrome Frame test's TimedMsgLoop. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131813 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch renderer in Moniker patch Step one of the changes. Inspect data and cause a switch in the moniker patch. Review URL: http://codereview.chromium.org/1589013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44038 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
scoped_ptr and new[] don't mix. BUG=99261 TEST=none Review URL: http://codereview.chromium.org/8207004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104592 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Add a setting to CF to remove 'chromeframe' from the UserAgent on a per-pattern basis. Useful for testing and dealing with sites with broken UA parsing. BUG=117157 TEST=chrome_frame_tests,chrome_frame_unittests,add a ExcludeUAFromDomain key to the CF settings, add some pattern values, observe that the UA string does not contain CF. Review URL: http://codereview.chromium.org/9720001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129985 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
More non-debug logging in Chrome Frame tests. There are only good reasons to not use DLOG and DVLOG in test code. Also, avoid a potential race by setting up ChromeFrameTestWithWebServer expectations before launching the browser. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9838058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128638 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move some files from base to base/memory. raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 |