PPdfium LUCI CQFixed a return value error in CJS_Document::getAnnots.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Always check return code from CPWL_ComboBox::SetPopup(). Operation must not continue when false is returned. Bug: chromium:1444238 Change-Id: Ic8c29653ac185ac80b6248203649ce05d0e10f06 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107390 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Cover another branch in CPDFSDK_BAAnnot::SetAnnotName() Exercise the path where setting the name to an empty string deletes from the dictionary. Change-Id: If7e24fb6f05fa342bee4fcaa18ec620336509d9c Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/84930 Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Cover another branch in CPDFSDK_BAAnnot::SetAnnotName() Exercise the path where setting the name to an empty string deletes from the dictionary. Change-Id: If7e24fb6f05fa342bee4fcaa18ec620336509d9c Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/84930 Auto-Submit: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Test high-valued unicode characters in app.alert() Tie pdfium_test to the us_EN.UTF-8 locale so that these will print consistently (they fail to print entirely in the "C" locale). Change-Id: I61c9e75666392e4b054a98cc67e11d67e6066503 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93771 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Test high-valued unicode characters in app.alert() Tie pdfium_test to the us_EN.UTF-8 locale so that these will print consistently (they fail to print entirely in the "C" locale). Change-Id: I61c9e75666392e4b054a98cc67e11d67e6066503 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93771 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Rename testing/resources/javascript/*_props.in to *_properties.in Be consistent; some are named one way vs. the other at present. Change-Id: I9e48459ec05af64fe4422d7d22d490710beee8d5 Reviewed-on: https://pdfium-review.googlesource.com/c/45473 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Merge to XFA: Add signatures to FXJS_V8. (cherry picked from commit 158e335717efba9dce3aa6f6d1e31ed884e1f59e) Original Review URL: https://codereview.chromium.org/1353193004 . TBR=jochen@chromium.org, krasin@google.com Review URL: https://codereview.chromium.org/1376343002 . | 10 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Roll v8/ c623fabe5..604c50c84 (9 commits) https://chromium.googlesource.com/v8/v8.git/+log/c623fabe5643..604c50c84e67 Version 7.1.132 Update array_buffer JS test to adjust for https://chromium.googlesource.com/v8/v8/+/5cfe1a6b on Windows for 32-bit and ASAN builds. Change-Id: I7cfea684ab56d4a809989a7f029d7fc013eac372 Reviewed-on: https://pdfium-review.googlesource.com/c/44370 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Dismiss exceptions while setting properties/elements from JS handlers. Otherwise, we can't use any other V8 functionality until the exception is handled. Bug: chromium:1098213 Change-Id: Ie846194afab52e5d61795c7af74b1e29b46db953 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70913 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Dismiss exceptions while setting properties/elements from JS handlers. Otherwise, we can't use any other V8 functionality until the exception is handled. Bug: chromium:1098213 Change-Id: Ie846194afab52e5d61795c7af74b1e29b46db953 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70913 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Tolerate empty local in JS_DateParse(). Return early, and let the error that triggered the empty local propogate to whatever may catch it. - Rewrite to use early returns - Prefer As<>() when previously tested with Is*() Bug: chromium:1142688 Change-Id: Iffe11bb0d75f61a6bf42f39beb37c9cb2de157a0 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/75790 Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Tolerate empty local in JS_DateParse(). Return early, and let the error that triggered the empty local propogate to whatever may catch it. - Rewrite to use early returns - Prefer As<>() when previously tested with Is*() Bug: chromium:1142688 Change-Id: Iffe11bb0d75f61a6bf42f39beb37c9cb2de157a0 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/75790 Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Retain original dictionary in CPDFSDK_AppStream::Write(). Bug: chromium:1314658 Change-Id: Iad1db4fc2285492e31b8bb535a0b078b07fb73ef Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/92432 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Retain original dictionary in CPDFSDK_AppStream::Write(). Bug: chromium:1314658 Change-Id: Iad1db4fc2285492e31b8bb535a0b078b07fb73ef Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/92432 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Retain nodes when manipulating their dictionaries in CPDF_NameTree. -- Pass retain ptrs consistently in a few other places. Bug: chromium:1335861 Change-Id: If23cf6b6ec39ef02384beaa6745e1c7256160cba Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/94430 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Retain nodes when manipulating their dictionaries in CPDF_NameTree. -- Pass retain ptrs consistently in a few other places. Bug: chromium:1335861 Change-Id: If23cf6b6ec39ef02384beaa6745e1c7256160cba Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/94430 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Return retained const objects from SearchNameNodeByNameInternal() Bug: chromium:1358075 Change-Id: I4c06f6c8c148804fa71a7ef156524be4776b2d16 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/97210 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 3 年前 | |
Return retained const objects from SearchNameNodeByNameInternal() Bug: chromium:1358075 Change-Id: I4c06f6c8c148804fa71a7ef156524be4776b2d16 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/97210 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 3 年前 | |
Observe CPWL_ComboBox across all On* methods Bug: chromium:1445426 Change-Id: I1d7ebf66fe170ca016c27a0df3ac4574e75c763c Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107650 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 3 年前 | |
Observe CPWL_ComboBox across all On* methods Bug: chromium:1445426 Change-Id: I1d7ebf66fe170ca016c27a0df3ac4574e75c763c Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107650 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 3 年前 | |
Avoid dangling ptr in ~CPWL_MsgControl(). During cleanup, remove some window pointers so they do not dangle, even for a brief period before the MsgControl gets cleaned up. Bug: chromium:1447268 Change-Id: I6579ed3acf288e2d955777f199644a4b501fdc0e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107950 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Avoid dangling ptr in ~CPWL_MsgControl(). During cleanup, remove some window pointers so they do not dangle, even for a brief period before the MsgControl gets cleaned up. Bug: chromium:1447268 Change-Id: I6579ed3acf288e2d955777f199644a4b501fdc0e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107950 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Avoid dangling ptr in ~CPWL_MsgControl(). During cleanup, remove some window pointers so they do not dangle, even for a brief period before the MsgControl gets cleaned up. Bug: chromium:1447268 Change-Id: I6579ed3acf288e2d955777f199644a4b501fdc0e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107950 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Roll V8 to ee5d9a0c. Update test expectations after V8 enabled --harmony-function-tostring by default. https://chromium.googlesource.com/v8/v8/+log/0c287882..ee5d9a0c TBR=dsinclair@chromium.org Change-Id: I4eabc6b2ed854153dcbfb75f527e209f57e86a2a Reviewed-on: https://pdfium-review.googlesource.com/24110 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 8 年前 | |
Fixed a return value error in CJS_Document::getAnnots. The function incorrectly returned the number of pages. After the fix, it returns the total number of annotations across all pages. Bug: 421304870 Change-Id: I923dfa5b9cabf7d37bdc75a1cb2f41e90d60c9c5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135230 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 11 个月前 | |
Fixed a return value error in CJS_Document::getAnnots. The function incorrectly returned the number of pages. After the fix, it returns the total number of annotations across all pages. Bug: 421304870 Change-Id: I923dfa5b9cabf7d37bdc75a1cb2f41e90d60c9c5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135230 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 11 个月前 | |
Fix a copy-pasta typo. Change-Id: I497c38fe6b2a311495157127ef5a10a2b7c40cc5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66211 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add support to Document::getAnnots method Although notably, the parameters handling support is not complete, CL intends to be the first step towards a more complete implementation of this API. TEST=testing/resources/javascript/bug_492_1.in BUG=pdfium:492 Review-Url: https://codereview.chromium.org/2281273002 | 9 年前 | |
Fix a copy-pasta typo. Change-Id: I497c38fe6b2a311495157127ef5a10a2b7c40cc5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66211 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add a test case for bug 494057. The expectation is set incorrectly to allow the test to pass. BUG=chromium:494057 Review-Url: https://codereview.chromium.org/2430583002 | 9 年前 | |
Fix a copy-pasta typo. Change-Id: I497c38fe6b2a311495157127ef5a10a2b7c40cc5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66211 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Remove ability to delete annot in CJS_Document::removeField() This path has only been present under XFA, and has resulted in several bugs, including the referenced one. There is a breakage in some XFA functionality, but I'm not confident we can do this without re-engineering all of fpdfsdk widget ownership. Bug: 891210 Change-Id: I5aa158fa5359b1c8338046eefb25fb25df9ace48 Reviewed-on: https://pdfium-review.googlesource.com/c/43311 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Fix uninitialized memory read in CJS_Object::GetEmbedObject() The expected way to create native PDFium objects for JS is via the NewFxDynamicObject() call in C++, but that doesn't mean that the corresponding constructors won't be called from JS. In that case, the internal fields will be uninitialized, and subsequent method calls may try to use them. Add a constructor callback for all PDFium objects that nulls out these fields (shame that v8 doesn't do this by default, but probably saves some cycles). Then ensure that we check for this possibility in all the places it might turn up. Conversely, if we've just gotten a successful return from NewFxDynamicObject(), we know the CJS_Object/EmbedObj are good, so avoid checking there. BUG=695826 Change-Id: Iadad644c4af937def967ddc83daac1dad7544d69 Reviewed-on: https://pdfium-review.googlesource.com/2839 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 9 年前 | |
Fix a copy-pasta typo. Change-Id: I497c38fe6b2a311495157127ef5a10a2b7c40cc5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66211 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Observe Annot destruction in CPDFSDK_PageView::DeleteAnnot Run test XFA-Only, since that's where the issue occurs, and the textual output is different for non-xfa. Fix a few lifetime issue in pdfium_test.cc unearthed by this test (doc must outlive pages now held in formfill info). Bug: 735912 Change-Id: Icc9e6a967c32ece67d897117896c973bb16a1515 Reviewed-on: https://pdfium-review.googlesource.com/8510 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> | 8 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
More tightly validate format strings in util.cpp. Re-work the previous fix to be even more particular about the input. Bug: chromium:740166 Change-Id: I6bea3b6a6dd320a83f830b07afd52951be7d1b63 Reviewed-on: https://pdfium-review.googlesource.com/7691 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> | 8 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Clone dict before iteration in CJS_Document::get_info Bug: 895152 Change-Id: I678350841892f88a5d580b58a33a639a1b6ec305 Reviewed-on: https://pdfium-review.googlesource.com/c/44050 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Ensure JavaScript sources are strings or streams. More closely follow the spec. Bug: chromium:959274 Change-Id: I25db01e846773f920fc466f17671b9f31056eb03 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/53971 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Replace UnownedPtr with RetainPtr to parser objects in fpdfdoc Bug: chromium:983867 Change-Id: Ib07bfb48ef85ee7a013f5e1a3d2127648dc950ba Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57854 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Replace UnownedPtr with RetainPtr to parser objects in fpdfdoc Bug: chromium:983867 Change-Id: Ib07bfb48ef85ee7a013f5e1a3d2127648dc950ba Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57854 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Fix a copy-pasta typo. Change-Id: I497c38fe6b2a311495157127ef5a10a2b7c40cc5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66211 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Use {{include}} directive in more tests. There are a few small variations in the wording of the messages in the expected.txt files as a result. Change-Id: I529fe04550372a47a97c5d0abfd1ed36470f8402 Reviewed-on: https://pdfium-review.googlesource.com/c/45472 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Rename testing/resources/javascript/*_props.in to *_properties.in Be consistent; some are named one way vs. the other at present. Change-Id: I9e48459ec05af64fe4422d7d22d490710beee8d5 Reviewed-on: https://pdfium-review.googlesource.com/c/45473 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Fix a copy-pasta typo. Change-Id: I497c38fe6b2a311495157127ef5a10a2b7c40cc5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66211 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add tests for CJS_Console methods. Change-Id: Ie534b26d8241e889ad9cdca942e142cddca44bf4 Reviewed-on: https://pdfium-review.googlesource.com/c/43933 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add JS test for constructing FXJSOBJTYPE_DYNAMIC objects. These won't be full-fledged objects since they lack C++ bindings (as tested in icons.in), but they shouldn't allow their constructor to be invoked as a plain function. Change-Id: I9be1eddfc6dc4eb2d836670c0eb3fd095c7bde8f Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66171 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Update old-style copyright headers Updates old-style copyright headers to the new style, by removing "All rights reserved." Also inserts "The" before "PDFium Authors", which is required by both styles. Mechanically generated by this command: PATTERN='Copyright \([0-9]\+\) \(The \)\?PDFium Authors. All rights reserved.' git grep -l "$PATTERN" \ | xargs sed "s/$PATTERN/Copyright \1 The PDFium Authors/" -i'' Fixed: pdfium:1884 Change-Id: I6f781d811df8839e2e21b85f716529b813828bcd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100371 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> | 3 年前 | |
Add JS test for constructing FXJSOBJTYPE_DYNAMIC objects. These won't be full-fledged objects since they lack C++ bindings (as tested in icons.in), but they shouldn't allow their constructor to be invoked as a plain function. Change-Id: I9be1eddfc6dc4eb2d836670c0eb3fd095c7bde8f Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66171 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add JS tests for global const equality. Add these tests before fixing bug 419. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1761923002 . | 10 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Allow print() only in response to a user gesture This prevents the print dialog opening automatically when a PDF is embedded in a web-page. As part of this change, move the existing tests from document_methods.in to mouse_events.in, and extend the mouse_events.in tests to check that print can only be called in response to a user gesture. BUG=chromium:968914 Change-Id: Ib55808cf500288460f79c940af0c4d2738bb93e5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/56790 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Ignore attempts to set document properties via JS. Various document properties are specified as read-only (always, or in Acrobat Reader) in the spec. Match the Acrobat Reader behavior and ignore calls to set them. Bug: pdfium:1820 Change-Id: I131fc715a7a1b692dbce0c1c6fbfdd9a4f614dae Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93253 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Use {{include}} directive in more tests. There are a few small variations in the wording of the messages in the expected.txt files as a result. Change-Id: I529fe04550372a47a97c5d0abfd1ed36470f8402 Reviewed-on: https://pdfium-review.googlesource.com/c/45472 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Fix JS event.value behavior. Add more tests and make sure the behavior matches Acrobat Reader's. Change-Id: I46ce84c77c5687acae1910f66ccecf2ef07793f8 Reviewed-on: https://pdfium-review.googlesource.com/c/45372 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Fix non-compliant copyright headers Fixes copyright headers that neither match the old nor the new style. In most of these cases, this is because the copyright header was copied from another project, such as Chromium. Bug: pdfium:1884 Change-Id: I1943df9c2f8a0282be9f7691bdd38b054d237458 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100391 Auto-Submit: K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Improve test for CJS_Field::get_button_position() Show that out-of-range /TP values are passed through as-is. Change-Id: I34169091069c74fd68e868975d46358b4fe52f3e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/80711 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Cover some more paths in CJS_Field.cpp from JS. Change-Id: I6aabe44e20a17c76d5586e52cdb0adcc0487dcad Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69290 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Improve test for CJS_Field::get_button_position() Show that out-of-range /TP values are passed through as-is. Change-Id: I34169091069c74fd68e868975d46358b4fe52f3e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/80711 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Return "circle" for the default radio button style. Unlike checkboxes, radio buttons don't use the "check" style by default. Change-Id: If60b8930f4ed44f441e2d30c34c8ae111d2a0cd9 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/91310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Return "circle" for the default radio button style. Unlike checkboxes, radio buttons don't use the "check" style by default. Change-Id: If60b8930f4ed44f441e2d30c34c8ae111d2a0cd9 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/91310 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Allow reproduction of the issue in 1156170 with pdfium_test. Pump the message loop more frequently to expose GC concurency issues. Does not fix the linked bug but rather makes it reproducible. To avoid a number of new #ifdefs at various layers, encapsulate the new logic in a std::function<> callback that can be passed down to called functions. Allows removal of a longstanding TODO() in foreground_task.in as this test now completes as designed. Bug: chromium:1156170 Change-Id: I82d95d71f31f9c427f330dbf08ab62ba94078079 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/76890 Reviewed-by: Hui Yingst <nigi@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Allow reproduction of the issue in 1156170 with pdfium_test. Pump the message loop more frequently to expose GC concurency issues. Does not fix the linked bug but rather makes it reproducible. To avoid a number of new #ifdefs at various layers, encapsulate the new logic in a std::function<> callback that can be passed down to called functions. Allows removal of a longstanding TODO() in foreground_task.in as this test now completes as designed. Bug: chromium:1156170 Change-Id: I82d95d71f31f9c427f330dbf08ab62ba94078079 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/76890 Reviewed-by: Hui Yingst <nigi@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Support Unicode names/values in CJS globals Currently, these are manipulated using default ANSI, meaning the strings are interpreted (on Windows at least) according to whatever code page is in effect for the system, with non-conforming characters removed (or replaced by placeholder '?' chars on Windows). These stored strings also risk being corrupted if the system default code page changes. These strings all come directly from JS as UTF-16, so we know precisely what they mean without requiring code page considerations. So convert everything to UTF-8 and avoid platform differences. This would be a breaking change if any platform actually implemented persistence and had previously stored, say, non-ASCII key/values. This seems unlikely. -- Downcast name to string rather than invoking toString(). -- Avoid converting from UTF-8 only to reconvert back to UTF-8 under the covers in fxv8. Change-Id: I0e0298fa8429c59215e2c5a44560308cab72ccb3 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93772 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Support Unicode names/values in CJS globals Currently, these are manipulated using default ANSI, meaning the strings are interpreted (on Windows at least) according to whatever code page is in effect for the system, with non-conforming characters removed (or replaced by placeholder '?' chars on Windows). These stored strings also risk being corrupted if the system default code page changes. These strings all come directly from JS as UTF-16, so we know precisely what they mean without requiring code page considerations. So convert everything to UTF-8 and avoid platform differences. This would be a breaking change if any platform actually implemented persistence and had previously stored, say, non-ASCII key/values. This seems unlikely. -- Downcast name to string rather than invoking toString(). -- Avoid converting from UTF-8 only to reconvert back to UTF-8 under the covers in fxv8. Change-Id: I0e0298fa8429c59215e2c5a44560308cab72ccb3 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93772 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 4 年前 | |
Cover cfxjs_engine.cpp's CallHandler() success case. Change-Id: I62df922ed62e00cc30d4179945e5eb4b6d2cc0d6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63510 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Cover cfxjs_engine.cpp's CallHandler() success case. Change-Id: I62df922ed62e00cc30d4179945e5eb4b6d2cc0d6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63510 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Make PDFium JS host object have immutable prototypes It is doubtful that any legitimate PDF would ever change __proto__ on these objects, and those that do are just trying to muck with us. Bug: chromium:1091404 Change-Id: I99367281e796b91c1858fead3eb18a3a655291f1 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70430 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Make PDFium JS host object have immutable prototypes It is doubtful that any legitimate PDF would ever change __proto__ on these objects, and those that do are just trying to muck with us. Bug: chromium:1091404 Change-Id: I99367281e796b91c1858fead3eb18a3a655291f1 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70430 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add single select box to field.fragment In turn, now use field.fragment in listbox_methods.in Change-Id: Ie8f6f244c6b83dfb9e48ca739a654388f6b64ac7 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52733 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Add a JS test for Field.value for listboxes. Set baseline expectations using the existing behavior, which is not the same as Acrobat's behavior. Change-Id: I441f25ad3e1a4dc2839003e33df163052b866bf3 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52611 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Add doubleclick event handling to pdfium_test_event_helper.cc As suggested on the referenced bug by reporter. Bug: chromium:1043510 Change-Id: I7d81240eee405fa24876f969472760e04638c2fa Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65410 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add doubleclick event handling to pdfium_test_event_helper.cc As suggested on the referenced bug by reporter. Bug: chromium:1043510 Change-Id: I7d81240eee405fa24876f969472760e04638c2fa Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65410 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Exercise FFI_ExecuteNamedAction paths Introduce logging in pdfium_test for this callback. Change-Id: Ic641196da23d9eeb77d890752a81a2b19cfa9c91 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93311 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Exercise FFI_ExecuteNamedAction paths Introduce logging in pdfium_test for this callback. Change-Id: Ic641196da23d9eeb77d890752a81a2b19cfa9c91 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93311 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Update old-style copyright headers Updates old-style copyright headers to the new style, by removing "All rights reserved." Also inserts "The" before "PDFium Authors", which is required by both styles. Mechanically generated by this command: PATTERN='Copyright \([0-9]\+\) \(The \)\?PDFium Authors. All rights reserved.' git grep -l "$PATTERN" \ | xargs sed "s/$PATTERN/Copyright \1 The PDFium Authors/" -i'' Fixed: pdfium:1884 Change-Id: I6f781d811df8839e2e21b85f716529b813828bcd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100371 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> | 3 年前 | |
Cover some JS public methods that do not "commit". The path taken sometimes depends on the nature of the event which triggered the JS execution and the callback, so test the public method callbacks under different types of triggering events. In particular, pick an event that does not set the "will commit" bit in the event recording structure. To trigger this, we need to send a keystroke to the appropriate field. Change-Id: I9aabefc1e391c5a89acddd6b3a96fe6337f142d7 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62212 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Cover some JS public methods that do not "commit". The path taken sometimes depends on the nature of the event which triggered the JS execution and the callback, so test the public method callbacks under different types of triggering events. In particular, pick an event that does not set the "will commit" bit in the event recording structure. To trigger this, we need to send a keystroke to the appropriate field. Change-Id: I9aabefc1e391c5a89acddd6b3a96fe6337f142d7 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62212 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Provide better logging from CJS_PublicMethods's AlertIfPossible(). Providing the name of the currently executing public method made diagnosing failures easier in an unrelated CL. -- consistently name one argument while at it. Change-Id: I81d27004e6342b4e199c13fe08be9409005d1d53 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/75810 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> | 5 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add test to ensure Net.* remains unimplemented Also do the same for other "dangerous" objects. Bug: chromium:853237 Change-Id: I99ba5037f76e91d386f9b13a614b02101b50499a Reviewed-on: https://pdfium-review.googlesource.com/c/50850 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Re-work some more c_str() usage. Many of these are converting ByteString => c_str => ByteStringView, since the ByteStringView ctor is implicit. This is unfortunate, since that involves a strlen() which the ByteString already knows if we use AsStringView() instead. This changed one test result where we can now return the string "\0" instead of "" -- since strlen no longer eats the NUL. This seems consistent, say, with String.fromCharCode(). Change-Id: I17f68d1a1f4b352960208f9148e68ab4c4d78bd2 Reviewed-on: https://pdfium-review.googlesource.com/35590 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 8 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Test error cases in util.printd() and printx(). Remove an exclamation point (!) from a message for consistency. Change-Id: Ie93faa2a9a6dedfecbe03e191db49b97fa36e84d Reviewed-on: https://pdfium-review.googlesource.com/c/44910 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Test error cases in util.printd() and printx(). Remove an exclamation point (!) from a message for consistency. Change-Id: Ie93faa2a9a6dedfecbe03e191db49b97fa36e84d Reviewed-on: https://pdfium-review.googlesource.com/c/44910 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Fix a copy-pasta typo. Change-Id: I497c38fe6b2a311495157127ef5a10a2b7c40cc5 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66211 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Use {{include}} directive in more tests. There are a few small variations in the wording of the messages in the expected.txt files as a result. Change-Id: I529fe04550372a47a97c5d0abfd1ed36470f8402 Reviewed-on: https://pdfium-review.googlesource.com/c/45472 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 7 年前 | |
Add missing endobj keywords to test files. Change-Id: I223daeace6b2c89c1b250909f66c595c6eb5f7b6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66212 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Use --no-expose-wasm flag in PDFium tests. Because no PDF file should contain webassembly. Hopefully other embedders will pick up on this change (PDFium doesn't directly control V8 initialization). Change-Id: Ifb3afd4aebefa7e2cb9da125bb673d449de80e6b Reviewed-on: https://pdfium-review.googlesource.com/c/45150 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 |