PPdfium LUCI CQAlways check return code from CPWL_ComboBox::SetPopup().
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Fix faulty indexing CFXJSE_FormCalcContext::unfoldArgs(). Length properties may dynamically change from call to call, so a pre-allocation may not be sufficient. Bug: chromium:1004106 Change-Id: Ica860e7d585a8d10346ea407f8a8e3cfc1bd4a1b Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67171 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Make CPDFSDK_Pageview observable across mouse move callbacks Bug: chromium:1017494 Change-Id: I8a7590be50d11f22e854531903565b2528539005 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/61871 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Make CPDFSDK_Pageview observable across mouse move callbacks Bug: chromium:1017494 Change-Id: I8a7590be50d11f22e854531903565b2528539005 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/61871 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Observe CPDFSDK_PageView inside ExitWidget(). ExitWidget() can trigger the deletion of caller. Use an ObserverPtr to check for this and bail out safely. Bug: chromium:1026991 Change-Id: If27c1b02a0d6f3bb39c999a85366e393fa150687 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66815 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Observe CPDFSDK_PageView inside ExitWidget(). ExitWidget() can trigger the deletion of caller. Use an ObserverPtr to check for this and bail out safely. Bug: chromium:1026991 Change-Id: If27c1b02a0d6f3bb39c999a85366e393fa150687 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66815 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Force .evt files to have LF line endings. Change-Id: I575368ec3523ec2e01ab590b3346958953155a52 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67370 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Make all CXFA_FFWidget observe their CXFA_FFPageview. Although a very blunt technique, the cost shouldn't be terrible in memory given the size of the CXFA_FFWidget itself, and shouldn't be terrible in runtime give the rarity of the notification case. Ideally, future memory work would improve this situation, but this safely adding more test cases at present to guard against regressions. Bug: chromium:1042915, chromium:1010844 Change-Id: Idd02967a8297d3bce7d35451db9ae05f79cdf3ac Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65870 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Make all CXFA_FFWidget observe their CXFA_FFPageview. Although a very blunt technique, the cost shouldn't be terrible in memory given the size of the CXFA_FFWidget itself, and shouldn't be terrible in runtime give the rarity of the notification case. Ideally, future memory work would improve this situation, but this safely adding more test cases at present to guard against regressions. Bug: chromium:1042915, chromium:1010844 Change-Id: Idd02967a8297d3bce7d35451db9ae05f79cdf3ac Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65870 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Make all CXFA_FFWidget observe their CXFA_FFPageview. Although a very blunt technique, the cost shouldn't be terrible in memory given the size of the CXFA_FFWidget itself, and shouldn't be terrible in runtime give the rarity of the notification case. Ideally, future memory work would improve this situation, but this safely adding more test cases at present to guard against regressions. Bug: chromium:1042915, chromium:1010844 Change-Id: Idd02967a8297d3bce7d35451db9ae05f79cdf3ac Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65870 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Remove CXFA_NodeOwner::FreeOwnedNode(). Nodes live essentially in an "arena" and live for the duration of the document. This appears to be an anachronism from earlier node ownership models. - use vector since lookup for removal not required. - remove a no-op assignment near the call as well. Bug: chromium:1042956 Change-Id: Ic1b4789766a6dc4b6e7a14ff289cc53090c93539 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65330 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Force .evt files to have LF line endings. Change-Id: I575368ec3523ec2e01ab590b3346958953155a52 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67370 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Bounds check in GetWordBreakProperty() wchar_t might be wider than 16 bits on non-windows platforms. - Make tables static and provide accessor functions. Bug: chromium:1043510 Change-Id: Ib573971692e8c35d299ed0fb376039878827ef7d Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65411 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Ensure label item lists are not excessively sized in CXFA_FFListBox. Truncate any spurious labels which do not correspond to underlying settable values. Bug: chromium:1047914 Change-Id: I0ba4cf09fb177f491f835d9f3046dea5df641fc4 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65930 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Ensure label item lists are not excessively sized in CXFA_FFListBox. Truncate any spurious labels which do not correspond to underlying settable values. Bug: chromium:1047914 Change-Id: I0ba4cf09fb177f491f835d9f3046dea5df641fc4 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65930 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Force .evt files to have LF line endings. Change-Id: I575368ec3523ec2e01ab590b3346958953155a52 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67370 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add test cases for several recently fixed XFA bugs. Backfilling some tests that I had not taken the time to convert to our template format. Change-Id: Ib848a267c1fbb0ed1da846eef555c85a7ec23862 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66813 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
CXFA_FFTabOrderPageWidgetIterator must retain layout items for widgets. This will keep the layout item owning the widget (and hence the widget itself) alive for the lifetime of the iterator. Bug: chromium:1060549 Change-Id: Ib5751ef9d302e9adc633ca1001b8a670732dd28e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67590 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
CXFA_FFTabOrderPageWidgetIterator must retain layout items for widgets. This will keep the layout item owning the widget (and hence the widget itself) alive for the lifetime of the iterator. Bug: chromium:1060549 Change-Id: Ib5751ef9d302e9adc633ca1001b8a670732dd28e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67590 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Observe pagview across JS invocation in cpdfxfa_page.cpp Bug: chromium:1069700 Change-Id: I68db0b17dc8cc7146a18d7caf88334f75b3d31fc Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68710 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add missing brace to bug_1069700.in Although this prevented proper replacement in the generated PDF file, the missing section did not affect the correctness of the test. Bug: chromium:1069700 Change-Id: Ia3dc81f4633be97de9f6b90380e02623afe28eee Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68750 Commit-Queue: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Retain widgets across SetFocus() calls in CXFA_FFWidgetHandler. Bug: chromium:1069789 Change-Id: I65e26b8eb1ef6646ffb29a88d84464cd099fe3cd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68696 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Retain widgets across SetFocus() calls in CXFA_FFWidgetHandler. Bug: chromium:1069789 Change-Id: I65e26b8eb1ef6646ffb29a88d84464cd099fe3cd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68696 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Retain owning layout items earlier in CXFA_FFField Safer, even on the paths where we know we short-circuit. Bug: chromium:1082597 Change-Id: Ie4116dba8bfac54c7a4fcb181fecbd3d7ee1389e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69910 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Retain owning layout items earlier in CXFA_FFField Safer, even on the paths where we know we short-circuit. Bug: chromium:1082597 Change-Id: Ie4116dba8bfac54c7a4fcb181fecbd3d7ee1389e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69910 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Retain layout items rather than raw widgets in CFXA_TabParam. Prevent them from popping out of existence while we might be iterating over them. -- forward-declare CXFA_TabParam in header file. Bug: chromium:1109108 Change-Id: I0e97cf3a98861e004808c124f5cfdffb3abf27fd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/71890 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Retain layout items rather than raw widgets in CFXA_TabParam. Prevent them from popping out of existence while we might be iterating over them. -- forward-declare CXFA_TabParam in header file. Bug: chromium:1109108 Change-Id: I0e97cf3a98861e004808c124f5cfdffb3abf27fd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/71890 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Retain layout items rather than raw widgets in CFXA_TabParam. Prevent them from popping out of existence while we might be iterating over them. -- forward-declare CXFA_TabParam in header file. Bug: chromium:1109108 Change-Id: I0e97cf3a98861e004808c124f5cfdffb3abf27fd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/71890 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Observe CFX_Timer's timer handler objects. Allows CFX_Timer lifetimes to be less precise in face of longer-lived garbage-collected objects. CFX_Timers refer back to form fill environments, which are shorter lived than the documents themselves, so this is a good precaution even in a non-gc'ed world. -- nest TimerHanderIface inside CFX_Timer while at it. Bug: chromium:1137668 Change-Id: I5738db783af43eff3b23b5936cfdb82d7510c410 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/75030 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Observe CFX_Timer's timer handler objects. Allows CFX_Timer lifetimes to be less precise in face of longer-lived garbage-collected objects. CFX_Timers refer back to form fill environments, which are shorter lived than the documents themselves, so this is a good precaution even in a non-gc'ed world. -- nest TimerHanderIface inside CFX_Timer while at it. Bug: chromium:1137668 Change-Id: I5738db783af43eff3b23b5936cfdb82d7510c410 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/75030 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 5 年前 | |
Avoid integer overflow in RelocateTableRowCells(). -- also add some consts as appropriate. Bug: chromium:1164158 Change-Id: I3146a8f0fc45e1282548dad136379a8f87a7770d Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/77230 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> | 5 年前 | |
Fix assertion !pValue.IsEmpty() in cfxjse_value.cpp. Second issue noted in referenced bug. Bug: pdfium:1238 Change-Id: I234f75e2de3669d2452f9b04c285b8f9d717acac Reviewed-on: https://pdfium-review.googlesource.com/c/50893 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Fix assertion !pValue.IsEmpty() in cfxjse_value.cpp. Second issue noted in referenced bug. Bug: pdfium:1238 Change-Id: I234f75e2de3669d2452f9b04c285b8f9d717acac Reviewed-on: https://pdfium-review.googlesource.com/c/50893 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
CJX_List::append() should not create cycles. Check for ancestors before inserting new nodes. Bug: chromium:1248901 Change-Id: Iae0916746cf6d2927fdd353327684fdf2e0efb5d Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85073 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
CJX_List::append() should not create cycles. Check for ancestors before inserting new nodes. Bug: chromium:1248901 Change-Id: Iae0916746cf6d2927fdd353327684fdf2e0efb5d Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85073 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Fix null-dereference in CJX_Object::SetContent() Bug: chromium:1312736 Change-Id: I31aed7895f5a1e49cf7c7b6dda490e932dd7bfe8 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/92190 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Fix null-dereference in CJX_Object::SetContent() Bug: chromium:1312736 Change-Id: I31aed7895f5a1e49cf7c7b6dda490e932dd7bfe8 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/92190 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Always check return code from CPWL_ComboBox::SetPopup(). Operation must not continue when false is returned. Bug: chromium:1444238 Change-Id: Ic8c29653ac185ac80b6248203649ce05d0e10f06 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107390 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Always check return code from CPWL_ComboBox::SetPopup(). Operation must not continue when false is returned. Bug: chromium:1444238 Change-Id: Ic8c29653ac185ac80b6248203649ce05d0e10f06 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/107390 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Handle CFDE_TextEditEngine delegate unexpectedly changing text. JavaScript might run and change the value into which text is about to be inserted, so recheck boundaries before continuing. Bug: chromium:976753 Change-Id: I7d5e8cf0ccc3be881ab7303fafad53c54d3f6ec2 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/56630 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Use more RetainPtrs in CXFA_FFTabOrderPageWidgetIterator. - Make CreateSpaceOrderLayoutItems() return a vector of RetainPtr<CXFA_ContentLayoutItem> instead of CXFA_FFWidget pointers. - Change CreateTabOrderWidgetArray() to use the RetainPtrs. - Add a test for this case. Bug: chromium:980116 Change-Id: I5ef172930e775a07fb37e2dffe2318ead76961cb Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70213 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Use more RetainPtrs in CXFA_FFTabOrderPageWidgetIterator. - Make CreateSpaceOrderLayoutItems() return a vector of RetainPtr<CXFA_ContentLayoutItem> instead of CXFA_FFWidget pointers. - Change CreateTabOrderWidgetArray() to use the RetainPtrs. - Add a test for this case. Bug: chromium:980116 Change-Id: I5ef172930e775a07fb37e2dffe2318ead76961cb Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70213 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Fix an UnownedPtr error in CXFA_FFTabOrderPageWidgetIterator. CPDFXFA_Page::GetNextXFAAnnot() and GetFirstOrLastXFAAnnot() can potentially trigger an UnownedPtr error in CXFA_FFTabOrderPageWidgetIterator. Fix the issue by using a RetainPtr to ensure the object in question has the right live time. This is a secondary issue from a previous bug report. Add a test case for that. Bug: chromium:980161 Change-Id: I895c3b6634aa0f7a68d2b44cc0307afc64716c78 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70252 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Fix an UnownedPtr error in CXFA_FFTabOrderPageWidgetIterator. CPDFXFA_Page::GetNextXFAAnnot() and GetFirstOrLastXFAAnnot() can potentially trigger an UnownedPtr error in CXFA_FFTabOrderPageWidgetIterator. Fix the issue by using a RetainPtr to ensure the object in question has the right live time. This is a secondary issue from a previous bug report. Add a test case for that. Bug: chromium:980161 Change-Id: I895c3b6634aa0f7a68d2b44cc0307afc64716c78 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70252 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
CJX_Object::SetContent() should only update value nodes. This method operates in two passes. In the first part, a set of value nodes children is collected, but in the second pass, all children are traversed regardless of whether they are value nodes. There's no reason to believe these are the same when the node has non-value node children. - Fix possibly overly-strong assert in CXFA_Node. In turn, this causes one test to leave a node unmodified rather than CHECK(). Bug: chromium:985781 Change-Id: Idd8ae5d8fb5f07ae01487db589036bdab3a99ada Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/57932 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Observe pNewWidget across OnKillFocus Bug: chromium:991899 Change-Id: Ieb1ab9bc3c14372d5b7e107f299cf161837bb3f6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59350 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Observe pNewWidget across OnKillFocus Bug: chromium:991899 Change-Id: Ieb1ab9bc3c14372d5b7e107f299cf161837bb3f6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59350 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Observe m_pFocusWidget across m_ArrayKeepItems.clear() Bug: chromium:993771 Change-Id: I24d2d0cb2ea1779b8aa1def9aa6a1dd639284a85 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59332 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Observe m_pFocusWidget across m_ArrayKeepItems.clear() Bug: chromium:993771 Change-Id: I24d2d0cb2ea1779b8aa1def9aa6a1dd639284a85 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59332 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Observe FWL widgets in events/messages that destroy them. Bug: chromium:995712 Change-Id: I3b1f8d9c31545aff4f2013cf6952791089cf65bc Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59832 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Observe FWL widgets in events/messages that destroy them. Bug: chromium:995712 Change-Id: I3b1f8d9c31545aff4f2013cf6952791089cf65bc Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59832 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Observe FWL widgets in events/messages that destroy them. Bug: chromium:995712 Change-Id: I3b1f8d9c31545aff4f2013cf6952791089cf65bc Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59832 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Fix a crash in CXFA_FFComboBox::OpenDropDownList(). Avoid calling it when the combobox has never been loaded. Bug: chromium:996123 Change-Id: I3b38b973cbde67f8caec54a74b0838f5994e9aac Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62450 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Prevent another integer overflow in AGG. Avoid another situation in AGG's sweep_scanline() where signed integer math can result in undefined behavior. Bug: chromium:997021 Change-Id: Ica952174f34f0907598a1778cde0790de25768dd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59891 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Prevent another integer overflow in AGG. Avoid another situation in AGG's sweep_scanline() where signed integer math can result in undefined behavior. Bug: chromium:997021 Change-Id: Ica952174f34f0907598a1778cde0790de25768dd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59891 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add missing /Pages object to some XFA test files. Change-Id: Ia193f26a008278bd29e9aa7c3274c13f483680b1 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66210 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Explicit test for XFA objects winding up in non-xfa methods. Change-Id: Ie63dfb6810476df655ae1161d59d8d5c25014f43 Reviewed-on: https://pdfium-review.googlesource.com/c/49790 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Update old-style copyright headers Updates old-style copyright headers to the new style, by removing "All rights reserved." Also inserts "The" before "PDFium Authors", which is required by both styles. Mechanically generated by this command: PATTERN='Copyright \([0-9]\+\) \(The \)\?PDFium Authors. All rights reserved.' git grep -l "$PATTERN" \ | xargs sed "s/$PATTERN/Copyright \1 The PDFium Authors/" -i'' Fixed: pdfium:1884 Change-Id: I6f781d811df8839e2e21b85f716529b813828bcd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100371 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> | 3 年前 | |
Test removing last instanceManager instance. Must be subject to the <occurs> contraints. Change-Id: Ia4fd4c26e0690f1155a9449058913fc0b43d4c61 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66031 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Fix typos of the word occurrence. Change-Id: I6bdeb64c7276850b5538a1e70faa2b740cb45739 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/85230 Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> | 4 年前 | |
Exercise more CJX_List methods from JavaScript. Change-Id: I7d5f1b8ea6c5fae7f4953ae944c617b7707a2fc1 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63050 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Exercise more CJX_List methods from JavaScript. Change-Id: I7d5f1b8ea6c5fae7f4953ae944c617b7707a2fc1 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63050 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Get code coverage for CPDFSDK_Widget::Synchronize() These tests require a mixed XFA form (i.e. no <config> XFA section, just a <template> section, say) with a PDF widget not overlapped by an XFA widget, and an XFA widget linked by the same name to the PDF widget. Send a click then type into the PDF widget to force it to sync with the XFA one. Change-Id: I71c5b346770b7da3045322b6af5765703f188556 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/104512 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Get code coverage for CPDFSDK_Widget::Synchronize() These tests require a mixed XFA form (i.e. no <config> XFA section, just a <template> section, say) with a PDF widget not overlapped by an XFA widget, and an XFA widget linked by the same name to the PDF widget. Send a click then type into the PDF widget to force it to sync with the XFA one. Change-Id: I71c5b346770b7da3045322b6af5765703f188556 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/104512 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 3 年前 | |
Cover CPDFXFA_DocEnvironment::PopupMenu() Right-clicking on a combobox should be sufficient. - Add pdfium_test callback to log invocation. - Remove passing one nullptr arg while at it. Change-Id: Ic59325c2095333e4851038e5916ce06933e293e6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68152 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Cover CPDFXFA_DocEnvironment::PopupMenu() Right-clicking on a combobox should be sufficient. - Add pdfium_test callback to log invocation. - Remove passing one nullptr arg while at it. Change-Id: Ic59325c2095333e4851038e5916ce06933e293e6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68152 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Cover CPDFXFA_DocEnvironment::PopupMenu() Right-clicking on a combobox should be sufficient. - Add pdfium_test callback to log invocation. - Remove passing one nullptr arg while at it. Change-Id: Ic59325c2095333e4851038e5916ce06933e293e6 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68152 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Convert resolve_nodes.pdf into 3 test cases There are 3 elements in the PDF that can be interacted with that cause testable output. This CL creates test cases for each of these elements. 2 of them work correctly, and a new bug, pdfium:1106, has been filed for the third. BUG=pdfium:1020 Change-Id: I524911d03927a0eeeee1d1479e1a855f90269e8e Reviewed-on: https://pdfium-review.googlesource.com/34370 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> | 8 年前 | |
Convert resolve_nodes.pdf into 3 test cases There are 3 elements in the PDF that can be interacted with that cause testable output. This CL creates test cases for each of these elements. 2 of them work correctly, and a new bug, pdfium:1106, has been filed for the third. BUG=pdfium:1020 Change-Id: I524911d03927a0eeeee1d1479e1a855f90269e8e Reviewed-on: https://pdfium-review.googlesource.com/34370 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> | 8 年前 | |
Remove ability to delete annot in CJS_Document::removeField() This path has only been present under XFA, and has resulted in several bugs, including the referenced one. There is a breakage in some XFA functionality, but I'm not confident we can do this without re-engineering all of fpdfsdk widget ownership. Bug: 891210 Change-Id: I5aa158fa5359b1c8338046eefb25fb25df9ace48 Reviewed-on: https://pdfium-review.googlesource.com/c/43311 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Convert resolve_nodes.pdf into 3 test cases There are 3 elements in the PDF that can be interacted with that cause testable output. This CL creates test cases for each of these elements. 2 of them work correctly, and a new bug, pdfium:1106, has been filed for the third. BUG=pdfium:1020 Change-Id: I524911d03927a0eeeee1d1479e1a855f90269e8e Reviewed-on: https://pdfium-review.googlesource.com/34370 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> | 8 年前 | |
Convert resolve_nodes.pdf into 3 test cases There are 3 elements in the PDF that can be interacted with that cause testable output. This CL creates test cases for each of these elements. 2 of them work correctly, and a new bug, pdfium:1106, has been filed for the third. BUG=pdfium:1020 Change-Id: I524911d03927a0eeeee1d1479e1a855f90269e8e Reviewed-on: https://pdfium-review.googlesource.com/34370 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> | 8 年前 | |
Convert resolve_nodes.pdf into 3 test cases There are 3 elements in the PDF that can be interacted with that cause testable output. This CL creates test cases for each of these elements. 2 of them work correctly, and a new bug, pdfium:1106, has been filed for the third. BUG=pdfium:1020 Change-Id: I524911d03927a0eeeee1d1479e1a855f90269e8e Reviewed-on: https://pdfium-review.googlesource.com/34370 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> | 8 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add JavasScript test for CJX_Container methods. Change-Id: Ice6b87d1fad42cdd44173ffa021dd21359255a1e Reviewed-on: https://pdfium-review.googlesource.com/c/50330 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Cover CJX_DataWindow properties and methods. These are all stubs, but we can at least call them from JS. Change-Id: I6cabadb6e8494ede52579e9476403ba0c0a6db4a Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65592 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Cover CJX_DataWindow properties and methods. These are all stubs, but we can at least call them from JS. Change-Id: I6cabadb6e8494ede52579e9476403ba0c0a6db4a Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65592 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Test CJX_Event::emit() and reset() Change-Id: I2b8d9058fcb7a4e8541f6c591630aeeeed9ca9ec Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63051 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Test CJX_Event::emit() and reset() Change-Id: I2b8d9058fcb7a4e8541f6c591630aeeeed9ca9ec Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63051 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Provide actual event names in xfa_exclgroup.in As taken from |gs_EventParaInfos| in cjx_node.cpp Change-Id: Id989c578023927fa99908d6696a3638f2dbc2a6f Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68411 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Provide actual event names in xfa_exclgroup.in As taken from |gs_EventParaInfos| in cjx_node.cpp Change-Id: Id989c578023927fa99908d6696a3638f2dbc2a6f Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68411 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Cover some more CJX_Field JavaScript callbacks. Change-Id: I99c4a2c860da0d4302ff41a8755041e609ecb054 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66292 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Cover some more CJX_Field JavaScript callbacks. Change-Id: I99c4a2c860da0d4302ff41a8755041e609ecb054 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66292 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Cover CJX_Form methods from JavaScript Change-Id: I173c8da11c0f785b7f028b5d1c0cf89a9e99117e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68670 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Cover CJX_Form methods from JavaScript Change-Id: I173c8da11c0f785b7f028b5d1c0cf89a9e99117e Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68670 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add missing /Pages object to some XFA test files. Change-Id: Ia193f26a008278bd29e9aa7c3274c13f483680b1 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66210 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add tests for XFA's JS global object. Get coverage of Context_GlobalObjToString(). Change-Id: Ie98f8ea41213794f16ddd20bcf23cba503b9c3bd Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66130 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Call xfa.host.pageUp(), pageDown(), and resetData() from JS tests. Change-Id: If26d11fb3257fbd28dbab1d9765c0b426b4b8684 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65030 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Large-scale usage of fxcrt::Mask<> Convert XFA_PrintOpt and XFA_ResolveNode -- Rename to XFA_ResolveFlag, since it is not a node per-se. Change-Id: I38d09f95befddd9a4e492d8585e5964daeca2eca Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83958 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 4 年前 | |
JavaScript test for many of the possible <items> types. In particular, <boolean> has some interesting methods for converting its contents from "0" or "1". Change-Id: Ie5c49b330d6412fba0b350f09f87e5bb6bf13d10 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66271 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
JavaScript test for many of the possible <items> types. In particular, <boolean> has some interesting methods for converting its contents from "0" or "1". Change-Id: Ie5c49b330d6412fba0b350f09f87e5bb6bf13d10 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66271 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Improve tests for CJX_LayoutPseudoModel. Check return from GetUnitFromString() to avoid tripping ASSERT() later on as uncovered by tests. Change-Id: I73881e792c48f1f1faae104078d5be4c73e1a5e7 Reviewed-on: https://pdfium-review.googlesource.com/c/50510 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add missing /Pages object to some XFA test files. Change-Id: Ia193f26a008278bd29e9aa7c3274c13f483680b1 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66210 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Call XFA log pseudomodel functions from test These are pretty much unimplemented, but confirm they do not crash, etc. Change-Id: I22657cff59c90c955ba6bc693eb61a1aaedafada Reviewed-on: https://pdfium-review.googlesource.com/c/49810 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add JavaScript test for CXJ_Model object. Fix NULL segv uncovered by test. Change-Id: I0015e234852b48f00315771e725b94fda844eaa5 Reviewed-on: https://pdfium-review.googlesource.com/c/50312 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Cover special |xfa| propname in CFXJSE_Engine::NormalPropertyGetter() Specifically, cfxjse_engine.cpp, lines 334-337 in the 2020-03-20 coverage report. Change-Id: I0d76c4f98aa848ec9a2f4392b18415c80318c764 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67731 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Cover special |xfa| propname in CFXJSE_Engine::NormalPropertyGetter() Specifically, cfxjse_engine.cpp, lines 334-337 in the 2020-03-20 coverage report. Change-Id: I0d76c4f98aa848ec9a2f4392b18415c80318c764 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67731 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add coverage for cjx_signaturepseudomodel.cpp. These are essentially no-ops, but call them to show nothing bad happens. Change-Id: I45164b973ef19457da6b58693bfe37cc134bdaa4 Reviewed-on: https://pdfium-review.googlesource.com/c/49850 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add JavaScript test for CJX_Subform object. Change-Id: Ie0348c598cef7a9c9aaf2d78b864eba8df8fbde6 Reviewed-on: https://pdfium-review.googlesource.com/c/50230 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Call CJX_Template methods from JavaScript. These methods are mostly no-ops, but ensure they do not crash when called. Change-Id: I3da331fbe50c85b45a00aa5ab7a1f5d6a6cce3d2 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66310 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Call CJX_Template methods from JavaScript. These methods are mostly no-ops, but ensure they do not crash when called. Change-Id: I3da331fbe50c85b45a00aa5ab7a1f5d6a6cce3d2 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/66310 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Add {{streamlen}} macro to javascript tests. Change-Id: I7c9858ba602162049cabc61c78fc09e9006dfa47 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/59716 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> | 6 年前 | |
Add JavaScript test for CJX_Tree object. Change-Id: I69ebdc3518fb62c15f11494f9ad355d4b7775f62 Reviewed-on: https://pdfium-review.googlesource.com/c/50353 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 7 年前 | |
Cover CJX_Script::stateless() from JavaScript test -- simplify its clumsy return value getter code. Change-Id: I3e865383d1f4684360238690a641e095cef11f84 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68430 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 | |
Cover CJX_Script::stateless() from JavaScript test -- simplify its clumsy return value getter code. Change-Id: I3e865383d1f4684360238690a641e095cef11f84 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68430 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> | 6 年前 |