VV8 LUCI CQRemove stray c_str() calls from v8.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Reland "[base] Move contextual variables to base" This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/4315774 Fixed bug: Avoid exporting the thread_local variable itself on Linux too and use explicit template specialization to make the exporting work. Change-Id: Iaa19e17b781167013b852b251f0f94e1af7c9aa2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4323384 Reviewed-by: Clemens Backes <clemensb@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#86328} | 3 年前 | |
Remove stray c_str() calls from v8. None of these would seem to require a truncation at an embedded NUL, so we can create strings/string_views directly. Bug: 412730353 Change-Id: I24aab7b376855000afbfe0d8bcc20865dc617890 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6484712 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Auto-Submit: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/main@{#100129} | 1 年前 | |
[torque] Replace uses of v8::base::Optional with std::optional 1. v8::base::Optional has been aliasing to std::optional for some time now. We should replace the uses and use std::optional directly. 2. Adjust the location of some header files and some namespace usage according to the coding standards. 3. Suppress some cpplint warnings and remove some redundant header files that were forgotten to be removed before. 4. To avoid spam, my non-@chromium.org email address has been removed from the AUTHORS file. Bug: chromium:355003178 Change-Id: I3a2050c07683f702ce40f1b88a2f9757c5ccacdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5741080 Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ho Cheung <hocheung@chromium.org> Cr-Commit-Position: refs/heads/main@{#95315} | 1 年前 | |
[torque-ls] Fix Json serialization Stringification of Json wrongly used quotes for "true", "false" and "null". Drive-by: Manually flush std::cout when sending messages. This might fix the server on windows. R=tebbi@chromium.org Bug: v8:8880 Change-Id: Ie499595a1b429514c5d8b1d3ece24f4690ece02e Reviewed-on: https://chromium-review.googlesource.com/c/1498132 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59992} | 7 年前 | |
Add required includes for <memory> when using std::unique_ptr Tbr: yangguo@chromium.org Change-Id: I9e774efdbff94be909470ab848c75e5120bb520e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803343 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63762} | 6 年前 | |
Reland "[base] Move contextual variables to base" This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/4315774 Fixed bug: Avoid exporting the thread_local variable itself on Linux too and use explicit template specialization to make the exporting work. Change-Id: Iaa19e17b781167013b852b251f0f94e1af7c9aa2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4323384 Reviewed-by: Clemens Backes <clemensb@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#86328} | 3 年前 | |
[cleanup] Avoid non-const reference arguments in src/torque This CL changes non-const reference arguments to either a const reference, or pass-by-value combined with std::move. Bug: v8:9429 Change-Id: Iabace132f855462612ac31922fbd8b456d8ae20d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690827 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62583} | 6 年前 | |
[torque-ls][cleanup] JsonValue accessors are now checked Instead of accessing JsonValue struct fields directly, typed accessors check that the tag matches with the type access. Drive-by: The factory methods are now static methods on the JsonValue type itself, making call-sites more readable. R=tebbi@chromium.org Bug: v8:8880 Change-Id: I49b37b3ba8eaf1153b8aa93ea08913077c923fdc Reviewed-on: https://chromium-review.googlesource.com/c/1495559 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#59968} | 7 年前 | |
[cleanup] Avoid non-const reference arguments in src/torque This CL changes non-const reference arguments to either a const reference, or pass-by-value combined with std::move. Bug: v8:9429 Change-Id: Iabace132f855462612ac31922fbd8b456d8ae20d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690827 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62583} | 6 年前 | |
[clang-tidy] Add override to overridden functions See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I904fa4fada2860938a32be9f0a84af091adc76ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211193 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67989} | 6 年前 | |
Fix most instances of -Wunreachable-code-aggressive. There are still a few cases remaining that seem more controversial; I'll upload those separately. Bug: chromium:1066980 Change-Id: Iabbaf23f9bbe97781857c0c589f2b3db685dfdc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994804 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#75494} | 4 年前 |