已合并
[AscendNPU IR][SIMT] Added SIMT support for non power of two tensors #1357
[AscendNPU IR][SIMT] Added SIMT support for non power of two tensors #1357
已合并
Max_Wang_Huawei创建于 7月4日
7月4日

描述 Description

请提供此 Pull Request 的高级别说明。
Added a pass that converts tensors that have non power of two dimensions into tensors with power of two dimensions by padding them.
Supports the following ops:

  • arith.constant ops
  • tensor.insert_slice, tensor.extract_slice, tensor.insert, tensor.extract ops that are supported by RewriteSliceOpToTriton
  • scf if/for ops
  • triton advance, atomic_rmw, broadcast, dot, expand_dims, histogram, load, make range, make tensor ptr, reduce, reshape, scan, store, splat, transpose ops
  • Elementwise ops (such as arith.addi, etc)

Also modified dynamic offset insert_slice lowering in RewriteSliceOpToTriton to support offsets that are not multiples of the insert tensor's insert axis dimension, and added a fallback to using the dynamic slice op lowering if the static offset is not a multiple of the small tensor axis dimension.

类型 Category

Checklist

likedislike
Pull Request已成功合入, 合并人@ascend-robot
(感谢 Max_Wang_Huawei 的贡献)
MMax_Wang_Huawei
7月4日 创建了 pull request,commit c5737ea2
ascend-robot
ascend-robot成员
7月4日 评论:

libing-pipeline创建中,请等待……

likedislike
ascend-robotascend-robot成员
7月4日 添加了label:ascend-cla/yes
ascend-robot
ascend-robot成员
7月4日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here
You can get sig-info at here


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-Ascend/AscendNPU-IR michael_hliao, yue-xy (2/2) michael_hliao (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

Max_Wang_Huawei, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
Max_Wang_Huawei
7月4日 评论:

compile-a5

likedislike
此处折叠了561条消息 查看更多
PpCSICompileDV成员
7月28日 通过测试
yue-xy
yue-xy
7月28日 评论:

/lgtm

likedislike
michael_hliao成员
7月28日 评论:

/lgtm
/approve

likedislike
ascend-robotascend-robot成员
7月28日 添加了label:approvedlgtm
ascend-robotascend-robot成员
7月28日 合入了pull request,合并节点 SHA:bc0df18720e2bc3f435e93382cda3bffd449b1ee