已开启
fix(ci): 移除 op-plugin ignore=dirty 并新增子模块 pin 一致性检查 #46296
fix(ci): 移除 op-plugin ignore=dirty 并新增子模块 pin 一致性检查 #46296
已开启
TheoCui创建于 26 天前
TheoCui
TheoCui
26 天前

关联 Issue

Fixes #4784

变更内容

  • .gitmodules:移除 third_party/op-plugin 的 ignore = dirty,恢复子模块本地改动的可见性;
  • 新增 ci/check_submodule_pins.sh:逐一校验每个子模块 pin 的 commit 在 .gitmodules 记录的 URL 上可达(git fetch --dry-run),防止镜像 fork 缺失 pin 导致 recursive clone 失败;
  • .gitcode/workflows/build_job.yml:在 compile 步骤前接入该检查,尽早拦截。

验证

本机执行 bash ci/check_submodule_pins.sh,11 个子模块全部输出 OK,退出码 0。

[check-submodule-pins] third_party/op-plugin: OK (5ab41c7d @ https://gitcode.com/ascend/op-plugin.git)
[check-submodule-pins] third_party/googletest: OK (58d77fa8 @ https://gitcode.com/GitHub_Trending/go/googletest.git)
...
likedislike
合并受阻
TheoCuiTheoCui
26 天前 创建了 pull request,commit 57eb1449
TheoCuiTheoCui
26 天前 关联了issue:子模块镜像无完整性校验 + op-plugin ignore=dirty 配置风险
atomgit-bot
atomgit-bot
26 天前 评论:

变更摘要

该 PR 主要聚焦 CI 中子模块完整性校验:在 .gitmodules 中移除 third_party/op-plugin 的 ignore = dirty,恢复子模块本地改动的可见性;新增 ci/check_submodule_pins.sh 脚本,逐一校验每个子模块 pin 的 commit 在 .gitmodules 记录的 URL 上是否可达(通过 git fetch --dry-run),防止镜像 fork 缺失 pin 导致 recursive clone 失败;并在 .gitcode/workflows/build_job.yml 中于 compile 步骤前接入该检查,尽早拦截问题。

主要改动

  • 移除 op-plugin 子模块的 ignore = dirty:在 .gitmodules 中删除 third_party/op-plugin 的 ignore = dirty 配置,恢复子模块本地改动的可见性,使 CI 能够感知其未提交的变更。
  • 新增 ci/check_submodule_pins.sh 校验脚本:脚本遍历 .gitmodules 中所有 submodule.*.url,通过 git ls-tree HEAD 读取对应路径的 gitlink SHA(mode 160000),并用 git fetch --dry-run "$url" "$sha" 验证 pin 在目标 URL 上可达;无 gitlink 时跳过,校验失败则置 fail=1 并以非零码退出。
  • CI 流程接入 pin 检查:在 .gitcode/workflows/build_job.yml 的 compile 步骤前新增 check submodule pins 步骤,执行 bash ci/check_submodule_pins.sh,在构建早期拦截子模块 pin 不可达导致的克隆失败。
likedislike
不准确?
atomgit-bot
atomgit-bot
26 天前 评论:

代码审查

✅ 未发现问题

likedislike
不准确?
ascend-robotascend-robot成员
26 天前 添加了label:ascend-cla/no
ascend-robot
ascend-robot成员
26 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.


PR Approval Progress

⚠️ This PR does not yet meet the following requirements:lgtm (requires ≥ 2 person(s) per module)、approve (requires ≥ 1 person(s) per module)

Module Approval Details

module lgtm status approve status
.gitcode ❌ (0/2)(You can also ask: liangsongwei, chenrayray, chujinjin, huangjingwei, zhenyu10) ❌ (0/1)(You can also ask: chenrayray, kisnwang, 楚浩田, chujinjin, renyujin)
ci ❌ (0/2)(You can also ask: 楚浩田, huangjingwei, wjlflyer, renyujin, zhenyu10) ❌ (0/1)(You can also ask: wjlflyer, 楚浩田, liangsongwei, renyujin, huangjingwei)
repo-Ascend/pytorch ❌ (0/2)(You can also ask: wjlflyer, renyujin, rmch, chengpeng25, wangqiang160) ❌ (0/1)(You can also ask: wasd1111222, li_jing_hw, 楚浩田, chengpeng25, wjlflyer)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

saulcy, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
ascend-robot
ascend-robot成员
26 天前 评论:

当前仓库存在以下 保护分支 :

Protected Branch Version Release
master
v2.9.0
v2.10.0
v2.11.0
v2.12.0
v2.7.1
v2.7.1-26.1.0
v2.9.0-26.1.0
v2.10.0-26.1.0
v2.11.0-26.1.0
v2.12.0-26.1.0
ci-test

评论 /sync <branch1> <branch2> ... 可将当前 PR 修改同步到其它分支(创建同步 PR):
a) 如果当前 PR 是 Open 状态,同步操作将延迟到 PR 被合并时执行
b) 如果当前 PR 已经 Merged,将立即执行同步操作

注意:

  1. /sync 命令可以指定同步到多个分支,仅最后一个 /sync 命令生效
  2. 如果创建的同步 PR 不正确,可通过向同步 PR 的源分支提交轻量级 PR 完善,或使用 /close 命令关闭
likedislike
AtlasAccountAtlasAccount成员
26 天前 添加了label:ci-pipeline-running
ascend-robot
ascend-robot成员
26 天前 评论:

ascend docs pipeline is running...

likedislike
ascend-robotascend-robot成员
26 天前 添加了label:docs-ci-pipeline-running
ascend-robot
ascend-robot成员
26 天前 评论:

✅ 跳过 docs ci 检查,没有需要检查的文档文件

likedislike
ascend-robotascend-robot成员
26 天前 删除了label:docs-ci-pipeline-running
ascend-robotascend-robot成员
26 天前 添加了label:docs-ci-pipeline-success
TheoCui
TheoCui
26 天前 评论:

/check-cla

likedislike
ascend-robotascend-robot成员
26 天前 删除了label:ascend-cla/no
ascend-robotascend-robot成员
26 天前 添加了label:ascend-cla/yes
ascend-robot
ascend-robot成员
26 天前 评论:

CLA检查已通过,详情可参考这里

likedislike
AtlasAccountAtlasAccount成员
26 天前 删除了label:ci-pipeline-running
AtlasAccountAtlasAccount成员
26 天前 添加了label:ci-pipeline-passed
AtlasAccount
AtlasAccount成员
26 天前 评论:
流水线 PR-pipeline_pytorch#67493 [ commitID:20604674 ] 已完成
>>>代码风格自动修复执行成功(无修复内容)
阶段 任务名 状态 详情
编译构建 Build_X86 ✅ COMPLETED >>>
Build_ARM ✅ COMPLETED >>>
Build_X86_torchair ⚪ IGNORED >>>
Build_ARM_torchair ⚪ IGNORED >>>
patch_test ⚪ IGNORED >>>
Build_X86_213 ✅ COMPLETED >>>
Build_ARM_213 ✅ COMPLETED >>>
恶意代码检查 Antipoison ✅ COMPLETED >>>
编码安全与规范检查 codecheck_pre-commit ✅ COMPLETED >>>
check_error ✅ COMPLETED >>>
lintrunner ✅ COMPLETED >>>
开源片段检查 SCA ✅ COMPLETED >>>
开发者测试 UT_ARM_A3_Part_01 ⚪ IGNORED >>>
UT_ARM_A3_Part_02 ⚪ IGNORED >>>
UT_ARM_A2_Part_01 ✅ COMPLETED >>>
UT_ARM_A2_Part_02 ✅ COMPLETED >>>
UT_ARM_A2_Part_03 ✅ COMPLETED >>>
UT_inductor_Part_01 ⚪ IGNORED >>>
UT_inductor_Part_02 ⚪ IGNORED >>>
UT_inductor_Part_03 ⚪ IGNORED >>>
UT_inductor_Part_04 ⚪ IGNORED >>>
UT_DIST_ARM_Part_01 ⚪ IGNORED >>>
UT_DIST_ARM_Part_02 ⚪ IGNORED >>>
UT_DIST_ARM_Part_03 ⚪ IGNORED >>>
UT_DIST_ARM_Part_04 ⚪ IGNORED >>>
UT_ARM_A2_Select_Part_01 ⚪ IGNORED >>>
UT_ARM_A2_Select_Part_02 ⚪ IGNORED >>>
UT_inductor_Part_213 ⚪ IGNORED >>>
流水线 PR-pipeline_pytorch ✅ COMPLETED >>>
此流水线已支持下列评论快捷指令,仅PR创建者和白名单成员[wujinyuan1, huangjingwei, liangsongwei, yashi999, culechan, Dring, wuyouqi1, L1919_snow, qq_52711437, WhiteNight12, nomiz, xiu_21, ffmh, wanglijun55, hss-shuai, husichao, smallsilly, lanshaozuishuai, jimmyisme1, lzy0920232, alpha-junh, Sunshine_Youngster, wei_zhuoyi, zhangyihuiben, zyw-hw, zzzkeke, rmch, yangch0324, LucciC, AACAES, renyujin, wjlflyer, senzhen-town, pengjingyou, qsc97, limuan, yule100, xiaoqi-zhou, kuhn7, chenxingying, hanye02, zichun_ye, anyrenwei, kkjocker, wangzili121, Lu_G, yvjc, puddingfjz, HandsoemLemon, bigprestigee1, huawuyi, zhenyu10, dairenjie, du-jin-hang, zou-jieyu, adelaideliu, TrHan, wanlinan, Windwindzzz, pengqihw, kisnwang, yuheng_wang, honghao_wang, jizewei, zhangguoguang, sunyu-xuan, chenrayray, hbhu_bin, liujunzhu, c_34, LiNuoh, maoyuanpeng1, zzhongmin, zhaoyu65, bellatan, jiabaolin, zhuofanshen, wencaiwen, lu_zhuge, caoshuyang, molly12, lyx324521, LQ1206, gitcode-chenjiao, cai-weiwei1989, CHDong, ogqin, yuanlipingGit, xuqinglin1, lqz2, zouwei1, chaoluoa, paradox325, jackzhang1116, yaoyao, akh, yujiacheng, dengjie0116, Hubert11111, Shine_Ws, wslhj555, longqiand, OYtao666, JiaqingQiang, luyyyy, Kingbelial, zhanghaiyu0101, wenxp1018, yanliu-luoluo, ksun_sekiro, liyong328, wgzheng, tangky, vivi_is_coding, aoiaoisola, weixin_44494597, wangmengmengwang65667, hid57809721, qq_35468730, comeonup, C547032, gcw_m5OQChA4, yao_yao_ling_xian, cnnbwcy, szqfes_12, cora_19, cann_lilin, can, shawnylee233, fanglanyue0916, hhz0, LiNuohang, taohuoquan, Jesse, WSs_321, SCh_zx]评论有效
  • compile、compile_inductor、compile_torchair : 运行流水线
  • retry : 重试流水线所有失败子任务
  • retry <任务名> : 仅重试指定失败子任务
  • stop : 停止流水线
likedislike