Merged
docs: 修复注释与代码不一致(concat compact 阈值与 transpose 分核说明) #6493
docs: 修复注释与代码不一致(concat compact 阈值与 transpose 分核说明) #6493
Merged
TangPCAdd on 24 days ago
TangPC
TangPCCollaborators
24 days ago

描述

  • conversion/concat/op_host/arch35/concat_tiling_arch35.cpp:compact 阈值注释 UINT32_MAX -> INT32_MAX,与 COMPACT_THRESHOLD 一致。
  • conversion/transpose/op_host/arch35/transpose_tiling_arch35.cpp:SMALL_SHAPE 分核注释改为与实现一致的单核条件与 CeilDiv 开核逻辑。

关联的Issue

测试

  • pre-commit(含 OAT):通过
  • Markdown 链接/图片检查:无新增失效项
  • Markdown 代码围栏检查:通过
  • 全部 26 个分支合并验证:无冲突

文档更新

  • conversion/concat/op_host/arch35/concat_tiling_arch35.cpp
  • conversion/transpose/op_host/arch35/transpose_tiling_arch35.cpp

类型标签

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for TangPC's contribution.)
TangPCTangPCCollaborators
24 days ago Created pull request, commit dce24c0c
atomgit-bot
atomgit-bot
24 days ago Comments:

变更摘要

本 PR 为文档/注释修正类变更,仅调整两处与实现不一致的代码注释,不涉及任何逻辑改动。在 conversion/concat/op_host/arch35/concat_tiling_arch35.cpp 的 GenTilingKey 中,将 compact 可用性判断的注释阈值由 UINT32_MAX 更正为 INT32_MAX,使之与代码中实际比较的 COMPACT_THRESHOLD 保持一致;在 conversion/transpose/op_host/arch35/transpose_tiling_arch35.cpp 的 CalcBlockSplitInfoForSmallShape 中,将 SMALL_SHAPE 分核逻辑注释改写为与实现一致的单核条件与基于 CeilDiv 的开核方式。

主要改动

  • concat compact 阈值注释修正: 在 GenTilingKey 中将「所有 tensor 的 dim1 < UINT32_MAX」的注释改为 < INT32_MAX,与 COMPACT_THRESHOLD 的实际语义对齐。
  • transpose SMALL_SHAPE 分核注释重写: 将原「总元素 < coreNum 按元素数开核、否则比较 ceil/floor 候选」的说明,改为「总元素不足 128B 对齐量或不足 coreNum 时只使用 1 核,否则按 ceilAlignFactor 开核」。
  • 开核公式说明同步: 注释显式补充核数计算方式为 CeilDiv(totalElements, ceilAlignFactor),与实现保持一致。

(本次改动仅涉及注释文本,未修改接口、数据结构、配置项或运行逻辑。)


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
24 days ago Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
24 days ago Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
24 days ago Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
conversion/concat ✅ 王林木, 张磊 (2/2) ✅ 张磊, 王林木 (2/1)
conversion/transpose ✅ 王林木, 张磊 (2/2) ✅ 王林木, 张磊 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

pingchuantang, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
CANN-robotCANN-robotCollaborators
24 days ago Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,jia0liang,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
CANN-robotCANN-robotCollaborators
24 days ago Set FelixTang7,yue-ma,zhou-qilong,wangrui_,rxtfeng,loov1,zhangzijie,zl_hw,songkai111,chenxingyu18,llimwang,gubaocheng,andong_hw,xuejinghui,zhanw_coding,clinglai0517 as approver
TangPC
TangPCCollaborators
21 days ago Comments:

compile

likedislike
TangPCTangPCCollaborators
21 days ago Pre merge succeeded (commit_id: 3a8d0982277921c699698630f7a902b027855145)
CANN-robot
CANN-robotCollaborators
21 days ago Comments:
🚀 CI 流水线已启动
📋 执行详情: 点击查看流水线
likedislike
CANN-robotCANN-robotCollaborators
21 days ago Added label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
21 days ago Removed label: ci-pipeline-running
CANN-robotCANN-robotCollaborators
21 days ago Added label: ci-pipeline-passed
chenyifengCollaborators
21 days ago Comments:

您好,PR已满足合入指标,请尽快联系Committer进行合入。如暂时不需要合入,请在PR标题前加[WIP]

likedislike
TangPCTangPCCollaborators
21 days ago Modify description of pull request
llimwangCollaborators
21 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
21 days ago Added label: approved
zl_hwCollaborators
21 days ago Comments:

/lgtm
/approve

likedislike
CANN-robotCANN-robotCollaborators
21 days ago Added label: lgtm
CANN-robotCANN-robotCollaborators
21 days ago Closed associated issue
CANN-robotCANN-robotCollaborators
21 days ago Merged pull request