[Bug-Report|缺陷反馈]: DynamicQuant 算子优化建议，消除冗余代码，提升代码可维护性-ops-nn-AtomGit

已关闭

[Bug-Report|缺陷反馈]: DynamicQuant 算子优化建议，消除冗余代码，提升代码可维护性 #2294

LetsAiGo创建于 4月24日关闭于 4月25日

4月24日创建

Thanks for sending an issue! Please fill in the following template to help quickly solve your problem.

Describe the current behavior / 问题描述 (Mandatory / 必填)

原始代码：
aicore inline void CopyOut(int32_t multiRow, int32_t loopCount)
{
LocalTensor outLocal = outQueue.DeQue();
LocalTensor scaleLocal = scaleQueue.DeQue();
LocalTensor offsetLocal;
if (isAsymmetrical) {
offsetLocal = offsetQueue.DeQue();
}
DataCopyExtParams copyParams{(uint16_t)multiRow, (uint16_t)(tilingData_.rowLen * sizeof(yDtype)), 0, 0, 0};
if constexpr (IsSameType<yDtype, int4b_t>::value) {
copyParams.blockLen = copyParams.blockLen >> 1;
uint32_t index = loopCount * lenGMMultiRow;
DataCopyPad(outGm[index], outLocal, copyParams);
} else {
DataCopyPad(outGm[loopCount * lenGMMultiRow], outLocal, copyParams);
}

    DataCopyParams copyParams1{1, (uint16_t)(multiRow * sizeof(float)), 0, 0};
    DataCopyPad(scaleGm[loopCount * multiRowNum], scaleLocal, copyParams1);
    if (isAsymmetrical) {
        DataCopyPad(offsetGm[loopCount * multiRowNum], offsetLocal, copyParams1);
        offsetQueue.FreeTensor(offsetLocal);
    }
    outQueue.FreeTensor(outLocal);
    scaleQueue.FreeTensor(scaleLocal);
}

建议代码：

  __aicore__ inline void CopyOut(int32_t multiRow, int32_t loopCount)
{
    LocalTensor<yDtype> outLocal = outQueue.DeQue<yDtype>();
    LocalTensor<float> scaleLocal = scaleQueue.DeQue<float>();

    DataCopyExtParams copyParams{(uint16_t)multiRow, (uint16_t)(tilingData_.rowLen * sizeof(yDtype)), 0, 0, 0};
    if constexpr (IsSameType<yDtype, int4b_t>::value) {
        copyParams.blockLen = copyParams.blockLen >> 1;
    }  
    <span style="background-color:#e60000;">DataCopyPad(outGm[loopCount * lenGMMultiRow], outLocal, copyParams);</span>

    DataCopyParams copyParams1{1, (uint16_t)(multiRow * sizeof(float)), 0, 0};
    DataCopyPad(scaleGm[loopCount * multiRowNum], scaleLocal, copyParams1);
    if (isAsymmetrical) {
        <span style="color:#e60000;">LocalTensor<float> offsetLocal = offsetQueue.DeQue<float>();</span>
        DataCopyPad(offsetGm[loopCount * multiRowNum], offsetLocal, copyParams1);
        offsetQueue.FreeTensor(offsetLocal);
    }

    outQueue.FreeTensor(outLocal);
    scaleQueue.FreeTensor(scaleLocal);
}