Pull Request has been successfully merged by CANN-robot.
(Thank you for tan_xin's contribution.)变更摘要
本 PR 针对 heaviside 算子完善健壮性与接口描述一致性:在 op_host 的 tiling 与 infershape 阶段补齐空指针、dtype 一致性和溢出边界校验,修正 CeilA2B 的潜在溢出;同步修正 aclnn_heaviside.h 的参数注释,补全 examples 示例程序在各失败分支的资源释放,并把 UT 中的 elementNum 字段宽度对齐为 int64_t;其余多为行尾换行补齐与测试脚本格式清理。
主要改动
RunBigKernelTiling校验增强:新增对GetInputDesc、GetInputShape、GetPlatformInfo、GetWorkspaceSizes、GetRawTilingData的空指针判断,并在values与input的 dtype 不一致、GetCoreNumAiv返回 0、GetShapeSize返回int64_t最小值(溢出哨兵)时返回ge::GRAPH_FAILED,避免后续解引用或错误分核。CeilA2B溢出修复:将(a + b - 1) / b改为(a - 1) / b + 1,并对b == 0、a <= 0单独返回,避免a接近INT64_MAX时有符号加法溢出。InferDataType4Heaviside数据类型校验:新增读取values的 dtype,当input/values为DT_UNDEFINED或两者不一致时报错并返回GRAPH_FAILED,否则以input的 dtype 设置输出类型。aclnn_heaviside接口注释修正:out参数标注由@param [in]改为@param [out],workspaceSize说明中的第二段接口来源由aclnnForeachAbsGetWorkspaceSize更正为aclnnHeavisideGetWorkspaceSize。- 示例与 UT 配套调整:
test_aclnn_heaviside.cpp在aclrtSetDevice、aclrtCreateStream、aclrtMemcpy、CreateAclTensor等失败分支补充aclrtFree/aclDestroyTensor/aclrtResetDevice/aclFinalize释放;heaviside_tiling_def.h中HeavisideTilingData::elementNum由int32_t改为int64_t以与 tiling 数据保持一致。
🧩 本次 Review 已使用自定义 Skill:


代码审查
审查结论
本 PR 主体是「空指针/返回值加固 + 行尾与格式清理」,核心逻辑改动集中在 heaviside_tiling.cpp(CeilA2B 防溢出重写、dtype/shape/platform/workspace 校验)、heaviside_infershape.cpp(dtype 一致性校验)与 UT 侧 heaviside_tiling_def.h(elementNum 由 int32_t 改为 int64_t,与 host TILING_DATA_FIELD_DEF(int64_t, elementNum) 对齐,属于正确修复)。未发现 P0/P1 级缺陷:CeilA2B 新写法的数学等价性成立(b 恒为 8192 常量,a>0 时 (a-1)/b+1 == ceil(a/b)),kernel 侧 elementNum 本身就是 int64_t,UT 结构体改动方向正确且 sizeof 布局与 host 一致。
发现 5 个问题,均为中低优先级:1 个 P2(kernel UT 精度校验恒通过,测试失效风险),4 个 P3(可选改进/无效校验/测试覆盖缺口)。
各文件审查情况
activation/heaviside/examples/test_aclnn_heaviside.cpp:no issues(错误路径补aclFinalize/aclrtFree正确,无双重释放;未补aclrtDestroyStream属示例级可忽略,aclrtResetDevice+aclFinalize已释放资源)activation/heaviside/op_api/aclnn_heaviside.h:no issues(out改[out]、aclnnForeachAbs→aclnnHeaviside文案修正正确)activation/heaviside/op_graph/CMakeLists.txt:no issues(仅空白/行尾)activation/heaviside/op_graph/heaviside_proto.h:no issues(仅行尾)activation/heaviside/op_host/config/ascend910_93/heaviside_binary.json:no issues(仅行尾,key 无拼写问题)activation/heaviside/op_host/config/ascend910b/heaviside_binary.json:no issues(同上)activation/heaviside/op_host/config/ascend950/heaviside_binary.json:no issues(同上)activation/heaviside/op_host/config/kirin9030/heaviside_binary.json:no issues(同上)activation/heaviside/op_host/config/kirinx90/heaviside_binary.json:no issues(同上)activation/heaviside/op_host/heaviside_infershape.cpp:1 个 P3(新增 dtype 一致性分支无有效 UT 覆盖)activation/heaviside/op_host/heaviside_tiling.cpp:2 个 P3(溢出哨兵值错误使校验失效;SaveToBuffer返回值未校验)activation/heaviside/op_host/heaviside_tiling.h:no issues(仅行尾)activation/heaviside/op_kernel/heaviside.cpp:no issues(仅行尾)activation/heaviside/op_kernel/heaviside.h:no issues(仅行尾)activation/heaviside/tests/CMakeLists.txt:no issues(仅空白/行尾;file(GLOB)为存量模式)activation/heaviside/tests/st/aclnnHeaviside/atk_aclnnHeaviside.json:no issues(单行文件仅行尾变更;dtype/键名 input/values/output 一致)activation/heaviside/tests/ut/CMakeLists.txt:no issues(仅空白/行尾)activation/heaviside/tests/ut/op_host/CMakeLists.txt:no issues(仅空白/行尾)activation/heaviside/tests/ut/op_host/op_api/CMakeLists.txt:no issues(仅空白)activation/heaviside/tests/ut/op_host/test_heaviside_infershape.cpp:no issues(仅行尾;输入名问题随 infershape 变更合并上报)activation/heaviside/tests/ut/op_kernel/CMakeLists.txt:no issues(仅空白)activation/heaviside/tests/ut/op_kernel/heaviside_data/compare_data.py:2 个问题(P2 恒通过、P3 缺 bf16 解析)activation/heaviside/tests/ut/op_kernel/heaviside_data/gen_data.py:no issues(删无效 import、补尾逗号均正确,os.system与output_size未用为存量问题)activation/heaviside/tests/ut/op_kernel/heaviside_tiling_def.h:no issues(elementNum改int64_t与 host tiling 定义一致,属修正)activation/heaviside/tests/ut/op_kernel/test_heaviside.cpp:no issues(仅行尾)
整体风险判断:改动整体是防御性加固,方向正确、回归风险低;主要隐患在测试侧——kernel 精度 UT 实际上永远不会失败(P2),使本次 tiling/类型相关改动的回归验证形同虚设,建议优先修复。
| 类型 | 数量 |
|---|---|
| 🔴 阻塞 | 0 |
| 🟡 建议 | 1 |
💬 仅评论
🧩 本次 Review 已使用自定义 Skill:


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| */*/README.md | ✅ 汤平川, 上官秦南, 陈娇 (3/2) | ✅ 陈娇 (1/1) |
| optim | ✅ 汤平川, 上官秦南 (2/2) | ✅ 汤平川 (1/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
tan_xin, thanks for your pull request. All authors of the commits have signed the CLA. 👍


/lgtm
/approve


Pull Request 已合并或已关闭。
If you want to solve this problem, you can click here to do it in the FAQs.


描述
本 PR 对 InplaceApplyCenteredRMSProp 与 InplaceApplyPowerSign 两个算子进行合规质量整改,修复质量规则/静态检查发现的问题。
InplaceApplyCenteredRMSProp
op_host/arch35/inplace_apply_centered_rms_prop_tiling_arch35.cpp)op_kernel/arch35/inplace_apply_centered_rms_prop.h)tests/assets/golden.py)__spec__;参考数学改由 Torch 基础算子组合 + float64 高精度域独立计算并 round 到输入 dtype,避免 |grad|>sqrt(FLT_MAX) 时 grad² 上溢与 kernel 同错而被比较掩盖。InplaceApplyPowerSign
examples/arch35/test_geir_inplace_apply_power_sign.cpp):GenOnesDataFloat32/GenOnesData 增加分配失败判空与delete[]释放;Session::AddGraph 失败分支补充错误处理与 delete session;结束处 delete session。关联的Issue
测试
文档更新
optim/inplace_apply_centered_rms_prop/README.md、README_en.mdoptim/inplace_apply_power_sign/README.md、README_en.md类型标签
AI/Agent生成声明