已合并
avgpool3d、adaptivemaxpool3d池化算子cleancode清理 #2534
avgpool3d、adaptivemaxpool3d池化算子cleancode清理 #2534
已合并
chenyanbin8创建于 3月11日
chenyanbin8
3月11日

描述

avgpool3d算子自身kernel重复代码:提取公共参数、函数到common.h文件中,复用代码提高易用性
avgpool3d、adaptivemaxpool3d算子之间kernel重复代码:提取公共函数到pool_3d_memory_optimized_utils.h文件中,复用代码提高易用性

关联的Issue

测试

ut、example运行pass,avgpool3d算子泛化200个用例,adaptivemaxpool3d算子泛化200个用例测试PASS

文档更新

类型标签

likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 chenyanbin8 的贡献)
Cchenyanbin8
3月11日 创建了 pull request,commit 2ca29b8e
CANN-robot
CANN-robot成员
3月11日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here
You can get sig-info at here


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
pooling zhangyuxiang0119, chenqi317 (2/2) zhangyuxiang0119, chenqi317 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)
likedislike
CANN-robotCANN-robot成员
3月11日 将crystalhu,fanqirui,zhou-qilong,chenqi317,liubo75,tangweiwei2,zhangyuxiang0119,wangyongguang,zhang-wu设为评审人
CANN-robotCANN-robot成员
3月11日 添加了label:cann-cla/yes
CANN-robotCANN-robot成员
3月11日 将crystalhu,zhou-qilong,chenqi317,liubo75,tangweiwei2,zhangyuxiang0119,wangyongguang,zhang-wu设为审查人
此处折叠了51条消息 查看更多
CANN-robot
CANN-robot成员
3月11日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: zhangyuxiang0119, chenqi317.
Reviewers who wrote a comment of /lgtm are: zhangyuxiang0119, chenqi317.

likedislike
CANN-robot
CANN-robot成员
3月11日 评论:

The MR can not be merged, because of CodeReview discussion not resolved

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike
Cchenyanbin8
3月11日 解决了最后一个问题
CANN-robot
CANN-robot成员
3月11日 评论:

Review Guide

This pull-request passes review.
Committers who wrote a comment of /approve are: zhangyuxiang0119, chenqi317.
Reviewers who wrote a comment of /lgtm are: zhangyuxiang0119, chenqi317.

likedislike
CANN-robotCANN-robot成员
3月11日 合入了pull request