已合并
refactor(foreach): clean up magic numbers and code style in arch35 #5669
xuejinghui创建于 6月4日
refactor(foreach): clean up magic numbers and code style in arch35 #5669
已合并
xuejinghui创建于 6月4日
xuejinghui
6月4日

描述

Foreach系列算子修复多余空行/magic number等问题

关联的Issue

https://gitcode.com/cann/ops-nn/issues/3130

测试

文档更新

类型标签

  • 新特性
  • 新特性
  • 性能优化
  • 文档更新
  • 其他,请描述:codeCheck修复
likedislike
Pull Request已成功合入, 合并人@CANN-robot
(感谢 xuejinghui 的贡献)
Xxuejinghui
6月4日 创建了 pull request,commit 2807e72b
CANN-robotCANN-robot成员
6月4日 添加了label:cann-cla/yes
CANN-robot
CANN-robot成员
6月4日 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here
You can get sig-info at here


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
foreach 周奇龙, 陈琦 (2/2) 周奇龙, 陈琦 (2/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

xuejinghui, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
xuejinghui
6月4日 评论:

compile

likedislike
Xxuejinghui
6月4日 update merge request[project id: 7665709, iid: 5669, commit_id: 9a019391b81d0e4695e9d9d57bb9f4376a6f3e55] virtual merging success
CANN-robotCANN-robot成员
6月4日 添加了label:ci-pipeline-running
CANN-robot
CANN-robot成员
6月4日 评论:

流水线任务触发成功
任务链接 [20646c5f27b54fc6a56b08ee0b0fca88][流水线指导]

任务名称状态日志下载链接
Compile_Ascend_X86_ubuntu24 ❌ FAILED >>>>>
Compile_Ascend_X86_mobile_station ❌ FAILED >>>>>
Compile_Ascend_ARM ❌ FAILED >>>>>
Compile_Ascend_experimental ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_X86_950 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM_950 ✅ SUCCESS >>>>> >>>>>
Compile_Pre ✅ SUCCESS >>>>>
pre_comment ✅ SUCCESS >>>>>
Compile_Ascend_X86 ❌ FAILED >>>>>
Compile_Ascend_X86_mobile_station_ubuntu24 ❌ FAILED >>>>>
Compile_Ascend_X86_950_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM_ubuntu24 ❌ FAILED >>>>>
Compile_Ascend_experimental_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM_950_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_X86_monitor_910b ❌ FAILED >>>>>
Compile_X86_monitor_910c ❌ FAILED >>>>>
Compile_X86_monitor_950 ❌ FAILED >>>>>
Compile_classify ✅ SUCCESS >>>>>
likedislike
CANN-robot
CANN-robot成员
6月4日 评论:

流水线任务触发成功
任务链接 [70d101ff6e3b4b0d9273b920e93c1aa7][流水线指导]

任务名称状态日志下载链接
codecheck ✅ SUCCESS >>>>>
antipoison ✅ SUCCESS >>>>>
codecheck_checkpr ✅ SUCCESS
StaticCheck_codespell_check ✅ SUCCESS
StaticCheck_link_validity_check ✅ SUCCESS
StaticCheck_resource_existence_check ✅ SUCCESS
StaticCheck_tag_closed_check ✅ SUCCESS
StaticCheck_markdownlint ✅ SUCCESS
codecheck_style ✅ SUCCESS >>>>>
codecheck_precommit ⚠️ WARNING >>>>> >>>>>
SCA ✅ SUCCESS >>>>>

[2026-06-04 09:31:34]    CI执行结束

likedislike
Xxuejinghui
6月4日 update merge request[project id: 7665709, iid: 5669, commit_id: 9f578444743795897e7e14a6081950e81d4c2894] virtual merging success
Xxuejinghui
6月4日 强制推送  1 个提交:6480f930-refactor(foreach): clean up magic numbers and code style in arch35
Xxuejinghui
6月4日 update merge request[project id: 7665709, iid: 5669, commit_id: f7fad4919b7d890ff8a52cc944f06123f1114b83] virtual merging success
xuejinghui
6月4日 评论:

compile

likedislike
Xxuejinghui
6月4日 update merge request[project id: 7665709, iid: 5669, commit_id: a41813e1361ba5a75e07aa86d9c69efec700d88f] virtual merging success
CANN-robotCANN-robot成员
6月4日 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
6月4日 添加了label:ci-pipeline-running
CANN-robot
CANN-robot成员
6月4日 评论:

流水线任务触发成功
任务链接 [3f48f515b3954719bf1dcb1ca090ed28][流水线指导]

任务名称状态日志下载链接
Compile_Ascend_X86_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_X86_mobile_station ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_single ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_experimental ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_X86_950 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM_950 ✅ SUCCESS >>>>> >>>>>
Compile_Pre ✅ SUCCESS >>>>>
pre_comment ✅ SUCCESS >>>>>
Compile_Ascend_X86 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_X86_mobile_station_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_X86_950_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_single_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_experimental_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_Ascend_ARM_950_ubuntu24 ✅ SUCCESS >>>>> >>>>>
Compile_X86_monitor_910b ✅ SUCCESS >>>>> >>>>>
Compile_X86_monitor_910c ✅ SUCCESS >>>>> >>>>>
Compile_X86_monitor_950 ✅ SUCCESS >>>>> >>>>>
Compile_classify ✅ SUCCESS >>>>>
UT_Test_ophost ✅ SUCCESS
UT_Test_opapi ✅ SUCCESS
UT_Test_kernel ✅ SUCCESS
UT_Test_opgraph ✅ SUCCESS
PreSmoke_A900 ✅ SUCCESS >>>>>
API_Check ✅ SUCCESS >>>>>
PreSmoke_ATK_Test_A2 ✅ SUCCESS >>>>>
UT_Test_report_lcov ⚠️ WARNING >>>>>

[2026-06-04 10:47:15]    CI执行结束

likedislike
CANN-robot
CANN-robot成员
6月4日 评论:

流水线任务触发成功
任务链接 [e680d203999640a89190dd8ca5a8b359][流水线指导]

任务名称状态日志下载链接
codecheck ✅ SUCCESS >>>>>
antipoison ✅ SUCCESS >>>>>
codecheck_checkpr ✅ SUCCESS
StaticCheck_codespell_check ✅ SUCCESS
StaticCheck_link_validity_check ✅ SUCCESS
StaticCheck_resource_existence_check ✅ SUCCESS
StaticCheck_tag_closed_check ✅ SUCCESS
StaticCheck_markdownlint ✅ SUCCESS
codecheck_style ✅ SUCCESS >>>>>
codecheck_precommit ⚠️ WARNING >>>>> >>>>>
SCA ✅ SUCCESS >>>>>

[2026-06-04 09:52:22]    CI执行结束

likedislike
CANN-robotCANN-robot成员
6月4日 添加了label:api-check-pass
CANN-robotCANN-robot成员
6月4日 删除了label:ci-pipeline-running
CANN-robotCANN-robot成员
6月4日 添加了label:ci-pipeline-passed
Xxuejinghui
6月5日 修改了pull request 的描述
xuejinghui
6月5日 评论:
likedislike
chenfeng
chenfeng成员
6月5日 评论:

/lgtm
/approve

likedislike
CANN-robot
CANN-robot成员
6月5日 评论:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
陈风

likedislike
CANN-robot
CANN-robot成员
6月5日 评论:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
陈风

likedislike
Xxuejinghui
6月5日 修改了pull request 的描述
sunday成员
6月5日 评论:

/lgtm
/approve

likedislike
CANN-robot
CANN-robot成员
6月5日 评论:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
陈风

likedislike
CANN-robotCANN-robot成员
6月5日 添加了label:approved
CANN-robot
CANN-robot成员
6月5日 评论:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
陈风

likedislike
chenqi317成员
6月6日 评论:

/lgtm
/approve

likedislike
CANN-robot
CANN-robot成员
6月6日 评论:

The following users do not have permission to comment /lgtm or /approve on any module in this PR:
陈风

likedislike
CANN-robotCANN-robot成员
6月6日 添加了label:lgtm
CANN-robotCANN-robot成员
6月6日 关闭了关联的issue
CANN-robotCANN-robot成员
6月6日 合入了pull request