Pull Request已成功合入, 合并人@CANN-robot
(感谢 青青吾心 的贡献)Thanks for your pull-request.
The full list of commands accepted by me can be found at here。
You can get sig-info at here
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| index | ✅ 唐燕峰, 唐玮玮 (2/2) | ✅ 唐燕峰, 唐玮玮 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
weixin_47641640, thanks for your pull request. All authors of the commits have signed the CLA. 👍


compile


流水线任务触发成功
任务链接 [642dfe9614dd4bc3a525bd5f48846b1a][流水线指导]
| 任务名称 | 状态 | 日志 | 下载链接 |
|---|---|---|---|
| Compile_Ascend_X86_ubuntu24 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_X86_mobile_station | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_ARM | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_single | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_experimental | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_X86_950 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_ARM_950 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Pre | ✅ SUCCESS | >>>>> | |
| pre_comment | ✅ SUCCESS | >>>>> | |
| Compile_Ascend_X86 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_X86_mobile_station_ubuntu24 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_X86_950_ubuntu24 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_ARM_ubuntu24 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_single_ubuntu24 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_experimental_ubuntu24 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_Ascend_ARM_950_ubuntu24 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_X86_monitor_910b | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_X86_monitor_910c | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_X86_monitor_950 | ✅ SUCCESS | >>>>> | >>>>> |
| Compile_classify | ✅ SUCCESS | >>>>> | |
| UT_Test_ophost | ✅ SUCCESS | ||
| UT_Test_opapi | ✅ SUCCESS | ||
| UT_Test_kernel | ✅ SUCCESS | ||
| UT_Test_opgraph | ✅ SUCCESS | ||
| PreSmoke_A900 | ✅ SUCCESS | >>>>> | |
| API_Check | ✅ SUCCESS | >>>>> | |
| PreSmoke_ATK_Test_A2 | ✅ SUCCESS | >>>>> | |
| UT_Test_report_lcov | ⚠️ WARNING | >>>>> |
[2026-06-25 21:39:27] CI执行结束


流水线任务触发成功
任务链接 [87ebfb3fbbf14abb8216f92987f3398a][流水线指导]
| 任务名称 | 状态 | 日志 | 下载链接 |
|---|---|---|---|
| codecheck | ✅ SUCCESS | >>>>> | |
| antipoison | ✅ SUCCESS | >>>>> | |
| codecheck_checkpr | ✅ SUCCESS | ||
| StaticCheck_codespell_check | ✅ SUCCESS | ||
| StaticCheck_link_validity_check | ✅ SUCCESS | ||
| StaticCheck_resource_existence_check | ✅ SUCCESS | ||
| StaticCheck_tag_closed_check | ✅ SUCCESS | ||
| StaticCheck_markdownlint | ✅ SUCCESS | ||
| codecheck_style | ✅ SUCCESS | >>>>> | |
| codecheck_precommit | ⚠️ WARNING | >>>>> | >>>>> |
| SCA | ✅ SUCCESS | >>>>> |
[2026-06-25 21:14:11] CI执行结束


代码审查
审查总结
逐文件审查结果:
| 文件 | 审查结论 |
|---|---|
index/scatter_elements/op_kernel_aicpu/CMakeLists.txt |
无问题 — 移除 v2 专属的依赖检查和 target 跟踪,恢复为与其他所有 AICPU op 一致的标准模式 |
index/scatter_elements/op_kernel_aicpu/scatter_elements_aicpu.cpp |
1 个 P3 建议(<memory> 头文件移除) |
index/scatter_elements/op_kernel_aicpu/scatter_elements_aicpu_def.cpp |
无问题 — 移除 v2 新增的 axis/reduction/include_self 属性和 OPEN_OPS_FLAG |
index/scatter_elements/tests/ut/op_kernel_aicpu/test_scatter_elements.cpp |
无问题 — 移除了与已移除功能对应的测试用例 |
index/scatter_elements_v2/tests/st/aclnnScatterReduce/atk_aclnnScatterReduce.json |
无问题 — 仅 +1/-1 微小变更,无法检测到具体问题 |
按优先级统计: P0: 0, P1: 0, P2: 0, P3: 1
整体风险评估:低风险。 这是一个干净的回退(revert),将 scatter_elements AICPU kernel 从 v2 版本(支持 max/min/mean/include_self 等归约操作)回退到原始的简化版本(仅支持 none/add/mul)。CMakeLists.txt 恢复了与其他 op 一致的标准模式;核心计算逻辑正确地将 reduction 简化到三种基本操作;op 定义文件恢复为 pre-v2 状态;测试文件正确移除了不再适用的测试用例。唯一的小问题是 #include <memory> 被移除但 std::shared_ptr 仍被直接使用,依赖传递包含,属于代码卫生问题。
⚠️ 已识别出整体风险,但无法提取行内评论,请参考整体评估。


/lgtm
/approve


/lgtm
/approve


描述
回退scatter_elements_v2A算子的AICPU新增代码逻辑,保证顺利出包
关联的Issue
https://gitcode.com/cann/ops-nn/issues/2654
测试
文档更新
类型标签