Pull Request已成功合入, 合并人@CANN-robot
(感谢 xieshengwei1024 的贡献)变更摘要
该 PR 为 AscendC 向量接口(vf 接口)的整改与重命名重构(源分支 refactor/rename-ascendc-api),不涉及业务逻辑调整,PR 描述声明"修改后二进制未变化"。改动主要针对 arch35 下多个算子的内核实现,将旧版 API 统一替换为新版接口:DataCopy 按读写方向拆分为 LoadAlign/StoreAlign,ReduceSum/ReduceMax/ReduceMin 统一为带模板参数的 Reduce<ReduceType::...>,CompareScalar 改为 Compares,ReduceMaxWithDataBlock 改为 ReduceDataBlock<ReduceType::MAX>,MaskNot/MaskAnd 改为 Not/And,并将 __local_mem__ 指针标注统一更正为 __ubuf__。
主要改动
- 规约接口统一为
Reduce<ReduceType::...>:在swiglu_group_base.h、swiglu_group_quant_base.h、foreach_norm_regbase.h、foreach_non_finite_check_and_unscale_regbase.h中,将ReduceSum、ReduceMax、ReduceMin分别替换为Reduce<ReduceType::SUM>、Reduce<ReduceType::MAX>、Reduce<ReduceType::MIN>,将ReduceMaxWithDataBlock替换为ReduceDataBlock<ReduceType::MAX>。 - 数据搬移接口按读写拆分:在
foreach_addcmul_scalar_regbase.h、foreach_mul_scalar_list_regbase.h、foreach_non_finite_check_and_unscale_regbase.h、foreach_norm_regbase.h、sigmoid_cross_entropy_with_logits_v2_dag.h中,将双向的DataCopy替换为读方向LoadAlign、写方向StoreAlign,并保留PostLiteral::POST_MODE_UPDATE、StoreDist::DIST_FIRST_ELEMENT_B32、LoadDist::DIST_BRC_B32等原有模式参数。 - 寄存器比较与掩码接口改名:在
swiglu_group_quant_base.h中,CompareScalar<uint16_t, CMPMODE::GT/LT>改为Compares<uint16_t, CMPMODE::GT/LT>,MaskAnd改为And、MaskNot改为Not,函数语义与调用参数保持一致。 - UB 指针标注统一为
__ubuf__:在多个foreach_*与group_norm_silu系列的regbase/welford头文件(如group_norm_silu_regbase_two_pass.h、group_norm_silu_regbase_welford_generalized.h等)中,将指向 UB 内存的__local_mem__指针声明及GetPhyAddr()处的强转统一改为__ubuf__。


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| activation | ✅ 钱泽洪, 汤平川 (2/2) | ✅ 钱泽洪, 汤平川 (2/1) |
| foreach | ✅ 汤平川, 钱泽洪 (2/2) | ✅ 钱泽洪, 汤平川 (2/1) |
| loss | ✅ 汤平川, 钱泽洪 (2/2) | ✅ 汤平川, 钱泽洪 (2/1) |
| norm | ✅ 汤平川, 钱泽洪 (2/2) | ✅ 钱泽洪, 汤平川 (2/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
xieshengwei1024, thanks for your pull request. All authors of the commits have signed the CLA. 👍


/approve


/lgtm
/approve


描述
整改vf接口
关联的Issue
测试
已验证,修改后二进制未变化
文档更新
类型标签
AI/Agent生成声明