Pull Request已成功合入, 合并人@CANN-robot
(感谢 duxinlei 的贡献)变更摘要
本 PR 为「日志规范性整改」(Bug 修复),针对 index/embedding、index/embedding_bag、index/embedding_dense_grad、pooling/adaptive_avg_pool2d、pooling/avg_pool3_d、pooling/max_pool3d_grad、pooling/max_pool_with_argmax 等算子模块的日志文案进行统一整改。改动不涉及业务逻辑,主要集中修正日志消息中的拼写/语法错误、纠正日志中引用的错误标识符与实际取值、为日志补充真实参数值(如 dtype、format、维度数值)、删除调试输出并调整日志级别,使日志更规范、可读且便于定位问题。
主要改动
- 修正日志文案的语法与拼写错误:将
"Get aivNum form compileInfo"改为"Get aivNum from compileInfo"、"samller than 0"改为"smaller than 0"、"is begin"改为"begins"、"is not match with"改为"does not match"、"invaild"改为"invalid"、"negtive"改为"negative"等,覆盖embedding_*与pooling/*各算子。 - 纠正日志中的错误标识符与对象名:如
embedding_dense_grad_tiling.cpp中"EmeddingDenseGrad"改为"EmbeddingDenseGrad"、embedding_dense_grad.cpp中"EmbeddingDenseGradAiCcore"改为"EmbeddingDenseGradAiCore"、aclnn_max_pool2d_with_indices_backward.cpp中将错误引用"The gradOutput Cast"纠正为"The gradInput Cast",并修正max_pool_grad_with_argmax_infershape.cpp中错误的索引描述"strides[3]"为"strides[1]"。 - 日志补充实际取值:
aclnn_adaptive_avg_pool2d_backward.cpp将硬编码的0替换为实际的selfShape.GetDim(i)/gradOutputShape.GetDim(i);adaptive_max_pool3d_grad、avg_pool3_d_grad等在格式校验日志中追加实际的[%s]格式值;embedding_bag_tiling.cpp与max_pool_v3_small_kernel_tiling.cpp等日志中打印computeRepTime_、minInRows等实际数值。 - 修正日志级别与清理调试输出:
max_pool3d_grad_small_kernel_tiling.cpp、max_pool_grad_nchw_tiling.cpp中将输入格式不符时的OP_LOGI提升为OP_LOGW;aclnn_adaptive_avg_pool3d_backward.cpp删除调试用的printf("wyh invalid format\n")。 - 修正宏调用参数与数值描述:
max_pool3d_grad_with_argmax_tiling_base_arch35.cpp中将OP_LOGE_FOR_INVALID_*_WITH_REASON的占位字符串(如"invalid_dtypes"、"invalid_shapes")替换为实际信息(如ge::TypeUtils::DataTypeToSerialString(...)、"shape check failed");aclnn_max_pool3d_with_argmax_backward.cpp将限制描述"2^32 - 1"修正为"2^31 - 1",并统一跨行字符串拼接规范。


Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| activation | ✅ 汤平川, 黄迪 (2/2) | ✅ 汤平川, 黄迪 (2/1) |
| index | ✅ 黄迪, 汤平川 (2/2) | ✅ 汤平川, 黄迪 (2/1) |
| pooling | ✅ 汤平川, 黄迪, 刘闯 (3/2) | ✅ 汤平川, 黄迪, 刘闯 (3/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
duxinlei, thanks for your pull request. All authors of the commits have signed the CLA. 👍


/lgtm
/approve


/lgtm
/approve


描述
给activation/pooling/index下部分算子做日志规范性整改,修改pr拼写错误、内容错误、关键信息泄露问题;
仅对loge内容做修改,其余部分为pre-commmit格式修改;
关联的Issue
关联Issue #5185
测试
david冒烟
obp冒烟
文档更新
类型标签
AI/Agent生成声明