Pull Request已成功合入, 合并人@CANN-robot
（感谢 Nice try 的贡献）
变更摘要
该 PR 旨在修复返回值判断应与函数调用紧密衔接的问题。改动仅发生在 conv3d_backprop_filter_v2_basic_block_tiling.cpp 的 Conv3DDWV2BasicBlockTiling::AdjustSingleNForStreamK 函数中：删除了 maxStreamKDim = std::max(maxStreamKDim, batchDoutDim); 赋值语句与其后 if (maxStreamKDim <= STREAM_K_DIM_MIN ...) 返回值判断之间的一个空行，使判断语句紧随函数调用之后。本次改动不涉及任何逻辑变更，纯为代码排版调整。
主要改动
- 删除函数调用与判断之间的空行: 在
AdjustSingleNForStreamK中移除std::max调用与if (maxStreamKDim <= STREAM_K_DIM_MIN || tailCnt + STREAM_K_TAIL_TOLERANCE >= targetCoreNum)判断之间的空行，使返回值判断紧跟函数调用，与 PR 标题所述意图一致。 - 无功能影响: 改动仅删除 1 行空白，
maxStreamKDim的计算、STREAM_K_DIM_MIN及STREAM_K_TAIL_TOLERANCE相关判断逻辑均保持不变，对外部行为无影响。
Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.
PR Approval Progress
✅ Congratulations! All modules have met the lgtm and approve requirements.
Module Approval Details
| module | lgtm status | approve status |
|---|---|---|
| conv | ✅ 柳宗谷, 汤平川 (2/2) | ✅ 柳宗谷 (1/1) |
💡 Tip:
- Committer can comment
/approveor/lgtm- Commenting
/approveimplies both code review (lgtm) and intent to merge (approve)
CLA Signature Pass
Nice_try, thanks for your pull request. All authors of the commits have signed the CLA. 👍
/lgtm
/approve
描述
对
conv/convolution_backward/op_api/aclnn_convolution_backward.cpp中aclnnConvolutionBackwardGetWorkspaceSize与aclnnConvTbcBackwardGetWorkspaceSize的空指针检查进行代码清理（cleancode）：if (x != nullptr)条件包裹Contiguous调用，现改为在参数检查后统一执行防御性空指针校验（CHECK_RET(..., ACLNN_ERR_PARAM_NULLPTR)），随后无条件调用Contiguous，消除条件嵌套，使返回值判断紧随函数调用；CheckParams()/CheckTbcParams()内部第一步即通过CheckNotNull()/CheckTbcNotNull()强制上述入参非空（否则返回ACLNN_ERR_PARAM_NULLPTR并提前退出），因此本改动不改变任何运行时行为，仅提升代码可读性与可维护性；conv/conv3d_backprop_filter_v2/op_host/op_tiling/arch22/conv3d_backprop_filter_v2_basic_block_tiling.cpp中AdjustSingleNForStreamK()函数内的多余空行。关联的Issue
测试
文档更新
无
类型标签
AI/Agent生成声明