Aasargent@chromium.orgDisable ExtensionApiTest.NativeMessageBasic
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Disable ExtensionApiTest.NativeMessageBasic The CL that introduced this was reverted, but that had to be reverted because of compile failures, and somehow a data file this depends on didn't get re-added. Just disable it until the revert can be re-landed. Make sense? :) TBR=mpcomplete@chromium.org BUG=142915 Review URL: https://codereview.chromium.org/10979038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158874 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
After delegating to chrome.exe (i.e. to launch a packaged app) check if app_host is out-of-date and, if so, invoke the Chrome Binaries installer to update it. R=erikwright,grt TBR=brettw BUG=138315 NOTRY=True TEST=Install Chrome vX at system level. Install App Host vY at user-level, where Y < X. Launch app_host.exe. Inspect "Properties" of app_host.exe and verify that it has been updated to vX. Review URL: https://chromiumcodereview.appspot.com/10905238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156934 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove default apps for Chrome OS from public repository BUG=chromium-os:6318 TEST=none Review URL: http://codereview.chromium.org/3353016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58917 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Reset registered events and dispatch runtime.onInstalled to all extensions when Chrome is updated. BUG=148898 Review URL: https://chromiumcodereview.appspot.com/10941003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157685 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Speculative revert did not stablize the tests... see crbug.com/149157 Revert 156865 - Revert 156744 - chromeos: Use EventRouterForwarder to disptch systemPrivate extension events Reason: Seem to be causing ExtensionServiceTest unit_tests timeout on "Linux ChromiumOS Tests (1)". See crbug.com/149157 for details. BUG=148552 TEST=Boot a Chromebook, type the password for a user, start pressing brightness up/down key randomly, press Enter to login while keeping pressing brightness keys, ensure no crash report is sent during login. Review URL: https://chromiumcodereview.appspot.com/10905250 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/10919299 TBR=satorux@chromium.org Review URL: https://codereview.chromium.org/10928211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156893 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify more ExtensionService methods, and IWYU. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10834078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152105 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add benwells and jeremya as extensions owners BUG=None Review URL: https://chromiumcodereview.appspot.com/10926002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154812 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Renamed old bot to existing trybot. TBR=ben@chromium.org BUG=112154 TEST=none Review URL: https://chromiumcodereview.appspot.com/9325016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120259 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make ActiveTabPermissionManager also grant the tabs permission for that tab; only respected for tabs.executeScript and tabs.insertCSS. This involved converting tabs.executeScript/insertCSS to use JSON schema compiler. BUG=137643 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10815028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149631 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extension white and force lists (set by policy) should have priority over auto-updated Google blacklist. BUG=93246 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10854009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152548 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extension white and force lists (set by policy) should have priority over auto-updated Google blacklist. BUG=93246 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10854009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152548 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extension white and force lists (set by policy) should have priority over auto-updated Google blacklist. BUG=93246 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10854009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152548 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionHost into extensions namespace BUG=139042,117261 Review URL: https://chromiumcodereview.appspot.com/10824030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149295 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert Review URL: https://chromiumcodereview.appspot.com/10920070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154730 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create content\public\test\test_utils.h to hold common test classes that are used by unit and browser tests. unit tests shouldn't be including ui_test_utils.h. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10807047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147602 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved the AppNotification system into extensions namespace Moved AppNotification, AppNotificationManager, AppNotificationStorage, AppNotifyChannelSetup, and AppNotifyChannelUI into extensions namespace. BUG=139148, 117261 Review URL: https://chromiumcodereview.appspot.com/10830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149444 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create chrome/browser/api directory. Move infobar delegates used by Autofill to the directory. Also, consolidate infobar delegate interfaces under infobars/ rather than some under infobars/ and some under tab_contents/, as the ones under tab_contents/ were not coupled with tab_contents/ in any way. Remove feedback/proto/extension.pb.h from Autofill's DEPS file simply by dropping the include, it was not being used. BUG=140037,138280 Review URL: https://chromiumcodereview.appspot.com/10843071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151279 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Grant popup blocker bypass based upon extension context type. BUG=117446 Review URL: https://chromiumcodereview.appspot.com/10990038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158864 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Packaged apps are now enabled by default (and arguments on launcher shortcuts are unlikely to function when chrome is already running), so this extra argument on shortcuts can be dropped. BUG=146037 TEST=ensure shortcuts for packaged apps are still created (e.g. on desktop), and can execute successfully Review URL: https://chromiumcodereview.appspot.com/10915079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155118 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland r145993. Original codereview at http://codereview.chromium.org/10766016/ [Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=stevet@chromium.org, rlarocque@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10690128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Generalize StringOrdinal to handle ordinal_in_parent field Rename StringOrdinal to Ordinal, move it to sync/, and templatize it. Make StringOrdinal be an instantiation of Ordinal that matches its previous behavior. Create NodeOrdinal, which is another instantiation of Ordinal for the ordinal_in_parent field in SyncEntity. Rework Ordinal to handle arbitrary byte ranges and to simplify the interpolation code a bit. Generalize StringOrdinal unit tests for Ordinal. Update users of StringOrdinal to prepend syncer::. BUG=145412 TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10920017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Generalize StringOrdinal to handle ordinal_in_parent field Rename StringOrdinal to Ordinal, move it to sync/, and templatize it. Make StringOrdinal be an instantiation of Ordinal that matches its previous behavior. Create NodeOrdinal, which is another instantiation of Ordinal for the ordinal_in_parent field in SyncEntity. Rework Ordinal to handle arbitrary byte ranges and to simplify the interpolation code a bit. Generalize StringOrdinal unit tests for Ordinal. Update users of StringOrdinal to prepend syncer::. BUG=145412 TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10920017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Generalize StringOrdinal to handle ordinal_in_parent field Rename StringOrdinal to Ordinal, move it to sync/, and templatize it. Make StringOrdinal be an instantiation of Ordinal that matches its previous behavior. Create NodeOrdinal, which is another instantiation of Ordinal for the ordinal_in_parent field in SyncEntity. Rework Ordinal to handle arbitrary byte ranges and to simplify the interpolation code a bit. Generalize StringOrdinal unit tests for Ordinal. Update users of StringOrdinal to prepend syncer::. BUG=145412 TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10920017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactoring: ProtocolHandler::MaybeCreateJob and other functions take NetworkDelegate as argument This change goes a long way to prepare for removing NetworkDelegate from URLRequestContext. TBR=sky@chromium.org, michaeln@chromium.org, benjhayden@chromium.org, brettw@chromium.org, ben@chromium.org, davemoore@chromium.org, zelidrag@chromium.org, mnissler@chromium.org, thestig@chromium.org, asargent@chromium.org, jhawkins@chromium.org, bulach@chromium.org BUG=crbug.com/142945 Review URL: https://chromiumcodereview.appspot.com/10855209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153133 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactoring: ProtocolHandler::MaybeCreateJob and other functions take NetworkDelegate as argument This change goes a long way to prepare for removing NetworkDelegate from URLRequestContext. TBR=sky@chromium.org, michaeln@chromium.org, benjhayden@chromium.org, brettw@chromium.org, ben@chromium.org, davemoore@chromium.org, zelidrag@chromium.org, mnissler@chromium.org, thestig@chromium.org, asargent@chromium.org, jhawkins@chromium.org, bulach@chromium.org BUG=crbug.com/142945 Review URL: https://chromiumcodereview.appspot.com/10855209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153133 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Re-enable extension GPU features. Re-enabling GPU-related features for extension pages, incl. background pages. One new ExtensionBrowserTest ExtensionBrowserTest.Canvas2D: tests using Canvas2D from an extension background page I had also created a second test, but subsequently removed it due to failures on linux_chromeos trybots that don't reproduce locally: ExtensionBrowserTest.BackgroundGL: tests creating a WebGL context from extension background page BUG=chromium-os:26524 TEST=browser_tests ExtensionBrowserTest.* TEST=Run Chat for Google extension with PPAPI gtalk/o3d Review URL: http://codereview.chromium.org/9624013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125966 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Introduce background.scripts feature for extension manifests. This optimizes for the common use case where background pages just include a reference to one or more script files and no additional HTML. BUG=107791 Review URL: http://codereview.chromium.org/9150008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117110 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update browserAction.setIcon and pageAction.setIcon for hidpi added support to defining icon as dictionary of paths/imageDatas with keys 19, 38. (new optional details parameters details.imageDataSet, details.pathSet) Dictionary values define icon's imageSkia representations for 1x and 2x scale respectively. BUG= 138025 Review URL: https://chromiumcodereview.appspot.com/10855154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155856 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update browserAction.setIcon and pageAction.setIcon for hidpi added support to defining icon as dictionary of paths/imageDatas with keys 19, 38. (new optional details parameters details.imageDataSet, details.pathSet) Dictionary values define icon's imageSkia representations for 1x and 2x scale respectively. BUG= 138025 Review URL: https://chromiumcodereview.appspot.com/10855154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155856 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update browserAction.setIcon and pageAction.setIcon for hidpi added support to defining icon as dictionary of paths/imageDatas with keys 19, 38. (new optional details parameters details.imageDataSet, details.pathSet) Dictionary values define icon's imageSkia representations for 1x and 2x scale respectively. BUG= 138025 Review URL: https://chromiumcodereview.appspot.com/10855154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155856 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Always send the full tab object in ExtensionAction click event. Along the way, decompose a few swiss army knife functions to simplify and generalize code. BUG=149020 Review URL: https://codereview.chromium.org/10909256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157082 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Always send the full tab object in ExtensionAction click event. Along the way, decompose a few swiss army knife functions to simplify and generalize code. BUG=149020 Review URL: https://codereview.chromium.org/10909256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157082 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert Review URL: https://chromiumcodereview.appspot.com/10920070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154730 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert Review URL: https://chromiumcodereview.appspot.com/10920070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154730 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.2 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - ExtensionDataDeleter (now extensions::DataDeleter) - ExtensionNavigationObserver (now extensions::NavigationObserver) - PackExtensionJob - PlatformAppBrowsertest - ShellWindowRegistry - ExtensionStartupUtil (see note in file) BUG=117261 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151535 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't show host permission warnings for platform apps. Since platform apps always use isolated storage, they can't (silently) access user data on other domains, so there's no need to prompt. BUG=130680 R=aa@chromium.org TBR=phajdan.jr@chromium.org,atwilson@chromium.org Review URL: https://chromiumcodereview.appspot.com/10837060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149688 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. This is so we can create one BrowserListImpl per universe. Eventually we'll get rid of BrowserList, but for now this change strives for compat. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10690151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146476 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Wired background loader component extension. TEST=make sure selected background pages are periodically loaded BUG=141677 Review URL: https://chromiumcodereview.appspot.com/10855239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156137 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PrefMember and PrefChangeRegistrar to api directory. This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move Extension into extensions namespace BUG=117262 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added check to prevent extensions from injecting scrips into pages hosted in iframe context of other extensions (other than itself). BUG=126257 TEST=ExtensionApiTest.ContentScriptOtherExtensions, added new checks to ExtensionScriptAndCaptureVisibleTest.Permissions Review URL: https://chromiumcodereview.appspot.com/10863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152955 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable CSP by default for extensions with manifest_version >= 2. Review URL: http://codereview.chromium.org/8585020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110531 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move UserScript and related into extensions namespace Moved UserScript, UserScriptMaster, UserScriptSlave, UserScriptListener, and UserScriptScheduler into extensions namespace. BUG=136876, 117261 Review URL: https://chromiumcodereview.appspot.com/10696176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146682 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move UserScript and related into extensions namespace Moved UserScript, UserScriptMaster, UserScriptSlave, UserScriptListener, and UserScriptScheduler into extensions namespace. BUG=136876, 117261 Review URL: https://chromiumcodereview.appspot.com/10696176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146682 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move UserScript and related into extensions namespace Moved UserScript, UserScriptMaster, UserScriptSlave, UserScriptListener, and UserScriptScheduler into extensions namespace. BUG=136876, 117261 Review URL: https://chromiumcodereview.appspot.com/10696176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146682 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.1 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - AppShortcutManager - AutoUpdateInterceptor - ConvertWebApp - ExtensionActivityLog (now extensions::ActivityLog) BUG=117261 TBR=jam@chromium.org, willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152159 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove FLAKY modifier from CrossOriginXHRFileAccess, it hasn't failed in the past month. R=asargent@chromium.org BUG=105179 Review URL: http://codereview.chromium.org/9314046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120124 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Moved CrxInstaller and CrxInstallerError into extensions namespace BUG=134756, 117261 Review URL: https://chromiumcodereview.appspot.com/10683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148244 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved CrxInstaller and CrxInstallerError into extensions namespace BUG=134756, 117261 Review URL: https://chromiumcodereview.appspot.com/10683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148244 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support an --install-from-webstore command line switch This is to make standalone installation of apps from the Chrome app host possible. BUG=138311 TBR=sky@chromium.org (for chrome/common/chrome_switches.{h,cc}) Review URL: https://chromiumcodereview.appspot.com/10907104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157088 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enforce the 'requirements' field in manifests. Try 2. First try: https://chromiumcodereview.appspot.com/10689097 BUG=133027, 130405 TBR=jhawkins@chromium.org, aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156119 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Mark ExtensionCrxInstaller.GrantScopes as flaky on Windows. BUG=141913 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10829460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152634 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved CrxInstaller and CrxInstallerError into extensions namespace BUG=134756, 117261 Review URL: https://chromiumcodereview.appspot.com/10683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148244 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
continuing from http://http://codereview.chromium.org/10823241 This intentionally doesn't change the ChromeOS behavior at all. They all still use the default FileSystemContext. This code also exposes the normal and media URLRequestGetters via the StoragePartition, and cleans up a bit of code that was accessing the URLRequestGetter in odd ways. Also, it makes Workers correctly use the Media Cache for Media fetches. TBR=benjhyden,sky,davemoore,piman,mkwst,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10909182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157284 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move IndexedDBContext into the StoragePartition and ensure isolation. This pickups up from http://codereview.chromium.org/10836216. After this, IndexedDB should be properly isolated in ChromeApps and Isolated Sites. TBR=kalman,sky,mkwst BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10919307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157045 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reliably install default apps into new installations. r139107 changed the check to see if the profile that we're running it was created by the current Chrome version. This does not appear to be true for the default profile created during the first run (it doesn't have an explicit profile.created_by_version preference, and the default value is 1.0.0), so bring back the IsChromeFirstRun check (the profile version check is still kept for additional profiles that are created). BUG=145351 R=asargent@chromium.org TEST=do a clean install of Chrome, the default profile should have the Gmail, YouTube and Search apps. Same for additional profiles that are created. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154450 Review URL: https://chromiumcodereview.appspot.com/10916041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154532 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable install of new default apps for existing users. Also moves the DefaultAppsTest in extension_service_unittest.cc to a separate file. BUG=138614 Review URL: https://chromiumcodereview.appspot.com/10875065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154064 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename constants used with default apps to confrom with naming convention. BUG=None TEST=No functionality change. Simply renaming constants. Review URL: http://codereview.chromium.org/8805022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113205 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove not required return statement in DefaultAppsTest. Review URL: https://chromiumcodereview.appspot.com/10912020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154290 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correct const accessors in base/values.(h|cc), Part II (ListValue) For problem description and other info please see the BUG page. This is for ListValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj Review URL: https://chromiumcodereview.appspot.com/10837044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149819 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert Review URL: https://chromiumcodereview.appspot.com/10920070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154730 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 157030 - breakage was due to something else. Revert 156348 (caused http://crbug.com/149828) - Change getDevices to use a DeviceCallback. This modifies the getDevices method of the bluetooth Extensions API to accept a DeviceCallback, which will be called for every matching device. This will allow more thorough, long-running searches (involving SDP queries) to be performed without slowing down access to matching devices that can be returned quickly. TEST=api test updated BUG=134545 Review URL: https://chromiumcodereview.appspot.com/10915148 TBR=bryeung@chromium.org Review URL: https://codereview.chromium.org/10916331 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157036 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 157030 - breakage was due to something else. Revert 156348 (caused http://crbug.com/149828) - Change getDevices to use a DeviceCallback. This modifies the getDevices method of the bluetooth Extensions API to accept a DeviceCallback, which will be called for every matching device. This will allow more thorough, long-running searches (involving SDP queries) to be performed without slowing down access to matching devices that can be returned quickly. TEST=api test updated BUG=134545 Review URL: https://chromiumcodereview.appspot.com/10915148 TBR=bryeung@chromium.org Review URL: https://codereview.chromium.org/10916331 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157036 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reset registered events and dispatch runtime.onInstalled to all extensions when Chrome is updated. BUG=148898 Review URL: https://chromiumcodereview.appspot.com/10941003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157685 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reset registered events and dispatch runtime.onInstalled to all extensions when Chrome is updated. BUG=148898 Review URL: https://chromiumcodereview.appspot.com/10941003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157685 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Remove unneeded includes of chrome_switches.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/6086003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert Review URL: https://chromiumcodereview.appspot.com/10920070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154730 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionHost into extensions namespace BUG=139042,117261 Review URL: https://chromiumcodereview.appspot.com/10824030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149295 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Generalize StringOrdinal to handle ordinal_in_parent field Rename StringOrdinal to Ordinal, move it to sync/, and templatize it. Make StringOrdinal be an instantiation of Ordinal that matches its previous behavior. Create NodeOrdinal, which is another instantiation of Ordinal for the ordinal_in_parent field in SyncEntity. Rework Ordinal to handle arbitrary byte ranges and to simplify the interpolation code a bit. Generalize StringOrdinal unit tests for Ordinal. Update users of StringOrdinal to prepend syncer::. BUG=145412 TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10920017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158691 - Give platform apps control over launcher right-click context menu. This moves most of the extension context menu related code from RenderViewContextMenu to a seperate class, which is then used in two other places as well. Reverted due to failures on Mac testers in: ExtensionContextMenuBrowserLazyTest.EventPage http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20(dbg)(1)/builds/1693/steps/browser_tests/logs/EventPage BUG=143222 Review URL: https://chromiumcodereview.appspot.com/10918103 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/10984034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158705 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move SessionID, CaptureVisibleTabFunction to WebContents. BUG=107201 TEST=no visible change TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10912156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155811 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow chrome.management.setEnabled() to re-enable crashed extensions. BUG=131977 Review URL: https://chromiumcodereview.appspot.com/10832237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153992 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionCreator and ExtensionCreatorFilter into extensions namespace BUG=134696, 117261 Review URL: https://chromiumcodereview.appspot.com/10665053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146134 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionCreator and ExtensionCreatorFilter into extensions namespace BUG=134696, 117261 Review URL: https://chromiumcodereview.appspot.com/10665053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146134 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove obviously unneeded forward declarations in chrome/browser/[abef]*/*.h. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3027041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55136 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionHost into extensions namespace BUG=139042,117261 Review URL: https://chromiumcodereview.appspot.com/10824030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149295 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable extension APIs for content scripts. This only enables extension functions. I will do events in a separate change. BUG=81760,80308 Review URL: http://codereview.chromium.org/8540012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109812 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove task.h and finish base::Bind() migration. Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support multiple disable reasons in ExtensionPerfs Use a bitmask to represent all the reasons an extension is disabled. Switch to a new key in ExtensionPrefs for the bitmask. When we init ExtensionPrefs, check for the old key, migrate the reason over to the new key, and delete the old key. BUG=142762 Review URL: https://chromiumcodereview.appspot.com/10828316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151785 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Put simple_message_box.h and chrome_web_contents_view_delegate.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145421 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Have different text for apps and regular extensions in some more places. BUG=146699 Review URL: https://chromiumcodereview.appspot.com/10905188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156622 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Have different text for apps and regular extensions in some more places. BUG=146699 Review URL: https://chromiumcodereview.appspot.com/10905188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156622 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Making ExtensionService less dependent on Browser. As part of the effort to get unit-tests linking on Android, making ExtensionService depend less on Browser. More specifically abstracting the use of the GlobalError class through a new ExtensionErrorUI class so that ExtensionService does not need direct access to Browser. BUG=None TEST=Unit-tests should still pass. Review URL: https://chromiumcodereview.appspot.com/10696210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146870 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Making ExtensionService less dependent on Browser. As part of the effort to get unit-tests linking on Android, making ExtensionService depend less on Browser. More specifically abstracting the use of the GlobalError class through a new ExtensionErrorUI class so that ExtensionService does not need direct access to Browser. BUG=None TEST=Unit-tests should still pass. Review URL: https://chromiumcodereview.appspot.com/10696210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146870 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixed segmentation fault in ExtensionErrorUIDefault::ExtensionGlobalError::OnBubbleViewDidClose BUG=142336 Review URL: https://chromiumcodereview.appspot.com/10832273 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151451 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Making ExtensionService less dependent on Browser. As part of the effort to get unit-tests linking on Android, making ExtensionService depend less on Browser. More specifically abstracting the use of the GlobalError class through a new ExtensionErrorUI class so that ExtensionService does not need direct access to Browser. BUG=None TEST=Unit-tests should still pass. Review URL: https://chromiumcodereview.appspot.com/10696210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146870 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make quota requests from background pages not crash BUG=149804 Review URL: https://chromiumcodereview.appspot.com/10948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158184 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make all quota-exceeding messages in the storage API explain what the failure is. This involves adding descriptions to all errors from ExtensionsQuotaService, affecting the other APIs that use this (bookmarks and webRequest). BUG=144533 Review URL: https://chromiumcodereview.appspot.com/10871034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make all quota-exceeding messages in the storage API explain what the failure is. This involves adding descriptions to all errors from ExtensionsQuotaService, affecting the other APIs that use this (bookmarks and webRequest). BUG=144533 Review URL: https://chromiumcodereview.appspot.com/10871034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make all quota-exceeding messages in the storage API explain what the failure is. This involves adding descriptions to all errors from ExtensionsQuotaService, affecting the other APIs that use this (bookmarks and webRequest). BUG=144533 Review URL: https://chromiumcodereview.appspot.com/10871034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make ActiveTabPermissionManager also grant the tabs permission for that tab; only respected for tabs.executeScript and tabs.insertCSS. This involved converting tabs.executeScript/insertCSS to use JSON schema compiler. BUG=137643 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10815028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149631 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving preference API into api/preferences Also putting it into extensions namespace and removing redundant "extension" prefixes from names. BUG=101244 TEST=N/A, no code change, moving stuff around only TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10952021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157600 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Improving the process model extension API BUG=32302 TEST=Unit tests. Review URL: https://chromiumcodereview.appspot.com/10175008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137690 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable ExtensionGeolocationAccessPass Timing out on windows and linux. BUG=128412 TEST= Review URL: https://chromiumcodereview.appspot.com/10417015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138130 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 124235 - Re-enable tests that were broken due to WebKit rename of DOMWindow to Window The extension code was fixed in r123884 This is a revert of r123590. BUG=None TEST=ExtensionApiTest.GetViews:ExtensionApiTest.TabRelativeURLs:ExtensionApiTest.TabGetCurrent:ExtensionApiTest.TabReload:ExtensionApiTest.GetViewsOfCreatedPopup:ExtensionApiTest.GetViewsOfCreatedWindow:ExtensionApiTest.WebSocket:ExtensionApiTest.WindowOpener:ExtensionApiTest.MAYBE_Infobars Review URL: http://codereview.chromium.org/9517002 TBR=arv@chromium.org Review URL: https://chromiumcodereview.appspot.com/9538018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124251 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Moves command handling from Browser to a new object, BrowserCommandController. Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846,151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/10961066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158219 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846,151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/10961066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158219 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add WebContents* to some more delegate methods This are required to identify the correct java peer-object on Android BUG= Review URL: https://chromiumcodereview.appspot.com/10837112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150470 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846,151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/10961066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158219 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Supply default icon to extension icon image. Icon image shuld return default representation until actual image is loaded instead of the empty representation. Also, handle the case when image loading tracker returns synchronously. BUG=138025 TEST=IconImageTests Review URL: https://chromiumcodereview.appspot.com/10861034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155330 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Generalize ExtensionIconSet to store icon paths for custom size sets. This is needed to make it easier to handle sets of extension icons that are not defined in extension manifest (e.g. default icons for browser_actions) BUG=138025, 135271 TEST=existing tests For mechanical changes caused by moving ExtensionIcons from ExtensionIconSet to extension_misc namespace (patchset 14): TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10843014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151992 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor and fix declarative webRequest API permissions This CL introduces proper host permission checking for the declarative webRequest API. It moves the permission checking code from web_request_api.cc into a separate class that is shared with the declarative WebRequest API. BUG=112155 TEST=no TBR=mirandac@chromium.org,akalin@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148965 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor and fix declarative webRequest API permissions This CL introduces proper host permission checking for the declarative webRequest API. It moves the permission checking code from web_request_api.cc into a separate class that is shared with the declarative WebRequest API. BUG=112155 TEST=no TBR=mirandac@chromium.org,akalin@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148965 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move each permission classes to its own files in extensions/permissions and rename classes from ExtensionPermission* to extensions::Permission* This CL replaces CL 10649003 TBR=estade BUG=133049 TEST=unit_tests & browser_tests Review URL: https://chromiumcodereview.appspot.com/10675007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144408 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename InfoBarTabService -> InfoBarService. This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10879037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154023 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename InfoBarTabService -> InfoBarService. This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10879037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154023 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
extensions: Extract the dependency on browser_view from extension_input_api.cc. BUG=125846 R=aa@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154950 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move in_process_browser_test and ui_test_utils to chrome/test/base BUG=90905 Review URL: http://codereview.chromium.org/7532034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Added support for multiple parameters to Extension API callbacks. BUG=135269 TEST= Review URL: https://chromiumcodereview.appspot.com/10694106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146469 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert "Reland "Move a bunch of ChromeOS APIs out of chrome/browser/extensions.""" This reverts commit fd92fe3ff7c0a4a0da97da00cdf6bd5476c46195. BUG= TEST= Review URL: http://codereview.chromium.org/8713006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111663 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Moving test_api to api/test . BUG=101244 TEST=N/A, only moving code, no change in functionality Review URL: https://chromiumcodereview.appspot.com/10690113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146107 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove API elements that are no longer in the IME API design document R=yusukes@chromium.org BUG=chromium-os:23639 TEST=Run the API tests Review URL: https://chromiumcodereview.appspot.com/9230004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118047 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support an --install-from-webstore command line switch This is to make standalone installation of apps from the Chrome app host possible. BUG=138311 TBR=sky@chromium.org (for chrome/common/chrome_switches.{h,cc}) Review URL: https://chromiumcodereview.appspot.com/10907104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157088 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158590 - Extensions: Fix a crash installing an app w/ oauth2 scopes in incognito. Get the parent profile when fetching oauth2 issue advice. BUG=152192 TEST=none R=aa Review URL: https://codereview.chromium.org/10981022 TBR=jhawkins@chromium.org Review URL: https://codereview.chromium.org/10983042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158824 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move application creation and extension install prompt showing off Browser and onto ExtensionTabHelper. ExtensionInstallPrompt does not need a Browser, just a parent window, a PageNavigator and a Profile. WebApp metadata retrieval/updating can be done entirely from ExtensionTabHelper. This results in the removal of ExtensionTabHelperDelegate. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10699057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145384 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved CrxInstaller and CrxInstallerError into extensions namespace BUG=134756, 117261 Review URL: https://chromiumcodereview.appspot.com/10683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148244 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved CrxInstaller and CrxInstallerError into extensions namespace BUG=134756, 117261 Review URL: https://chromiumcodereview.appspot.com/10683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148244 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix some clang errors on Android. BUG= Review URL: https://chromiumcodereview.appspot.com/10843029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149498 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
- testSetTheme was already covered (after adding theme name verification). - testThemeUndo was already covered - testThemeOverInstall was already covered - testThemeInFullScreen -> TestInstallThemeInFullScreen - testThemeReset -> TestThemeReset - Runner was not running by default and is missing data files so it doesn't look like it has run in a while. Remove automation hooks: GetThemeInfo, ResetToDefaultTheme BUG=143637 TEST=browser_tests --gtest_filter=ExtensionInstallUIBrowserTest.* Review URL: https://chromiumcodereview.appspot.com/10916328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157427 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce InfoBarTabService API. The new interface extracts the API bits from InfoBarTabHelper. This change switches files under chrome/browser/autofill and chrome/browser/api to use the API and remove the temporarily-allowed dependency on InfoBarTabHelper. TBRing other owners as the changes are just to match the updated API and include paths. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10830353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved CrxInstaller and CrxInstallerError into extensions namespace BUG=134756, 117261 Review URL: https://chromiumcodereview.appspot.com/10683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148244 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix callback for chrome.tabs.update with javascript URLs. UpdateTabFunction is asynchronous when updating a tab with a javascript URL. In this situation, the method was returning early before generating the callback result. This fixes the ExecuteScriptApiTest.NavigationRaceJavaScriptUrl test. BUG=89731 TEST=ExecuteScriptApiTest.NavigationRaceJavaScriptUrl Review URL: http://codereview.chromium.org/9225010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119690 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Panels] Provide a tab id for web contents in Panels. TBR=mihaip BUG=150830 TEST=ExtensionApiTest.MessagingPanel Review URL: https://chromiumcodereview.appspot.com/10965023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158052 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added support for multiple parameters to Extension API callbacks. BUG=135269 TEST= Review URL: https://chromiumcodereview.appspot.com/10694106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146469 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Exposing extension preferences via the chrome.extension API. chrome.extension.isAllowedIncognitoAccess gives access to chrome://extension's "Allowed in Incognito" checkbox's state, and chrome.extension.isAllowedFileSchemeAccess does the same for "Allow access to File URLs". Patch by Mike West <mkwst@google.com>. BUG=74694 TEST=Create an extension that checks whether 'Allow in Incognito' or 'Allow access to File URLs' is checked. It should work correctly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78347 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correct const accessors in base/values.(h|cc) For problem description and other info please see the BUG page. This is for DictionaryValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar scottbyer achuith agl mnissler davemoore garykac akalin hans bulach phajdan.jr jamesr Review URL: https://chromiumcodereview.appspot.com/10834004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148833 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
RefCounted types should not have public destructors, chrome/browser/extensions version BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10071035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134370 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExtensionPrefs and related into extensions namespace Moved ExtensionPrefs, ExtensionPrefsScope, and TestExtensionPrefs into extensions namespace. BUG=135024, 117261 Review URL: https://chromiumcodereview.appspot.com/10704023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145898 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make ExtensionPrefValueMap a ProfileKeyedService. BUG=104095 TEST=no Review URL: http://codereview.chromium.org/9764006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131136 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make ExtensionPrefValueMap a ProfileKeyedService. BUG=104095 TEST=no Review URL: http://codereview.chromium.org/9764006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131136 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Moved ExtensionPrefs and related into extensions namespace Moved ExtensionPrefs, ExtensionPrefsScope, and TestExtensionPrefs into extensions namespace. BUG=135024, 117261 Review URL: https://chromiumcodereview.appspot.com/10704023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145898 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Implement default app ordering. - Support more default app ordering than just web store app; - Add default app ordering for ChromeOS; - Add tests for default ordering; BUG=149750 TEST=Verify it does not break NTP page on non-chromeos. And for chromeos, wait until app list CL that respects NTP ordering is landed. R=csharp@chromium.org,asargent@chromium.org Review URL: https://chromiumcodereview.appspot.com/10969044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158472 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reset registered events and dispatch runtime.onInstalled to all extensions when Chrome is updated. BUG=148898 Review URL: https://chromiumcodereview.appspot.com/10941003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157685 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Generalize StringOrdinal to handle ordinal_in_parent field Rename StringOrdinal to Ordinal, move it to sync/, and templatize it. Make StringOrdinal be an instantiation of Ordinal that matches its previous behavior. Create NodeOrdinal, which is another instantiation of Ordinal for the ordinal_in_parent field in SyncEntity. Rework Ordinal to handle arbitrary byte ranges and to simplify the interpolation code a bit. Generalize StringOrdinal unit tests for Ordinal. Update users of StringOrdinal to prepend syncer::. BUG=145412 TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10920017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix a bug where the inspector would not keep event pages alive. The notification that an inspector window was opened was not always being sent. BUG=143284 TBR=creis@chromium.org,pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10837296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152733 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionHost into extensions namespace BUG=139042,117261 Review URL: https://chromiumcodereview.appspot.com/10824030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149295 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Define the public interface for content browser SiteInstance. This interface is implemented by the SiteInstanceImpl class which lives in content\browser\site_instance.cc/.h. Changes as part of creating a content API. BUG=98716 TEST=No change in functionality. Hopefully it all compiles and works. Review URL: http://codereview.chromium.org/8515027 Review URL: https://chromiumcodereview.appspot.com/9146028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119102 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Refactoring: ProtocolHandler::MaybeCreateJob and other functions take NetworkDelegate as argument This change goes a long way to prepare for removing NetworkDelegate from URLRequestContext. TBR=sky@chromium.org, michaeln@chromium.org, benjhayden@chromium.org, brettw@chromium.org, ben@chromium.org, davemoore@chromium.org, zelidrag@chromium.org, mnissler@chromium.org, thestig@chromium.org, asargent@chromium.org, jhawkins@chromium.org, bulach@chromium.org BUG=crbug.com/142945 Review URL: https://chromiumcodereview.appspot.com/10855209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153133 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Turned job_factory into a pure virtual class This makes it possible to create wrappers for job_factory that handle a particular job type, and forward the rest to the old job_factory. TBR=michaeln@chromium.org, brettw@chromium.org, davemoore@chromium.org, kalman@chromium.org, benjhayden@chromium.org, jochen@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/10836248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153241 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactoring: ProtocolHandler::MaybeCreateJob and other functions take NetworkDelegate as argument This change goes a long way to prepare for removing NetworkDelegate from URLRequestContext. TBR=sky@chromium.org, michaeln@chromium.org, benjhayden@chromium.org, brettw@chromium.org, ben@chromium.org, davemoore@chromium.org, zelidrag@chromium.org, mnissler@chromium.org, thestig@chromium.org, asargent@chromium.org, jhawkins@chromium.org, bulach@chromium.org BUG=crbug.com/142945 Review URL: https://chromiumcodereview.appspot.com/10855209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153133 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Check for warnings when loading extensions in browser tests. Test extension should be well-formed. Having warnings is often an early indicator that something else is wrong (see for example https://chromiumcodereview.appspot.com/10852016/). Review URL: https://chromiumcodereview.appspot.com/10826157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151123 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Implement default app ordering. - Support more default app ordering than just web store app; - Add default app ordering for ChromeOS; - Add tests for default ordering; BUG=149750 TEST=Verify it does not break NTP page on non-chromeos. And for chromeos, wait until app list CL that respects NTP ordering is landed. R=csharp@chromium.org,asargent@chromium.org Review URL: https://chromiumcodereview.appspot.com/10969044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158472 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add "inspect background page" to platform app right-click menu. BUG=148470 Review URL: https://chromiumcodereview.appspot.com/10907243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157645 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move gpu blacklist data file to content side. This also fixes the bug that GPU histograms are missing. BUG=151057 TEST=tree R=jbauman Review URL: https://codereview.chromium.org/10911315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157851 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Implement default app ordering. - Support more default app ordering than just web store app; - Add default app ordering for ChromeOS; - Add tests for default ordering; BUG=149750 TEST=Verify it does not break NTP page on non-chromeos. And for chromeos, wait until app list CL that respects NTP ordering is landed. R=csharp@chromium.org,asargent@chromium.org Review URL: https://chromiumcodereview.appspot.com/10969044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158472 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Implement default app ordering. - Support more default app ordering than just web store app; - Add default app ordering for ChromeOS; - Add tests for default ordering; BUG=149750 TEST=Verify it does not break NTP page on non-chromeos. And for chromeos, wait until app list CL that respects NTP ordering is landed. R=csharp@chromium.org,asargent@chromium.org Review URL: https://chromiumcodereview.appspot.com/10969044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158472 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
cros: Implement default app ordering. - Support more default app ordering than just web store app; - Add default app ordering for ChromeOS; - Add tests for default ordering; BUG=149750 TEST=Verify it does not break NTP page on non-chromeos. And for chromeos, wait until app list CL that respects NTP ordering is landed. R=csharp@chromium.org,asargent@chromium.org Review URL: https://chromiumcodereview.appspot.com/10969044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158472 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Updates the Chrome OS file browser to support opening files with Web Intent handlers. Adds a basic test. This is added to the list of 'normal' file handlers in the same way that Drive tasks are currently added. (although I feel like the whole flow needs to be changed a bit, since we don't store defaults for anything but the original file browser tasks). BUG=138664 Review URL: https://chromiumcodereview.appspot.com/10834383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157693 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Updates the Chrome OS file browser to support opening files with Web Intent handlers. Adds a basic test. This is added to the list of 'normal' file handlers in the same way that Drive tasks are currently added. (although I feel like the whole flow needs to be changed a bit, since we don't store defaults for anything but the original file browser tasks). BUG=138664 Review URL: https://chromiumcodereview.appspot.com/10834383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157693 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Updates the Chrome OS file browser to support opening files with Web Intent handlers. Adds a basic test. This is added to the list of 'normal' file handlers in the same way that Drive tasks are currently added. (although I feel like the whole flow needs to be changed a bit, since we don't store defaults for anything but the original file browser tasks). BUG=138664 Review URL: https://chromiumcodereview.appspot.com/10834383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157693 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable crashing ExtensionApiTest.Storage and ExtensionApiTest.IncognitoPopup tests. BUG=104419,104438 TEST=tree gets greener. TBR=aleksey,kmadhusu Review URL: http://codereview.chromium.org/8572050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110271 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland r145993. Original codereview at http://codereview.chromium.org/10766016/ [Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=stevet@chromium.org, rlarocque@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10690128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland r145993. Original codereview at http://codereview.chromium.org/10766016/ [Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=stevet@chromium.org, rlarocque@chromium.org BUG=135108 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10690128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146050 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Generalize StringOrdinal to handle ordinal_in_parent field Rename StringOrdinal to Ordinal, move it to sync/, and templatize it. Make StringOrdinal be an instantiation of Ordinal that matches its previous behavior. Create NodeOrdinal, which is another instantiation of Ordinal for the ordinal_in_parent field in SyncEntity. Rework Ordinal to handle arbitrary byte ranges and to simplify the interpolation code a bit. Generalize StringOrdinal unit tests for Ordinal. Update users of StringOrdinal to prepend syncer::. BUG=145412 TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10920017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Rename csync namespace to syncer Everyone was confused by 'csync'. 'syncer' seems more understandable. (Note that we can't use the 'sync' namespace since sync() is a function from unistd.h.) BUG=10662035 TEST= TBR=jhawkins@chromium.org,pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144820 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158830 - Revert 156678 - Native messaging now uses the MessageService back-end. Reason: Regression in a ChromeOS extension causing it to continue running after unloading. BUG=142915 Review URL: https://codereview.chromium.org/10818013 TBR=eaugusti@chromium.org TBR=mpcomplete@chromium.org TBR=mmoss, rouslan Review URL: https://codereview.chromium.org/10991044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158833 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of remembering platform app window geometry. This adds the infastructure necesary to remember and restore window sizes and positions, but doesn't include the platform-specific bits to actually remember window geometry yet. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154451 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch NOTIFICATION_TAB_PARENTED to use WebContents. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10917198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157134 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Always send the full tab object in ExtensionAction click event. Along the way, decompose a few swiss army knife functions to simplify and generalize code. BUG=149020 Review URL: https://codereview.chromium.org/10909256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157082 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Always send the full tab object in ExtensionAction click event. Along the way, decompose a few swiss army knife functions to simplify and generalize code. BUG=149020 Review URL: https://codereview.chromium.org/10909256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157082 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Always send the full tab object in ExtensionAction click event. Along the way, decompose a few swiss army knife functions to simplify and generalize code. BUG=149020 Review URL: https://codereview.chromium.org/10909256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157082 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158707 - Enable by default: 1. threaded compositing on windows (except XP) 2. force compositing mode on mac On linux we switch to a 1/3 1/3 fcm and thread experiments . This patch also gives priority to the command line switches so that both threaded and force compositing mode can be turned off via the about:flags page or command line. In the near future, we will use the Finch framework to tweak the experiment percentages. Note: This patch has a dependency on: https://bugs.webkit.org/show_bug.cgi?id=96871 It also disables ExtensionApiTest.CaptureVisibleTabJPeg as it triggers flakiness on it. chrome.tabs.captureVisibleTab is inherently racy as there is no way to guarantee that the tab has been painted at least once when that call is made. Note how the other variants of CaptureVisibleTab tests have already been disabled for similar reasons. BUG=143809,128387,146861 Review URL: https://chromiumcodereview.appspot.com/10914247 Reverted due to failures on Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/29446/steps/interactive_ui_tests/logs/AutoResize http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/2143/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%283%29/builds/26358/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/1804/steps/interactive_ui_tests/logs/TightAutosizeAroundSingleLine TBR=vangelis@chromium.org Review URL: https://codereview.chromium.org/10991032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158711 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10822030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148514 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Renamed ExtensionIdSet to ExtensionIds BUG= Review URL: https://chromiumcodereview.appspot.com/10824344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152173 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Initial implementation of action box menu. It is still work in progress, just CL is getting too big and need to share existing code with other developers. BUG=125307 Review URL: https://chromiumcodereview.appspot.com/10533086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150869 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactored SettingsFrontend and forwarding of calls to the backends. Added a SettingsNamespaceFrontend interface for namespace frontends, that allows different namespaces to forward StorageCallbacks in their own way. The LOCAL and SYNC namespaces use an implementation that does the same as before, but the new MANAGED namespace can now be implemented using a ValueStore that loads settings from policies, in the UI thread. BUG=108992 TEST=Everything works as before, all tests are green Review URL: https://chromiumcodereview.appspot.com/10784035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147464 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix for pixelated icons in extension install ui on 2x scale. We should probably do something like https://chromiumcodereview.appspot.com/10917146/ (and add lazy representation loading for views), but for M23 timeframe this will also do. BUG=135268 TEST=manual TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10915251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157000 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Move global error to subdir. chrome/browser/ui/global_error* -> chrome/browser/ui/global_error/global_error* BUG=135018 R=ben@chromium.org TBR=atwilson@chromium.org,ivankr@chromium.org,willchan@chromim.org Review URL: https://chromiumcodereview.appspot.com/10700027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144952 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Move global error to subdir. chrome/browser/ui/global_error* -> chrome/browser/ui/global_error/global_error* BUG=135018 R=ben@chromium.org TBR=atwilson@chromium.org,ivankr@chromium.org,willchan@chromim.org Review URL: https://chromiumcodereview.appspot.com/10700027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144952 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
extensions: Fix typo in bookmarks url. TEST=navigate to chrome-extension://eemcgdkfndhakfknompkggombfjjjeno/main.html#1, by copying it in the omnibox and pressing enter. It should open the bookmark manager. R=mpcomplete@chromium.org NOTRY=True Review URL: https://chromiumcodereview.appspot.com/10961078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158616 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correct const accessors in base/values.(h|cc), Part II (ListValue) For problem description and other info please see the BUG page. This is for ListValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj Review URL: https://chromiumcodereview.appspot.com/10837044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149819 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable the special behaviour of document.cookie in platform apps. Previously, if code within a platform app attempted to access (or override) the document.cookie field then a DOM security exception would have been raised. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10636039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144091 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum value in the WebContents' property bag. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/10409088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138434 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
It can now be used in content without a layering violation. This was discussed in https://chromiumcodereview.appspot.com/9693065/#msg11 BUG= TEST= Review URL: http://codereview.chromium.org/9820005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128155 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Make all quota-exceeding messages in the storage API explain what the failure is. This involves adding descriptions to all errors from ExtensionsQuotaService, affecting the other APIs that use this (bookmarks and webRequest). BUG=144533 Review URL: https://chromiumcodereview.appspot.com/10871034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make all quota-exceeding messages in the storage API explain what the failure is. This involves adding descriptions to all errors from ExtensionsQuotaService, affecting the other APIs that use this (bookmarks and webRequest). BUG=144533 Review URL: https://chromiumcodereview.appspot.com/10871034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make all quota-exceeding messages in the storage API explain what the failure is. This involves adding descriptions to all errors from ExtensionsQuotaService, affecting the other APIs that use this (bookmarks and webRequest). BUG=144533 Review URL: https://chromiumcodereview.appspot.com/10871034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PrefMember and PrefChangeRegistrar to api directory. This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support DIR_STANDALONE_EXTERNAL_EXTENSIONS on Chrome OS This source of external extensions will be used on Chrome OS for installing board specific default extensions. They need to be from CWS same as other default apps on Chrome OS. BUG=149158 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10916312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156810 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable install of new default apps for existing users. Also moves the DefaultAppsTest in extension_service_unittest.cc to a separate file. BUG=138614 Review URL: https://chromiumcodereview.appspot.com/10875065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154064 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExternalExtensionLoaders/Providers into extensions namespace Moved ExternalExtensionLoader, ExternalExtensionProviderImpl, ExternalExtensionProviderInterface, ExternalRegistryExtensionLoader, ExternalPrefsExtensionLoader, and ExternalPolicyExtensionLoader into extensions namespace. Renamed appropriately. BUG=136873, 117261 Review URL: https://chromiumcodereview.appspot.com/10692168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146847 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
base::Bind conversion for chrome/browser/extensions/file_reader. Review URL: http://codereview.chromium.org/8343008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108553 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionHost into extensions namespace BUG=139042,117261 Review URL: https://chromiumcodereview.appspot.com/10824030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149295 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chromeos: Fix pixelated icons in app list and launcher (part 3) - Use extensions::IconImage for HiDPI icons; - Fix IconImage use default icon for bundled component extension icon; - Fix ImageLoadingTracker does not properly resize bundled component extension icon; - Get rid of icon cache and work thread for shadow generation. We are using the exact icon size (smaller) and only generate shadow for visible ones. Thus, it is no longer needed. BUG=131738, 131739 TEST=Verify launcher and app list have crispy icons on HiDPI. Review URL: https://chromiumcodereview.appspot.com/10868003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155939 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chromeos: Fix pixelated icons in app list and launcher (part 3) - Use extensions::IconImage for HiDPI icons; - Fix IconImage use default icon for bundled component extension icon; - Fix ImageLoadingTracker does not properly resize bundled component extension icon; - Get rid of icon cache and work thread for shadow generation. We are using the exact icon size (smaller) and only generate shadow for visible ones. Thus, it is no longer needed. BUG=131738, 131739 TEST=Verify launcher and app list have crispy icons on HiDPI. Review URL: https://chromiumcodereview.appspot.com/10868003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155939 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
taking over xiyuan's patch: http://codereview.chromium.org/10701087/ *************************************************************** chromeos: Fix pixelated icons in app list and launcher (part 2) Add an ExtensionIconImage, which loads image that supports DIP by having a special ImageSkiaSource that makes ImageLoadingTracker to load image for additional DIP scale. BUG=131738, 131739 TEST=None. Wait for the last CL to update laucher/app list code to use LoadImageInDIP to verify. *************************************************************** For gypi files (I reckon this part is trivial enough) TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152407 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add histogram for total number of user-installed items. Review URL: https://codereview.chromium.org/10970045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158058 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable IsolatedAppTest.NoCookieIsolationWithoutApp due to flakiness. BUG=145588 TBR=ajwong Review URL: https://chromiumcodereview.appspot.com/10890048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153998 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove views::KeyEvent, replacing uses of it with ui::KeyEvent. http://crbug.com/125937 TEST=existing TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150895 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Second try of 157576 https://chromiumcodereview.appspot.com/10780013/ Add reverse URL handler for shortening uber URLs BUG=120493 TEST=Open the settings page. The address bar should show "chrome://settings". Click the "extensions" button on the left. The address bar should show "chrome://extensions". Click the "settings" button on the left, "show advanced settings", "content settings". The address bar should show "chrome://settings/content". Review URL: https://chromiumcodereview.appspot.com/10941050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158504 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create content\public\test\test_utils.h to hold common test classes that are used by unit and browser tests. unit tests shouldn't be including ui_test_utils.h. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10807047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147602 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Unrevert 152017 - Add chrome.runtime.onStartup, which is fired on browser start. I reused LazyBackgroundTaskQueue so that this works for regular background pages, which may not be fully loaded by the time this event is dispatched. BUG=132328 Review URL: https://chromiumcodereview.appspot.com/10828218 Reason for revert: introduced a frequent crash Review URL: https://chromiumcodereview.appspot.com/10855237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152238 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove obsolete cruft in LazyBackgroundTaskQueue that dealt with queueing up events for a closing background page. We now cancel the close instead, so we don't need to queue the events. BUG=136469 Review URL: https://chromiumcodereview.appspot.com/10830235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150716 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement scriptBadge.requestToAct. Currently it just shows the script badge and responds to clicks by granting permission, without changing its appearance or explaining the result of a click at all. BUG=133142 Review URL: https://chromiumcodereview.appspot.com/10695070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146930 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable modifying extensions when in managed mode. Consolidate yellow banners on Extensions and Options pages. Add managed mode as an extensions::ManagementPolicy::Provider. Managed mode prohibits installing, uninstalling, enabling, or disabling extensions, both in the UI and in the back end. Also remove links to the web store, as well as optional controls (options, incognito, reload, etc.). BUG=117987 TEST=unit tests (for managed mode methods); manual: verify that chrome://extensions UI is disabled in managed mode; manual: launch in managed mode and verify that managed mode can be disabled Review URL: https://chromiumcodereview.appspot.com/10542023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143960 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor the various ways to control what users can do to extensions. Add an ExtensionManagementPolicy class, held by the ExtensionService, that registers delegates and mediates questions about what can be done to extensions (install, uninstall, modify, etc.). Convert existing mechanisms to control extension operations, namely administrator policy black/whitelists and component extension requirements, to use this abstraction. In addition to cleaning up existing mechanisms, this will support the control managed mode needs to impose (in an upcoming patch). BUG=117987 TEST=covered by unit, browser, and api tests Review URL: https://chromiumcodereview.appspot.com/10382149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140194 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158691 - Give platform apps control over launcher right-click context menu. This moves most of the extension context menu related code from RenderViewContextMenu to a seperate class, which is then used in two other places as well. Reverted due to failures on Mac testers in: ExtensionContextMenuBrowserLazyTest.EventPage http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20(dbg)(1)/builds/1693/steps/browser_tests/logs/EventPage BUG=143222 Review URL: https://chromiumcodereview.appspot.com/10918103 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/10984034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158705 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reset registered events and dispatch runtime.onInstalled to all extensions when Chrome is updated. BUG=148898 Review URL: https://chromiumcodereview.appspot.com/10941003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157685 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158830 - Revert 156678 - Native messaging now uses the MessageService back-end. Reason: Regression in a ChromeOS extension causing it to continue running after unloading. BUG=142915 Review URL: https://codereview.chromium.org/10818013 TBR=eaugusti@chromium.org TBR=mpcomplete@chromium.org TBR=mmoss, rouslan Review URL: https://codereview.chromium.org/10991044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158833 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moved ExtensionMessage* into extensions namespace Moved ExtensionMessageBundle, ExtensionMessageService, and ExtensionMessageHandler into extensions namespace. Renamed appropriately. BUG=137298, 117261 Review URL: https://chromiumcodereview.appspot.com/10787002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148354 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
QuotaManager: Return the remaining free disk space as quota. Previously we returned kNoLimit, which prevents apps from managing disk usage. BUG=141583 TEST= R=kinuko Review URL: https://chromiumcodereview.appspot.com/10826270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153248 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
QuotaManager: Return the remaining free disk space as quota. Previously we returned kNoLimit, which prevents apps from managing disk usage. BUG=141583 TEST= R=kinuko Review URL: https://chromiumcodereview.appspot.com/10826270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153248 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added browsertest to assert that extension API calls are counted as V8RecursionScopes and delay microtask delivery BUG=105962 TEST= Review URL: http://codereview.chromium.org/9969178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix crash in extension NavigationObserver We were derefering a scoped_ptr<> immediately after resetting it. This caused crashes on Linux and a top-crash on Chrome OS. Fixed by copying out the data we need before we delete the object. BUG=145741 TEST=none Review URL: https://chromiumcodereview.appspot.com/10912101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155000 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move small c/b/extensions classes into extensions namespace no.2 Since these classes are small, they can be all be moved in one cl without it becoming overly large. This one moves: - ExtensionDataDeleter (now extensions::DataDeleter) - ExtensionNavigationObserver (now extensions::NavigationObserver) - PackExtensionJob - PlatformAppBrowsertest - ShellWindowRegistry - ExtensionStartupUtil (see note in file) BUG=117261 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151535 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Only allows extensions to create HTML notifications. createHTMLNotification has been removed from the W3C Notifications spec. We do not want it to be exposed for web pages. However, since quite a few extensions are still using it, we would still keep it to be exposed for extensions. BUG=98061 TEST=existing tests Review URL: https://chromiumcodereview.appspot.com/10808113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149054 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disallow packing or loading unpacked manifest v1 extensions. BUG=132718 Review URL: https://chromiumcodereview.appspot.com/10912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154637 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch ScriptBadgeController and PageActionController to use WebContents. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10911105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155378 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move SessionID, CaptureVisibleTabFunction to WebContents. BUG=107201 TEST=no visible change TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10912156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155811 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PendingExtensionManager and PendingExtensionInfo into extensions namespace BUG=134744, 117261 Review URL: https://chromiumcodereview.appspot.com/10682007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148654 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PendingExtensionManager and PendingExtensionInfo into extensions namespace BUG=134744, 117261 Review URL: https://chromiumcodereview.appspot.com/10682007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148654 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland 152221 - chromeos: Sync animation. - Pulse app list button while LauncherModel has STATUS_LOADING; - Remove LauncherItemStatus::STATUS_IS_PENDING etc since it is no longer needed; - ChromeLauncherController sets LauncherModel::STATUS_LOADING on starting and watch for sync finish and pending extension install. It sets LauncherModel::STATUS_NORMAL when sync is finished and there is no pending extension install from sync, or when a maximum 60 seconds timeout since turning on loading status; BUG=129236 TEST=Verify sync animation after OOBE. TBR=sky@chromium.org, kalman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10860053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152684 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland 152221 - chromeos: Sync animation. - Pulse app list button while LauncherModel has STATUS_LOADING; - Remove LauncherItemStatus::STATUS_IS_PENDING etc since it is no longer needed; - ChromeLauncherController sets LauncherModel::STATUS_LOADING on starting and watch for sync finish and pending extension install. It sets LauncherModel::STATUS_NORMAL when sync is finished and there is no pending extension install from sync, or when a maximum 60 seconds timeout since turning on loading status; BUG=129236 TEST=Verify sync animation after OOBE. TBR=sky@chromium.org, kalman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10860053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152684 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Get content_browsertest working. I've added a simple test for now, and will convert the tests in src/content in future changes. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10803026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147404 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add "inspect background page" to platform app right-click menu. BUG=148470 Review URL: https://chromiumcodereview.appspot.com/10907243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157645 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add "inspect background page" to platform app right-click menu. BUG=148470 Review URL: https://chromiumcodereview.appspot.com/10907243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157645 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add "inspect background page" to platform app right-click menu. BUG=148470 Review URL: https://chromiumcodereview.appspot.com/10907243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157645 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor PlatformAppCommandLineLauncher into PlatformAppPathLauncher (This is an isolated part of change 10834383). This allows platform apps to be launched targeted at specific paths. Previously, this only worked if the path was specified as part of a CommandLine. BUG= Review URL: https://chromiumcodereview.appspot.com/10919058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154741 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor PlatformAppCommandLineLauncher into PlatformAppPathLauncher (This is an isolated part of change 10834383). This allows platform apps to be launched targeted at specific paths. Previously, this only worked if the path was specified as part of a CommandLine. BUG= Review URL: https://chromiumcodereview.appspot.com/10919058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154741 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158217 - Allow extensions which can run without NPAPI to run under Windows 8 Metro. Extensions which include NPAPI plugins are assumed to require them, causing them to be blocked on Windows 8 Metro mode, where NPAPI is not supported. This CL allows extensions which include NPAPI plugins, but which can still run without them, to load in Windows 8 Metro mode. It also fixes the handling of extensions with no explicit NPAPI requirement. BUG=130405 Review URL: https://chromiumcodereview.appspot.com/10949017 TBR=wez@chromium.org Review URL: https://codereview.chromium.org/10982037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158696 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix extensions compile issues for Android on sync_unit_tests. Get sync_unit_tests compiling with the chrome_browser.gypi extensions files included. This required creating a stub for the ExtensionView for Android, but should be ok as there are platform specific stubs already. Still does not link, but progress. BUG=113487 TEST= Review URL: http://codereview.chromium.org/9433044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123358 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add site_instance_id to ProcessMap::Item. This is needed because there can be two site instances for the same extension/process pair. Boo. The linear scan for Contains() is a bummer. I thought about more exotic data structures, but it didn't seem worth it. BUG=105328 Review URL: http://codereview.chromium.org/8769022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112921 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Revert 158217 - Allow extensions which can run without NPAPI to run under Windows 8 Metro. Extensions which include NPAPI plugins are assumed to require them, causing them to be blocked on Windows 8 Metro mode, where NPAPI is not supported. This CL allows extensions which include NPAPI plugins, but which can still run without them, to load in Windows 8 Metro mode. It also fixes the handling of extensions with no explicit NPAPI requirement. BUG=130405 Review URL: https://chromiumcodereview.appspot.com/10949017 TBR=wez@chromium.org Review URL: https://codereview.chromium.org/10982037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158696 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enforce the 'requirements' field in manifests. Try 2. First try: https://chromiumcodereview.appspot.com/10689097 BUG=133027, 130405 TBR=jhawkins@chromium.org, aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156119 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move gpu blacklist data file to content side. This also fixes the bug that GPU histograms are missing. BUG=151057 TEST=tree R=jbauman Review URL: https://codereview.chromium.org/10911315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157851 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add sandboxed_pages to allow extension/app pages to be served in a sandboxed, unique origin. This allows manifest_version 2 extensions to have pages that are exempt from their Content Security Policy (but these pages can't call extension APIs either). Depends on http://webkit.org/b/88014 Review URL: https://chromiumcodereview.appspot.com/10458063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140689 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify more ExtensionService methods, and IWYU. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10834078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152105 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExtensionUnpacker into extensions:: namespace, rename it to Unpacker BUG=135462, 117261 Review URL: https://chromiumcodereview.appspot.com/10704060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146853 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, to remove static_cast<> in the callers. BUG=139130 TEST=try bots Review URL: https://chromiumcodereview.appspot.com/10855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151192 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch ScriptBadgeController and PageActionController to use WebContents. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10911105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155378 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch Extensions::TabHelper to use WebContents, WebContentsUserData. BUG=107201 TEST=no visible change TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155743 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=155901 Review URL: https://chromiumcodereview.appspot.com/10917026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156366 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and add debugging for it. BUG=138323 Review URL: https://chromiumcodereview.appspot.com/10826141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150303 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Formalise a CHECK for the NULL NavigationEntry in ScriptBadgeController, and add debugging for it. BUG=138323 Review URL: https://chromiumcodereview.appspot.com/10826141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150303 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Shim that simulates a <browser> tag via Mutation Observers. The actual tag is implemented via the browser plugin. The internals of this are hidden via Shadow DOM. Also fixes a bug with Shadow DOM not being enabled for all extensions views. BUG=133379 Review URL: https://chromiumcodereview.appspot.com/10598006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145229 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of remembering platform app window geometry. This adds the infastructure necesary to remember and restore window sizes and positions, but doesn't include the platform-specific bits to actually remember window geometry yet. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154451 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of remembering platform app window geometry. This adds the infastructure necesary to remember and restore window sizes and positions, but doesn't include the platform-specific bits to actually remember window geometry yet. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154451 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of remembering platform app window geometry. This adds the infastructure necesary to remember and restore window sizes and positions, but doesn't include the platform-specific bits to actually remember window geometry yet. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154451 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support an --install-from-webstore command line switch This is to make standalone installation of apps from the Chrome app host possible. BUG=138311 TBR=sky@chromium.org (for chrome/common/chrome_switches.{h,cc}) Review URL: https://chromiumcodereview.appspot.com/10907104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157088 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support an --install-from-webstore command line switch This is to make standalone installation of apps from the Chrome app host possible. BUG=138311 TBR=sky@chromium.org (for chrome/common/chrome_switches.{h,cc}) Review URL: https://chromiumcodereview.appspot.com/10907104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157088 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
CPM Extension Uninstall Watching Add in watching for extension uninstall events. This also changes NOTIFICATION_EXTENSION_UNINSTALL to have the Extension as details. BUG=130212 TEST=Included browsertest; existing tests to test for regression on the notification change. Review URL: https://chromiumcodereview.appspot.com/10694056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147025 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enable extension APIs for content scripts. This only enables extension functions. I will do events in a separate change. BUG=81760,80308 Review URL: http://codereview.chromium.org/8540012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109812 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the basic code skeleton for system info event router. BUG=136519 TEST=browser_tests --gtest_filter=SystemInfoStorageApiTest.* Review URL: https://chromiumcodereview.appspot.com/10836341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154770 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add the basic code skeleton for system info event router. BUG=136519 TEST=browser_tests --gtest_filter=SystemInfoStorageApiTest.* Review URL: https://chromiumcodereview.appspot.com/10836341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154770 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Polish the SystemInfoProvider template code and refactor StorageInfoProvider based on it. BUG=136519 TEST=browser_tests --gtest_filter=SystemInfoStorageApiTest.* Review URL: https://chromiumcodereview.appspot.com/10876041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Generalize StringOrdinal to handle ordinal_in_parent field Rename StringOrdinal to Ordinal, move it to sync/, and templatize it. Make StringOrdinal be an instantiation of Ordinal that matches its previous behavior. Create NodeOrdinal, which is another instantiation of Ordinal for the ordinal_in_parent field in SyncEntity. Rework Ordinal to handle arbitrary byte ranges and to simplify the interpolation code a bit. Generalize StringOrdinal unit tests for Ordinal. Update users of StringOrdinal to prepend syncer::. BUG=145412 TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org, Review URL: https://chromiumcodereview.appspot.com/10920017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extension white and force lists (set by policy) should have priority over auto-updated Google blacklist. BUG=93246 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10854009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152548 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extension white and force lists (set by policy) should have priority over auto-updated Google blacklist. BUG=93246 TEST=unit_tests Review URL: https://chromiumcodereview.appspot.com/10854009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152548 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of remembering platform app window geometry. This adds the infastructure necesary to remember and restore window sizes and positions, but doesn't include the platform-specific bits to actually remember window geometry yet. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154451 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of remembering platform app window geometry. This adds the infastructure necesary to remember and restore window sizes and positions, but doesn't include the platform-specific bits to actually remember window geometry yet. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154451 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable modifying extensions when in managed mode. Consolidate yellow banners on Extensions and Options pages. Add managed mode as an extensions::ManagementPolicy::Provider. Managed mode prohibits installing, uninstalling, enabling, or disabling extensions, both in the UI and in the back end. Also remove links to the web store, as well as optional controls (options, incognito, reload, etc.). BUG=117987 TEST=unit tests (for managed mode methods); manual: verify that chrome://extensions UI is disabled in managed mode; manual: launch in managed mode and verify that managed mode can be disabled Review URL: https://chromiumcodereview.appspot.com/10542023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143960 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce InfoBarTabService API. The new interface extracts the API bits from InfoBarTabHelper. This change switches files under chrome/browser/autofill and chrome/browser/api to use the API and remove the temporarily-allowed dependency on InfoBarTabHelper. TBRing other owners as the changes are just to match the updated API and include paths. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10830353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce InfoBarTabService API. The new interface extracts the API bits from InfoBarTabHelper. This change switches files under chrome/browser/autofill and chrome/browser/api to use the API and remove the temporarily-allowed dependency on InfoBarTabHelper. TBRing other owners as the changes are just to match the updated API and include paths. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10830353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enforce the 'requirements' field in manifests. Try 2. First try: https://chromiumcodereview.appspot.com/10689097 BUG=133027, 130405 TBR=jhawkins@chromium.org, aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156119 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enforce the 'requirements' field in manifests. Try 2. First try: https://chromiumcodereview.appspot.com/10689097 BUG=133027, 130405 TBR=jhawkins@chromium.org, aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156119 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
UserScriptListener: Don't resume requests that it didn't defer. While this behavior doesn't currently break anything, it makes issue 130854 occur more often, and seems rather fragile. A fix for 130854 is in a separate CL. R=mpcomplete@chromium.org BUG=130854 Review URL: https://chromiumcodereview.appspot.com/10914319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157211 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move UserScript and related into extensions namespace Moved UserScript, UserScriptMaster, UserScriptSlave, UserScriptListener, and UserScriptScheduler into extensions namespace. BUG=136876, 117261 Review URL: https://chromiumcodereview.appspot.com/10696176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146682 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
UserScriptListener: Don't resume requests that it didn't defer. While this behavior doesn't currently break anything, it makes issue 130854 occur more often, and seems rather fragile. A fix for 130854 is in a separate CL. R=mpcomplete@chromium.org BUG=130854 Review URL: https://chromiumcodereview.appspot.com/10914319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157211 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Clean-up inline members of nested classes (chrome/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10855075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Clean-up inline members of nested classes (chrome/) Due to a bug, the Clang-plugin style checker failed to warn about inline constructors, destructors, non-empty virtual methods, etc. for nested classes. The plugin has been fixed, and this patch is part of a clean-up of all the code that now causes the plugin to issue errors. BUG=139346 Review URL: https://chromiumcodereview.appspot.com/10855075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move UserScript and related into extensions namespace Moved UserScript, UserScriptMaster, UserScriptSlave, UserScriptListener, and UserScriptScheduler into extensions namespace. BUG=136876, 117261 Review URL: https://chromiumcodereview.appspot.com/10696176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146682 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10795090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148132 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Coverity] Pass-by-val -> pass-by-ref CID=105989,105990 CID_COUNT=2 R=mihaip@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10911072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155221 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Coverity] Pass-by-val -> pass-by-ref CID=105989,105990 CID_COUNT=2 R=mihaip@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/10911072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155221 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support an --install-from-webstore command line switch This is to make standalone installation of apps from the Chrome app host possible. BUG=138311 TBR=sky@chromium.org (for chrome/common/chrome_switches.{h,cc}) Review URL: https://chromiumcodereview.appspot.com/10907104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157088 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support an --install-from-webstore command line switch This is to make standalone installation of apps from the Chrome app host possible. BUG=138311 TBR=sky@chromium.org (for chrome/common/chrome_switches.{h,cc}) Review URL: https://chromiumcodereview.appspot.com/10907104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157088 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support an --install-from-webstore command line switch This is to make standalone installation of apps from the Chrome app host possible. BUG=138311 TBR=sky@chromium.org (for chrome/common/chrome_switches.{h,cc}) Review URL: https://chromiumcodereview.appspot.com/10907104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157088 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move WebstoreInstaller, WebstoreInlineInstaller, related in extensions namespace BUG=136833, 117261 Review URL: https://chromiumcodereview.appspot.com/10703142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146407 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Correct const accessors in base/values.(h|cc), Part II (ListValue) For problem description and other info please see the BUG page. This is for ListValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj Review URL: https://chromiumcodereview.appspot.com/10837044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149819 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move WebstoreInstaller, WebstoreInlineInstaller, related in extensions namespace BUG=136833, 117261 Review URL: https://chromiumcodereview.appspot.com/10703142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146407 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove DownloadManager::GetDownloadItem() and GetActiveDownloadItem() in favor of GetDownload() Followup to GetAllDownloads() does now: http://codereview.chromium.org/10913015/ Precursor to DownloadHistory-is-an-Observer: http://codereview.chromium.org/10665049/ Reviewers: estade: chrome/browser/ui/webui/downloads_dom_handler.cc Done: bauerb: chrome/browser/plugins/plugin_installer.cc aa: chrome/browser/extensions/webstore_installer.cc achuith: chrome/browser/chromeos/gdata jcivelli: content/public/test jochen: content/shell rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10912183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158595 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Guard against more NULL pointers in WebstoreInstaller. BUG=126013,124627 Review URL: https://chromiumcodereview.appspot.com/10876089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154469 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support chrome.windows extension API events for browserless Panels. Modified window_open/panel test to check for chrome.windows.onCreated event. BUG=127323 TEST=Verified against WindowOpenApiTest.WindowOpen* using --browserless-panels flag Review URL: https://chromiumcodereview.appspot.com/10777004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148167 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert Review URL: https://chromiumcodereview.appspot.com/10920070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154730 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support chrome.windows extension API events for browserless Panels. Modified window_open/panel test to check for chrome.windows.onCreated event. BUG=127323 TEST=Verified against WindowOpenApiTest.WindowOpen* using --browserless-panels flag Review URL: https://chromiumcodereview.appspot.com/10777004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148167 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support chrome.windows extension API events for browserless Panels. Modified window_open/panel test to check for chrome.windows.onCreated event. BUG=127323 TEST=Verified against WindowOpenApiTest.WindowOpen* using --browserless-panels flag Review URL: https://chromiumcodereview.appspot.com/10777004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148167 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Support chrome.windows extension API events for browserless Panels. Modified window_open/panel test to check for chrome.windows.onCreated event. BUG=127323 TEST=Verified against WindowOpenApiTest.WindowOpen* using --browserless-panels flag Review URL: https://chromiumcodereview.appspot.com/10777004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148167 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fixing cross-incognito dispatch of onFocusChanged event. BUG=141474 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10829263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151083 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Panels] Fix browser crash when killing extension on Windows. BUG=150053 TEST=WindowOpenPanelTest.ClosePanelsOnExtensionCrash Review URL: https://chromiumcodereview.appspot.com/10948027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157602 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |