| Cleanup: Simplify some extension API code. Review URL: https://chromiumcodereview.appspot.com/10915153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155890 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Move chrome.experimental.app.onLaunched event handler to chrome.app.runtime.onLaunched. Other: 1) Made the "api.runtime" permission set implicitly (i.e., it is not required in an app's manifest.json). 2) Updated tests and regenerated docs. BUG=139253 NOTRY=true TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151580 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Move context-sensitive app.window.* functions to app.window.current().* This changes app.window.create() to call back with a wrapper AppWindow object instead of a direct reference to the DOM of the child window. The DOM is still accessible via child.dom. chrome.app.window.create('child.html', function (child) { child.dom.onload = function () { ... } child.maximize(); }) R=mihaip@chromium.org,kalman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10878040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154631 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Revert 156659 - Restart running apps when chrome restarts. This adds the event chrome.app.runtime.onRestarted, which apps can use to restore their state after a restart. BUG=138676,149727 Review URL: https://chromiumcodereview.appspot.com/10875027 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10905306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157076 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Re-enable native UI for {frame:'chrome'} in app windows. The HTML titlebar is still available as {frame:'experimental-html'} when the --enable-experimental-extensions-apis command line switch is present. R=mihaip@chromium.org BUG=149689 Review URL: https://chromiumcodereview.appspot.com/10917274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157216 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Revert 157030 - breakage was due to something else. Revert 156348 (caused http://crbug.com/149828) - Change getDevices to use a DeviceCallback. This modifies the getDevices method of the bluetooth Extensions API to accept a DeviceCallback, which will be called for every matching device. This will allow more thorough, long-running searches (involving SDP queries) to be performed without slowing down access to matching devices that can be returned quickly. TEST=api test updated BUG=134545 Review URL: https://chromiumcodereview.appspot.com/10915148 TBR=bryeung@chromium.org Review URL: https://codereview.chromium.org/10916331 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157036 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Move chrome/browser/plugin_* to chrome/browser/plugins/ TBR=jhawkins@chromium.org BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10933044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157834 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Renamed chrome_auth to cloud_print. No functionality changed except naming. Server side changes already alive. BUG=137129 TEST=unittest Review URL: https://chromiumcodereview.appspot.com/10690177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149303 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Separate plugin_metadata from plugin_installer, make plugin_finder thread-safe and expose its sync interface BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10910168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158679 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Revert 158691 - Give platform apps control over launcher right-click context menu. This moves most of the extension context menu related code from RenderViewContextMenu to a seperate class, which is then used in two other places as well. Reverted due to failures on Mac testers in: ExtensionContextMenuBrowserLazyTest.EventPage http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20(dbg)(1)/builds/1693/steps/browser_tests/logs/EventPage BUG=143222 Review URL: https://chromiumcodereview.appspot.com/10918103 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/10984034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158705 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Cleanup: Simplify some extension API code. Review URL: https://chromiumcodereview.appspot.com/10915153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155890 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| DevTools: provide the debugger detach reason in chrome.debugger.onDetach extension API. BUG=129539 Review URL: https://chromiumcodereview.appspot.com/10947037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157754 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Attempt to fix a crash in RulesRegistryStorageDelegate on shutdown. BUG=142729 Review URL: https://chromiumcodereview.appspot.com/10824339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152216 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Extracting header testing code from WebRequestConditionAttributeResponseHeaders. In preparation for adding a new condition attribute for matching request headers, the code independent of the headers being 'response' or 'request' is extracted and put into a separate class TestManager to be easily reused. BUG=143662, 112155 TEST=This change should introduce no change in behaviour and no new features. To check that it does not break the old functionality, install the extension attached to BUG 143662. If this feature is working correctly the extension should cancel every navigation. Review URL: https://chromiumcodereview.appspot.com/10923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154939 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| JSON Schema Compiler: Add event compilation and allow multiple parameters to callbacks Compiles events to objects that look similar to this: namespace OnObjectFired { struct SomeObject { ~SomeObject(); SomeObject(); enum State { STATE_FOO, STATE_BAR, STATE_BAZ, }; static scoped_ptr<Value> CreateEnumValue(State state); State state; // Returns a new DictionaryValue representing the serialized form of this // SomeObject object. Passes ownership to caller. scoped_ptr<DictionaryValue> ToValue() const; private: DISALLOW_COPY_AND_ASSIGN(SomeObject); }; Value* Create(const SomeObject& some_object); }; BUG=133757, 135237 TEST= Review URL: https://chromiumcodereview.appspot.com/10701012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146899 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Remove DownloadManager::GetDownloadItem() and GetActiveDownloadItem() in favor of GetDownload() Followup to GetAllDownloads() does now: http://codereview.chromium.org/10913015/ Precursor to DownloadHistory-is-an-Observer: http://codereview.chromium.org/10665049/ Reviewers: estade: chrome/browser/ui/webui/downloads_dom_handler.cc Done: bauerb: chrome/browser/plugins/plugin_installer.cc aa: chrome/browser/extensions/webstore_installer.cc achuith: chrome/browser/chromeos/gdata jcivelli: content/public/test jochen: content/shell rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10912183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158595 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Always include base extension type in Mac select file dialog Previously, we were only converting the extension to a UTI, and using that to control what files the user could load using the generic select file dialog. For some reason, Mac's conversions of some types - such as '.ogg' - resulted in a UTI prefixed with 'dyn' that didn't seem to correspond back to '.ogg' itself. The solution here is just to always include the original extension as well as the UTI. FWIW, the rest of this file needs updating to support lots of more complex things we now do with Packaged Apps. BUG=148840 Review URL: https://chromiumcodereview.appspot.com/10915252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157332 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Extensions Docs Server: Enum values do not show up if enum is a type If an enumerated string is a type, the possible values were not shown. BUG=146301 Review URL: https://chromiumcodereview.appspot.com/10907151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158475 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Use JSON schema compiler in i18n API code TBR=ben@chromium.org BUG=121174 Review URL: https://chromiumcodereview.appspot.com/10701026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149045 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Disable ExtensionApiTest.Idle on all platforms, since it's flaky everywhere. BUG=130138 TBR=brg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10828248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150998 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Added support for multiple parameters to Extension API callbacks. BUG=135269 TEST= Review URL: https://chromiumcodereview.appspot.com/10694106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146469 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Moving preference API into api/preferences Also putting it into extensions namespace and removing redundant "extension" prefixes from names. BUG=101244 TEST=N/A, no code change, moving stuff around only TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10952021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157600 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Allow chrome.management.setEnabled() to re-enable crashed extensions. crrev.com/10832237, take two. Removed code that treated crashed extensions as a special case. Now, developers can reload their crashed extensions like so: setEnabled(false); setEnabled(true); BUG=131977 Review URL: https://chromiumcodereview.appspot.com/10912105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155456 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Disable MediaGalleriesNoAccess and MediaGalleriesRead browser tests on Windows Due to flakiness on the WinXP builder. BUG=152185 TBR=csilv@chromium.org Review URL: https://codereview.chromium.org/10986024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158581 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Cleanup: Fix nits from r156409. Review URL: https://chromiumcodereview.appspot.com/10919276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156694 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Disable ExtensionApiTest.NativeMessageBasic The CL that introduced this was reverted, but that had to be reverted because of compile failures, and somehow a data file this depends on didn't get re-added. Just disable it until the revert can be re-landed. Make sense? :) TBR=mpcomplete@chromium.org BUG=142915 Review URL: https://codereview.chromium.org/10979038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158874 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Move StatisticsRecorder out of histogram.cc/h for further refactoring. Review URL: https://chromiumcodereview.appspot.com/10703037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146659 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Move SessionID, CaptureVisibleTabFunction to WebContents. BUG=107201 TEST=no visible change TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10912156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155811 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Refactor chrome.pageCapture to use JSON schema compiler BUG=121174 Review URL: https://chromiumcodereview.appspot.com/10806072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149110 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Remove permission warnings from most tabs and windows APIs. Patch contributed by 'Chris Hebert <chebert@chromium.org>'. See http://codereview.chromium.org/10829186/ BUG=137404 TBR=jennb,derat,chebert Review URL: https://chromiumcodereview.appspot.com/10920070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154730 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Moving preference API into api/preferences Also putting it into extensions namespace and removing redundant "extension" prefixes from names. BUG=101244 TEST=N/A, no code change, moving stuff around only TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10952021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157600 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Upstream processes_api.h This also fix clang's compiling error. BUG=143931 Review URL: https://chromiumcodereview.appspot.com/10918229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156759 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Moving preference API into api/preferences Also putting it into extensions namespace and removing redundant "extension" prefixes from names. BUG=101244 TEST=N/A, no code change, moving stuff around only TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10952021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157600 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Browser test for the push messaging feature We've implemented a push messaging feature and checked it in with a unit test. This change is adding a browser test to get better coverage in a running environment. The browser test basically brings up a small packaged app, and injects a message into the sync code. For the test to succeed, the message must arrive into the JS code of the packaged app. BUG=148550 Review URL: https://chromiumcodereview.appspot.com/10915216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157296 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Correct const accessors in base/values.(h|cc), Part II (ListValue) For problem description and other info please see the BUG page. This is for ListValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj Review URL: https://chromiumcodereview.appspot.com/10837044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149819 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Extensions Docs Server: Enum values do not show up if enum is a type If an enumerated string is a type, the possible values were not shown. BUG=146301 Review URL: https://chromiumcodereview.appspot.com/10907151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158475 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Reset registered events and dispatch runtime.onInstalled to all extensions when Chrome is updated. BUG=148898 Review URL: https://chromiumcodereview.appspot.com/10941003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157685 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Use cfsetispeed and cfsetospeed helpers to set bitrate. Instead of accessing termios members directly, use the helper functions. The current code has a portability issue that is exposed when compiling for MIPS. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Review URL: https://chromiumcodereview.appspot.com/10961009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157868 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Extensions Docs Server: Enum values do not show up if enum is a type If an enumerated string is a type, the possible values were not shown. BUG=146301 Review URL: https://chromiumcodereview.appspot.com/10907151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158475 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Implement querying CPU time from /proc/stat on Linux for systemInfo.cpu API BUG=136519 TEST=None Review URL: https://chromiumcodereview.appspot.com/10907139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157984 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Extensions Docs Server: Enum values do not show up if enum is a type If an enumerated string is a type, the possible values were not shown. BUG=146301 Review URL: https://chromiumcodereview.appspot.com/10907151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158475 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Switch SnapshotTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10909282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157252 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Make all quota-exceeding messages in the storage API explain what the failure is. This involves adding descriptions to all errors from ExtensionsQuotaService, affecting the other APIs that use this (bookmarks and webRequest). BUG=144533 Review URL: https://chromiumcodereview.appspot.com/10871034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154415 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Changing USB API buffer ownership. This change changes the ownership of the buffer used in the final transfer callback to the UsbDevice itself instead of having the USB API keep a reference to its own buffer. BUG=151987 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10972018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158608 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Disable WebNavigationApiTest.CrossProcess on windows BUG=152000 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/10969080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158353 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Implement 'Do Not Track' header DNT support is currently under development. BUG=81844 TBR=pkasting@chromium.org for chrome/browser/ui TBR=brettw@chromium.org for chrome/ Review URL: https://codereview.chromium.org/10911283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Added support for multiple parameters to Extension API callbacks. BUG=135269 TEST= Review URL: https://chromiumcodereview.appspot.com/10694106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146469 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Protect the entire webstore origin, not just the webstore path, with XFO. Follow-up to crrev.com/157802 to close a hole pointed out by cevans@ Review URL: https://chromiumcodereview.appspot.com/10959032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158453 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Initial unit tests for the discovery API. Includes a slight change to the behavior of chrome.discovery.suggest, documentation updated. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10388192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139273 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Refactored away the abomination of poor object-oriented design that was APIResourceController. - Removed APIResourceController from ExtensionService. - Conformed "API" capitalization to match style guide. - Introduced ApiResourceManager as the successor to APIResourceController. Each instance knows about exactly one ApiResource type, which allows us to avoid the horrible circular dependencies and static_casts<> of APIResourceController. - Made each ApiResourceManager a ProfileKeyedService so that it's clearer that they're bound to a single Profile. I didn't see any benefit to moving the resource destructors to PKS's Shutdown method, so I didn't do that. RECOMMENDED METHOD OF CONSUMPTION OF THIS CHANGELIST FOR MAXIMUM ENJOYMENT: 1. Understand what APIResourceController was trying to do. 2. See that APIResourceController is now gone. 3. Review the new ApiResourceManager template. 4. Confirm that all usage of APIRC is replaced with ApiRM<> usage. 5. Scan the remainder for API -> Api changes. BUG=112902 TEST=updated Review URL: https://chromiumcodereview.appspot.com/10777003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147589 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Refactored away the abomination of poor object-oriented design that was APIResourceController. - Removed APIResourceController from ExtensionService. - Conformed "API" capitalization to match style guide. - Introduced ApiResourceManager as the successor to APIResourceController. Each instance knows about exactly one ApiResource type, which allows us to avoid the horrible circular dependencies and static_casts<> of APIResourceController. - Made each ApiResourceManager a ProfileKeyedService so that it's clearer that they're bound to a single Profile. I didn't see any benefit to moving the resource destructors to PKS's Shutdown method, so I didn't do that. RECOMMENDED METHOD OF CONSUMPTION OF THIS CHANGELIST FOR MAXIMUM ENJOYMENT: 1. Understand what APIResourceController was trying to do. 2. See that APIResourceController is now gone. 3. Review the new ApiResourceManager template. 4. Confirm that all usage of APIRC is replaced with ApiRM<> usage. 5. Scan the remainder for API -> Api changes. BUG=112902 TEST=updated Review URL: https://chromiumcodereview.appspot.com/10777003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147589 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Refactor extension event distribution to use Values instead of JSON strings. Also renames Event.dispatchJSON to Event.dispatch and removes all JSON serialization surrounding invocations of DispatchEvent variants. BUG=136045 TEST=none Review URL: https://chromiumcodereview.appspot.com/10694085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150460 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |