Iibraaaa@google.comRemove PluginFinder async interface
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Share Font Code for New Autofill. Move the gfx::Font code into the base class to allow the platform specific subclasses to share it. BUG=51644 Review URL: https://chromiumcodereview.appspot.com/10987018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158684 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] re-acquire input grab on bubbles when another widget that has shadowed that input grab is hidden. BUG=111153 TEST=website settings bubble, bookmark bubble, extension action bubble: right click in the bubble, or open a combobox that grabs input, or whatever. Close that popup, and the bubble should have focus again (clicking outside the bubble dismisses it). Clicking outside the bubble (left or right click or whatever) should still dismiss it normally. Review URL: https://codereview.chromium.org/10961016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157973 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] Close zoom bubble immediately when window is closed to avoid orphaned bubbles hanging around for up to 1.5 seconds. BUG=151498 Review URL: https://chromiumcodereview.appspot.com/10985026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158666 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING Changes from original CL only in downloads_api.* Reviewers: Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc rdsmith, asanka: all Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.* Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.* Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.* Scott (sky): chrome/browser/history/history_unittest.cc Aaron (aa): chrome/browser/extensions/webstore_installer.* Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history. Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086 http://crbug.com/140687 Review URL: https://chromiumcodereview.appspot.com/10704026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846,151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/10961066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158219 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add Copy URL option to Omnibox context menu when URL is replaced by Instant Extended. BUG=135106 Review URL: https://chromiumcodereview.appspot.com/10915069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156406 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
We do not pass enums by conts references. This CL fixes style errors introduced in a previous CL. BUG=none Review URL: https://chromiumcodereview.appspot.com/10915304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157205 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch Extensions::TabHelper to use WebContents, WebContentsUserData. BUG=107201 TEST=no visible change TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155743 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=155901 Review URL: https://chromiumcodereview.appspot.com/10917026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156366 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Start copying ui_test_utils_* files into their new locations. BUG=125846 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10867010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153425 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] re-acquire input grab on bubbles when another widget that has shadowed that input grab is hidden. BUG=111153 TEST=website settings bubble, bookmark bubble, extension action bubble: right click in the bubble, or open a combobox that grabs input, or whatever. Close that popup, and the bubble should have focus again (clicking outside the bubble dismisses it). Clicking outside the bubble (left or right click or whatever) should still dismiss it normally. Review URL: https://codereview.chromium.org/10961016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157973 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove Evan from chromium gtk OWNERS. BUG=none TEST=none Review URL: http://codereview.chromium.org/10107006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132510 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress BUG=139581 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10823233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154694 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move accelerator related files to ui/base/accelerators BUG=104599 R=mazda@chromium.org Review URL: http://codereview.chromium.org/8695005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111597 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Display action box menu on Linux/gtk. Known issues: - The send-to-mobile bubble should not have an arrow and should be anchored to the action box button. BUG=145624 Review URL: https://chromiumcodereview.appspot.com/10889052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154822 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Display action box menu on Linux/gtk. Known issues: - The send-to-mobile bubble should not have an arrow and should be anchored to the action box button. BUG=145624 Review URL: https://chromiumcodereview.appspot.com/10889052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154822 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix crash in AvatarMenuBubbleGtk BUG=130632 TEST=none Review URL: https://chromiumcodereview.appspot.com/10695189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146914 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moves command handling from Browser to a new object, BrowserCommandController. Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] Use correct string (user name) in avatar bubble. BUG=140964 Review URL: https://chromiumcodereview.appspot.com/10828199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150435 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make disabled browser actions on GTK right-clickable and draggable. BUG=150789 TEST=Use chrome.browserAction.disable to disable a browser action. Check that it is right-clickable and draggable and has the disabled appearance. Review URL: https://chromiumcodereview.appspot.com/10959028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158082 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Page actions behave as disableable browser actions when script badges are enabled. Some code is based off http://codereview.chromium.org/10703090/ Includes: transparentization of icons on views. Does not include: overflow menu on cocoa updating properly. It currently only updates when the set of actions in the overflow menu changes, _not_ when any of those actions change state. BUG=133094 TEST=Enable script badges; have extensions with page actions; observe them (as browser actions) changing state, both on the toolbar and in the overflow menu. Review URL: https://chromiumcodereview.appspot.com/10700007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147188 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
The touch menu for ChromeOS will be used for all flavors of ChromeOS while other operating systems should stay as they are. Furthermore changed according to specifications which can be seen in the issue. Cleaned up the menu separator constants. BUG=137345 TEST=visually checked Review URL: https://chromiumcodereview.appspot.com/10837317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PrefMember and PrefChangeRegistrar to api directory. This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: Do not depend on the notification observer order between WrenchMenu and WrenchMenuModel. BUG=118823 TEST=Turn on sync, verify zoom buttons in the wrench menu work correctly. Review URL: https://chromiumcodereview.appspot.com/10892002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156481 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Don't show the zoom bubble when the settings menu is showing on views or GTK. BUG=128816,128070 R=estade@chromium.org,sky@chromium.org,khorimoto@chromium.org TEST=Hotdogs > +/- zoom (shouldn't show bubble nor jack focus) NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10878013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152957 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change visibility semantics for Instant. Don't change the visibility of the active tab as the Instant preview shows or hides. Instant previews should be considered transient a la the omnibox drop down, and shouldn't affect the active tab's visibility state. Also, now that we have SetInstantPreviewHeight(), this is a more reasonable approach when the preview doesn't completely obscure the tab. Also: + Remove the Hide() call when deleting the loader. This was only used in the past when there was a fade, and is not needed anymore. Instead, reset the state variables correctly. + Remove WasShown/WasHidden calls from BrowserInstantController. These are instead handled by the view code. + The "GetBackingStore called while hidden" DCHECK doesn't fire anymore, so enable a test on Windows. BUG=101593,101922 R=sky@chromium.org,shishir@chromium.org TEST=Instant works as usual. The preview gets visibility change events as usual, but the underlying tab never gets a hidden event. Review URL: https://chromiumcodereview.appspot.com/10959049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158613 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove BrowserList::GetLastActive usage from WebUI pages. I've plumbed the TabContents to the page bubble code so that the webui certificate viewer can get the Browser from it. BUG=129187 Review URL: https://chromiumcodereview.appspot.com/10554010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142963 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Put more files in chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145102 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: More GSEALing. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/9147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117267 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Integrate ChromeToMobile with GTK Action Box. Show the bubble anchored to the action box button widget on command. Update the command state with other LocationBarViewGtk updates. TODO(followup): Show the lit mobile icon during the bubble lifetime. BUG=102709,145624 TEST=Chrome To Mobile works with GTK Action Box. Review URL: https://chromiumcodereview.appspot.com/10908157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Integrate ChromeToMobile with GTK Action Box. Show the bubble anchored to the action box button widget on command. Update the command state with other LocationBarViewGtk updates. TODO(followup): Show the lit mobile icon during the bubble lifetime. BUG=102709,145624 TEST=Chrome To Mobile works with GTK Action Box. Review URL: https://chromiumcodereview.appspot.com/10908157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Show Flash LSOs for Pepper Flash in cookie dialog. It won't show anything until the Flash side has been updated. BUG=132409 Review URL: https://chromiumcodereview.appspot.com/10790150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149439 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Show apps protecting local data in chrome://settings/cookies. Related cleanup: * Add a method to ExtensionSpecialStoragePolicy that returns the set of extensions protecting an origin. * Rename CookieTreeOriginNode to CookieTreeHostNode, because that's what it is. * Modify |origin| in CookieTreeModel::DetailedInfo to actually contain the origin. * Remove |origin| from CocoaCookieDetails, because - it's a domain, not an origin, and - it can be inferred from the cookie information. * Change std::wstring usage in CookieTreeModel to string16. BUG=136487 TEST=none Review URL: https://chromiumcodereview.appspot.com/10709006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146550 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement input type=color UI BUG=92608 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126889 Review URL: https://chromiumcodereview.appspot.com/9203001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127656 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
browser: Put more files in chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145102 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move WebDialogWebContentsDelegate to ui/web_dialogs. Also move WebDialogWebContentsDelegate into ui namespace. BUG=124222,125841 TEST=None Review URL: https://chromiumcodereview.appspot.com/10796049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147620 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContentsWrapper -> TabContents, part 41. browser/ui/gtk BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10545115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141474 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove PluginFinder async interface Depends on this CL: http://codereview.chromium.org/10910168/ BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10917189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158799 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Packaged apps are now enabled by default (and arguments on launcher shortcuts are unlikely to function when chrome is already running), so this extra argument on shortcuts can be dropped. BUG=146037 TEST=ensure shortcuts for packaged apps are still created (e.g. on desktop), and can execute successfully Review URL: https://chromiumcodereview.appspot.com/10915079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155118 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ui/gfx: Remove the deprecated "operator const GdkPixbuf*" from Image API. BUG=58030 R=rsesek@chromium.org,erg@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9815006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128486 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: More raw struct access removal, this time focusing on GtkDialog. BUG=79722 TEST=compiles Review URL: http://codereview.chromium.org/9113033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116717 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add high DPI assets and update defaults for CrOS find in page bar. The new theme has a pushed image for the find next and find prev buttons, requires the find in page text boxes to have a transparent background as the theme draws a partially transparent text box area which partially shows the theme panel color through. Also we use the tab close button for the find in page bar. BUG=149032 TEST=Run chrome with --force-device-scale-factor=2, find in page bar is high DPI. Review URL: https://chromiumcodereview.appspot.com/10908234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157358 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] polish website settings bubble revise the tabstrip, fix up padding constants, improve the appearance of the close button, make most labels non-selectable To do this, I had to change BubbleGtk to let the contents use the entire bubble, and this triggered me to also fix some other bubbles which had the wrong amount of border. BUG=150750 Review URL: https://chromiumcodereview.appspot.com/10918275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157739 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename back _linuxish to linux. _linuxish is ambiguous. Use 'target_conditions' to include the required files that are for linux on Android. (TBR because the changes in chrome/browser/ui/gtk and content/app/android are all simple changes of #include file names) BUG=none TEST=Build successfully TBR=erg@chromium.org,jrg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10532178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144176 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add FullscreenController::ToggleFullscreenModeWithExtension Add a new method Remove unused argument |for_tab|, it is only used inside fullscreen_controller.cc BUG=112782 TEST=build success Review URL: http://codereview.chromium.org/9353010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122969 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Linux: Use GConfTitlebarListener on Unity or when the WM is Metacity. BUG=145545 Review URL: https://chromiumcodereview.appspot.com/10889038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154062 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] polish website settings bubble revise the tabstrip, fix up padding constants, improve the appearance of the close button, make most labels non-selectable To do this, I had to change BubbleGtk to let the contents use the entire bubble, and this triggered me to also fix some other bubbles which had the wrong amount of border. BUG=150750 Review URL: https://chromiumcodereview.appspot.com/10918275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157739 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
gtk: Extract event functions into event_utils module. This now matches with chrome/browser/ui/cocoa/event_utils.* and chrome/browser/ui/views/event_utils.* R=erg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10546116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142207 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moves command handling from Browser to a new object, BrowserCommandController. Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move PrefMember and PrefChangeRegistrar to api directory. This is the first step in breaking Autofill's concrete dependency on prefs. These two classes are essentially utilities with very small dependencies back to PrefService (which I will break in the next change, by introducing a virtual PrefServiceBase) so they are suitable for api. TBRing other owners for mechanical changes. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10857031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152544 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: Take 2: Bring global menu out of about:flags. This makes some substantial changes to 1) The ownership model needed to change slightly; Global{Bookmark,History}Menu needed to own its GtkMenu due to timing issues. (The other possible way to do this (use gtk_widget_destroyed to NULL out the reference) was discussed and rejected in a similar recent code review). 2) The first connection to the TabRestoreService needs to happen lazily. While this doesn't appear to have any affect during normal startup, it breaks the majority of browser, ui and unit tests that depend on the TabRestoreService because they all depend on controlling the loading state. We can't use the OnShow/PostTask method (see previous CL) so connect to the GtkMenuItem's activate signal. BUG=30213 TEST=ui_tests and browser_tests pass Review URL: http://codereview.chromium.org/7017028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86328 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
ui: Rename the IDR constants to put hot/pressed state before position. Note: This was a TODO for @jamescook. R=sky@chromium.org,jamescook@chromium.org Review URL: https://chromiumcodereview.appspot.com/10456077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140385 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move CanonicalCookie into separate files BUG=137014,112155 TEST=no TBR=sky@chromium.org, erg@chromium.org, tony@chromium.org, eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10785017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147222 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move browsing_data_helper files into a separate directory. BUG=121862 TEST=existing unit_tests TBR=eroman@chromium.org,sky@chromium.org,erg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10805015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147504 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Web Intents] CWS inline install for GTK BUG=113476 TEST=none Review URL: https://chromiumcodereview.appspot.com/9837011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130238 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: More GSEALing. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/9147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117267 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reapplies r91761. Now that the ARM bot is upgraded to have the same libgtk as all the other bots, this shouldn't break the build. GTK: More 2.18 goodness. Move from macros to real accessor functions. This does not take care of everything! There are many deprecated macros that can't replace because their accessor replacements were in 2.20 or later. First Review URL: http://codereview.chromium.org/7227027 BUG=none TEST=none Review URL: http://codereview.chromium.org/7484035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93685 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
GTK: More GSEALing. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/9147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117267 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: More GSEALing. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/9147044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117267 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: More removal of raw GtkWidget->allocation access. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/8773025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113031 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] fix theming of content settings bubble BUG=none TEST=block images on a site, click on the image icon in omnibox. Bubble should look normal even when your system theme is light-on-dark, and chrome's in classic theme mode. Review URL: https://codereview.chromium.org/10948037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157951 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] fix theming of content settings bubble BUG=none TEST=block images on a site, click on the image icon in omnibox. Bubble should look normal even when your system theme is light-on-dark, and chrome's in classic theme mode. Review URL: https://codereview.chromium.org/10948037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157951 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert r123782. See bug for why. BUG=108554 TEST=none TBR=ben Review URL: https://chromiumcodereview.appspot.com/10337010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135063 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
fix a couple apparent memory leaks and add a suppression and remove a suppression BUG=130640,114979 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10451102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140183 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make search icon in omnibox results hidpi Review URL: https://chromiumcodereview.appspot.com/10829370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make search icon in omnibox results hidpi Review URL: https://chromiumcodereview.appspot.com/10829370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK implementation of remembering platform app window geometry. This adds the necesary code to shell_window_gtk to remember window geometry, and a browser test to test the behavior. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154537 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK implementation of remembering platform app window geometry. This adds the necesary code to shell_window_gtk to remember window geometry, and a browser test to test the behavior. BUG=140658 Review URL: https://chromiumcodereview.appspot.com/10871087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154537 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: Create the start of a compatibility header wrapping deprecated methods. GTK 2.24 deprecated all sorts of raw access to object internals in preparation for GTK3. BUG=79722 TEST=compiles TBR=tony,jam Review URL: http://codereview.chromium.org/8588068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111065 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change return type of FaviconTabHelper::GetFavicon() to gfx::Image. No intended behavior change for now. Depends on http://codereview.chromium.org/10832128/ Part of supporting hidpi favicons in the tab strip. BUG=138550 TBR=joi Review URL: https://chromiumcodereview.appspot.com/10837090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149891 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
content: Move javascript_message_type.h into content/ from ui/. BUG=98716 R=jam@chromium.org TBR=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10451047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139242 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch WebIntentPickerController to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158650 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContentsWrapper -> TabContents, part 41. browser/ui/gtk BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10545115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141474 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: Even more cleanup to access allocation through the accessor. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/8921022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114153 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Linux: Fix a wide range of crashes resulting from a very bad interaction of our dynamic menu-building code (mostly used by bookmarks, but also by some extension menus) with libdbusmenu-gtk as used in Ubuntu 12.04 for global menu support. Basically, the problem is that it loads itself into our address space, and shows and hides menus in ways that can't be triggered through normal user interaction. It does this on purpose to get applications that build menus on demand to do so; unfortunately, it doesn't work very well when the menus are also torn down when hidden, especially the way we were doing it. This CL changes how we tear down menus when hidden to avoid getting into loops where menu changes are detected causing menus to be shown again, and is more robust in the face of event orderings that don't normally occur. BUG=131974,124110,128994 Review URL: https://codereview.chromium.org/10966043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158316 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert ui::MenuModel to use gfx::Image instead of ImageSkia. BUG=58030 TEST=none Review URL: https://chromiumcodereview.appspot.com/10824402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152767 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
ui/gfx: Remove the deprecated "operator const GdkPixbuf*" from Image API. BUG=58030 R=rsesek@chromium.org,erg@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9815006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128486 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] polish website settings bubble revise the tabstrip, fix up padding constants, improve the appearance of the close button, make most labels non-selectable To do this, I had to change BubbleGtk to let the contents use the entire bubble, and this triggered me to also fix some other bubbles which had the wrong amount of border. BUG=150750 Review URL: https://chromiumcodereview.appspot.com/10918275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157739 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update behavior of one-click infobar to remove modal dialog, add "undo". There are many non-signin-related files in this CL because of a method signature change. The significant changes are in the one_click_* files. BUG=125253 TEST=See bug description for complete UX spec. Review URL: https://chromiumcodereview.appspot.com/10332185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139365 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert r123782. See bug for why. BUG=108554 TEST=none TBR=ben Review URL: https://chromiumcodereview.appspot.com/10337010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135063 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Put more files in chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145102 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] polish website settings bubble revise the tabstrip, fix up padding constants, improve the appearance of the close button, make most labels non-selectable To do this, I had to change BubbleGtk to let the contents use the entire bubble, and this triggered me to also fix some other bubbles which had the wrong amount of border. BUG=150750 Review URL: https://chromiumcodereview.appspot.com/10918275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157739 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First version to add some UMA stats to the chrome histograms. This change covers most part of the main flow chart along the password generation function, including: - detected account creation form - password generation icon shown - password generation bubble shown (Linux) - regeneration password button clicked (Linux) - password entry edited by users (Linux) - learn more link clicked (Linux) - generated password accepted (Linux) - generated password submitted All this are simple counters for now and Windows UI will come next as a separate CL. BUG=130330 TEST=unit tests, browser tests Review URL: https://chromiumcodereview.appspot.com/10787023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147757 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. This allow us to have a single pattern for handling the gtk "response" callback. So now in every gtk dialog on chromium, it looks like this: my_dialog_gtk.h: CHROMEGTK_CALLBACK_1(MyDialogGtk, void, OnResponse, int); my_dialog_gtk.cc: void MyDialogGtk::OnResponse(GtkWidget* dialog, int response_id) { } And to subscribe to this event: g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this); BUG=None TEST=None Review URL: http://codereview.chromium.org/6627038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77180 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
IWYU and other random cleanup in chrome/browser/ui. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10810027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149249 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Added reload drop-down menu for the Reload button on Linux when in the DevTools mode. When on the tab with DevTools opened, Reload button of the browser will behave similar to Back button. Simple click will still perform default reload. Long click, right click or click and move down will bring up drop-down menu and allow user to specify Normal, Hard or Clear Cache and Hard Reload. This is Linux only UI change now. Win and Mac will follow after commiting this CL. BUG=136670 TEST=Open webpage. Bring up DevTools. Verify Reload button behavior. Review URL: https://chromiumcodereview.appspot.com/10736008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146340 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update references part 2: files in chrome/browser/ui/ Update chrome/browser/gtk references & copyright dates of touched files. Re-alphabetize include lists as necessary from this change. Update header guard & add EOF newline in chrome/browser/ui/view_ids.h Split C/C++ system headers into blocks in: chrome/browser/ui/gtk/gtk_expanded_container.cc chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.cc Sync manually with r71749 BUG=69289 TEST=none Review URL: http://codereview.chromium.org/6296012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71816 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
GTK: Another GTK deprecation patch. BUG=79722 TEST=none Review URL: http://codereview.chromium.org/9109028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116602 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Put simple_message_box.h and chrome_web_contents_view_delegate.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145421 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: Do more GSEALing. BUG=79722 R=jhawkins TBR=sky Review URL: http://codereview.chromium.org/9371005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121304 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
image-skia: Remove implicit conversion to SkBitmap on linux and chromeos. The code for the implicit conversion is still used on windows and mac, but they will eventually be removed too. BUG=141146 Review URL: https://chromiumcodereview.appspot.com/10860004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152583 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
initialize un-inited values BUG=74383 Review URL: https://chromiumcodereview.appspot.com/10914227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156565 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change visibility semantics for Instant. Don't change the visibility of the active tab as the Instant preview shows or hides. Instant previews should be considered transient a la the omnibox drop down, and shouldn't affect the active tab's visibility state. Also, now that we have SetInstantPreviewHeight(), this is a more reasonable approach when the preview doesn't completely obscure the tab. Also: + Remove the Hide() call when deleting the loader. This was only used in the past when there was a fade, and is not needed anymore. Instead, reset the state variables correctly. + Remove WasShown/WasHidden calls from BrowserInstantController. These are instead handled by the view code. + The "GetBackingStore called while hidden" DCHECK doesn't fire anymore, so enable a test on Windows. BUG=101593,101922 R=sky@chromium.org,shishir@chromium.org TEST=Instant works as usual. The preview gets visibility change events as usual, but the underlying tab never gets a hidden event. Review URL: https://chromiumcodereview.appspot.com/10959049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158613 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change visibility semantics for Instant. Don't change the visibility of the active tab as the Instant preview shows or hides. Instant previews should be considered transient a la the omnibox drop down, and shouldn't affect the active tab's visibility state. Also, now that we have SetInstantPreviewHeight(), this is a more reasonable approach when the preview doesn't completely obscure the tab. Also: + Remove the Hide() call when deleting the loader. This was only used in the past when there was a fade, and is not needed anymore. Instead, reset the state variables correctly. + Remove WasShown/WasHidden calls from BrowserInstantController. These are instead handled by the view code. + The "GetBackingStore called while hidden" DCHECK doesn't fire anymore, so enable a test on Windows. BUG=101593,101922 R=sky@chromium.org,shishir@chromium.org TEST=Instant works as usual. The preview gets visibility change events as usual, but the underlying tab never gets a hidden event. Review URL: https://chromiumcodereview.appspot.com/10959049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158613 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
image-skia: Remove implicit conversion to SkBitmap on linux and chromeos. The code for the implicit conversion is still used on windows and mac, but they will eventually be removed too. BUG=141146 Review URL: https://chromiumcodereview.appspot.com/10860004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152583 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add GPU memory tab to the task manager. Each renderer process will have all of the resources that the GPU process has allocated on its behalf (including WebGL resources, compositor resources, and the backbuffer) included in its printed total. The GPU process will have the all resources currently allocated by the GPU process in its column. This will be approximately the sum of all other rows. The row for the GPU process is printed in ()s to draw attention to the fact that its size includes duplicates from other processes' sizes. I happy this UI scheme (having played with a few), but I'd wider feedback. Note that we do not account for swapchains or for backbuffers allocated by the browser process, so those allocations are not counted in the total. BUG=140157 Review URL: https://chromiumcodereview.appspot.com/10854076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152233 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change the visual appearance of panel on GTK per new UI design. In order not to add more panel specific stuff to BrowserTitlebar, I decided to put all titlebar painting and handling logic in PanelBrowserTitlebarGtk. This is also needed for the ongoing effort to strip out the BrowserWindow dependency from panel implementation. I also moved throbber logic out of BrowserTitlebar into a separate class so that the code can be shared between BrowserTitlebar and PanelBrowserTitlebarGtk. BUG=none TEST=existing tests Review URL: https://chromiumcodereview.appspot.com/10483010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140636 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Linux: Detect Unity as a desktop environment. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10735034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147134 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GTK: Integrate with the Unity desktop environment. - When we're maximized and unity is active, don't draw the min/max/close buttons. Unity will take care of that in the title bar. - When unity is active and we're downloading a file, badge the dock icon like we do on other platforms. BUG=75485 TEST=Using a custom frame, maximize the window while running unity. We shouldn't draw our own min/max/close buttons. TEST=Download a file on Natty; download count/progress bar should appear on dock icon. Review URL: http://codereview.chromium.org/6903017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83173 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Move application lifetime functionality off BrowserList. This makes no attempt to really rationalize/simplify this flow, just get it off the BrowserList. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10409022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137927 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Integrate Chrome To Mobile with Action Box UI. Gate IsChromeToMobileEnabled on Action Box flag. Nix commandline flags, and about:flags entry. Nix IDS_FLAGS_[EN|DIS]ABLE_CHROME_TO_MOBILE_[NAME|DESCRIPTION]. Remove page action icons, anchor to action box button: Nix chrome_to_mobile_decoration.[h|mm] and use. Nix chrome_to_mobile_view.[h|cc] and use. Nix LocationBarViewGtk::CreateChromeToMobileButton, etc. Nix Command observation from LocationBarView[Mac|Gtk|<win>]. Nix chromeToMobileBubblePoint, GetChromeToMobileBubblePoint, etc. Nix SetChromeToMobileDecorationLit, VIEW_ID_CHROME_TO_MOBILE_BUTTON, etc. Add SetActionBoxIcon, call from bubble show/close. Revise SetTextButtonIconToId for TextButton anchor view. Disable ShowChromeToMobileBubble on GTK :( TODO(followup): Refine updating/observation of IDC_CHROME_TO_MOBILE_PAGE. TODO(followup): TBD GTK Action Box, fallback UI, or more cleanup. BUG=102709,120905,125307 TEST=Chrome To Mobile is enabled iff Action Box is enabled; disabled on GTK. Review URL: https://chromiumcodereview.appspot.com/10885024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154120 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 150041 to re-enable Chrome to Mobile by default on trunk (after M22 branch). Change 150041 - Revert 143421 to disable Chrome to Mobile by default on trunk (for M22 branch). Change 143421 - Revert 142809 to re-enable Chrome to Mobile by default on trunk (after M21 branch). Change 142809 - Revert 135840 to disable Chrome to Mobile by default on trunk (for M21 branch). Change 135840 - Revert 135442 to re-enable Chrome to Mobile by default on trunk. We passed the M20 branch point with Chrome to Mobile disabled, as intended. Change 135442 - Disable Chrome To Mobile by default; enable via chrome://flags. This feature should be disabled-by-default on M19; for immediate merge. Don't revert http://crrev.com/130312 to keep the AboutFlags_disable-chrome-to-mobile UMA bin. Note: Mac's ViewIDTests don't yet support VIEW_ID_CHROME_TO_MOBILE_BUTTON. BUG=102709, 120905 TEST=Chrome To Mobile is enabled on trunk (after M22 branch point). TBR=msw@chromium.org,sky@chromium.org,nyquist@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151120 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Pass result of blockage across content API when new tab blocked. This change allows the proper blockage of foreground tabs created without user-gestures for rel=noreferrer links. BUG=118317 Review URL: https://chromiumcodereview.appspot.com/10868116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155535 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Pass result of blockage across content API when new tab blocked. This change allows the proper blockage of foreground tabs created without user-gestures for rel=noreferrer links. BUG=118317 Review URL: https://chromiumcodereview.appspot.com/10868116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155535 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch WebIntentPickerController to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158650 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[WebIntents, Gtk] "Waiting for Suggestion" dialog Mostly a refactor of the picker controller, plus an initial (not complete - missing throbber image support) version of the Gtk dialog BUG=137281 Review URL: https://chromiumcodereview.appspot.com/10827238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151598 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] Close zoom bubble immediately when window is closed to avoid orphaned bubbles hanging around for up to 1.5 seconds. BUG=151498 Review URL: https://chromiumcodereview.appspot.com/10985026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158666 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] When mouse is inside of an auto-closing zoom bubble and the zoom is changed again, a timer is restarted and closes the bubble (not desired). R=estade@chromium.org BUG=None TEST=Zoom, put mouse inside bubble, zoom again - bubble should not auto-close. Review URL: https://chromiumcodereview.appspot.com/10907168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156068 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |