Aavi@chromium.orgSwitch PepperBrokerObserver to use WebContentsUserData.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846,151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/10961066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158219 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert r155813 "Reland - cros: Add chat icon to app list" r155813 turns out to be no longer needed and causing failures with ntp ordering change. BUG=152237,149750 TEST=Verify no DCHECK failure or crash when showing app list with gtalk extension installed and gtalk extension does not show in app list. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10979020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158760 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix a Windows crash bug with javascript alerts from extension popups. BUG=137707 Review URL: https://chromiumcodereview.appspot.com/10828423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152716 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158691 - Give platform apps control over launcher right-click context menu. This moves most of the extension context menu related code from RenderViewContextMenu to a seperate class, which is then used in two other places as well. Reverted due to failures on Mac testers in: ExtensionContextMenuBrowserLazyTest.EventPage http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20(dbg)(1)/builds/1693/steps/browser_tests/logs/EventPage BUG=143222 Review URL: https://chromiumcodereview.appspot.com/10918103 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/10984034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158705 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch BlockedContentTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10938033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch BookmarkTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10945010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157456 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove PluginFinder async interface Depends on this CL: http://codereview.chromium.org/10910168/ BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10917189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158799 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch BlockedContentTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10938033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch WebIntentPickerController to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158650 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove mouse lock / pointer lock flags. BUG=137172 Review URL: https://chromiumcodereview.appspot.com/10917278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157381 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove PluginFinder async interface Depends on this CL: http://codereview.chromium.org/10910168/ BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10917189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158799 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Review URL: https://codereview.chromium.org/10978016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158725 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[cros] disable GDrive option on certain file pickers This disables the GDrive folder for features that don't support reading/writing gdata. See bug for complete list. BUG=149184 TEST=manual (all pickers listed on bug under "doesn't work", no longer shows gdrive, others still do) Review URL: https://chromiumcodereview.appspot.com/10908262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157012 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move RunAllPendingInMessageLoop from ui_test_utils.h to test_utils.h, so that it can be reused by content_browsertests. I put it in test_utils.h instead of browser_test_utils.h because this is also used by unit tests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10825085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149026 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add support for the NavigateContentWindow function to the extended Instant API and reduce the number of autocomplete providers that trigger when extended Instant is enabled. BUG=150045 Review URL: https://chromiumcodereview.appspot.com/10918288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157677 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix bug 152277: [Panels] Panels are still showing taskbar icons in smaller resolution on Windows The test is added at http://codereview.chromium.org/10987037/ that contains all the test cases for more than this bug. We want to separate out the fix and the remaining complicated test such that we could merge the fix to the branch if needed. BUG=152277 TEST=Test will be added in next patch Review URL: https://chromiumcodereview.appspot.com/10979023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158739 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Separate plugin_metadata from plugin_installer, make plugin_finder thread-safe and expose its sync interface BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10910168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158679 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
FontScaleFactor and ForceEnableZoom pref_names. Adding prefs::kWebKitFontScaleFactor and prefs::kWebKitForceEnableZoom to the pref_names. It will be used by font boosting on Android. BUG=151216 Review URL: https://chromiumcodereview.appspot.com/10983010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158664 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
NTP Omnibox height wrong for --enable-instant-extended-api Tweaks to NTP Omnibox height and placement. Height is now 40px high as per spec. BUG=152253 TEST=Visual inspection. R=sky@chromium.org, kuan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10987046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158810 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch SearchEngineTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10963042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158161 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
A crash fix: removed the entire implicated section as obsolete. Note that the TODO points to a crbug which is declared obsolete / irrelevant. BUG=149729 Review URL: https://chromiumcodereview.appspot.com/10948021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157974 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Sync] Refactor handling of session tabs Add SessionTab <-> sync_pb::SessionTab conversion functions. Add IsPinned() method to SyncedTabDelegate and fix latent NULL-dereference bug in the process. Remove HasExtensionAppId() also. Rework tab contents association to: - update a SessionTab from the tab delegate (UpdateSessionTabFromDelegate); - get the current virtual URL for the tab (GetCurrentVirtualURL); - and convert to sync_pb::SessionTab in separate phases. Rework the SessionModelAssociator tests. BUG=128449 Review URL: https://chromiumcodereview.appspot.com/10990012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158777 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch PepperBrokerObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158887 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
tabs: Make the vector in MockTabStripModelObserver own values instead of pointers. TEST=unit_tests R=sky@chromium.org Review URL: https://codereview.chromium.org/10938027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158356 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove deprecated gfx::Image::operator NSImage*(). BUG=58030 TEST=Compiles. TBR=rohitrao@chromium.org Review URL: https://chromiumcodereview.appspot.com/10933083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156820 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's only used for ChromeFrame, move it to the ExternalTabContainer interface instead. Also remove WebContentsDelegate::GetFrameNativeWindow which isn't used. Review URL: https://codereview.chromium.org/10987047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158861 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
website_settings: Fix Website Settings popup for chrome://bookmarks. BUG=151575 TEST=1- go to chrome://bookmarks 2- click on the icon next to the URL 3- The bubble should say "You are viewing a secure Google Chrome page." R=markusheintz@chromium.org TBR=rsesek@chromium.org Review URL: https://codereview.chromium.org/10973013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158429 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Notes: F4 was recently changed to toggle between Maximize/Restored unless in Fullscreen. In Fullscreen F4 toggles out of it. This fix adds Shift-F4 to toggle Fullscreen (as F4 used to do). TOGGLE_MAXIMIZED must be in kReservedActions in ash/accelerators/accelerator_table.cc. It was recently removed. BUG=151544 TEST=Press Shift F4 to toggle fullscreen; Ctrl-Alt-/ for keyboard overlay, then Shift. Review URL: https://chromiumcodereview.appspot.com/10987034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158811 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adding new window management Windows get placed according to the new algorithm: The first window restores as the previous window was created (or if none were, the default will be chosen). When the second window gets created, the first one will get pushed towards the left or right side (dependent on which side it was 'more') and the new window will get pushed to the other side and made fully visible. Everything else remains as is. Update: The bug 127283 seems also to be fixed with this change. I therefore add this into the bug section. BUG=146528, 127283 TEST=unit test Review URL: https://chromiumcodereview.appspot.com/10911274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156655 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
GrabWindowSnapshotTest.TestGrabWindowSnapshot fails in HighDPI Fixes snapshot test to work on HighDPI Mac. BUG=140924 TEST=GrabWindowSnapshotTest.TestGrabWindowSnapshot R=thakis@chromium.org Review URL: https://codereview.chromium.org/10957031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157993 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[gtk] fix zoom bubble showing up on wrong window ... most of the time. Since IsActive doesn't work, it still can show the bubble on the wrong window if two windows both show the same host. BUG=152229 Review URL: https://chromiumcodereview.appspot.com/10979019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158806 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Remove tab_modal_confirm_dialog_views.h entry from DEPS whitelist. This dependency was fixed in a past review so it's to remove this now. BUG=125846 TBR=ben@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/10996024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158882 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove more set noparents BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10824025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148406 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch AlternateErrorPageTabObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10907268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157261 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch AlternateErrorPageTabObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10907268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157261 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moving google_apis and GaiaClient to src/google_apis. TBR=mechanicalowners@chromium.org BUG=145584 Review URL: https://chromiumcodereview.appspot.com/10928017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155312 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create chrome/browser/api directory. Move infobar delegates used by Autofill to the directory. Also, consolidate infobar delegate interfaces under infobars/ rather than some under infobars/ and some under tab_contents/, as the ones under tab_contents/ were not coupled with tab_contents/ in any way. Remove feedback/proto/extension.pb.h from Autofill's DEPS file simply by dropping the include, it was not being used. BUG=140037,138280 Review URL: https://chromiumcodereview.appspot.com/10843071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151279 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Making AutoLoginPrompter::ParseAutoLoginHeader public. iOS needs to parse the AutoLogin header but doesn't follow the same path than other platform to obtain it. Making this method public ensures that implementation is shared between platforms. R=pkasting@chromium.org TEST=None BUG=None Review URL: https://chromiumcodereview.appspot.com/10800074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148128 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Making AutoLoginPrompter::ParseAutoLoginHeader public. iOS needs to parse the AutoLogin header but doesn't follow the same path than other platform to obtain it. Making this method public ensures that implementation is shared between platforms. R=pkasting@chromium.org TEST=None BUG=None Review URL: https://chromiumcodereview.appspot.com/10800074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148128 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Upstream changes needed by Android auto-login. This is part of Chrome for Android upstreaming. This adapts AutoLoginInfoBarDelegate/AutoLoginPrompter so that the Android implementation of the auto-login bar on the app side can reuse these classes. Review URL: https://chromiumcodereview.appspot.com/10690006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144907 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Draggable region support for frameless app window on Windows. BUG=134169 TEST=Manual test by dragging frameless window Review URL: https://chromiumcodereview.appspot.com/10822004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150471 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Review URL: https://codereview.chromium.org/10978016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158725 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch ZoomTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158510 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Review URL: https://codereview.chromium.org/10978016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158725 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
First part of PAGE_TRANSITION_START_PAGE cleanup. I replaced START_PAGE with AUTO_TOPLEVEL because that more accurately describes how its being used in the code. In a followed CL I will add specific support for startup pages, which was the original intention of START_PAGE. This CL is basically a large search and replace and does not change the behaviour of the code. BUG=144002 TEST=No user visible change Review URL: https://chromiumcodereview.appspot.com/10897034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155047 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable history menu in incognito or guest mode BUG=127627 TEST=manual test Review URL: https://chromiumcodereview.appspot.com/10990026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158808 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Extract abstract base to API directory for ProfileSyncService. Move ProfileSyncServiceObserver to API directory. Use these to break Autofill's concrete dependency on ProfileSyncService. Remove last usages of Profile in Autofill code (modulo usage in one file that I expect will be moved to chrome/browser/configuration). TBR=ben@chromium.org,mechanicalowners@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10910071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157563 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10911351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157438 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
crbug.com/127841 - Request Tablet Site on CB with touch screen. Allow user to request tablet site via a toggle on the wrench menu. Under about-flag & cmd line switch: --enable-request-tablet-site BUG=127841 TEST=Run with flag; URLs to try: whatsmyuseragent.com, whatsmyua.com, slashdot.org, www.espn.com, www,facebook.com, www.google.com toggle "Request tablet site" under wrench menu Review URL: https://chromiumcodereview.appspot.com/10827146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155872 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Bring up a content settings icon for ungestured registerProtocolHandler call. Reverted by shess@chromium.org, turned out not to be related to the problem. Revert CL: https://chromiumcodereview.appspot.com/10782038/ Original CL: https://chromiumcodereview.appspot.com/10584042 R=benwells@chromium.org BUG=122020 TEST=None TBR=gbillock@chromium.org Review URL: https://chromiumcodereview.appspot.com/10789053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147135 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Give access to browsers by Profile/HostDesktopType. And fix existing callers of FindBrowserForProfile. BUG=None TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152788 Review URL: https://chromiumcodereview.appspot.com/10855183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153207 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Give access to browsers by Profile/HostDesktopType. And fix existing callers of FindBrowserForProfile. BUG=None TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152788 Review URL: https://chromiumcodereview.appspot.com/10855183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153207 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change visibility semantics for Instant. Don't change the visibility of the active tab as the Instant preview shows or hides. Instant previews should be considered transient a la the omnibox drop down, and shouldn't affect the active tab's visibility state. Also, now that we have SetInstantPreviewHeight(), this is a more reasonable approach when the preview doesn't completely obscure the tab. Also: + Remove the Hide() call when deleting the loader. This was only used in the past when there was a fade, and is not needed anymore. Instead, reset the state variables correctly. + Remove WasShown/WasHidden calls from BrowserInstantController. These are instead handled by the view code. + The "GetBackingStore called while hidden" DCHECK doesn't fire anymore, so enable a test on Windows. BUG=101593,101922 R=sky@chromium.org,shishir@chromium.org TEST=Instant works as usual. The preview gets visibility change events as usual, but the underlying tab never gets a hidden event. Review URL: https://chromiumcodereview.appspot.com/10959049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158613 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Hook up SetInstantPreviewHeight for ChromeOS. I tested this by specifying the fake instant page with --instant-url and adding some calls to setNonNativeDropdownHeight(). BUG= Review URL: https://chromiumcodereview.appspot.com/10915217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157670 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. This is so we can create one BrowserListImpl per universe. Eventually we'll get rid of BrowserList, but for now this change strives for compat. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10690151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146476 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
[Web Intents] Add ability to dispatch intents from extension-caused code (i.e. context menus) R=ben@chromium.org,groby@chromium.org BUG=109425,128964 Review URL: https://chromiumcodereview.appspot.com/10830102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150876 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove call to IsTryingToQuit from BrowserListImpl::SetLastActive Instead the profile manager watches notifications to determine this. BUG=130456 Review URL: https://chromiumcodereview.appspot.com/10826044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150743 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. This is so we can create one BrowserListImpl per universe. Eventually we'll get rid of BrowserList, but for now this change strives for compat. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10690151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146476 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate Browser Creation. . Make all instantiators use a single ctor that takes CreateParams. . Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10692195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate Browser Creation. . Make all instantiators use a single ctor that takes CreateParams. . Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10692195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch Extensions::TabHelper to use WebContents, WebContentsUserData. BUG=107201 TEST=no visible change TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155743 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=155901 Review URL: https://chromiumcodereview.appspot.com/10917026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156366 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert banned calls to use Navigate in ash app list. The ash app list uses FindLastActiveWithProfile and FindOrCreateTabbedBrowser, which are banned. This change replaces them with calls to chrome::Navigate. BUG=138632 TEST=Check the app list on ChromeOS can be used to show application options and links from the search box, with and without chrome browser windows open. Review URL: https://chromiumcodereview.appspot.com/10825317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152018 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Second try of 157576 https://chromiumcodereview.appspot.com/10780013/ Add reverse URL handler for shortening uber URLs BUG=120493 TEST=Open the settings page. The address bar should show "chrome://settings". Click the "extensions" button on the left. The address bar should show "chrome://extensions". Click the "settings" button on the left, "show advanced settings", "content settings". The address bar should show "chrome://settings/content". Review URL: https://chromiumcodereview.appspot.com/10941050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158504 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Put browser_navigator.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145115 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Put browser_navigator.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145115 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move browser_otr_state.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149364 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move browser_otr_state.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149364 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move browser_otr_state.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149364 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix user agent override restoration pipeline There were some disconnects in the pipeline that prevented the user agent override string from being saved and restored from the temporary tab structions in sessions/, but couldn't be tested on Android because the pathways weren't being exercised in the same way. This CL finishes hooking it up for ChromeOS (and presumably the other platforms). BUG=140600 Review URL: https://chromiumcodereview.appspot.com/10827168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152207 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix user agent override restoration pipeline There were some disconnects in the pipeline that prevented the user agent override string from being saved and restored from the temporary tab structions in sessions/, but couldn't be tested on Android because the pathways weren't being exercised in the same way. This CL finishes hooking it up for ChromeOS (and presumably the other platforms). BUG=140600 Review URL: https://chromiumcodereview.appspot.com/10827168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152207 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 151036 - Speculative revert to see if this change introduced a performance regression on Mac intl perf bots. If this change was responsible for this regression, it may also have been responsible for http://crbug.com/133762 http://crbug.com/138260 TEST=mac intl perf bot drops: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1 Review URL: https://chromiumcodereview.appspot.com/10837192 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151482 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move all TabNavigation logic to session_types.{h,cc} In particular, move the conversion to/from NavigationEntry, to/from sync_pb::TabNavigation, and pickling/unpickling logic to member functions of TabNavigation. Merge TabNavigation and SyncedTabNavigation (i.e., add unique_id and timestamp to TabNavigation). Mark most TabNavigation accessors ForTest(). Make CreateUpdateTabNavigationCommand() and UpdateTabNavigation() take a TabNavigation instead of an index + NavigationEntry. Make TabNavigation use default copy constructor and assignment operator. Also do some other misc. cleanups. Also remove unused field 'unique_id' from sync_pb::TabNavigation. Use correct indices in session model associator. Add some unit tests for TabNavigation. BUG=128449 Review URL: https://chromiumcodereview.appspot.com/10917231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157491 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix user agent override restoration pipeline There were some disconnects in the pipeline that prevented the user agent override string from being saved and restored from the temporary tab structions in sessions/, but couldn't be tested on Android because the pathways weren't being exercised in the same way. This CL finishes hooking it up for ChromeOS (and presumably the other platforms). BUG=140600 Review URL: https://chromiumcodereview.appspot.com/10827168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152207 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch BlockedContentTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10938033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158051 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Pass result of blockage across content API when new tab blocked. This change allows the proper blockage of foreground tabs created without user-gestures for rel=noreferrer links. BUG=118317 Review URL: https://chromiumcodereview.appspot.com/10868116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155535 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement 'Do Not Track' header DNT support is currently under development. BUG=81844 TBR=pkasting@chromium.org for chrome/browser/ui TBR=brettw@chromium.org for chrome/ Review URL: https://codereview.chromium.org/10911283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Moves command handling from Browser to a new object, BrowserCommandController. Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Put more files in chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145102 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Allow secondary tiles to be unpinned. This change updates the pin menu item to say 'Unpin from Start Screen' when the item is pinned, and if the menu is clicked the tile will be unpinned from the start screen. This change is accompanied by a corresponding change to metro_driver.dll BUG=129598 TEST=Check secondary tiles can be pinned and unpinned from the start screen. Review URL: https://chromiumcodereview.appspot.com/10801006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147347 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Hook up SetInstantPreviewHeight for ChromeOS. I tested this by specifying the fake instant page with --instant-url and adding some calls to setNonNativeDropdownHeight(). BUG= Review URL: https://chromiumcodereview.appspot.com/10915217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157670 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Move window sizer to subdir. chrome/browser/ui/window_sizer*.cc/h etc -> chrome/browser/ui/window_sizer/window_sizer*.cc.h BUG=135017 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10704022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144767 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove redirection header and add "ui::" before all SelectFileDialog usage. BUG=134529 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149111 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove redirection header and add "ui::" before all SelectFileDialog usage. BUG=134529 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149111 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Options: s/options2/options/. BUG=122251 R=csilv Review URL: https://chromiumcodereview.appspot.com/10837331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152280 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Refactor the way to show the feedback ui and move it into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149624 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
disable media galleries if local file access is blocked by policy. BUG=none Review URL: https://chromiumcodereview.appspot.com/10832330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153077 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
disable media galleries if local file access is blocked by policy. BUG=none Review URL: https://chromiumcodereview.appspot.com/10832330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153077 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove redirection header and add "ui::" before all SelectFileDialog usage. BUG=134529 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149111 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce InfoBarTabService API. The new interface extracts the API bits from InfoBarTabHelper. This change switches files under chrome/browser/autofill and chrome/browser/api to use the API and remove the temporarily-allowed dependency on InfoBarTabHelper. TBRing other owners as the changes are just to match the updated API and include paths. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10830353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce InfoBarTabService API. The new interface extracts the API bits from InfoBarTabHelper. This change switches files under chrome/browser/autofill and chrome/browser/api to use the API and remove the temporarily-allowed dependency on InfoBarTabHelper. TBRing other owners as the changes are just to match the updated API and include paths. TBR=ben@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10830353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152338 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Implement confirm bubble for Mac. This change is the initial implementation that ports the ConfirmBubble classes to Mac. To allow the ConfirmBubbleModel class to add/remove its controls, this change programmatically creates a custom NSView without using a nib file. BUG=99130 TEST=ConfirmBubbleControllerTest.* Review URL: http://codereview.chromium.org/8697001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117621 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport Currently ConstrainedWindowMac and TabStripController are tightly coupled. This makes it harder to add the new constrained window UI along side the old UI. To simplify things this CL refactors ConstrainedWindowSupport to be much simpler. BUG=BUG=134584 TEST= Review URL: https://chromiumcodereview.appspot.com/10871082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154832 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport Currently ConstrainedWindowMac and TabStripController are tightly coupled. This makes it harder to add the new constrained window UI along side the old UI. To simplify things this CL refactors ConstrainedWindowSupport to be much simpler. BUG=BUG=134584 TEST= Review URL: https://chromiumcodereview.appspot.com/10871082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154832 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Constrained Windows Cocoa: Part 4 Refactor ConstrainedWindowSupport Currently ConstrainedWindowMac and TabStripController are tightly coupled. This makes it harder to add the new constrained window UI along side the old UI. To simplify things this CL refactors ConstrainedWindowSupport to be much simpler. BUG=BUG=134584 TEST= Review URL: https://chromiumcodereview.appspot.com/10871082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154832 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContentsWrapper -> TabContents, part 53. browser/ui BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10546106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141542 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
TabContentsWrapper -> TabContents, part 53. browser/ui BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10546106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141542 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Cleanup: Constify some ProfileKeyedBaseFactory methods and all overrides. Remove ProfileKeyedBaseFactory::ForceRegisterPrefsForTest() Review URL: https://chromiumcodereview.appspot.com/10908088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155073 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Give access to browsers by Profile/HostDesktopType. And fix existing callers of FindBrowserForProfile. BUG=None TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152788 Review URL: https://chromiumcodereview.appspot.com/10855183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153207 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Render/pepper hang debugging: generate dumps for the browser and renderer processes if users kill a hung pepper plugin. This CL collects information in order to diagnose inter-process pepper deadlocks. - We don't crash those renderers or the browser. - We only do this on the Windows Canary channel for 20% of pepper plugin hangs, if there are not too many renderers (<4). BUG=147593 TEST=None Review URL: https://chromiumcodereview.appspot.com/10983028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158717 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch HungPluginTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10968043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158502 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Begin adding support for tab mirroring via the MediaStream audio/video capturing framework. Expanded the scope of the content::MediaStreamDeviceType enum to support the new concept of "internal capture devices." From there, many modules were tweaked to account for the new concept. In some cases, significant new functionality was added (described below). In this change, tab mirroring audio and video capture devices have been introduced, but stubbed-out. The following proposal provides more backrgound on this and the overall motivation for the code changes at-hand: http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/webrtc-tab-content-capture Significant changes: 1. content/common/media and content/public/common -- a) Expand content::MediaStreamDeviceType enum; b) Update media_stream::StreamOptions so that extension API bindings can ask for any of the MediaStreamTypes. 2. content/browser/renderer_host/media -- Minor refactoring: MediaStreamManager handles all MediaStreamDeviceTypes. Only supports EnumerateDevices and OpenDevice for physical device types. Add new GenerateStreamForDevice() API. 3. chrome/browser/media and chrome/browser/ui -- Enhance "Allow/Deny and device selection" infobar to handle all MediaStreamDeviceTypes. Review URL: https://chromiumcodereview.appspot.com/10912004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155925 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Begin adding support for tab mirroring via the MediaStream audio/video capturing framework. Expanded the scope of the content::MediaStreamDeviceType enum to support the new concept of "internal capture devices." From there, many modules were tweaked to account for the new concept. In some cases, significant new functionality was added (described below). In this change, tab mirroring audio and video capture devices have been introduced, but stubbed-out. The following proposal provides more backrgound on this and the overall motivation for the code changes at-hand: http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/webrtc-tab-content-capture Significant changes: 1. content/common/media and content/public/common -- a) Expand content::MediaStreamDeviceType enum; b) Update media_stream::StreamOptions so that extension API bindings can ask for any of the MediaStreamTypes. 2. content/browser/renderer_host/media -- Minor refactoring: MediaStreamManager handles all MediaStreamDeviceTypes. Only supports EnumerateDevices and OpenDevice for physical device types. Add new GenerateStreamForDevice() API. 3. chrome/browser/media and chrome/browser/ui -- Enhance "Allow/Deny and device selection" infobar to handle all MediaStreamDeviceTypes. Review URL: https://chromiumcodereview.appspot.com/10912004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155925 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch MetroPinTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10891033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155420 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch WebContentsUserData to be a friended base. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10933105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156988 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove GetLastActive from NetworkProfileBubble. BUG=129187 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/10887021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154280 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
browser: Put simple_message_box.h and chrome_web_contents_view_delegate.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145421 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch SadTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10949011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157575 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch SadTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10949011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157575 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Put browser_navigator.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10698068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145115 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch SnapshotTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10909282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157252 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch SnapshotTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10909282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157252 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move notifications used only in chrome/ out of content/. Moved NOTIFICATION_TAB_ADDED, NOTIFICATION_TAB_PARENTED, and NOTIFICATION_TAB_CLOSING. Turned NOTIFICATION_TAB_CLOSED into NOTIFICATION_WEB_CONTENTS_DESTROYED. BUG=76698 TEST=none Review URL: http://codereview.chromium.org/10079023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132449 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
extensions: Extract the dependency on browser_view from extension_input_api.cc. BUG=125846 R=aa@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154950 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move the NOTIFICATION_APP_TERMINATING notification from content to chrome, since it's fired by chrome. I removed the code watching it in the workers devtools code. It's not clear if this code is needed or not, so removing it for now. If we get crash reports or memory leaks on bots, then we'll have a repro that we can use to fix this. Review URL: https://codereview.chromium.org/10968064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158566 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. This is so we can create one BrowserListImpl per universe. Eventually we'll get rid of BrowserList, but for now this change strives for compat. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10690151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146476 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
IWYU and other random cleanup in chrome/browser/ui. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10810027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149249 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Integrate Chrome To Mobile with Action Box UI. Gate IsChromeToMobileEnabled on Action Box flag. Nix commandline flags, and about:flags entry. Nix IDS_FLAGS_[EN|DIS]ABLE_CHROME_TO_MOBILE_[NAME|DESCRIPTION]. Remove page action icons, anchor to action box button: Nix chrome_to_mobile_decoration.[h|mm] and use. Nix chrome_to_mobile_view.[h|cc] and use. Nix LocationBarViewGtk::CreateChromeToMobileButton, etc. Nix Command observation from LocationBarView[Mac|Gtk|<win>]. Nix chromeToMobileBubblePoint, GetChromeToMobileBubblePoint, etc. Nix SetChromeToMobileDecorationLit, VIEW_ID_CHROME_TO_MOBILE_BUTTON, etc. Add SetActionBoxIcon, call from bubble show/close. Revise SetTextButtonIconToId for TextButton anchor view. Disable ShowChromeToMobileBubble on GTK :( TODO(followup): Refine updating/observation of IDC_CHROME_TO_MOBILE_PAGE. TODO(followup): TBD GTK Action Box, fallback UI, or more cleanup. BUG=102709,120905,125307 TEST=Chrome To Mobile is enabled iff Action Box is enabled; disabled on GTK. Review URL: https://chromiumcodereview.appspot.com/10885024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154120 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |