| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Remove the "set noparent" from the chrome\browser\ui subdirectories. This is causing a lot of pain for people doing refactorings. Developers have two choices: -wait for days until all OWNERS respond, which is soul-sucking -ignore the OWNERS check and just force-commit, which is something we don't want to make acceptable since it moves the onus from a top level owner to decide whether they can approve a wide refactoring to individual contributors. Ideally there'd be no way to force. For background, Ben had added most of these 7 weeks ago when he added "set noparent" to chrome\browser\ui because he didn't want to be inundated with review requests for subdirectories. The exceptions are: cocoa: which got "set noparent" a few weeks before Ben's actions sync: which Avi added when he moved the code from chrome\browser\ui to chrome\browser\ui\sync (so there's no change from before his move compared to with this patch) So for cocoa folks: I think we can all agree that the owners in chrome\browser\ui will only approve changes in cocoa subdirectory that are trivial (i.e. renaming functions etc). For anything substantive, they will redirect. I have also added comments in chrome\browser\ui\OWNERS about this. Review URL: https://chromiumcodereview.appspot.com/9481010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124195 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. TBR=sky@chromium.org,jam@chromium.org,avi@chromium.org BUG=140474 Review URL: https://chromiumcodereview.appspot.com/10905304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157242 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Give request-to-act badges a grey background, and increase spacing to make it fit. Screen shots: http://imgur.com/a/COWzt Original mock: https://docs.google.com/a/google.com/folder/d/0B21JpVYxVLsASVVyZlJDb3d3a2M/edit?docId=0B21JpVYxVLsAVE56VWptV3RDTHc BUG=135460,133142 Review URL: https://chromiumcodereview.appspot.com/10834279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157619 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Give request-to-act badges a grey background, and increase spacing to make it fit. Screen shots: http://imgur.com/a/COWzt Original mock: https://docs.google.com/a/google.com/folder/d/0B21JpVYxVLsASVVyZlJDb3d3a2M/edit?docId=0B21JpVYxVLsAVE56VWptV3RDTHc BUG=135460,133142 Review URL: https://chromiumcodereview.appspot.com/10834279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157619 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert mostly favicon related code from SkBitmap to ImageSkia and Image. BUG=None Test=Compiles Review URL: https://chromiumcodereview.appspot.com/10834368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152050 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add support for the NavigateContentWindow function to the extended Instant API and reduce the number of autocomplete providers that trigger when extended Instant is enabled. BUG=150045 Review URL: https://chromiumcodereview.appspot.com/10918288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157677 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Instant extended API: Make arrow up/down work. BUG=none R=sky@chromium.org,pkasting@chromium.org TEST=In extended API, arrow up/down should work. Pressing Enter should use the selected match. Review URL: https://chromiumcodereview.appspot.com/10918289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157466 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert mostly favicon related code from SkBitmap to ImageSkia and Image. BUG=None Test=Compiles Review URL: https://chromiumcodereview.appspot.com/10834368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152050 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make search icon in omnibox results hidpi Review URL: https://chromiumcodereview.appspot.com/10829370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make search icon in omnibox results hidpi Review URL: https://chromiumcodereview.appspot.com/10829370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152379 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update page icon in the omnibox The location bar and the omnibox popup currently show an "empty page" icon for http entries. This CL makes it so that the asset in the location bar is different from the one in the popup, and updates the asset used in both places. BUG=149903 Review URL: https://codereview.chromium.org/10951023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157549 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add Copy URL option to Omnibox context menu when URL is replaced by Instant Extended. BUG=135106 Review URL: https://chromiumcodereview.appspot.com/10915069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156406 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable EnterToSearch on Windows BUG=146953 TBR=ben@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10916166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155290 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix memory leak in BookmarkUtilsTest.CopyPaste. BUG=130805 TBR=thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156089 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
| 14 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 | ||
| 13 年前 |