Aavi@chromium.orgSwitch PepperBrokerObserver to use WebContentsUserData.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Remove the "set noparent" from the chrome\browser\ui subdirectories. This is causing a lot of pain for people doing refactorings. Developers have two choices: -wait for days until all OWNERS respond, which is soul-sucking -ignore the OWNERS check and just force-commit, which is something we don't want to make acceptable since it moves the onus from a top level owner to decide whether they can approve a wide refactoring to individual contributors. Ideally there'd be no way to force. For background, Ben had added most of these 7 weeks ago when he added "set noparent" to chrome\browser\ui because he didn't want to be inundated with review requests for subdirectories. The exceptions are: cocoa: which got "set noparent" a few weeks before Ben's actions sync: which Avi added when he moved the code from chrome\browser\ui to chrome\browser\ui\sync (so there's no change from before his move compared to with this patch) So for cocoa folks: I think we can all agree that the owners in chrome\browser\ui will only approve changes in cocoa subdirectory that are trivial (i.e. renaming functions etc). For anything substantive, they will redirect. I have also added comments in chrome\browser\ui\OWNERS about this. Review URL: https://chromiumcodereview.appspot.com/9481010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124195 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch CoreTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10905301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157629 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch CoreTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10905301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157629 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch CoreTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10905301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157629 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch CoreTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10905301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157629 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch PepperBrokerObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158887 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch PepperBrokerObserver to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158887 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move tab functions off Browser into browser_tabstrip and browser_tabrestore. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Consolidate Browser Creation. . Make all instantiators use a single ctor that takes CreateParams. . Get rid of InitBrowserWindow() and make CreateBrowserWindow() a anonymous namespace function in browser.cc http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10692195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148396 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make TabContents ctor private; poke hole for existing callers. BUG=107201 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10868072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153527 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |