Aakalin@chromium.orgRework arguments of HistoryService::AddPage()
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Switch BookmarkTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10945010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157456 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Only show chrome2mobile in action box if it is enabled. BUG=145299 Review URL: https://chromiumcodereview.appspot.com/10887029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154458 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Introduce structures to reduce the number of arguments in the FaviconService methods. Issue 10870022 introduced new arguments for the FaviconService methods, some of them now having more than 6 arguments. These methods cannot be called using the base::Bind mechanism because of template limitations. This patch introduces auxiliar structures to reduce the number of arguments in these methods and therefore allow using base::Bind on them. BUG=146003 Review URL: https://chromiumcodereview.appspot.com/10918065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155113 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change FaviconData to be able to return data for multiple bitmaps for same icon URL. Add methods to FaviconService to get gfx::Image more easily from Favicon. BUG=138553 Test=Compiles, FaviconHandlerTest.* pass. Review URL: https://chromiumcodereview.appspot.com/10870022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Review URL: https://codereview.chromium.org/10963018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158063 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move menu item for pinning to start screen on Windows 8 into the bookmarks menu. Also the text for the menu item has been updated slightly to be more clear. BUG=145152 Review URL: https://chromiumcodereview.appspot.com/10918209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156714 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Migrate the rest of the "global" prefs. This is a continuation of the work in r137835. TBR=gene for cloud print, mpcomplete for extension BUG=123812 TEST=browser_tests --gtest_filter=PrefsTab* and ExtensionApiTest.Font* Review URL: https://chromiumcodereview.appspot.com/10409046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138219 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move test_browser_thread.h from content\test to content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Update page icon in the omnibox The location bar and the omnibox popup currently show an "empty page" icon for http entries. This CL makes it so that the asset in the location bar is different from the one in the popup, and updates the asset used in both places. BUG=149903 Review URL: https://codereview.chromium.org/10951023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157549 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
A simple version of search term replacement for testing. Google search URLs that support the extended instant API will be replaced in the Omnibox by the search terms. BUG=135106,139176 Review URL: https://chromiumcodereview.appspot.com/10867038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153341 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Disable ToolbarModelTest.ShouldDisplayURLInstantExtendedAPIEnabled on branch Disables ToolbarModelTest.ShouldDisplayURLInstantExtendedAPIEnabled on branded branch. These tests don't work there due to channel status with branded builds. BUG=none TEST=ToolbarModelTest.ShouldDisplayURLInstantExtendedAPIEnabled TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10949031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157692 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Move menu item for pinning to start screen on Windows 8 into the bookmarks menu. Also the text for the menu item has been updated slightly to be more clear. BUG=145152 Review URL: https://chromiumcodereview.appspot.com/10918209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156714 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
The touch menu for ChromeOS will be used for all flavors of ChromeOS while other operating systems should stay as they are. Furthermore changed according to specifications which can be seen in the issue. Cleaned up the menu separator constants. BUG=137345 TEST=visually checked Review URL: https://chromiumcodereview.appspot.com/10837317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
The touch menu for ChromeOS will be used for all flavors of ChromeOS while other operating systems should stay as they are. Furthermore changed according to specifications which can be seen in the issue. Cleaned up the menu separator constants. BUG=137345 TEST=visually checked Review URL: https://chromiumcodereview.appspot.com/10837317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153157 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |